Summary:
This has been failing since the move in D31688105 (9a47f41056).
Pull Request resolved: https://github.com/facebook/flipper/pull/3264
Test Plan: _eyes_
Reviewed By: antonk52
Differential Revision: D33509970
Pulled By: passy
fbshipit-source-id: 5cb49cc96fe7d74fa9a1820a99daf79641f25837
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/3211
The GH retry action did ate all the stdout / stderr, so if the retry fails, it was completely unclear why. This was fixed in a newer version of the action
Reviewed By: antonk52
Differential Revision: D33308437
fbshipit-source-id: a599161e0c72b95b35e6ecab8cd84c6fa7027cd3
Summary:
This includes a bunch of different things which I wanted to do separately, but it's all a massive Jenga Tower and you cannot remove a single piece.
- Litho upgrade
- Gradle plugin upgrade
- Remove storage permission as it apparently doesn't do anything above Android 10
- Upgraded build target to Android 12 because the new support lib/Kotlin stdlib required this which then caused the issue below to pop up
- Added "export=true" everywhere as this is now a blocking issue if you don't have it
- Upgraded to the LeakCanary2 plugin as version one no longer builds with an Android 12 target for the export reason
- Make CI run on JRE 11 because that's required by the new Gradle plugin
- Update internal CI to no longer define the SDK twice and use Java 11
Pull Request resolved: https://github.com/facebook/flipper/pull/3095
Test Plan: Built Android Sample and Tutorial app, connected to Flipper.
Reviewed By: lblasa
Differential Revision: D32644410
Pulled By: passy
fbshipit-source-id: 8978f158d9c642b3bbd9dbbd7321eb20098a7a53
Summary:
This one is actually fine. We don't do the upload/download dance,
so the file exists in the place we expect it to.
We can see in this run that the current path actually works:
https://github.com/facebook/flipper/runs/4316082427?check_suite_focus=true
Reviewed By: nikoant
Differential Revision: D32652626
fbshipit-source-id: ca9c52d2c3016fe2ec300d1f4fd875b9f3301e3b
Summary:
I can run the same commands locally and everything is fine but in CI, it creates two separate staging repositories.
Maybe this will shed some light.
Pull Request resolved: https://github.com/facebook/flipper/pull/3100
Reviewed By: nikoant
Differential Revision: D32651863
Pulled By: passy
fbshipit-source-id: 30441b29ab6a4270dee1c958e19242f71265a174
Summary:
I've been investigating the now persistent upload issue for our artifacts and it appears to come down to artifacts being uploaded and downloaded as folder structures while they used to be individual files.
Annoyingly, the `ghr` tool we use for uploading throws a cryptic and misleading error: https://github.com/facebook/flipper/runs/4314584032?check_suite_focus=true
There is some more control in the `v2` version of the actions but for now, this seems like the safer option to fix this problem.
{F682461661}
Reviewed By: lblasa
Differential Revision: D32649218
fbshipit-source-id: 47ebefc434cb3b928b82a9fe8da3002b7b8465b6
Summary:
Fixed an issue with the setup of the retry script:
31ee58a796
Reviewed By: nikoant
Differential Revision: D32644463
fbshipit-source-id: 23ac1508784f24e9403e0bca0091f05847a9e91d
Summary:
We've done this for the "release" part of the workflow
before but need to handle the "publish" branch separately.
Pull Request resolved: https://github.com/facebook/flipper/pull/3071
Test Plan: _eyes
Reviewed By: nikoant
Differential Revision: D32532348
Pulled By: passy
fbshipit-source-id: 622ed99ba509d4eaf7671e9b6ff3adbab277ab4e
Summary:
We're seeing some spurious failures, unrelated to any changes on our end.
I've upgraded the action to do two things:
- Retry on failure (up to three times): b0dfcdf1c7
- Replace the artefact if it's already present (otherwise this might fail subsequent retries): 92bec0ba48
Pull Request resolved: https://github.com/facebook/flipper/pull/3070
Reviewed By: nikoant
Differential Revision: D32532277
Pulled By: passy
fbshipit-source-id: f1899c89c405772490958674fa7f46f479c666f9
Summary:
1. Update js-flipper's version in pre-release
2. Update current version of js-flipper to match react-native-flipper
3. Publish js-flipper automatically
Reviewed By: mweststrate
Differential Revision: D31858522
fbshipit-source-id: e5a9816980d89d3ca6745bc16942f7b75f8d2a88
Summary:
Following mweststrate's advice on how to fix this.
Pull Request resolved: https://github.com/facebook/flipper/pull/2956
Test Plan: Watch the Action.
Reviewed By: lblasa
Differential Revision: D31502115
Pulled By: passy
fbshipit-source-id: 0f6dc73bcfde30fe7e2ee78e58d1c8e6fc16ec29
Summary: I upgraded the docker image which should pull the latest GHR release (https://github.com/tcnksm/ghr).
Reviewed By: lblasa
Differential Revision: D31442256
fbshipit-source-id: 0f9fa81ec1be1285aea3da621b7ef5a1e63c3e84
Summary:
I believe that matches what we have internally. This has been causing some upgrades to fail.
Pull Request resolved: https://github.com/facebook/flipper/pull/2928
Reviewed By: aigoncharov
Differential Revision: D31324394
Pulled By: passy
fbshipit-source-id: eec38dcc6322e3e8957bbc20bf74d343855be8c0
Summary:
Because the publish runs aren't triggered on the main branch, we have limited visibility. Sending push notifications, webhooks or email integrations are hard, but opening an issue seems like a decent work-around for this.
We can broaden this to more publish actions as needed.
Pull Request resolved: https://github.com/facebook/flipper/pull/2904
Test Plan: Ran on my fork which generated this issue: https://github.com/passy/flipper/issues/9
Reviewed By: mweststrate
Differential Revision: D31146956
Pulled By: passy
fbshipit-source-id: 08f66bd4c96a5ea2cc5e70a7461c30e7e1f3d42e
Summary:
I've been really sweating about this one. It looks like Google now removed NDK 21 as it's too old. However, we've been struggling with the upgrade because OpenSSL was built against an old version of the NDK/glibc/LLVM/some other stuff.
I've now managed to create an OpenSSL distribution for 1.1.1k (we had 1.1.0h before) that seems to build with this after some small modifications.
This seems to do the trick, but I wouldn't be shocked if we found some more incompatibilities further down the line.
Pull Request resolved: https://github.com/facebook/flipper/pull/2836
Test Plan:
- Locally: `./gradlew :tutorial:installDebug`. Builds, starts up. Cool.
- Public GitHub CI: Happy.
- Circle CI: Only triggers post-land. We'll see. But the setup is simple, so hopefully it should work there, too.
- Internal CI: Waiting for signal.
Reviewed By: fabiomassimo
Differential Revision: D30839209
Pulled By: passy
fbshipit-source-id: efe599f28cc0edfdf2149f905c3483555239edc0
Summary:
Often fails with things like "can't resolve github.com" ... I don't think there's a fix for that apart from trying again.
Pull Request resolved: https://github.com/facebook/flipper/pull/2685
Test Plan: Waiting for things to turn green here.
Reviewed By: timur-valiev
Differential Revision: D30301456
Pulled By: passy
fbshipit-source-id: 585758284e18bd02ab2a905b6f110a32099b861e
Summary:
This is a starting point. `types/*` is aggressive but it's not only spammy but also should only really be used in combination with a dep update.
Pull Request resolved: https://github.com/facebook/flipper/pull/2641
Test Plan: hopeitwork
Reviewed By: nikoant
Differential Revision: D29992458
Pulled By: passy
fbshipit-source-id: f42023d2dff55bf2226ddd984c81a1cfa017b0bb
Summary:
From the changelog:
> Removed the deprecated uploadArchives and installArchives tasks. Use publish and publishToMavenLocal instead.
Made the necessary changes to docs and scripts.
Reviewed By: nikoant
Differential Revision: D29752895
fbshipit-source-id: 6e96c7ea9b26be2acb40b9089cb361837ab10a1b
Summary:
This PR splits the linting of the flipperkit pods into different subspecs. This will fasten the overall validation time. Before, all the pods were validated in a serialised fashion, but now its done in a parallel way.
This brings down the total validation time from 2+ hrs to ~ 25mins
## Changelog
- Split the validation of the FlipperKit pod into parallelised subspecs
Pull Request resolved: https://github.com/facebook/flipper/pull/2540
Test Plan: https://github.com/facebook/flipper/actions/runs/986790548
Reviewed By: passy
Differential Revision: D29489716
Pulled By: priteshrnandgaonkar
fbshipit-source-id: 55557c581d56ee01796ca64405cf78b647d2a68b
Summary:
This PR adds a script to publish pods. It handles different edge cases like:
- The version was already pushed but still you are trying to push it, it will skip in that case and give a proper message.
- This also makes sure that the same version Flipper pod exists before pushing FlipperKit.
- It also has the retry mechanism in place if at all the pod trunk push fails to push.
## Changelog
Updated the workflow to push pods
Pull Request resolved: https://github.com/facebook/flipper/pull/2511
Test Plan:
While pushing already published release:
https://github.com/facebook/flipper/actions/runs/974346766
While pushing new release:
https://github.com/facebook/flipper/actions/runs/978707041
Reviewed By: passy
Differential Revision: D29415078
Pulled By: priteshrnandgaonkar
fbshipit-source-id: f0fb68a2e399802e5719d7be4216d4a5ed6ef782
Summary:
This should take care of the build issue. It's an annoying caching issue that's been around for ages. Also why it didn't happen locally.
Pull Request resolved: https://github.com/facebook/flipper/pull/2432
Test Plan: GitHub CI
Reviewed By: mweststrate
Differential Revision: D28958707
Pulled By: passy
fbshipit-source-id: 8538f6616dec934d924c04713af93e7a6b89e617
Summary:
We missed that D28795384 (09951d505e) broke the Kotlin plugin until we got to
our Snapshot job. This makes sure we build all artifacts and get
signal on PRs.
Pull Request resolved: https://github.com/facebook/flipper/pull/2404
Test Plan:
CI
`./gradlew assembleDebug` failed correctly when applying the change.
Reviewed By: nikoant
Differential Revision: D28801494
Pulled By: passy
fbshipit-source-id: 704047ea17af632091c6597024ddacc9247255a9
Summary:
Per title
After landing this and verifying in CI, will apply those version bumps to RN itself: https://github.com/facebook/react-native/pull/31562, and remove the custom overrides in the future
Reviewed By: passy
Differential Revision: D28573552
fbshipit-source-id: e52c40f4751f933f17312aac2aacfd695f554a3f
Summary:
This diff updates and adds the boost ios podspec in flipper repo. This new boost dep works for Arm and i386 archs for simulator too.
This diff also updates our GH Action to remove i386 from excluded archs. Still arm64 is kept as non M1 mac machines do not have arm swift symbols for arm simulator. And since all our CI is on non M1, it is required.
It also takes care of https://github.com/facebook/flipper/issues/2268
## Changelog
- Update the boost dep
- Update the GH action
Pull Request resolved: https://github.com/facebook/flipper/pull/2341
Test Plan: CI
Reviewed By: mweststrate
Differential Revision: D28537004
Pulled By: priteshrnandgaonkar
fbshipit-source-id: 474ccec674d0edf5fa7b792b15a326e0f139d977
Summary:
Updated to the latest version which apparently doesn't need a privileged token anymore, which would be good news.
Also updated the message to include a `[ci skip]` which instructs CircleCI not to run because we're having a chicken-and-egg-problem here with CircleCI otherwise needing a config to tell it not to run, otherwise it will run and fail because there's no config.
Pull Request resolved: https://github.com/facebook/flipper/pull/2342
Test Plan:
hopeitwork
Task: T91157540
Reviewed By: mweststrate
Differential Revision: D28539468
Pulled By: passy
fbshipit-source-id: 609c3fa1578e0506aadeb225c4e38ff53db67934
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/2275
Forced all current pods to use the latest available. If this builds successfully, will create a PR against React Native so that they become the default, and remove them here again.
This job currently does limit the architectures we build for. Pritesh is investigating if we can wide that again, as this might not be acceptable to RN in general.
This doesn't bump the android version to 0.88, as the artifact publishing failed for that version, but since there are currently less problems with the Android version I wanted to go ahead with just iOS.
Reviewed By: cekkaewnumchai, priteshrnandgaonkar
Differential Revision: D28257283
fbshipit-source-id: a631b1c354617ed356cd1e74b9e8e8aa050eed60
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/2271
Fix react native OSS build. As discussed a couple of weeks ago, we can bump deps, but cannot bump lock files during release, as artifacts are then not yet available.
We backed out from these bumps before D27764997 (98c3913b62), but that didn't seem to be sufficient. Filed T90301619 as follow up
Reviewed By: priteshrnandgaonkar
Differential Revision: D28255272
fbshipit-source-id: ee4d5b158a653c78f73b46c9ca695cfced315e56
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/2245
This diff does the following:
- Updates Folly to the latest version.
- Updates boost to latest version and the boost is added as pre built artefact
- Updates RSocket to the latest version
- Updates ComponentKit to the latest version which has a fix for XCode 12.5
- Adds Flipper-Glog dependency updated with a fix for the issue mentioned [here](https://github.com/facebook/flipper/issues/2174)
- This diff also ensures that Flipper, FlipperKit builds with Sample and SampleSwift app.
- This diff also ensures that the bug mentioned [here](https://github.com/facebook/flipper/issues/2248) is addressed.
Note: For Tutorial App to work we will have to make a release of Flipper and FlipperKit to CococaPods. Because the tutorial app refers the released version of Flipper and FlipperKit. It doesn't refer it locally.
Reviewed By: passy
Differential Revision: D28058972
fbshipit-source-id: d45dfc7315ace5d5c7d3a4ba94911fd4b58bdc31
Summary:
This PR updates the Glog and DoubleConversion deps. Now the deps are shipped with precompiled xcframework. It will speed up our build time a bit.
The definition can be found [here for glog](https://github.com/priteshrnandgaonkar/glog/tree/update-0.3.5) and [here for double-conversion](https://github.com/priteshrnandgaonkar/double-conversion/)
There has been improvements in time. I will try to precompile folly to improve the timings significantly.
## Changelog
- Updated the Glog and DoubleConversion deps to the precompiled xcframework one
- Updated the sample app's Podfile.lock
Pull Request resolved: https://github.com/facebook/flipper/pull/2153
Test Plan:
- CI should be green
- Verified that sample app builds.
Reviewed By: mweststrate
Differential Revision: D27560567
Pulled By: priteshrnandgaonkar
fbshipit-source-id: ba295cbe84bb9d5ed6bd6ab17bd1cf5ea22f3cee
Summary:
The time we spend on this isn't much. However, we quite often see flakiness coming from yarnpkg not responding which should hopefully be addressed by this.
Pull Request resolved: https://github.com/facebook/flipper/pull/2137
Test Plan: CI
Reviewed By: mweststrate
Differential Revision: D27461679
Pulled By: passy
fbshipit-source-id: c7144d2a8426c078f9cab2d3a94662908a03a182
Summary:
Updates the run conditions of iOS jobs so that it is triggered when we change "Flipper.podspec" and "FlipperKit.podspec"
## Changelog
- Update the run conditions
Pull Request resolved: https://github.com/facebook/flipper/pull/2136
Test Plan: CI
Reviewed By: passy
Differential Revision: D27402914
Pulled By: priteshrnandgaonkar
fbshipit-source-id: 3b687612f26a0e22773c48540b76a7660bb29ed6
Summary:
This PR updates the logic when these iOS jobs should be run. This change just makes it run for pushes to iOS folders and xplat c++ folders.
## Changelog
- Update the GH action.
Pull Request resolved: https://github.com/facebook/flipper/pull/2118
Test Plan: Note that no iOS job is run.
Reviewed By: mweststrate
Differential Revision: D27395681
Pulled By: priteshrnandgaonkar
fbshipit-source-id: 37a7c2fb9b3fdfa22307ac5e7403364bfeb0a384
Summary:
Sample and SampleSwift directly link to the debug version and don't reference `flipperkit_version` which is why the script is failing.
Pull Request resolved: https://github.com/facebook/flipper/pull/2117
Test Plan: hopeitwork
Reviewed By: priteshrnandgaonkar
Differential Revision: D27395244
Pulled By: passy
fbshipit-source-id: 3485731b0489376fbdf987c082ef7d288f66bbe8
Summary:
I don't fully understand how dependabot works with Android but it seems to only look at the literal fbjni version number based on the logs and we're actually outdated on a bunch of dependencies which Gradle doesn't handle very well.
Pull Request resolved: https://github.com/facebook/flipper/pull/1997
Test Plan: Tested on my fork and I've got a ton of PRs because of this. Brace yourselves.
Reviewed By: mweststrate
Differential Revision: D26784112
Pulled By: passy
fbshipit-source-id: 98ebd0b899a0603868d4b6bc0866e557c87fecd5
Summary:
Builds up a file with checksums of all `build.gradle` files. Deliberately excludes the `gradle.properties` which changes all the time. The cache shouldn't require nuking except in some rare circumstances.
Pull Request resolved: https://github.com/facebook/flipper/pull/1922
Test Plan: From 41 minutes down to 17: https://github.com/passy/flipper-1/actions/runs/561501374
Reviewed By: mweststrate
Differential Revision: D26427242
Pulled By: passy
fbshipit-source-id: ff1d7370d477c9d7b57c62082ec985108a5ba698
