jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Update Boost iOSX dep and make it work for arm and i386 for sims (#2341)

Browse Source 
Summary:
This diff updates and adds the boost ios podspec in flipper repo. This new boost dep works for Arm and i386 archs for simulator too.

This diff also updates our GH Action to remove i386 from excluded archs. Still arm64 is kept as non M1 mac machines do not have arm swift symbols for arm simulator. And since all our CI is on non M1, it is required.

It also takes care of https://github.com/facebook/flipper/issues/2268
## Changelog

- Update the boost dep
- Update the GH action

Pull Request resolved: https://github.com/facebook/flipper/pull/2341

Test Plan: CI

Reviewed By: mweststrate

Differential Revision: D28537004

Pulled By: priteshrnandgaonkar

fbshipit-source-id: 474ccec674d0edf5fa7b792b15a326e0f139d977
This commit is contained in:
Pritesh Nandgaonkar
2021-05-19 11:13:57 -07:00
committed by Facebook GitHub Bot
parent e0e95b59c7
commit 15454ceec7
6 changed files with 42 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
.github/workflows/iOS-Sample.yml vendored
View File

@@ -27,7 +27,7 @@ jobs:
- name: Build Sample app
run: |
IPHONESIMULATOR=$(xcodebuild -showsdks | grep -o "iphonesimulator[0-9]\\+\\.[0-9]\\+$") && echo $IPHONESIMULATOR
xcodebuild build -workspace Sample.xcworkspace -scheme Sample -sdk $IPHONESIMULATOR EXCLUDED_ARCHS="arm64 i386"
xcodebuild build -workspace Sample.xcworkspace -scheme Sample -sdk $IPHONESIMULATOR EXCLUDED_ARCHS="arm64"
build-sample-swift:
runs-on: macos-latest
@@ -42,7 +42,7 @@ jobs:
- name: Build SampleSwift app
run: |
IPHONESIMULATOR=$(xcodebuild -showsdks | grep -o "iphonesimulator[0-9]\\+\\.[0-9]\\+$") && echo $IPHONESIMULATOR
xcodebuild build -workspace SampleSwift.xcworkspace -scheme SampleSwift -sdk $IPHONESIMULATOR EXCLUDED_ARCHS="arm64 i386"
xcodebuild build -workspace SampleSwift.xcworkspace -scheme SampleSwift -sdk $IPHONESIMULATOR
build-tutorial:
runs-on: macos-latest
@@ -57,4 +57,4 @@ jobs:
- name: Build Tutorial app
run: |
IPHONESIMULATOR=$(xcodebuild -showsdks | grep -o "iphonesimulator[0-9]\\+\\.[0-9]\\+$") && echo $IPHONESIMULATOR
xcodebuild build -workspace Tutorial.xcworkspace -scheme Tutorial -sdk $IPHONESIMULATOR EXCLUDED_ARCHS="arm64 i386"
xcodebuild build -workspace Tutorial.xcworkspace -scheme Tutorial -sdk $IPHONESIMULATOR