Bump gradle-maven-publish-plugin from 0.16.0 to 0.17.0

Summary:
From the changelog:

> Removed the deprecated uploadArchives and installArchives tasks. Use publish and publishToMavenLocal instead.

Made the necessary changes to docs and scripts.

Reviewed By: nikoant

Differential Revision: D29752895

fbshipit-source-id: 6e96c7ea9b26be2acb40b9089cb361837ab10a1b

.github/workflows/publish-android.yml

@@ -40,7 +40,7 @@ jobs:
     - name: Build artifacts
       run: ./gradlew :sample:assembleDebug :sample:assembleRelease && ./gradlew :android:assembleRelease
     - name: Upload Archives
-      run: ./gradlew uploadArchives --no-parallel --no-daemon
+      run: ./gradlew publish --no-parallel --no-daemon
     - name: Release and close
       run: ./gradlew closeAndReleaseRepository
     - name: Clean secrets

build.gradle

@@ -12,7 +12,7 @@ buildscript {
     }
     dependencies {
         classpath 'com.android.tools.build:gradle:4.2.1'
-        classpath 'com.vanniktech:gradle-maven-publish-plugin:0.16.0'
+        classpath 'com.vanniktech:gradle-maven-publish-plugin:0.17.0'
         classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$KOTLIN_VERSION"
         classpath "org.jetbrains.dokka:dokka-gradle-plugin:1.5.0"
     }
@@ -24,7 +24,7 @@ plugins {
 }
 
 ext.isSnapshot = { VERSION_NAME.endsWith('-SNAPSHOT') }
-ext.isRelease = { ['uploadArchives', 'bintrayUpload'].any { gradle.startParameter.taskNames.contains(it) } }
+ext.isRelease = { ['publish', 'publishToMavenLocal'].any { gradle.startParameter.taskNames.contains(it) } }
 
 subprojects {
     repositories {

docs/extending/public-releases.mdx

@@ -127,7 +127,7 @@ involves creating a JIRA account and opening an issue to apply for the `com.face
 to find an existing member of this namespace to vouch for you. While this is a lot, it ensures that nobody
 from outside the organisation can publish under our name.
 
-The `uploadArchives` gradle task uses the OSSRH Sonatype Nexus credentials to upload all Flipper Java artifacts. That
+The `publish` (previously `uploadArchives`) gradle task uses the OSSRH Sonatype Nexus credentials to upload all Flipper Java artifacts. That
 includes the core SDK as well as our plugins. The credentials are *not* your login to Nexus, but the user tokens
 you can get from [your profile](https://oss.sonatype.org/#profile;User%20Token).
 

scripts/publish-android-snapshot.sh

@@ -17,5 +17,5 @@ elif [ "$IS_SNAPSHOT" == "" ]; then
   exit 1
 else
   openssl aes-256-cbc -d -in scripts/gradle-publish-keys.enc -k "$ANDROID_PUBLISH_KEY" >> "$BASEDIR/gradle.properties"
-  "$BASEDIR"/gradlew uploadArchives
+  "$BASEDIR"/gradlew publish
 fi