Summary: When running tests locally, some are quite flaky, and there is a lot of error logging noise. This diff doesn't remove all of it, but does reduce it significantly.
Reviewed By: nikoant
Differential Revision: D20034619
fbshipit-source-id: 183f74475b644f803b2f92b1b1301f4d0f6e193a
Summary:
This sets up a basic UI for a bundling command. It checks for the source, creates an output directory if necessary and automatically creates an output name, so it should hopefully be as intuitive as possible.
There are plenty of potential error case that I don't directly handle. That's something we may want to consider in the future.
Reviewed By: nikoant
Differential Revision: D19973889
fbshipit-source-id: 5638ed0e45187c5ad567b9e2559c8befe52c6085
Summary:
## The dependency [uuid](https://github.com/uuidjs/uuid) was updated from `3.4.0` to `7.0.0`.
This version is **not covered** by your **current version range**.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
---
**Publisher:** [ctavan](https://www.npmjs.com/~ctavan)
**License:** MIT
[Find out more about this release](https://github.com/uuidjs/uuid).
---
<details>
<summary>FAQ and help</summary>
There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>
---
Your [Greenkeeper](https://greenkeeper.io) bot 🌴
Pull Request resolved: https://github.com/facebook/flipper/pull/827
Reviewed By: jknoxville
Differential Revision: D20067749
Pulled By: passy
fbshipit-source-id: 045c94cc1c28f0854680340f56bb35b854a37c51
Summary: The constructor is getting quite a few args now, so to avoid string, string mistakes I'm making sure you pass objects with named params.
Reviewed By: passy, mweststrate
Differential Revision: D20034012
fbshipit-source-id: 4e0d23eeaa9100c6c19d3e36fee62649659ad261
Summary:
Provides some really nice helpers and generators for
multi command CLIs, including test helpers and all
sorts of output niceties. This should make it quite
easy for us to add additional sub-commands for
bundling, publishing and keeping docs for all of it.
Heroku maintains this and provides some excellent
docs, too: https://oclif.io/
My only complaint is that it's class-based but that's
effectively only the way to declare new commands and
enforces a set of required/static properties on it.
Reviewed By: nikoant
Differential Revision: D19970293
fbshipit-source-id: 4228e502198c6fd376854a90ed2f01da29e96bc2
Summary: This will query for and display all of the associated theme information for each of the descriptors.
Reviewed By: passy
Differential Revision: D20008056
fbshipit-source-id: 720d224144b0822528ca8e23cdbec9fe9dd25e6b
Summary:
We don't want to test again against the compiled JS output.
Also, we *do* want to fail if we break the config and don't
actually run any tests.
Reviewed By: nikoant
Differential Revision: D20068114
fbshipit-source-id: c46e5a25fcd155d160f717a9db8f088787913a28
Summary:
## The dependency [uuid](https://github.com/uuidjs/uuid) was updated from `3.4.0` to `7.0.0`.
This version is **not covered** by your **current version range**.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
---
**Publisher:** [ctavan](https://www.npmjs.com/~ctavan)
**License:** MIT
[Find out more about this release](https://github.com/uuidjs/uuid).
---
<details>
<summary>FAQ and help</summary>
There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>
---
Your [Greenkeeper](https://greenkeeper.io) bot 🌴
Pull Request resolved: https://github.com/facebook/flipper/pull/828
Reviewed By: cekkaewnumchai
Differential Revision: D20067757
Pulled By: passy
fbshipit-source-id: ac9e7f6aaff86e30c320c427323627ac732ddb73
Summary:
== Highlights ==
- Android: Theme information for Application, Activity and View descriptors are now visible in the Layout plugin. (6f4de969fb)
- App Visualiser: When importing an archived device, you can now see and inspect the last screen of the app. (20db85adf4)
== Fixes ==
- Fix `FlipperKit` warnings in XCode. (972277b031)
- Upgrade Folly to v2020.02.17.00 (GH809)
- Several performance improvements, originally caused by unnecessary rerenders.
- Crash reports weren't scrollable. (e1e8bb841c)
- Kill orhpaned instruments processes. (GH819)
Reviewed By: nikoant
Differential Revision: D20067792
fbshipit-source-id: 3f0ebcb03881373fd909f513e5d82e23a5f9f1f1
Summary: Use dev bundling for "yarn start"
Reviewed By: jknoxville
Differential Revision: D20034300
fbshipit-source-id: a46c75074c969f5a4958f498c5c0e15aab808552
Summary: Skip the main process code bundling when nothing changed
Reviewed By: mweststrate
Differential Revision: D20030261
fbshipit-source-id: 78de87377afe7e768627059425c51081239687dd
Summary:
As a first step I've configured bundling for the main process code using Metro. For now I haven't converted anything to ts, just made that possible.
The bundle is just produced into the "static" directory. To avoid too many changes I kept the "static" folder as it is, but probably non-static code should be moved from there.
Also installed modules from "node_modules" for the main process are not bundled to avoid potential issues with node native modules.
Reviewed By: mweststrate
Differential Revision: D19960982
fbshipit-source-id: efbd426254e2b37c913c5f5f75f042c50ccee2f3
Summary:
Tried to upgrade both electron and electron-builder but failed due to Windows binary build stuck.
Upgraded only electron for now. electron-builder will be upgraded separately
Reviewed By: nikoant
Differential Revision: D19877865
fbshipit-source-id: a2282c2f4062e6b470cdcba2e9e693419bfeaec4
Summary:
This workflow is currently building the android app and then trying to upload the mac app (which isn't built) which is failing.
I think it should be uploading the android app instead.
Pull Request resolved: https://github.com/facebook/flipper/pull/820
Reviewed By: passy
Differential Revision: D20035055
Pulled By: jknoxville
fbshipit-source-id: 08367d464a045b47cf1b8b5395fd2151793a23cf
Summary:
Adds a visual indicator of layout nodes when using an archived device.
The "device" window isn't movable for some reason. I've tried the movable and draggable attributes but with no luck. It would obviously be good to fix that but I think its probably shippable as is, and I don't have any more ideas about how to do it.
Reviewed By: passy
Differential Revision: D19885719
fbshipit-source-id: 186ba38c85afee18ce111e30187bdccd9b919025
Summary:
Fix https://github.com/facebook/flipper/issues/808
Kills any orphaned Instruments processes belonging to the user.
In some cases, we've seen interactions between Instruments and the iOS
simulator that cause hung instruments and DTServiceHub processes. If
enough instances pile up, the host machine eventually becomes
unresponsive. Until the underlying issue is resolved, manually kill any
orphaned instances (where the parent process has died and PPID is 1)
before launching another instruments run.
Taking the same approach as done by flutter here.
Reviewed By: passy
Differential Revision: D20030005
Pulled By: jknoxville
fbshipit-source-id: aa80be78c80f7797e88bf29b15f90d4aad0c66e4
Summary: When determing whether to queue a message, the logic checked if the plugin is enabled on the currently selected app, rather than checking if it is enabled for the receiving app. This diff fixes that.
Reviewed By: passy
Differential Revision: D20000055
fbshipit-source-id: 665f0a650dcee8f7f46aa56f399a4f7d0d0aa1e0
Summary: Adding the new "Identity" section to CK root views' description.
Reviewed By: cuva
Differential Revision: D19948784
fbshipit-source-id: f5e7fe51afd387a476f6500db32b8b5149594007
Summary:
Discussed that we want this to be both a library and a CLI
tool. Also added a README stub.
Reviewed By: nikoant
Differential Revision: D19969788
fbshipit-source-id: 2c54935ce5953d2053c7bdf601debe0e5e911647
Summary: Enabling greenkeeper in the next diff.
Reviewed By: nikoant
Differential Revision: D19969790
fbshipit-source-id: 9a81c0505429512dc2e70523ab0b87eb0c6a2050
Summary:
Device management was inconsistent so far, this diff addresses the following issues
* pending a subtle timing issue, a physical android device might also show up as emulator, so effectively the device would be shown twice, but with the same content
* Metro devices now behave more like the android devices: offline devices are replaced if it comes online again
* Generalized this logic; the reducer now forces serials to be unique
* Fixed issue where a Metro device that disconnected due to a connection failure would be archived twice
* Use the metro connection url as serial, to have a slightly more future proof serial
Reviewed By: jknoxville
Differential Revision: D19996385
fbshipit-source-id: 0f6e3ddc6444542553d25cc3b592591652d688f2
Summary:
Nested subobjects work but aren't very well typed in the layout plugin.
So changing it to help flipper work with it.
From:
```
positionOnScreen: {x: 234, y: 456},
```
to
```
positionOnScreenX: 234,
positionOnScreenY: 456,
```
Reviewed By: passy
Differential Revision: D19998161
fbshipit-source-id: 4e4d7ced3cb37c527bbdf65549ec436311a8c2b8
Summary: Fixed a bunch of key errors in the network plugin, when a plugin is selected
Reviewed By: passy
Differential Revision: D19980275
fbshipit-source-id: 0ae61ed3b655c03d11c848d3502f455a409dcdcf
Summary:
This issue fixes a bunch of performance issues:
* The introduction of a context menu around every _row_ in D18808544 breaks the internal contract between lists and rows that react-window has, causing empty element to appear during scrolling, and some optimizations not working. Fixed by wrapping the context menu at the right level
* Every time a new row is created for the listview, it gets fresh event handlers and column configurations. THis has been fixed by precomputing the column configuration and avoiding the need to close over the row data in the event handlers
* Added some stricter immutable typings to make sure we don't break the immutable contract somewhere
* Fix the introduction of on the fly styling generation, which isn't needed
Reviewed By: passy
Differential Revision: D19853595
fbshipit-source-id: dc82b6586889f4e8c7a437cfdc27a50dc33ba2a2
Summary:
If the browser makes a network request, and it fails, this is _always_ logged to the console, despite any error handling being in place. (see https://stackoverflow.com/questions/43012334/silence-neterr-connection-refused)
This diffs doesn't use the browser network stack, but the node network stack instead, which doesn't suffer from the same fate.
Reviewed By: passy
Differential Revision: D19995684
fbshipit-source-id: 4ffc12b820620c5310c140c1a3af63e5d2053a50
Summary: This will query for and display all of the associated theme information for each of the descriptors.
Reviewed By: passy
Differential Revision: D19987003
fbshipit-source-id: c9b51311d28712a1af76c45a434bfb25d28d5c54
Summary:
Hovering a tooltip container would cause the full application to re-render. (Even if there isn't an actual tooltip!).
Fixed it by killing legacy context code, and using proper fragments rather than returning arrays.
Reviewed By: priteshrnandgaonkar
Differential Revision: D19969775
fbshipit-source-id: 59f6470d03b6c476305681fde7bbe3f0dca063aa
Summary:
# Summary
Folly became once again incompatible with the Android NDK, which caused our CI to fail to produce sample APK builds on release. I managed to repro this on my machine and it's working again now.
Sadly, I had to patch another file manually because something about the template parameter inference wasn't working ...
# Notes
This was done by first bumping the version, then going through the compiler errors and simply removing the lines that the C++ compiler in the NDK had trouble inferring the types for. We were lucky in that the exported symbols this affected weren't actually used, so I copied over the file to `overrides/Folly/` and set up another copy rule in Gradle.
# Meta
Pull Request resolved: https://github.com/facebook/flipper/pull/809
Test Plan:
```
./gradlew :sample:assembleDebug
```
Internal, external CI.
Reviewed By: mweststrate
Differential Revision: D19948797
Pulled By: passy
fbshipit-source-id: b2e98d3a5c89b0fc77c157683cde90997232fee0
Summary:
Getting really pissed off with Travis and this has significantly shorter queue times.
Mind that this probably won't work until the Folly PR is merged.
Pull Request resolved: https://github.com/facebook/flipper/pull/810
Test Plan: CI
Reviewed By: mweststrate
Differential Revision: D19951126
Pulled By: passy
fbshipit-source-id: ed51ad5ec6d4df3a59784dbd31e7c1667593d04f
Summary:
This diff fixes the warnings raised from FlipperKit. Also this diff updates the deployement target of FlipperKit to iOS 10. Even wilde assumes the min deployment OS version to be iOS 10. In layout plugin we use [UIAccessibiltyTraiTabBar](https://developer.apple.com/documentation/uikit/uiaccessibility/uiaccessibilitytraits/1648592-tabbar), which assumes iOS 10 and above.
Partially fixes https://github.com/facebook/flipper/issues/803
Still there are some warnings which are coming from the dependencies outside of Flipper.
Reviewed By: passy
Differential Revision: D19941558
fbshipit-source-id: 31809fedb9aa297bc318b5af72e29e8444f0142f
Summary:
As per title.
Ran `arc lint -a --take CLANGFORMAT --paths-cmd 'hg files ./'` from xplat/sonar
Reviewed By: zertosh
Differential Revision: D19943131
fbshipit-source-id: c1dc10b27389fd6f54f055803519dac6bf0e7997
Summary: This diff runs CLANGFORMAT lint on SonarKitTests. I have added CLANGFORMAT as the lint engined for objc files in xplat/sonar. Right now the iOS folder is not formatted according to CLANGFORMAT.
Reviewed By: cekkaewnumchai
Differential Revision: D19942169
fbshipit-source-id: d4a51dd4ffba3acb30177345c51eb469124f9f5f
Summary: This diff runs CLANGFORMAT lint on sample. I have added CLANGFORMAT as the lint engined for objc files in xplat/sonar. Right now the iOS folder is not formatted according to CLANGFORMAT.
Reviewed By: passy
Differential Revision: D19942174
fbshipit-source-id: bef3e67bf31f13bb52417c81c4c330d6c258872d
Summary:
This diff runs CLANGFORMAT lint on plugins. I have added CLANGFORMAT as the lint engined for objc files in xplat/sonar. Right now the iOS folder is not formatted according to CLANGFORMAT.
Ran `arc lint -a --paths-cmd "find ./iOS/Plugins -type f" --verbose`
Reviewed By: passy
Differential Revision: D19942173
fbshipit-source-id: 8b975b0a344df073b02d69cd1f9ee5629af2799d
Summary:
This diff runs CLANGFORMAT lint on FlipperKitTestUtils. I have added CLANGFORMAT as the lint engined for objc files in xplat/sonar. Right now the iOS folder is not formatted according to CLANGFORMAT.
Ran `arc lint -a --paths-cmd "find ./iOS/FlipperKitTestUtils -type f" --verbose`
Reviewed By: passy
Differential Revision: D19942175
fbshipit-source-id: a5067100e604aad438fef1842157217a8cd1734c
