Fix warnings of FlipperKit in iOS
Summary: This diff fixes the warnings raised from FlipperKit. Also this diff updates the deployement target of FlipperKit to iOS 10. Even wilde assumes the min deployment OS version to be iOS 10. In layout plugin we use [UIAccessibiltyTraiTabBar](https://developer.apple.com/documentation/uikit/uiaccessibility/uiaccessibilitytraits/1648592-tabbar), which assumes iOS 10 and above. Partially fixes https://github.com/facebook/flipper/issues/803 Still there are some warnings which are coming from the dependencies outside of Flipper. Reviewed By: passy Differential Revision: D19941558 fbshipit-source-id: 31809fedb9aa297bc318b5af72e29e8444f0142f
This commit is contained in:
Pritesh Nandgaonkar
committed by
Facebook Github Bot
Facebook Github Bot
parent
bd388f73e4
commit
972277b031
@@ -17,7 +17,7 @@ Pod::Spec.new do |spec|
|
||||
spec.source = { :git => 'https://github.com/facebook/Sonar.git',
|
||||
:tag=> "v"+flipperkit_version }
|
||||
spec.module_name = 'FlipperKit'
|
||||
spec.platforms = { :ios => "8.4" }
|
||||
spec.platforms = { :ios => "10.0" }
|
||||
spec.default_subspecs = "Core"
|
||||
|
||||
# This subspec is necessary since FBDefines.h is imported as <FBDefines/FBDefines.h>
|
||||
|
||||
@@ -120,7 +120,7 @@ static NSString* const kSKCellIdentifier =
|
||||
}
|
||||
|
||||
- (UIInterfaceOrientation)preferredInterfaceOrientationForPresentation {
|
||||
return UIInterfaceOrientationMaskPortrait;
|
||||
return UIInterfaceOrientationPortrait;
|
||||
}
|
||||
|
||||
@end
|
||||
|
||||
@@ -11,7 +11,7 @@
|
||||
|
||||
SK_EXTERN_C_BEGIN
|
||||
void FlipperPerformBlockOnMainThread(
|
||||
void (^block)(),
|
||||
void (^block)(void),
|
||||
id<FlipperResponder> responder);
|
||||
SK_EXTERN_C_END
|
||||
|
||||
|
||||
@@ -10,7 +10,7 @@
|
||||
#import "FlipperResponder.h"
|
||||
|
||||
void FlipperPerformBlockOnMainThread(
|
||||
void (^block)(),
|
||||
void (^block)(void),
|
||||
id<FlipperResponder> responder) {
|
||||
if ([NSThread isMainThread]) {
|
||||
@try {
|
||||
|
||||
@@ -177,7 +177,7 @@ static CK::StaticMutex _mutex = CK_MUTEX_INITIALIZER;
|
||||
NSMutableArray<NSDictionary<NSString*, NSObject*>*>* responders =
|
||||
[NSMutableArray new];
|
||||
|
||||
for (const auto action : _actions) {
|
||||
for (const auto& action : _actions) {
|
||||
if ((action.first & [controlEvent integerValue]) == 0) {
|
||||
continue;
|
||||
}
|
||||
|
||||
@@ -46,7 +46,6 @@
|
||||
@"currentTitleColor" :
|
||||
SKMutableObject(node.currentTitleColor),
|
||||
}]];
|
||||
|
||||
return data;
|
||||
}
|
||||
|
||||
|
||||
@@ -16,8 +16,7 @@
|
||||
@interface FlipperKitNetworkPlugin
|
||||
: SKBufferingPlugin<SKNetworkReporterDelegate>
|
||||
|
||||
- (instancetype)initWithNetworkAdapter:(id<SKNetworkAdapterDelegate>)adapter
|
||||
NS_DESIGNATED_INITIALIZER;
|
||||
- (instancetype)initWithNetworkAdapter:(id<SKNetworkAdapterDelegate>)adapter;
|
||||
- (instancetype)initWithNetworkAdapter:(id<SKNetworkAdapterDelegate>)adapter
|
||||
queue:(dispatch_queue_t)
|
||||
queue; // For test purposes
|
||||
|
||||
@@ -13,7 +13,7 @@
|
||||
|
||||
@interface SKBufferingPlugin : NSObject<FlipperPlugin>
|
||||
|
||||
- (instancetype)initWithQueue:(dispatch_queue_t)queue NS_DESIGNATED_INITIALIZER;
|
||||
- (instancetype)initWithQueue:(dispatch_queue_t)queue;
|
||||
|
||||
- (void)send:(NSString*)method
|
||||
sonarObject:(NSDictionary<NSString*, id>*)sonarObject;
|
||||
|
||||
@@ -10,13 +10,13 @@
|
||||
@interface SKRequestInfo : NSObject
|
||||
@property(assign, readwrite) int64_t identifier;
|
||||
@property(assign, readwrite) uint64_t timestamp;
|
||||
@property(strong, nonatomic) NSURLRequest* request;
|
||||
@property(strong, nonatomic) NSString* body;
|
||||
@property(strong, nonatomic) NSURLRequest* _Nullable request;
|
||||
@property(strong, nonatomic) NSString* _Nullable body;
|
||||
|
||||
- (instancetype)initWithIdentifier:(int64_t)identifier
|
||||
timestamp:(uint64_t)timestamp
|
||||
request:(NSURLRequest*)request
|
||||
data:(NSData*)data;
|
||||
- (instancetype _Nonnull)initWithIdentifier:(int64_t)identifier
|
||||
timestamp:(uint64_t)timestamp
|
||||
request:(NSURLRequest* _Nullable)request
|
||||
data:(NSData* _Nullable)data;
|
||||
- (void)setBodyFromData:(NSData* _Nullable)data;
|
||||
|
||||
@end
|
||||
|
||||
@@ -11,13 +11,13 @@
|
||||
|
||||
@property(assign, readwrite) int64_t identifier;
|
||||
@property(assign, readwrite) uint64_t timestamp;
|
||||
@property(strong, nonatomic) NSURLResponse* response;
|
||||
@property(strong, nonatomic) NSString* body;
|
||||
@property(strong, nonatomic) NSURLResponse* _Nullable response;
|
||||
@property(strong, nonatomic) NSString* _Nullable body;
|
||||
|
||||
- (instancetype)initWithIndentifier:(int64_t)identifier
|
||||
timestamp:(uint64_t)timestamp
|
||||
response:(NSURLResponse*)response
|
||||
data:(NSData*)data;
|
||||
- (instancetype _Nonnull)initWithIndentifier:(int64_t)identifier
|
||||
timestamp:(uint64_t)timestamp
|
||||
response:(NSURLResponse* _Nullable)response
|
||||
data:(NSData* _Nullable)data;
|
||||
- (void)setBodyFromData:(NSData* _Nullable)data;
|
||||
|
||||
@end
|
||||
|
||||
@@ -3,7 +3,7 @@ source 'https://github.com/facebook/Sonar.git'
|
||||
source 'https://github.com/CocoaPods/Specs'
|
||||
|
||||
target 'Sample' do
|
||||
platform :ios, '9.0'
|
||||
platform :ios, '10.0'
|
||||
pod 'FlipperKit', :path => '../../FlipperKit.podspec'
|
||||
pod 'FlipperKit/FlipperKitLayoutComponentKitSupport', :path => '../../FlipperKit.podspec'
|
||||
pod 'FlipperKit/SKIOSNetworkPlugin', :path => '../../FlipperKit.podspec'
|
||||
|
||||
@@ -3,7 +3,7 @@ source 'https://github.com/facebook/Sonar.git'
|
||||
source 'https://github.com/CocoaPods/Specs'
|
||||
|
||||
target 'SampleSwift' do
|
||||
platform :ios, '9.0'
|
||||
platform :ios, '10.0'
|
||||
pod 'Flipper', :path => '../../Flipper.podspec'
|
||||
pod 'FlipperKit', :path => '../../FlipperKit.podspec'
|
||||
pod 'FlipperKit/SKIOSNetworkPlugin', :path => '../../FlipperKit.podspec'
|
||||
|
||||
@@ -4,7 +4,7 @@ flipperkit_version = '0.31.2'
|
||||
use_frameworks!
|
||||
|
||||
target 'Tutorial' do
|
||||
platform :ios, '9.0'
|
||||
platform :ios, '10.0'
|
||||
|
||||
pod 'FlipperKit', '~>' + flipperkit_version
|
||||
# Layout and network plugins are not yet supported for swift projects
|
||||
|
||||
Reference in New Issue
Block a user