jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Change positionOnScreen to positionOnScreen{X,Y}

Browse Source 
Summary:
Nested subobjects work but aren't very well typed in the layout plugin.
So changing it to help flipper work with it.
From:
```
positionOnScreen: {x: 234, y: 456},
```
to
```
positionOnScreenX: 234,
positionOnScreenY: 456,
```

Reviewed By: passy

Differential Revision: D19998161

fbshipit-source-id: 4e4d7ced3cb37c527bbdf65549ec436311a8c2b8
This commit is contained in:
John Knox
2020-02-20 11:21:24 -08:00
committed by Facebook Github Bot
parent 35eeebffd0
commit c262ab4e14
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
android/src/main/java/com/facebook/flipper/plugins/inspector/descriptors/ViewDescriptor.java
View File

@@ -150,12 +150,8 @@ public class ViewDescriptor extends NodeDescriptor<View> {
new FlipperObject.Builder()
.put("x", InspectorValue.mutable(node.getPivotX()))
.put("y", InspectorValue.mutable(node.getPivotY())))
.put(
"positionOnScreen",
new FlipperObject.Builder()
.put("x", positionOnScreen[0])
.put("y", positionOnScreen[1])
.build());
.put("positionOnScreenX", positionOnScreen[0])
.put("positionOnScreenY", positionOnScreen[1]);
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN_MR1) {
viewProps