Commit Graph

7387 Commits

Author SHA1 Message Date
Colin Bendell
1e1cc37c3b cleanup 2022-09-08 12:05:53 +01:00
Colin Bendell
2216a3f94d add static binary to repo 2022-09-08 12:05:53 +01:00
Colin Bendell
6cc083b860 Update to enable universal builds of Flipper
* added PortForwardingMacApp project target
* updated Podfiles
* updated electron builder to 22.14.10
* updated electron to 16.0.3
* added universal architecture to the build process
2022-09-08 12:05:53 +01:00
Jeferson S. Brito
2b927b4e72 fix: 404 docs links in app inspect (#4042)
Summary:
Currently, the `app inspect` tooltip at the left rail has a link to the getting started page that doesn't exist.
New path is `/docs/getting-started/`.

Also fix troubleshooting guide and no devices are found to `/docs/getting-started/troubleshooting/`

Pull Request resolved: https://github.com/facebook/flipper/pull/4042

Reviewed By: lawrencelomax

Differential Revision: D39314971

Pulled By: lblasa

fbshipit-source-id: 000b354b60bd05211b99134b63d790bf6949060f
2022-09-08 03:45:47 -07:00
Matt Hamil
eb98a042b7 docs: fix broken header in callout block on Getting Started page (#4044)
Summary:
Changes the callout block header to separate the icon from the header of the callout.

The "information" callout at https://fbflipper.com/docs/getting-started/ displays the info icon and "RMATION".

![image](https://user-images.githubusercontent.com/11802078/187704594-2d9553b1-b754-48b9-b55d-7d64b2fd20ee.png)

## Changelog

Fixed broken header in a callout block in the getting started docs page

Pull Request resolved: https://github.com/facebook/flipper/pull/4044

Test Plan:
Build the docs and open `/docs/getting-started/`

**Static Docs Preview: flipper**
|[Full Site](https://our.intern.facebook.com/intern/staticdocs/eph/D39314921/V4/flipper/)|

|**Modified Pages**|
|[docs/getting-started](https://our.intern.facebook.com/intern/staticdocs/eph/D39314921/V4/flipper/docs/getting-started/)|

Reviewed By: lawrencelomax

Differential Revision: D39314921

Pulled By: lblasa

fbshipit-source-id: 0d7edc28e5457e0f68e93e871b3518711d35ccc1
2022-09-08 03:35:01 -07:00
Lorenzo Blasa
ccec5a6abe Add a very simple attributes inspector
Summary: Add a very simple attributes inspector

Reviewed By: LukeDefeo

Differential Revision: D39306728

fbshipit-source-id: 0e46b3efc617253d0b3006e81a46f00fdf8e8457
2022-09-07 06:46:41 -07:00
Luke De Feo
2fc1ff9f9c Added increment activity
Summary: Added simple activity to test how flipper reacts to changes in native UI

Reviewed By: passy

Differential Revision: D38704012

fbshipit-source-id: 8a593577322922c6f6f0f96dd5cb0761c3035389
2022-09-07 04:37:17 -07:00
Luke De Feo
0426966b14 Additional test activities
Summary: Some activities for testing the UI debugger

Reviewed By: lblasa

Differential Revision: D39208140

fbshipit-source-id: a6fcc1f082df5dc61f72019f92a6307d0e90176e
2022-09-07 04:37:17 -07:00
Luke De Feo
41068d1c90 Native UI scan
Summary: Added scheduler to scan the Native UI every 500 ms to test, Also added instrumentation in a separate event with the timings of each stage visualised in a Data table on desktop which can be accessed with ctrl+I. Currently this instrumentation event is sent every time but it could be a config option controlled from the desktop in the future

Reviewed By: lblasa

Differential Revision: D39205313

fbshipit-source-id: ca034171db6b062396b4ef28028aaa663c4d852a
2022-09-07 04:37:17 -07:00
Luke De Feo
a5da6923eb Flatten layout during traversal
Summary: Move from a nested structure to a flatten one for data exchange, this will allow us to only send sections of the UI in the future

Reviewed By: lblasa

Differential Revision: D38982138

fbshipit-source-id: d578a07a6d2d7e117fbd741bd6e33062223ce10d
2022-09-07 04:37:17 -07:00
Luke De Feo
55b852f90c Basic tree UI
Summary: A very basic tree in Antd to visualise the UI

Reviewed By: lblasa

Differential Revision: D38977035

fbshipit-source-id: f9bbf765ea8027eeb263cad86407502c6a5779dd
2022-09-07 04:37:17 -07:00
Luke De Feo
f123e65e8f Added strongly typed tree for sidebar inspector
Summary:
Introduced a JSON like tree structure for the sidebar insepector. Descriptors can provide their data as well as  if its mutable or not.

Enum mapping was simplified

Reviewed By: lblasa

Differential Revision: D38947238

fbshipit-source-id: cd8a6a8a752c5f626582ab8ac5efae6e9ff6a2ad
2022-09-07 04:37:17 -07:00
Lorenzo Blasa
c69e737f19 README update
Summary: Add instructions for building and running our RNW sample application.

Reviewed By: antonk52

Differential Revision: D39305056

fbshipit-source-id: 2adb41d713381c1b79ea5fe55a4f8a40d43e7f4c
2022-09-07 03:53:50 -07:00
Lorenzo Blasa
8fb7c503b8 Add CI workflow (#4054)
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/4054

Build RNW example on Github

Reviewed By: aigoncharov

Differential Revision: D39257309

fbshipit-source-id: dda414c025bfe6720449fe6c3d81fe9fb9373b2a
2022-09-07 02:21:58 -07:00
Andrey Goncharov
9c7a53fd05 Fix iOS crash parsing
Reviewed By: lawrencelomax

Differential Revision: D39058673

fbshipit-source-id: 64065c6d7e9fa96e827419bd6cffbceccc110d89
2022-09-05 07:46:02 -07:00
Luke De Feo
c854d0a2bb Added kotlin serialization
Summary: ^

Reviewed By: lblasa

Differential Revision: D38976576

fbshipit-source-id: 32022c263a0c81e6e99478375592ef1be9fea1cf
2022-09-05 05:36:23 -07:00
Lorenzo Blasa
2d4ca7003e Fixes RN iOS (#4053)
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/4053

Update usage of RN `RCTBundleURLProvider` `jsBundleURLForBundleRoot` API.

The previous signature was removed in the current used RN version.

Reference:
https://github.com/facebook/react-native/blob/main/React/Base/RCTBundleURLProvider.h

Reviewed By: aigoncharov

Differential Revision: D39256797

fbshipit-source-id: 2074698597f691f46f6ffd2f6b569e7742d5fffc
2022-09-05 04:25:50 -07:00
Lorenzo Blasa
23ed745105 Update Java version in Github workflow (#4052)
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/4052

Update to use Java 11 instead of 1.8.

Aim is to bring parity with the other existing workflows but more importantly fix the build as is broken at the moment.

Reviewed By: antonk52

Differential Revision: D39254936

fbshipit-source-id: c60332a288d9a671df5db0180fb501ddf185a075
2022-09-05 03:54:17 -07:00
Lorenzo Blasa
6a9d54f93a Plugin and Module implementations
Summary:
Last diff in the the RNW saga.

This change creates the necessary bridgings between the module and the plugin.

With this in place, JS plugins can be written and used. Also, we have a fully functional RNW sample app.

Reviewed By: aigoncharov

Differential Revision: D39087480

fbshipit-source-id: f4fde404716aa619a64553ffa556d060f49c0ac7
2022-09-04 12:19:26 -07:00
Lorenzo Blasa
322a1ba6b1 Initialise Flipper on module initialisation
Summary:
^

This diff brings most things together and can be considered the test platform for RNW.

With this, Flipper client gets initialised and started.

This means the application connects and is ready for debugging.

Reviewed By: antonk52

Differential Revision: D39054912

fbshipit-source-id: 94397f6a72b1e9d9c0f2f3efaf9967be525076cd
2022-09-04 12:19:26 -07:00
Lorenzo Blasa
69df1ee362 Device Info
Summary: Utility class to obtain device information.

Reviewed By: antonk52

Differential Revision: D39054479

fbshipit-source-id: 9e237e2a45cf46ceb5fb8fd8a9da5d87837e61b6
2022-09-04 12:19:26 -07:00
Lorenzo Blasa
446bb042d0 React Socket
Summary: React ws implementations

Reviewed By: antonk52

Differential Revision: D39053839

fbshipit-source-id: 7e68770c7bc4e0a0307679713a8b210bba2bbd0b
2022-09-04 12:19:26 -07:00
Lorenzo Blasa
c2440b6660 WIN32 support for path concatenation
Summary:
So far, Flipper has concatenated paths assuming is only ever built on unix-like systems.

For RNW, this approach fails.

This change is a very simple way of achieving WIN32 support without using any extra libraries or routines for path building.

Reviewed By: antonk52

Differential Revision: D39053479

fbshipit-source-id: e8b4b71cc1d17ca6aba88d40cad7d96a30ad1267
2022-09-04 12:19:26 -07:00
Lorenzo Blasa
82c06ac280 React Scheduler
Summary: Introduces a Scheduler implementation using ReactDispatcher. The scheduler is/will be used by the FlipperConnectionManager as to serialise socket operations in it.

Reviewed By: antonk52

Differential Revision: D39053301

fbshipit-source-id: 5bc2d68a753ec4be3e28533b4c29e2d6ff6d8ba0
2022-09-04 08:02:21 -07:00
Yizhe Chen
09e81b19ad fix strict mode exemption to allow disk write as well
Summary: Filpper is doing disk IO on UI thread which actually produce `DiskWriteViolation` (presumably when the directory is not there, it will write to create)

Differential Revision: D39196484

fbshipit-source-id: f6b15785ea6ecf3ea5b41211908c14eac3d1309e
2022-09-01 17:39:49 -07:00
Deborah Attuah
95af1428ce automatic update for docusaurus-plugin-internaldocs-fb@0.12.3
Reviewed By: antonk52

Differential Revision: D39169091

fbshipit-source-id: 249c5f092c1b0f8e0d6f303e6ac96cdee019ecfa
2022-08-31 07:59:11 -07:00
Lorenzo Blasa
4b8be189ba rnw] ReactNativeFlipperExample
Summary:
This change is the direct results of doing the following:

    npx react-native-windows-init --overwrite

Notes: ignore the format warnings below. In this case, the ordering of includes does matter. Missing license is for auto-generated files, so ignore too.

Reviewed By: aigoncharov

Differential Revision: D36775215

fbshipit-source-id: 1cd00ff2bfc258c8505e97dcdbd9cb4365c4acfb
2022-08-26 08:43:30 -07:00
facebook-flipper-bot
25f40605a8 Automated: Update Podfile.lock (#4025)
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)

Pull Request resolved: https://github.com/facebook/flipper/pull/4025

Reviewed By: lblasa

Differential Revision: D38979176

Pulled By: cekkaewnumchai

fbshipit-source-id: d455bbdb5390340cd2b310d9be5045b088dbb994
2022-08-25 02:39:27 -07:00
Lorenzo Blasa
dab510c546 Fix starting screen captures
Summary:
Starting a screencapture longer than 30 seconds would timeout as the start command waits for the process to finish. Removed that wait is it is the stop command that should only wait for the finish.

(n.b. please ship after accepting, as I'm on PTO)

Reviewed By: LukeDefeo

Differential Revision: D38918570

fbshipit-source-id: fd93e1239985c81a2143ceb79312518e7ebb27f5
2022-08-25 02:18:40 -07:00
Lorenzo Blasa
947d00c6c3 Fix send raw messages
Summary:
^

The last change removed the overload of `send` in favour of `sendRaw`

Reviewed By: LukeDefeo

Differential Revision: D38946386

fbshipit-source-id: c4491c4afe4d719602c99878dc7185d436179aef
2022-08-24 11:17:21 -07:00
Lorenzo Blasa
1b2f875cc6 Scheduler
Summary:
Add a simple scheduler which operates in the following way.

There are two type of tasks: main, background.

The main task will run on the main thread whilst the background task will run on a background thread.

The main task will be executing at a fixed internal whereas the background task will get queued on demand but can effectively consume what was produced by the main task at its own rate.

Reviewed By: LukeDefeo

Differential Revision: D38975283

fbshipit-source-id: 0633385d2938705a16f5fc75a28cad067e4a8e55
2022-08-24 09:03:39 -07:00
Flipper Bot
2e33febcde Flipper Snapshot Bump: v0.162.1-SNAPSHOT
Summary: Releasing snapshot version 0.162.1-SNAPSHOT

Reviewed By: cekkaewnumchai

Differential Revision: D38973667

fbshipit-source-id: 845578ae7c00d74e0669723b7856274bb7214ea8
2022-08-24 03:55:15 -07:00
Flipper Bot
3734225dd7 Flipper Release: v0.162.0
Summary: Releasing version 0.162.0

Reviewed By: cekkaewnumchai

Differential Revision: D38973666

fbshipit-source-id: cb17fe83c805a1c4fbef69bf035f4437516665d0
2022-08-24 03:55:15 -07:00
Andrey Goncharov
5515b27499 Fix importing large Flipper exports
Reviewed By: lblasa

Differential Revision: D38945105

fbshipit-source-id: ba78ccfc82b65013b79c6c962de7bdef5ae41a60
2022-08-23 09:46:29 -07:00
Andrey Goncharov
9b58f5217e Catch crash file parsing errors
Reviewed By: passy

Differential Revision: D38940908

fbshipit-source-id: 59f0669311093a4a9c24f570d7e63de0a51f9376
2022-08-23 08:55:25 -07:00
Lorenzo Blasa
5aff69d1c9 traversal
Summary: This adds a simple traversal to the UI. As it stands, it will most likely be updated in future iterations.

Reviewed By: LukeDefeo

Differential Revision: D38907292

fbshipit-source-id: 98cea1f971a4ef37ba2d1c75b882dd44df29bb3a
2022-08-23 05:45:29 -07:00
Luke De Feo
f1e80b18b1 Basic desktop plugin
Summary:
Scaffolded desktop UI for UI debugger
I changed getroot from an rpc call to an event sent on connect. The root should never change as its the application object.

Reviewed By: lblasa

Differential Revision: D38866008

fbshipit-source-id: ca0f1908bedb643238f11ed796922e3359619167
2022-08-22 03:02:53 -07:00
Lorenzo Blasa
6adf1d666f Descriptors
Summary:
Introducing descriptors. Taken from the existing inspector, refreshed with a few things from Stetho, and translated to Kotlin.

Note: doesn't use FlipperObject or FlipperArray.

This is a very rough draft for them all, but can be used as basis for experimentation.

Reviewed By: LukeDefeo

Differential Revision: D38860763

fbshipit-source-id: 9f6bf4ad0e61fc40b0a773dfb8bfa80b1f397b3a
2022-08-19 08:47:58 -07:00
Lorenzo Blasa
b5bdd56d2c Application to instantiate Plugin
Summary:
Plugin needs both the Context and Application. Application is Context. Pass Application.

:)

Reviewed By: LukeDefeo

Differential Revision: D38831033

fbshipit-source-id: ff12a8ddc875fb54389e591a1c1c9febedb3aa37
2022-08-19 08:47:58 -07:00
Lorenzo Blasa
fbbb793497 Shutdown flipper-server on Flipper Desktop launch
Summary: At launch, if flipper-server is running, send the shutdown message.

Reviewed By: passy

Differential Revision: D38861178

fbshipit-source-id: 4aab5f2b50938cb70a2dfae0d9056df337baecc3
2022-08-19 06:41:38 -07:00
Adam Ernst
0aa1f14536 Remove @scarf-generated from xplat/sonar
Summary: See D38829381.

Reviewed By: d16r

Differential Revision: D38837720

fbshipit-source-id: c576e16ebb5a0afd5e6dfc71adb3cf0c2361e9a3
2022-08-19 05:54:13 -07:00
Lorenzo Blasa
dc28e2ad45 ApplicationRef
Summary:
Introduce ApplicationRef which holds a reference to Application. It exposes a few utility methods to get view roots and activities.

ApplicationInspector has a few template methods for useful things which are not used in this diff and most likely will either be moved/deleted/changed on the final implementation.

Reviewed By: LukeDefeo

Differential Revision: D38829523

fbshipit-source-id: b8aeb133dceb3af42b5f7d6851ef531d35fc7d69
2022-08-19 05:08:49 -07:00
Flipper Bot
c861b3af4d Flipper Snapshot Bump: v0.161.1-SNAPSHOT
Summary: Releasing snapshot version 0.161.1-SNAPSHOT

Reviewed By: lblasa

Differential Revision: D38858848

fbshipit-source-id: d05120295e49095ded355555e4c2f76848084c41
2022-08-19 05:02:55 -07:00
Flipper Bot
f9afe75a81 Flipper Release: v0.161.0
Summary: Releasing version 0.161.0

Reviewed By: lblasa

Differential Revision: D38858847

fbshipit-source-id: 56a356ed7028110fb028f36a490efb6fa61a3598
2022-08-19 05:02:55 -07:00
Pascal Hartig
c90ab4ed7b Change author from Facebook Inc to Meta
Reviewed By: mweststrate

Differential Revision: D38828665

fbshipit-source-id: b9beb1f445a0caeed536f2119694da00df825005
2022-08-19 04:31:32 -07:00
Michel Weststrate
075c9e1dda Disable NUX animations
Summary:
I noticed that on my Mac M1 Flipper feels really sluggish in term of interactions compared to my Mac Pro. Started profiling and notices we have continously 60 reflows/sec and a very continous stream of DOM nodes allocations. This in turn is caused by our NUX elements, whose opacity anymation causes a reflow, which causes our interactive container (used for resizable sidebars etc) do to some calculations.

This is quite noticeble in how fluent clicks etc are handled, as long as there are NUX-es open. Not sure why this doesn't feel as bad on Intel machines, but alas the effect is very clearly visible in the performance monitor. Or when dismissing all NUX-es, which drops the performance issue even in current builds.

Disabling the opacity anymation and giving it a fixed value, fixes the issue as well, which is done in this diff.

Changelog: Minor improvements on M1 machines

Reviewed By: passy

Differential Revision: D38859406

fbshipit-source-id: 3b97c6c8444290e2a0a8b17b175de9e44159e258
2022-08-19 04:28:43 -07:00
dependabot[bot]
32bda2e48c Bump react-native-flipper from 0.156.0 to 0.159.0 in /react-native/ReactNativeFlipperExample (#4010)
Summary:
Bumps [react-native-flipper](https://github.com/facebook/flipper) from 0.156.0 to 0.159.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/facebook/flipper/releases">react-native-flipper's releases</a>.</em></p>
<blockquote>
<h2>v0.159.0</h2>
<p>See <a href="https://github.com/facebook/flipper/blob/main/desktop/static/CHANGELOG.md">https://github.com/facebook/flipper/blob/main/desktop/static/CHANGELOG.md</a>
for full notes.</p>
<h2>v0.158.0</h2>
<p>See <a href="https://github.com/facebook/flipper/blob/main/desktop/static/CHANGELOG.md">https://github.com/facebook/flipper/blob/main/desktop/static/CHANGELOG.md</a>
for full notes.</p>
<h2>v0.157.0</h2>
<p>See <a href="https://github.com/facebook/flipper/blob/main/desktop/static/CHANGELOG.md">https://github.com/facebook/flipper/blob/main/desktop/static/CHANGELOG.md</a>
for full notes.</p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="a2df0e36e3"><code>a2df0e3</code></a> Flipper Release: v0.159.0</li>
<li><a href="02c21f5cb0"><code>02c21f5</code></a> Changed documentation with DataSource to be up to date</li>
<li><a href="b7c38556ce"><code>b7c3855</code></a> Name the Flipper scheduler/threads</li>
<li><a href="e1a305a6ca"><code>e1a305a</code></a> Flipper Snapshot Bump: v0.158.1-SNAPSHOT</li>
<li><a href="c96c5ca1a3"><code>c96c5ca</code></a> Flipper Release: v0.158.0</li>
<li><a href="a357e280c2"><code>a357e28</code></a> Fix highlight selection background colour</li>
<li><a href="7227f722ac"><code>7227f72</code></a> Apply rustfmt</li>
<li><a href="4d5b358beb"><code>4d5b358</code></a> Fix broken links</li>
<li><a href="e91a94393d"><code>e91a943</code></a> Flipper Snapshot Bump: v0.157.1-SNAPSHOT</li>
<li><a href="714ee44929"><code>714ee44</code></a> Flipper Release: v0.157.0</li>
<li>Additional commits viewable in <a href="https://github.com/facebook/flipper/compare/v0.156.0...v0.159.0">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=react-native-flipper&package-manager=npm_and_yarn&previous-version=0.156.0&new-version=0.159.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/4010

Reviewed By: lblasa

Differential Revision: D38833293

Pulled By: passy

fbshipit-source-id: 2373455f469273e3b29514633539e27e24a38d34
2022-08-19 03:58:23 -07:00
Lorenzo Blasa
769a1844b7 Common types
Summary:
EnumMapping and InspectableValue taken from the original 'inspector' plugin but translated to Kotlin.

Accumulator is just a Map<String, Any>

Reviewed By: LukeDefeo

Differential Revision: D38823678

fbshipit-source-id: 6af395cab2e3e6930575eb63d22d660dab962fde
2022-08-19 03:39:06 -07:00
dependabot[bot]
9c8f80c70c Bump dokka-gradle-plugin from 1.6.21 to 1.7.10 (#3916)
Summary:
Bumps [dokka-gradle-plugin](https://github.com/Kotlin/dokka) from 1.6.21 to 1.7.10.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/Kotlin/dokka/releases">dokka-gradle-plugin's releases</a>.</em></p>
<blockquote>
<h2>1.7.10 Beta</h2>
<p>Bugfix release that addresses several blockers and regressions.</p>
<h3>General</h3>
<ul>
<li>Support <code>Kotlin</code> 1.7.10</li>
</ul>
<h3>Gradle plugin</h3>
<ul>
<li>Do not expose <code>Kotlin</code> stdlib in plugin dependencies, this should fix errors like <code>Module was compiled with an incompatible version of Kotlin</code> when using <code>Dokka</code>. Thanks to <a href="https://github.com/martinbonnin"><code>@​martinbonnin</code></a> (<a href="https://github-redirect.dependabot.com/Kotlin/dokka/issues/2543">https://github.com/facebook/flipper/issues/2543</a>)</li>
</ul>
<h3>Java sources</h3>
<ul>
<li>Fixed build failure caused by having configured source links for <code>Java</code> code (<a href="https://github-redirect.dependabot.com/Kotlin/dokka/issues/2544">https://github.com/facebook/flipper/issues/2544</a>)</li>
<li>Fixed several exotic problems that led to build failures, all related to using annotation in <code>Java</code> sources (<a href="https://github-redirect.dependabot.com/Kotlin/dokka/issues/2509">https://github.com/facebook/flipper/issues/2509</a>, <a href="https://github-redirect.dependabot.com/Kotlin/dokka/issues/2551">https://github.com/facebook/flipper/issues/2551</a>, <a href="https://github-redirect.dependabot.com/Kotlin/dokka/issues/2350">https://github.com/facebook/flipper/issues/2350</a>)</li>
<li>Fixed <code>IntelliJ</code> platform <code>WARN: Attempt to load key</code> messages that appeared when analyzing <code>Java</code> sources (<a href="https://github-redirect.dependabot.com/Kotlin/dokka/issues/2559">https://github.com/facebook/flipper/issues/2559</a>)</li>
</ul>
<h2>1.7.0 Beta</h2>
<h2>Improvements</h2>
<h3>General</h3>
<ul>
<li>Update to <code>Kotlin</code> 1.7.0, <code>IntelliJ</code> Platform 213</li>
<li>Support <a href="https://kotlinlang.org/docs/whatsnew17.html#stable-definitely-non-nullable-types">definitely non-nullable types</a> (<a href="https://github-redirect.dependabot.com/Kotlin/dokka/pull/2520">Kotlin/dokka#2520</a>)</li>
<li>Don't expose enum entry constructor arguments, thanks to <a href="https://github.com/ebraminio"><code>@​ebraminio</code></a> (<a href="https://github-redirect.dependabot.com/Kotlin/dokka/pull/2497">Kotlin/dokka#2497</a>)</li>
<li>Preserve ordering of enum entries as in source code, previously reversed (<a href="https://github-redirect.dependabot.com/Kotlin/dokka/pull/2469">Kotlin/dokka#2469</a>)</li>
<li>Improve support for inherited <code>Java</code> fields with accessors, now properly interpreted as <code>val</code>/<code>var</code> properties (<a href="https://github-redirect.dependabot.com/Kotlin/dokka/pull/2481">Kotlin/dokka#2481</a>, <a href="https://github-redirect.dependabot.com/Kotlin/dokka/pull/2532">Kotlin/dokka#2532</a>, <a href="https://github-redirect.dependabot.com/Kotlin/dokka/pull/2540">Kotlin/dokka#2540</a>)</li>
<li>Skip <code>Deprecated</code> members with <code>HIDDEN</code> level (<a href="https://github-redirect.dependabot.com/Kotlin/dokka/pull/2486">Kotlin/dokka#2486</a>)</li>
<li>Make rendered default value dependent on source set for expect/actual declarations (<a href="https://github-redirect.dependabot.com/Kotlin/dokka/pull/2449">Kotlin/dokka#2449</a>)</li>
</ul>
<h3>HTML format</h3>
<ul>
<li>Render quotes as blockquotes instead of code blocks, thanks to <a href="https://github.com/TheOnlyTails"><code>@​TheOnlyTails</code></a> (<a href="https://github-redirect.dependabot.com/Kotlin/dokka/pull/2496">Kotlin/dokka#2496</a>)</li>
</ul>
<h3>Javadoc format</h3>
<ul>
<li>Make <code>Javadoc</code> pages generation deterministic (<a href="https://github-redirect.dependabot.com/Kotlin/dokka/pull/2479">Kotlin/dokka#2479</a>)</li>
<li>Update shipped <code>jQuery</code> to avoid multiple CVEs, thanks to <a href="https://github.com/ToppleTheNun"><code>@​ToppleTheNun</code></a> (<a href="https://github-redirect.dependabot.com/Kotlin/dokka/issues/1938">Kotlin/dokka#1938</a>)</li>
</ul>
<h3>GFM format</h3>
<ul>
<li>Support rendering of code blocks and inline code used in KDocs, thanks to <a href="https://github.com/cosinekitty"><code>@​cosinekitty</code></a> (<a href="https://github-redirect.dependabot.com/Kotlin/dokka/pull/2485">Kotlin/dokka#2485</a>)</li>
</ul>
<h3>Kotlin-as-Java plugin</h3>
<ul>
<li>Include <code>Java</code> access modifiers into function signatures, thanks to <a href="https://github.com/tripolkaandrey"><code>@​tripolkaandrey</code></a> (<a href="https://github-redirect.dependabot.com/Kotlin/dokka/pull/2510">Kotlin/dokka#2510</a>)</li>
</ul>
<h3>Gradle runner</h3>
<ul>
<li>Make <code>dokka-analysis</code> dependency <code>compileOnly</code>, this should help avoid compatibility problems if different versions of <code>Kotlin</code> are bundled in <code>Gradle</code> and <code>Dokka</code> (<a href="https://github-redirect.dependabot.com/Kotlin/dokka/pull/2521">Kotlin/dokka#2521</a>)</li>
<li>Enable stricter validation for cacheable <code>Gradle</code> tasks, thanks to <a href="https://github.com/3flex"><code>@​3flex</code></a> (<a href="https://github-redirect.dependabot.com/Kotlin/dokka/pull/2500">Kotlin/dokka#2500</a>)</li>
<li>Remove unused &amp; redundant dependencies for <code>Gradle</code> runner, thanks to <a href="https://github.com/3flex"><code>@​3flex</code></a> (<a href="https://github-redirect.dependabot.com/Kotlin/dokka/pull/2502">Kotlin/dokka#2502</a>)</li>
<li>Remove outdated suppression in <code>Gradle</code> runner, thanks to <a href="https://github.com/3flex"><code>@​3flex</code></a> (<a href="https://github-redirect.dependabot.com/Kotlin/dokka/pull/2501">Kotlin/dokka#2501</a>)</li>
</ul>

</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="cfa433f59b"><code>cfa433f</code></a> Update references and documentation to Dokka 1.7.10 (<a href="https://github-redirect.dependabot.com/Kotlin/dokka/issues/2567">https://github.com/facebook/flipper/issues/2567</a>)</li>
<li><a href="5633f27b55"><code>5633f27</code></a> Ignore messages emitted by the IntelliJ Logger (<a href="https://github-redirect.dependabot.com/Kotlin/dokka/issues/2563">https://github.com/facebook/flipper/issues/2563</a>)</li>
<li><a href="b6ba965288"><code>b6ba965</code></a> Update Kotlin to 1.7.10 (<a href="https://github-redirect.dependabot.com/Kotlin/dokka/issues/2564">https://github.com/facebook/flipper/issues/2564</a>)</li>
<li><a href="fa175bdd95"><code>fa175bd</code></a> Improve handling of Java annotation parameters (<a href="https://github-redirect.dependabot.com/Kotlin/dokka/issues/2562">https://github.com/facebook/flipper/issues/2562</a>)</li>
<li><a href="6490083c03"><code>6490083</code></a> Do not generate source links for synthetic elements (<a href="https://github-redirect.dependabot.com/Kotlin/dokka/issues/2547">https://github.com/facebook/flipper/issues/2547</a>)</li>
<li><a href="e1e114b2c8"><code>e1e114b</code></a> Do not expose kotlin stdlib in the Gradle plugin dependencies (<a href="https://github-redirect.dependabot.com/Kotlin/dokka/issues/2543">https://github.com/facebook/flipper/issues/2543</a>)</li>
<li><a href="abd963b71f"><code>abd963b</code></a> Update documentation and examples to Dokka 1.7.0 (<a href="https://github-redirect.dependabot.com/Kotlin/dokka/issues/2542">https://github.com/facebook/flipper/issues/2542</a>)</li>
<li><a href="5e770efe41"><code>5e770ef</code></a> Update Dokka version to release</li>
<li><a href="89fc2494b4"><code>89fc249</code></a> Fix incorrectly labeling java properties as val/var (<a href="https://github-redirect.dependabot.com/Kotlin/dokka/issues/2540">https://github.com/facebook/flipper/issues/2540</a>)</li>
<li><a href="a11a8dd92f"><code>a11a8dd</code></a> Dont escape text inside gfm code blocks (<a href="https://github-redirect.dependabot.com/Kotlin/dokka/issues/2541">https://github.com/facebook/flipper/issues/2541</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/Kotlin/dokka/compare/v1.6.21...v1.7.10">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.jetbrains.dokka:dokka-gradle-plugin&package-manager=gradle&previous-version=1.6.21&new-version=1.7.10)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/3916

Reviewed By: lblasa

Differential Revision: D38833324

Pulled By: passy

fbshipit-source-id: 63b26b3bf08077d4616da0c017f20d26b28643fa
2022-08-19 02:57:58 -07:00
Lorenzo Blasa
d1c06c9c46 Do not overload send as this causes issues with folly::dynamic
Summary:
folly::dynamic, std::string, implicit constructors and method overloading is not a good combination.

This renames the send method to sendRaw as to avoid issues with existing plugins currently sending string params.

Reviewed By: mweststrate

Differential Revision: D38827539

fbshipit-source-id: 653f62e41ebfbe93d1af25f39c81f6b05bf84cb4
2022-08-18 09:39:42 -07:00