Do not overload send as this causes issues with folly::dynamic

Summary:
folly::dynamic, std::string, implicit constructors and method overloading is not a good combination.

This renames the send method to sendRaw as to avoid issues with existing plugins currently sending string params.

Reviewed By: mweststrate

Differential Revision: D38827539

fbshipit-source-id: 653f62e41ebfbe93d1af25f39c81f6b05bf84cb4

android/src/main/cpp/sonar.cpp

@@ -524,7 +524,7 @@ class JFlipperConnectionImpl
   }
 
   void sendString(const std::string method, const std::string params) {
-    _connection->send(std::move(method), std::move(params));
+    _connection->sendRaw(std::move(method), std::move(params));
   }
 
   void sendObject(

xplat/Flipper/FlipperConnection.h

@@ -38,7 +38,9 @@ class FlipperConnection {
    identifier.
    Note: The `message` argument is expected to contain a valid JSON.
    */
-  virtual void send(const std::string& method, const std::string& params) = 0;
+  virtual void sendRaw(
+      const std::string& method,
+      const std::string& params) = 0;
 
   /**
   Report an error to the Flipper desktop app

xplat/Flipper/FlipperConnectionImpl.h

@@ -53,7 +53,7 @@ class FlipperConnectionImpl : public FlipperConnection {
     socket_->sendMessage(message);
   }
 
-  void send(const std::string& method, const std::string& params) override {
+  void sendRaw(const std::string& method, const std::string& params) override {
     std::stringstream ss;
     ss << "{"
           "\"method\": \"execute\","
@@ -66,8 +66,8 @@ class FlipperConnectionImpl : public FlipperConnection {
        << "\","
           "\"params\":"
        << params << "}}";
-
-    socket_->sendMessage(ss.str());
+    auto message = ss.str();
+    socket_->sendMessage(message);
   }
 
   void error(const std::string& message, const std::string& stacktrace)

xplat/Flipper/FlipperConnectionManager.h

@@ -58,7 +58,7 @@ class FlipperConnectionManager {
    Send message to the ws server.
    Note: The `message` argument is expected to contain a valid JSON.
    */
-  virtual void sendMessage(const std::string& message) = 0;
+  virtual void sendMessageRaw(const std::string& message) = 0;
 
   /**
    Handler for connection and message receipt from the ws server.

xplat/Flipper/FlipperConnectionManagerImpl.cpp

@@ -341,7 +341,7 @@ void FlipperConnectionManagerImpl::sendMessage(const folly::dynamic& message) {
   });
 }
 
-void FlipperConnectionManagerImpl::sendMessage(const std::string& message) {
+void FlipperConnectionManagerImpl::sendMessageRaw(const std::string& message) {
   flipperScheduler_->schedule([this, message]() {
     try {
       if (client_) {

xplat/Flipper/FlipperConnectionManagerImpl.h

@@ -42,7 +42,7 @@ class FlipperConnectionManagerImpl : public FlipperConnectionManager {
 
   void sendMessage(const folly::dynamic& message) override;
 
-  void sendMessage(const std::string& message) override;
+  void sendMessageRaw(const std::string& message) override;
 
   void onMessageReceived(
       const folly::dynamic& message,

xplat/FlipperTestLib/FlipperConnectionManagerMock.h

@@ -40,7 +40,7 @@ class FlipperConnectionManagerMock : public FlipperConnectionManager {
     messages.push_back(message);
   }
 
-  void sendMessage(const std::string& message) override {
+  void sendMessageRaw(const std::string& message) override {
     messages.push_back(folly::parseJson(message));
   }
 

xplat/FlipperTestLib/FlipperConnectionMock.h

@@ -23,7 +23,7 @@ class FlipperConnectionMock : public FlipperConnection {
     sent_message_history[method].push(params);
   }
 
-  void send(const std::string& method, const std::string& params) override {
+  void sendRaw(const std::string& method, const std::string& params) override {
     sent_[method] = folly::parseJson(params);
     sent_message_history[method].push(params);
   }