Files
flipper/xplat/Flipper/FlipperConnectionImpl.h
Lorenzo Blasa d1c06c9c46 Do not overload send as this causes issues with folly::dynamic
Summary:
folly::dynamic, std::string, implicit constructors and method overloading is not a good combination.

This renames the send method to sendRaw as to avoid issues with existing plugins currently sending string params.

Reviewed By: mweststrate

Differential Revision: D38827539

fbshipit-source-id: 653f62e41ebfbe93d1af25f39c81f6b05bf84cb4
2022-08-18 09:39:42 -07:00

100 lines
2.8 KiB
C++

/*
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*/
#pragma once
#include <map>
#include <sstream>
#include <string>
#include "FlipperConnection.h"
#include "FlipperConnectionManager.h"
#include "Log.h"
namespace facebook {
namespace flipper {
class FlipperConnectionImpl : public FlipperConnection {
public:
FlipperConnectionImpl(
FlipperConnectionManager* socket,
const std::string& name)
: socket_(socket), name_(name) {}
void call(
const std::string& method,
const folly::dynamic& params,
std::shared_ptr<FlipperResponder> responder) {
if (receivers_.find(method) == receivers_.end()) {
std::string errorMessage = "Receiver " + method + " not found.";
log("Error: " + errorMessage);
responder->error(folly::dynamic::object("message", errorMessage));
return;
}
try {
receivers_.at(method)(params, responder);
} catch (const std::exception& ex) {
std::string errorMessage = "Receiver " + method + " failed with error. ";
std::string reason = ex.what();
errorMessage += "Error: '" + reason + "'.";
log("Error: " + errorMessage);
responder->error(folly::dynamic::object("message", errorMessage));
}
}
void send(const std::string& method, const folly::dynamic& params) override {
folly::dynamic message = folly::dynamic::object("method", "execute")(
"params",
folly::dynamic::object("api", name_)("method", method)(
"params", params));
socket_->sendMessage(message);
}
void sendRaw(const std::string& method, const std::string& params) override {
std::stringstream ss;
ss << "{"
"\"method\": \"execute\","
"\"params\": {"
"\"api\": \""
<< name_
<< "\","
"\"method\": \""
<< method
<< "\","
"\"params\":"
<< params << "}}";
auto message = ss.str();
socket_->sendMessage(message);
}
void error(const std::string& message, const std::string& stacktrace)
override {
socket_->sendMessage(folly::dynamic::object(
"error",
folly::dynamic::object("message", message)("stacktrace", stacktrace)));
}
void receive(const std::string& method, const FlipperReceiver& receiver)
override {
receivers_[method] = receiver;
}
/**
Runtime check which receivers are supported for this app
*/
bool hasReceiver(const std::string& method) {
return receivers_.find(method) != receivers_.end();
}
private:
FlipperConnectionManager* socket_;
std::string name_;
std::map<std::string, FlipperReceiver> receivers_;
};
} // namespace flipper
} // namespace facebook