Commit Graph

162 Commits

Author SHA1 Message Date
Pascal Hartig
93bc23e9cd Potential fix for artefact upload issue
Summary:
I've been investigating the now persistent upload issue for our artifacts and it appears to come down to artifacts being uploaded and downloaded as folder structures while they used to be individual files.

Annoyingly, the `ghr` tool we use for uploading throws a cryptic and misleading error: https://github.com/facebook/flipper/runs/4314584032?check_suite_focus=true

There is some more control in the `v2` version of the actions but for now, this seems like the safer option to fix this problem.

{F682461661}

Reviewed By: lblasa

Differential Revision: D32649218

fbshipit-source-id: 47ebefc434cb3b928b82a9fe8da3002b7b8465b6
2021-11-24 09:52:46 -08:00
Pascal Hartig
d9848ab6cf Upgrade upload action
Summary:
Fixed an issue with the setup of the retry script:

31ee58a796

Reviewed By: nikoant

Differential Revision: D32644463

fbshipit-source-id: 23ac1508784f24e9403e0bca0091f05847a9e91d
2021-11-24 06:31:15 -08:00
Pascal Hartig
dbe9106762 Create issue on publish failure (#3071)
Summary:
We've done this for the "release" part of the workflow
before but need to handle the "publish" branch separately.

Pull Request resolved: https://github.com/facebook/flipper/pull/3071

Test Plan: _eyes

Reviewed By: nikoant

Differential Revision: D32532348

Pulled By: passy

fbshipit-source-id: 622ed99ba509d4eaf7671e9b6ff3adbab277ab4e
2021-11-18 09:28:13 -08:00
Pascal Hartig
1b54a079f5 Upgrade upload actions (#3070)
Summary:
We're seeing some spurious failures, unrelated to any changes on our end.

I've upgraded the action to do two things:

- Retry on failure (up to three times): b0dfcdf1c7
- Replace the artefact if it's already present (otherwise this might fail subsequent retries): 92bec0ba48

Pull Request resolved: https://github.com/facebook/flipper/pull/3070

Reviewed By: nikoant

Differential Revision: D32532277

Pulled By: passy

fbshipit-source-id: f1899c89c405772490958674fa7f46f479c666f9
2021-11-18 08:50:26 -08:00
Pascal Hartig
c4fe39f413 Add failure issue tracking for release task (#3025)
Summary:
This failed without giving us a notification.

Pull Request resolved: https://github.com/facebook/flipper/pull/3025

Reviewed By: nikoant

Differential Revision: D32246987

Pulled By: mweststrate

fbshipit-source-id: da04b5d8e7e50480bdb0e0a5b55d387b0b23eced
2021-11-09 04:09:52 -08:00
Michel Weststrate
1e146d68c3 Fix publish script
Summary:
Changelog: Fix js-flipper package being published empty

Build js-flipper before publishing

Fixes(?) https://github.com/facebook/flipper/issues/3023

Reviewed By: jknoxville

Differential Revision: D32201978

fbshipit-source-id: 962b14fe1b5accb99bb06c098d86a6824599c967
2021-11-05 05:08:46 -07:00
Andrey Goncharov
3176c2f81d Update js-flipper in the pre-release phase and publish it
Summary:
1. Update js-flipper's version in pre-release
2. Update current version of js-flipper to match react-native-flipper
3. Publish js-flipper automatically

Reviewed By: mweststrate

Differential Revision: D31858522

fbshipit-source-id: e5a9816980d89d3ca6745bc16942f7b75f8d2a88
2021-10-25 04:35:12 -07:00
Pascal Hartig
0ae986758e Fix android build (#2956)
Summary:
Following mweststrate's advice on how to fix this.

Pull Request resolved: https://github.com/facebook/flipper/pull/2956

Test Plan: Watch the Action.

Reviewed By: lblasa

Differential Revision: D31502115

Pulled By: passy

fbshipit-source-id: 0f6dc73bcfde30fe7e2ee78e58d1c8e6fc16ec29
2021-10-08 06:55:05 -07:00
Pascal Hartig
4736abc29c Upgrade publish action
Summary: I upgraded the docker image which should pull the latest GHR release (https://github.com/tcnksm/ghr).

Reviewed By: lblasa

Differential Revision: D31442256

fbshipit-source-id: 0f9fa81ec1be1285aea3da621b7ef5a1e63c3e84
2021-10-08 03:40:49 -07:00
Pascal Hartig
111177b44e Upgrade to Node 14 for Actions (#2928)
Summary:
I believe that matches what we have internally. This has been causing some upgrades to fail.

Pull Request resolved: https://github.com/facebook/flipper/pull/2928

Reviewed By: aigoncharov

Differential Revision: D31324394

Pulled By: passy

fbshipit-source-id: eec38dcc6322e3e8957bbc20bf74d343855be8c0
2021-10-01 04:40:09 -07:00
Pascal Hartig
1ec7ebbdb5 Create issue on publish failure (#2904)
Summary:
Because the publish runs aren't triggered on the main branch, we have limited visibility. Sending push notifications, webhooks or email integrations are hard, but opening an issue seems like a decent work-around for this.

We can broaden this to more publish actions as needed.

Pull Request resolved: https://github.com/facebook/flipper/pull/2904

Test Plan: Ran on my fork which generated this issue: https://github.com/passy/flipper/issues/9

Reviewed By: mweststrate

Differential Revision: D31146956

Pulled By: passy

fbshipit-source-id: 08f66bd4c96a5ea2cc5e70a7461c30e7e1f3d42e
2021-09-27 06:10:08 -07:00
Pascal Hartig
da9511a5bf Fix CI build for Android (#2836)
Summary:
I've been really sweating about this one. It looks like Google now removed NDK 21 as it's too old. However, we've been struggling with the upgrade because OpenSSL was built against an old version of the NDK/glibc/LLVM/some other stuff.

I've now managed to create an OpenSSL distribution for 1.1.1k (we had 1.1.0h before) that seems to build with this after some small modifications.

This seems to do the trick, but I wouldn't be shocked if we found some more incompatibilities further down the line.

Pull Request resolved: https://github.com/facebook/flipper/pull/2836

Test Plan:
- Locally: `./gradlew :tutorial:installDebug`. Builds, starts up. Cool.
- Public GitHub CI: Happy.
- Circle CI: Only triggers post-land. We'll see. But the setup is simple, so hopefully it should work there, too.
- Internal CI: Waiting for signal.

Reviewed By: fabiomassimo

Differential Revision: D30839209

Pulled By: passy

fbshipit-source-id: efe599f28cc0edfdf2149f905c3483555239edc0
2021-09-09 08:46:59 -07:00
Pascal Hartig
781df776f2 Rename default branch references to main (#2689)
Summary:
I really hope I hit everything and didn't break anything that wasn't
referring to branch names.

Pull Request resolved: https://github.com/facebook/flipper/pull/2689

Test Plan:
_eyes

CI

|[Site Preview: flipper](https://our.intern.facebook.com/intern/staticdocs/eph/D30305789/V2/flipper/)

Reviewed By: timur-valiev

Differential Revision: D30305789

Pulled By: passy

fbshipit-source-id: 5daaa09250bb96bb50be679fc01dae86c666eb73
2021-08-13 15:00:39 -07:00
Pascal Hartig
4909296d86 Wrap yarn install with a retry (#2685)
Summary:
Often fails with things like "can't resolve github.com" ... I don't think there's a fix for that apart from trying again.

Pull Request resolved: https://github.com/facebook/flipper/pull/2685

Test Plan: Waiting for things to turn green here.

Reviewed By: timur-valiev

Differential Revision: D30301456

Pulled By: passy

fbshipit-source-id: 585758284e18bd02ab2a905b6f110a32099b861e
2021-08-13 03:34:23 -07:00
Pascal Hartig
3afcc9f415 Dependabot antispam (#2641)
Summary:
This is a starting point. `types/*` is aggressive but it's not only spammy but also should only really be used in combination with a dep update.

Pull Request resolved: https://github.com/facebook/flipper/pull/2641

Test Plan: hopeitwork

Reviewed By: nikoant

Differential Revision: D29992458

Pulled By: passy

fbshipit-source-id: f42023d2dff55bf2226ddd984c81a1cfa017b0bb
2021-07-30 03:35:04 -07:00
Pascal Hartig
4f3ee3ea57 Bump gradle-maven-publish-plugin from 0.16.0 to 0.17.0
Summary:
From the changelog:

> Removed the deprecated uploadArchives and installArchives tasks. Use publish and publishToMavenLocal instead.

Made the necessary changes to docs and scripts.

Reviewed By: nikoant

Differential Revision: D29752895

fbshipit-source-id: 6e96c7ea9b26be2acb40b9089cb361837ab10a1b
2021-07-29 09:35:04 -07:00
Pritesh Nandgaonkar
3f04577548 Pod lib lint subspecs in a concurrent manner (#2540)
Summary:
This PR splits the linting of the flipperkit pods into different subspecs. This will fasten the overall validation time. Before, all the pods were validated in a serialised fashion, but now its done in a parallel way.

This brings down the total validation time from 2+ hrs to ~ 25mins

## Changelog

- Split the validation of the FlipperKit pod into parallelised subspecs

Pull Request resolved: https://github.com/facebook/flipper/pull/2540

Test Plan: https://github.com/facebook/flipper/actions/runs/986790548

Reviewed By: passy

Differential Revision: D29489716

Pulled By: priteshrnandgaonkar

fbshipit-source-id: 55557c581d56ee01796ca64405cf78b647d2a68b
2021-06-30 09:52:19 -07:00
Pritesh Nandgaonkar
8ef5a62010 Update pod push script to handle multiple edge cases (#2511)
Summary:
This PR adds a script to publish pods. It handles different edge cases like:
- The version was already pushed but still you are trying to push it, it will skip in that case and give a proper message.
- This also makes sure that the same version Flipper pod exists before pushing FlipperKit.
- It also has the retry mechanism in place if at all the pod trunk push fails to push.

## Changelog

Updated the workflow to push pods

Pull Request resolved: https://github.com/facebook/flipper/pull/2511

Test Plan:
While pushing already published release:
https://github.com/facebook/flipper/actions/runs/974346766

While pushing new release:

https://github.com/facebook/flipper/actions/runs/978707041

Reviewed By: passy

Differential Revision: D29415078

Pulled By: priteshrnandgaonkar

fbshipit-source-id: f0fb68a2e399802e5719d7be4216d4a5ed6ef782
2021-06-30 07:21:43 -07:00
Pascal Hartig
f3f0756da7 Update android-sample.yml (#2432)
Summary:
This should take care of the build issue. It's an annoying caching issue that's been around for ages. Also why it didn't happen locally.

Pull Request resolved: https://github.com/facebook/flipper/pull/2432

Test Plan: GitHub CI

Reviewed By: mweststrate

Differential Revision: D28958707

Pulled By: passy

fbshipit-source-id: 8538f6616dec934d924c04713af93e7a6b89e617
2021-06-08 03:08:46 -07:00
Pascal Hartig
89d05d5e46 Build all artifacts as part of GH workflow (#2404)
Summary:
We missed that D28795384 (09951d505e) broke the Kotlin plugin until we got to
our Snapshot job. This makes sure we build all artifacts and get
signal on PRs.

Pull Request resolved: https://github.com/facebook/flipper/pull/2404

Test Plan:
CI

`./gradlew assembleDebug` failed correctly when applying the change.

Reviewed By: nikoant

Differential Revision: D28801494

Pulled By: passy

fbshipit-source-id: 704047ea17af632091c6597024ddacc9247255a9
2021-06-01 11:02:10 -07:00
Michel Weststrate
c94fbbee14 Fix bump pods (#2374)
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/2374

Quick fix for create_pr flow

Reviewed By: priteshrnandgaonkar

Differential Revision: D28711029

fbshipit-source-id: 893a15a62896a96739b3cf5e784ca29e5d9647b5
2021-05-26 09:22:39 -07:00
Michel Weststrate
d680a2807f Bumped deps / pods to latest (0.91.1), re-enabled i386
Summary:
Per title

After landing this and verifying in CI, will apply those version bumps to RN itself: https://github.com/facebook/react-native/pull/31562, and remove the custom overrides in the future

Reviewed By: passy

Differential Revision: D28573552

fbshipit-source-id: e52c40f4751f933f17312aac2aacfd695f554a3f
2021-05-21 03:54:39 -07:00
Pritesh Nandgaonkar
15454ceec7 Update Boost iOSX dep and make it work for arm and i386 for sims (#2341)
Summary:
This diff updates and adds the boost ios podspec in flipper repo. This new boost dep works for Arm and i386 archs for simulator too.

This diff also updates our GH Action to remove i386 from excluded archs. Still arm64 is kept as non M1 mac machines do not have arm swift symbols for arm simulator. And since all our CI is on non M1, it is required.

It also takes care of https://github.com/facebook/flipper/issues/2268
## Changelog

- Update the boost dep
- Update the GH action

Pull Request resolved: https://github.com/facebook/flipper/pull/2341

Test Plan: CI

Reviewed By: mweststrate

Differential Revision: D28537004

Pulled By: priteshrnandgaonkar

fbshipit-source-id: 474ccec674d0edf5fa7b792b15a326e0f139d977
2021-05-19 11:15:13 -07:00
Pascal Hartig
e0e95b59c7 Update docs workflow (#2342)
Summary:
Updated to the latest version which apparently doesn't need a privileged token anymore, which would be good news.
Also updated the message to include a `[ci skip]` which instructs CircleCI not to run because we're having a chicken-and-egg-problem here with CircleCI otherwise needing a config to tell it not to run, otherwise it will run and fail because there's no config.

Pull Request resolved: https://github.com/facebook/flipper/pull/2342

Test Plan:
hopeitwork

Task: T91157540

Reviewed By: mweststrate

Differential Revision: D28539468

Pulled By: passy

fbshipit-source-id: 609c3fa1578e0506aadeb225c4e38ff53db67934
2021-05-19 09:37:41 -07:00
Pascal Hartig
ab93c24dd6 Fix publishing pipeline (hopefully) (#2311)
Summary:
https://github.com/facebook/flipper/runs/2574198766?check_suite_focus=true
shows that the env vars aren't getting picked up. There's some sort
of transformation syntax (https://docs.gradle.org/current/userguide/build_environment.html#sec:project_properties)
which I thought this would follow but didn't.

I'm merging this now with the already existing gradle.properties update
we do. I also tested locally that this approach works.

Pull Request resolved: https://github.com/facebook/flipper/pull/2311

Test Plan:
Updated my local gradle.properties accordingly and re-uploaded the 0.90
release.

Reviewed By: nikoant

Differential Revision: D28440724

Pulled By: passy

fbshipit-source-id: 9f7238b61fe309eea087b5d6a063788e9ea76e85
2021-05-14 06:57:13 -07:00
Michel Weststrate
42325e41c5 Automatically bump iOS pods
Summary: Update our pods automatically post release

Reviewed By: priteshrnandgaonkar

Differential Revision: D28283782

fbshipit-source-id: eff0b033c6704e4e46c0eb96cc4d527969ce7ccc
2021-05-07 09:41:22 -07:00
Michel Weststrate
25424ed47c Bump all Pods to latest (#2275)
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/2275

Forced all current pods to use the latest available. If this builds successfully, will create a PR against React Native so that they become the default, and remove them here again.

This job currently does limit the architectures we build for. Pritesh is investigating if we can wide that again, as this might not be acceptable to RN in general.

This doesn't bump the android version to 0.88, as the artifact publishing failed for that version, but since there are currently less problems with the Android version I wanted to go ahead with just iOS.

Reviewed By: cekkaewnumchai, priteshrnandgaonkar

Differential Revision: D28257283

fbshipit-source-id: a631b1c354617ed356cd1e74b9e8e8aa050eed60
2021-05-07 05:05:20 -07:00
Pascal Hartig
4a636c8e7b Update android publish task
Summary: A recent plugin upgrade removed the previous ones.

Reviewed By: cekkaewnumchai

Differential Revision: D28285219

fbshipit-source-id: e8dcb004ede225283d805b13011709c9d5f3bdae
2021-05-07 04:21:52 -07:00
Michel Weststrate
fcab54a76d Fix React Native build (#2271)
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/2271

Fix react native OSS build. As discussed a couple of weeks ago, we can bump deps, but cannot bump lock files during release, as artifacts are then not yet available.

We backed out from these bumps before D27764997 (98c3913b62), but that didn't seem to be sufficient. Filed T90301619 as follow up

Reviewed By: priteshrnandgaonkar

Differential Revision: D28255272

fbshipit-source-id: ee4d5b158a653c78f73b46c9ca695cfced315e56
2021-05-06 09:48:41 -07:00
Pritesh Nandgaonkar
5a69213dc3 Fixes the create pr job. (#2273)
Summary:
It fixes the GH action to create PR.

## Changelog

Updated the GH action to v3.

Pull Request resolved: https://github.com/facebook/flipper/pull/2273

Test Plan:
Check the PR created by CI
https://github.com/facebook/flipper/actions/runs/817306111
https://github.com/facebook/flipper/pull/2274/files

Reviewed By: mweststrate

Differential Revision: D28256828

Pulled By: priteshrnandgaonkar

fbshipit-source-id: c8d7a09723d6a1de1d4534891428b6dbc5be6277
2021-05-06 09:01:33 -07:00
Pritesh Nandgaonkar
e9ae8f45f9 Update all flipper transitive deps to latest versions (#2245)
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/2245

This diff does the following:
- Updates Folly to the latest version.
- Updates boost to latest version and the boost is added as pre built artefact
- Updates RSocket to the latest version
- Updates ComponentKit to the latest version which has a fix for XCode 12.5
- Adds Flipper-Glog dependency updated with a fix for the issue mentioned [here](https://github.com/facebook/flipper/issues/2174)
- This diff also ensures that Flipper, FlipperKit builds with Sample and SampleSwift app.
- This diff also ensures that the bug mentioned [here](https://github.com/facebook/flipper/issues/2248) is addressed.

Note: For Tutorial App to work we will have to make a release of Flipper and FlipperKit to CococaPods. Because the tutorial app refers the released version of Flipper and FlipperKit. It doesn't refer it locally.

Reviewed By: passy

Differential Revision: D28058972

fbshipit-source-id: d45dfc7315ace5d5c7d3a4ba94911fd4b58bdc31
2021-05-04 05:03:09 -07:00
Pritesh Nandgaonkar
6ba5a410a0 Update glog and doubleconversion which uses xcframework (#2153)
Summary:
This PR updates the Glog and DoubleConversion deps. Now the deps are shipped with precompiled xcframework. It will speed up our build time a bit.
The definition can be found [here for glog](https://github.com/priteshrnandgaonkar/glog/tree/update-0.3.5) and [here for double-conversion](https://github.com/priteshrnandgaonkar/double-conversion/)

There has been improvements in time. I will try to precompile folly to improve the timings significantly.

## Changelog

- Updated the Glog and DoubleConversion deps to the precompiled xcframework one
- Updated the sample app's Podfile.lock

Pull Request resolved: https://github.com/facebook/flipper/pull/2153

Test Plan:
- CI should be green
- Verified that sample app builds.

Reviewed By: mweststrate

Differential Revision: D27560567

Pulled By: priteshrnandgaonkar

fbshipit-source-id: ba295cbe84bb9d5ed6bd6ab17bd1cf5ea22f3cee
2021-04-06 06:02:47 -07:00
Pascal Hartig
77abba6459 Persist yarn cache (#2137)
Summary:
The time we spend on this isn't much. However, we quite often see flakiness coming from yarnpkg not responding which should hopefully be addressed by this.

Pull Request resolved: https://github.com/facebook/flipper/pull/2137

Test Plan: CI

Reviewed By: mweststrate

Differential Revision: D27461679

Pulled By: passy

fbshipit-source-id: c7144d2a8426c078f9cab2d3a94662908a03a182
2021-03-31 06:40:40 -07:00
Pritesh Nandgaonkar
526d985d15 Run iOS jobs on podspec changes (#2136)
Summary:
Updates the run conditions of iOS jobs so that it is triggered when we change "Flipper.podspec" and "FlipperKit.podspec"
## Changelog

- Update the run conditions

Pull Request resolved: https://github.com/facebook/flipper/pull/2136

Test Plan: CI

Reviewed By: passy

Differential Revision: D27402914

Pulled By: priteshrnandgaonkar

fbshipit-source-id: 3b687612f26a0e22773c48540b76a7660bb29ed6
2021-03-29 11:41:34 -07:00
Pritesh Nandgaonkar
d22e893169 Update the run logic of iOS jobs (#2118)
Summary:
This PR updates the logic when these iOS jobs should be run. This change just makes it run for pushes to iOS folders and xplat c++ folders.

## Changelog

- Update the GH action.

Pull Request resolved: https://github.com/facebook/flipper/pull/2118

Test Plan: Note that no iOS job is run.

Reviewed By: mweststrate

Differential Revision: D27395681

Pulled By: priteshrnandgaonkar

fbshipit-source-id: 37a7c2fb9b3fdfa22307ac5e7403364bfeb0a384
2021-03-29 06:57:10 -07:00
Pascal Hartig
1d67dd8a9f Remove pod bumps without flipperkit_version (#2117)
Summary:
Sample and SampleSwift directly link to the debug version and don't reference `flipperkit_version` which is why the script is failing.

Pull Request resolved: https://github.com/facebook/flipper/pull/2117

Test Plan: hopeitwork

Reviewed By: priteshrnandgaonkar

Differential Revision: D27395244

Pulled By: passy

fbshipit-source-id: 3485731b0489376fbdf987c082ef7d288f66bbe8
2021-03-29 06:53:54 -07:00
Pascal Hartig
55341dfc59 Fix React Native build (#2100)
Summary:
Currently failing because the 0.64.x build requires Node >= 0.12

Pull Request resolved: https://github.com/facebook/flipper/pull/2100

Test Plan: CI

Reviewed By: mweststrate

Differential Revision: D27265576

Pulled By: passy

fbshipit-source-id: d7ee0cac8bab1dc90a1b453eef6a7be30177052e
2021-03-23 10:57:46 -07:00
Pascal Hartig
7c22fe8acb Add more gradle sub projects (#1997)
Summary:
I don't fully understand how dependabot works with Android but it seems to only look at the literal fbjni version number based on the logs and we're actually outdated on a bunch of dependencies which Gradle doesn't handle very well.

Pull Request resolved: https://github.com/facebook/flipper/pull/1997

Test Plan: Tested on my fork and I've got a ton of PRs because of this. Brace yourselves.

Reviewed By: mweststrate

Differential Revision: D26784112

Pulled By: passy

fbshipit-source-id: 98ebd0b899a0603868d4b6bc0866e557c87fecd5
2021-03-04 08:36:58 -08:00
Michel Weststrate
3c60798352 Set up CI for ReactNativeFlipperExample (#1995)
Summary:
Added CI to build the Android and iOS debug ReactNativeFlipperExample app

Pull Request resolved: https://github.com/facebook/flipper/pull/1995

Test Plan:
The relevant jobs succedeed in:
https://github.com/facebook/flipper/pull/1995/checks?check_run_id=2023075981

Reviewed By: passy

Differential Revision: D26778297

Pulled By: mweststrate

fbshipit-source-id: 61f953739e1fa7dc7467af2fa5134798cce8b928
2021-03-03 09:43:32 -08:00
Pascal Hartig
3cda93dade Cache Android builds on GitHub Actions (#1922)
Summary:
Builds up a file with checksums of all `build.gradle` files. Deliberately excludes the `gradle.properties` which changes all the time. The cache shouldn't require nuking except in some rare circumstances.

Pull Request resolved: https://github.com/facebook/flipper/pull/1922

Test Plan: From 41 minutes down to 17: https://github.com/passy/flipper-1/actions/runs/561501374

Reviewed By: mweststrate

Differential Revision: D26427242

Pulled By: passy

fbshipit-source-id: ff1d7370d477c9d7b57c62082ec985108a5ba698
2021-02-16 04:18:28 -08:00
Pascal Hartig
761f1354db Clean up secrets (#1921)
Summary:
See this being done elsewhere. I don't think it's necessary but why not?

Pull Request resolved: https://github.com/facebook/flipper/pull/1921

Test Plan: eyes

Reviewed By: jknoxville

Differential Revision: D26427191

Pulled By: passy

fbshipit-source-id: 80823bf50d6416d29d54c82cef433650c1451ac0
2021-02-15 10:31:03 -08:00
Pascal Hartig
7fd0c7d82e Fix upload of sample app apk (#1920)
Summary:
This was an expected failure, you can see here how the last step of the "Publish Android" workflow currently fails: https://github.com/facebook/flipper/runs/1873750507?check_suite_focus=true

This is because it no longer runs in a tagging context. We're now providing the tag as an input and my custom action knows how to attach to existing tags by name.

Pull Request resolved: https://github.com/facebook/flipper/pull/1920

Test Plan:
Test run here finished successfully: https://github.com/passy/flipper-1/actions/runs/560774414
Publish Android job: https://github.com/passy/flipper-1/actions/runs/560775419
Attached release: https://github.com/passy/flipper-1/releases/tag/v0.0.7
Artifacts on Central: https://repo.maven.apache.org/maven2/com/facebook/flipper/flipper/0.0.7/

{F372552533}

{F372552532}

Reviewed By: mweststrate

Differential Revision: D26402629

Pulled By: passy

fbshipit-source-id: 7290e6bb8d1078ee20a0cf10105dc37f1e7aa99a
2021-02-12 04:36:11 -08:00
Pascal Hartig
0085a0d140 Set up release automation (#1915)
Summary:
Depends on https://github.com/facebook/flipper/issues/1914.
This sets up the workflows for automatically building, publishing and "closing" the repository on Maven Central, which is a step you usually need to do manually in the web UI.

Still need to transfer all the secrets over to this repo for it to work.

Pull Request resolved: https://github.com/facebook/flipper/pull/1915

Test Plan:
Ran all of this in my this in my fork and released some `0.0.x` versions.

- Successful workflow: https://github.com/passy/flipper-1/actions/runs/552170713
- It's actually all on Maven: https://repo.maven.apache.org/maven2/com/facebook/flipper/

Reviewed By: jknoxville

Differential Revision: D26367469

Pulled By: passy

fbshipit-source-id: d65f64ee8eec1dc71af64b7e0f87473b9c956fec
2021-02-10 07:16:32 -08:00
Pritesh Nandgaonkar
87e7afe4ab Update tutorial podfiles and GH actions (#1896)
Summary:
This PR updates the flipperkit version of the Tutorial and updates the GH action to test it without the arch flag.
This PR also fixes the script which updates the `flipperkit_version` tag in all the files. It was broken for Tutorial, as it used to replace the last released version of the pod with the current one in each file, but for some reason the flipper version in the Tutorial/Podfile was way older and it never got updated.

I have fixed the logic now to replace the current version in the file with the new one, rather than relying on only last version to be replaced.

## Changelog

- Updated the GH action of tutorial to remove the -arch flag
- Updated Tutorial/Podfile and Podfile.lock
- Updated scripts/update-pod-versions.sh

Pull Request resolved: https://github.com/facebook/flipper/pull/1896

Test Plan:
CI should be green
Tested that the version gets updated for each and every file, file tested were Flipper.podspec, FlipperKit.podspec, Sample/Podfile SampleSwift/Podfile Tutorial/Podfile

{F369967362}

{F369967395}

Reviewed By: nikoant

Differential Revision: D26275657

Pulled By: priteshrnandgaonkar

fbshipit-source-id: 0f21a2a33c740938d2b29624e95974e80a2e38ba
2021-02-05 04:51:11 -08:00
Pritesh Nandgaonkar
8ade24abbc Solves the sampleswift failing job (#1893)
Summary:
Solves the sampleswift failing job, by removing the linker flags which were used when we relied on CocoaLibEvent, but now we do not rely on this.

## Changelog

- Removed cocoalib flag
- Removed arch requirement from the workflow for sample swift

If the flag is removed from the objc sample then I get the following error. It looks like for the objc project, xcode is not able to find the arm64 artifacts for swift deps.

I tried all the alternatives for solving this issue, but it didn't work for objc. I will wait for new xcode and will try with that, hopefully, the newer xcode has the fix.

```
ld: warning: Could not find or use auto-linked library 'swiftFoundation'
ld: warning: Could not find or use auto-linked library 'swiftMetal'
ld: warning: Could not find or use auto-linked library 'swiftUIKit'
ld: warning: Could not find or use auto-linked library 'swiftDarwin'
ld: warning: Could not find or use auto-linked library 'swiftObjectiveC'
ld: warning: Could not find or use auto-linked library 'swiftCoreFoundation'
ld: warning: Could not find or use auto-linked library 'swiftDispatch'
ld: warning: Could not find or use auto-linked library 'swiftCoreImage'
ld: warning: Could not find or use auto-linked library 'swiftCore'
ld: warning: Could not find or use auto-linked library 'swiftQuartzCore'
ld: warning: Could not find or use auto-linked library 'swiftCoreGraphics'
ld: warning: Could not find or use auto-linked library 'swiftSwiftOnoneSupport'
Undefined symbols for architecture arm64:
  "protocol descriptor for Swift.ExpressibleByFloatLiteral", referenced from:
      l_got.$ss25ExpressibleByFloatLiteralMp in libYogaKit.a(YGLayoutExtensions.o)
  "associated type descriptor for Swift.ExpressibleByIntegerLiteral.IntegerLiteralType", referenced from:
      l_got.$s18IntegerLiteralTypes013ExpressibleByaB0PTl in libYogaKit.a(YGLayoutExtensions.o)
  "associated conformance descriptor for Swift.ExpressibleByIntegerLiteral.Swift.ExpressibleByIntegerLiteral.IntegerLiteralType: Swift._ExpressibleByBuiltinIntegerLiteral", referenced from:
      l_got.$ss27ExpressibleByIntegerLiteralP0cD4TypeAB_s01_ab7BuiltincD0Tn in libYogaKit.a(YGLayoutExtensions.o)
  "method descriptor for Swift.ExpressibleByFloatLiteral.init(floatLiteral: A.FloatLiteralType) -> A", referenced from:
      l_got.$ss25ExpressibleByFloatLiteralP05floatD0x0cD4TypeQz_tcfCTq in libYogaKit.a(YGLayoutExtensions.o)
  "protocol descriptor for Swift.ExpressibleByIntegerLiteral", referenced from:
      l_got.$ss27ExpressibleByIntegerLiteralMp in libYogaKit.a(YGLayoutExtensions.o)
  "value witness table for Builtin.Int32", referenced from:
      full type metadata for __C.YGUnit in libYogaKit.a(YGLayoutExtensions.o)
  "__swift_FORCE_LOAD_$_swiftCoreImage", referenced from:
      __swift_FORCE_LOAD_$_swiftCoreImage_$_YogaKit in libYogaKit.a(YGLayoutExtensions.o)
     (maybe you meant: __swift_FORCE_LOAD_$_swiftCoreImage_$_YogaKit)
  "associated type descriptor for Swift.ExpressibleByFloatLiteral.FloatLiteralType", referenced from:
      l_got.$s16FloatLiteralTypes013ExpressibleByaB0PTl in libYogaKit.a(YGLayoutExtensions.o)
  "__swift_FORCE_LOAD_$_swiftQuartzCore", referenced from:
      __swift_FORCE_LOAD_$_swiftQuartzCore_$_YogaKit in libYogaKit.a(YGLayoutExtensions.o)
     (maybe you meant: __swift_FORCE_LOAD_$_swiftQuartzCore_$_YogaKit)
  "__swift_FORCE_LOAD_$_swiftDispatch", referenced from:
      __swift_FORCE_LOAD_$_swiftDispatch_$_YogaKit in libYogaKit.a(YGLayoutExtensions.o)
     (maybe you meant: __swift_FORCE_LOAD_$_swiftDispatch_$_YogaKit)
  "method descriptor for Swift.ExpressibleByIntegerLiteral.init(integerLiteral: A.IntegerLiteralType) -> A", referenced from:
      l_got.$ss27ExpressibleByIntegerLiteralP07integerD0x0cD4TypeQz_tcfCTq in libYogaKit.a(YGLayoutExtensions.o)
  "__swift_FORCE_LOAD_$_swiftCoreFoundation", referenced from:
      __swift_FORCE_LOAD_$_swiftCoreFoundation_$_YogaKit in libYogaKit.a(YGLayoutExtensions.o)
     (maybe you meant: __swift_FORCE_LOAD_$_swiftCoreFoundation_$_YogaKit)
  "protocol witness table for Swift.Int : Swift._ExpressibleByBuiltinIntegerLiteral in Swift", referenced from:
      associated type witness table accessor for Swift.ExpressibleByIntegerLiteral.IntegerLiteralType : Swift._ExpressibleByBuiltinIntegerLiteral in __C.YGValue : Swift.ExpressibleByIntegerLiteral in YogaKit in libYogaKit.a(YGLayoutExtensions.o)
  "__swift_FORCE_LOAD_$_swiftObjectiveC", referenced from:
      __swift_FORCE_LOAD_$_swiftObjectiveC_$_YogaKit in libYogaKit.a(YGLayoutExtensions.o)
     (maybe you meant: __swift_FORCE_LOAD_$_swiftObjectiveC_$_YogaKit)
  "__swift_FORCE_LOAD_$_swiftCoreGraphics", referenced from:
      __swift_FORCE_LOAD_$_swiftCoreGraphics_$_YogaKit in libYogaKit.a(YGLayoutExtensions.o)
     (maybe you meant: __swift_FORCE_LOAD_$_swiftCoreGraphics_$_YogaKit)
  "_swift_getForeignTypeMetadata", referenced from:
      type metadata accessor for __C.YGValue in libYogaKit.a(YGLayoutExtensions.o)
      type metadata accessor for __C.YGUnit in libYogaKit.a(YGLayoutExtensions.o)
  "__swift_FORCE_LOAD_$_swiftFoundation", referenced from:
      __swift_FORCE_LOAD_$_swiftFoundation_$_YogaKit in libYogaKit.a(YGLayoutExtensions.o)
     (maybe you meant: __swift_FORCE_LOAD_$_swiftFoundation_$_YogaKit)
  "associated conformance descriptor for Swift.ExpressibleByFloatLiteral.Swift.ExpressibleByFloatLiteral.FloatLiteralType: Swift._ExpressibleByBuiltinFloatLiteral", referenced from:
      l_got.$ss25ExpressibleByFloatLiteralP0cD4TypeAB_s01_ab7BuiltincD0Tn in libYogaKit.a(YGLayoutExtensions.o)
  "__swift_FORCE_LOAD_$_swiftUIKit", referenced from:
      __swift_FORCE_LOAD_$_swiftUIKit_$_YogaKit in libYogaKit.a(YGLayoutExtensions.o)
     (maybe you meant: __swift_FORCE_LOAD_$_swiftUIKit_$_YogaKit)
  "__swift_FORCE_LOAD_$_swiftMetal", referenced from:
      __swift_FORCE_LOAD_$_swiftMetal_$_YogaKit in libYogaKit.a(YGLayoutExtensions.o)
     (maybe you meant: __swift_FORCE_LOAD_$_swiftMetal_$_YogaKit)
  "Swift.Float.init(Swift.Double) -> Swift.Float", referenced from:
      static (extension in YogaKit):CoreGraphics.CGFloat.% postfix(CoreGraphics.CGFloat) -> __C.YGValue in libYogaKit.a(YGLayoutExtensions.o)
      (extension in YogaKit):__C.YGValue.init(CoreGraphics.CGFloat) -> __C.YGValue in libYogaKit.a(YGLayoutExtensions.o)
  "__swift_FORCE_LOAD_$_swiftDarwin", referenced from:
      __swift_FORCE_LOAD_$_swiftDarwin_$_YogaKit in libYogaKit.a(YGLayoutExtensions.o)
     (maybe you meant: __swift_FORCE_LOAD_$_swiftDarwin_$_YogaKit)
  "protocol witness table for Swift.Float : Swift._ExpressibleByBuiltinFloatLiteral in Swift", referenced from:
      associated type witness table accessor for Swift.ExpressibleByFloatLiteral.FloatLiteralType : Swift._ExpressibleByBuiltinFloatLiteral in __C.YGValue : Swift.ExpressibleByFloatLiteral in YogaKit in libYogaKit.a(YGLayoutExtensions.o)
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
```

Pull Request resolved: https://github.com/facebook/flipper/pull/1893

Test Plan:
CI in github should be green

flipper-oss-ios-build works
https://www.internalfb.com/intern/sandcastle/job/22517998513117018/

Reviewed By: mweststrate

Differential Revision: D26254390

Pulled By: priteshrnandgaonkar

fbshipit-source-id: 291cfb949e781ccb9e0317679daa673dcf8e9479
2021-02-05 02:10:26 -08:00
Pritesh Nandgaonkar
0ebe3956a4 Update OpenSSL pod and remove exclude arch setting (#1892)
Summary:
This PR updates the OpenSSL pod and thus updates the corresponding Folly and RSocket pods. The new OpenSSL pod has a support of arm64 artifact for iPhomeSimulators.This PR also updates the replaces the libevent pod which didn't work with arm64 arch for iPhoneSimulator.

## Changelog

- Update OpenSSL pod
- Update Folly dep
- Update RSocket dep
- Replace Libevent pod.

Pull Request resolved: https://github.com/facebook/flipper/pull/1892

Test Plan: CI

Reviewed By: mweststrate

Differential Revision: D26229304

Pulled By: priteshrnandgaonkar

fbshipit-source-id: 46256d9cd3e0cf5aab6e477e612c3bcb77e31627
2021-02-04 08:50:14 -08:00
Pritesh Nandgaonkar
140ff8861e Add github actions for dependency pod validations (#1834)
Summary:
This PR adds github actions to validate the pods, so that the changes which breaks the validation is not made. This PR also downgrades the version update of OpenSSL, as it doesn't validate the Folly podspec. I have [raised](https://github.com/krzyzanowskim/OpenSSL/issues/113) an issue on the repository which manages the openssl dependency.
## Changelog

- Added githubaction for dependent pod validation
- Downgraded the openssl version, as with upgraded version the folly pod didn't validate.

Pull Request resolved: https://github.com/facebook/flipper/pull/1834

Test Plan: CI

Reviewed By: passy

Differential Revision: D25939525

Pulled By: priteshrnandgaonkar

fbshipit-source-id: f70d043f1f6b2c79028212d8f56c6b8632092e33
2021-01-19 14:20:50 -08:00
Anton Nikolaev
dbc888613b Do not bump every package version for every release
Summary:
This diff sets all package version to "0.0.0" except of the root package and changes the bump script to only bump version in the root package. This should reduce possibility of conflicts on release diffs. Anyway we always use the same version for all of our packages, so we can only set it to the root.

Before npm publishing we will set all package versions to the same number as in the root package (we actually already do that) so there will be no differences except we won't need to bump version in  more than 100 packages each release.

Reviewed By: mweststrate

Differential Revision: D25162373

fbshipit-source-id: 02fe401bee72845339c67925c130027bdaee559d
2020-12-02 02:38:47 -08:00
Pascal Hartig
30628c8139 Publish npm packages from Action
Summary: Adds an action for publishing packages to npm. Secret was added as part of T80403944.

Reviewed By: nikoant

Differential Revision: D25195740

fbshipit-source-id: 51d43d9f5e84a25a67b637233b2c62a9a1a15063
2020-11-27 09:30:06 -08:00
Pascal Hartig
ac475d315c Pin down Rust toolchain (#1719)
Summary:
To make sure we're staying in sync with the internal version. Requires some more manual updating, but even if we do this every couple of months, it should be fine.

Pull Request resolved: https://github.com/facebook/flipper/pull/1719

Test Plan: CI

Reviewed By: nikoant

Differential Revision: D25195565

Pulled By: passy

fbshipit-source-id: 763a9d877a20659e91c8b77d0900b999e5f630d3
2020-11-27 08:45:04 -08:00