Summary:
This diff aims to make the selected device a little clearer, the button now shows different icons depending on the selected devices: physical, emulators and archived devices.
The dropdown now is grouped in these sections, depending on their availability:
- Connected Devices
- Running Emulators
- Imported Devices
- Launch Android emulators
- Open File...
"Open File..." allows to import a file the same way as File -> Open File...
Reviewed By: jknoxville
Differential Revision: D14460789
fbshipit-source-id: 8d6edff0d90d5e02e4ef5976af5680ab8eaf77b4
Summary: Adds revision information which is used to build the flipper app. for more context follow the [discussion](https://fb.workplace.com/groups/1489943347777350/permalink/2046366362135043/)
Reviewed By: danielbuechele
Differential Revision: D14458169
fbshipit-source-id: 71860f1e78c042f76d0e220dd3be96f2adaf609e
Summary:
The headless version used to use `JSON.stringify` to serialize the output of `serializeStore` which basically transformed the store to a specific format which is serializable. But we have written the custom serialize function which cateres to the non serializable object types. Headless didn't use it, so thats why it exported Flipper trace in an unrecognizable format for the flipper.
I have also renamed `serializeStore` to `prepareToSerializeStore` so that the confusion doesn't occur in future. I have used an `exportStore` function in headless which exports the store to the `Promise<String>`
Reviewed By: jknoxville
Differential Revision: D14480096
fbshipit-source-id: f312d7637aa082d96c3bc1dfd00eefb19182e97f
Summary:
= Highlights
This is a bit of a boring release, to be frank. Most of the stuff happened behind the scenes, but a lot of preparation for interesting stuff happened behind the scenes, so stay tuned!
= Fixes
- Upgraded to Electron 4.0.8 (e0127b8438)
- Fixes to node expansion in the layout inspector.
- Connectivity improvements.
See https://github.com/facebook/flipper/compare/v0.17.1...v0.18.0 for reference.
Reviewed By: jknoxville
Differential Revision: D14477605
fbshipit-source-id: 0d927ba08fa5fab9d95c76ec763f5b9dd5bc104d
Summary: Should also fix the build.
Reviewed By: jknoxville
Differential Revision: D14477777
fbshipit-source-id: 01fcfb2321c9b7a12acdf079473d91b6805d4dda
Summary:
This can be used in integration tests/headless to create
some data to match against.
Ideally, headless also will need some mechanism to be
told to exit, but that's a separate issue.
Reviewed By: jknoxville
Differential Revision: D14387494
fbshipit-source-id: 88d7c27e342fb0b26251e6edf12e7b922d5144c0
Summary:
To run a test with the chrome debugger attached:
* Add `debugger` statement in the code
* Open 'chrome://inspect' and then "Open dedicated DevTools for Node"
* run `yarn test:debug $TEST_FILE` where $TEST_FILE is the file containing the tests to debug
I haven't done this for test-electron and test-with-device because the debugger didn't hit the breakpoint for some reason. Shipping this because some is better than all.
Reviewed By: danielbuechele
Differential Revision: D14457843
fbshipit-source-id: 3ce7ba7a95f4623bd87b5feeae0c26a65f4b7eb8
Summary:
@public
This bumps Prettier to v1.16.4
Only format source files were updated.
Reviewed By: mjesun
Differential Revision: D14454893
fbshipit-source-id: 72f9872fe764a79dbf0d9fab9bebb1456b039f2f
Summary: To read the current revision written into the manifest at build-time.
Reviewed By: danielbuechele
Differential Revision: D14454983
fbshipit-source-id: adad7d85dbf410701d2f8601bfccbcfbc0f30dff
Summary:
Uploading the Flipper data could take some while. With the current implementation the user didn't know what was happening. This is why this diff immediately shows a sheet with a spinner, until the upload is finished.
The URL is still copied to the clipboard and a notifications is displayed. Additionally the user can copy the URL from the sheet.
Reviewed By: priteshrnandgaonkar
Differential Revision: D14441759
fbshipit-source-id: c853526a7da76e2dea5e1aaf6b6eff21e4268789
Summary:
if we use WeakReferences, DebugSection nodes are released very fast and highlighting doesn't work because the node is removed from the ObjectTracker.
passy do you know who else I can add as reviewer?
Reviewed By: passy
Differential Revision: D14385872
fbshipit-source-id: ecc63190a84a7186296ed9c4c82ff6ab2aca8ad2
Summary:
Due to faulty condition default state was not being added in the persistedState, which casued the following bug.
{F153286217}
Reviewed By: danielbuechele
Differential Revision: D14425166
fbshipit-source-id: 557dc3717b650dae90dc44ad12970a684cecbf24
Summary:
I'm accumulating a lot of those in my tmpfs and
it would be great to immediately identify the
ones coming from Flipper.
Reviewed By: danielbuechele
Differential Revision: D14406809
fbshipit-source-id: 6b74e8260a841d5db76ac34643ee0226abba735a
Summary:
Package up the current repository's revision when building
a release.
This will then be used to write it into exported traces
so we can find a compatible version when opening it up
again.
Reviewed By: danielbuechele
Differential Revision: D14406684
fbshipit-source-id: 761a51e69adbcab1d541c2daa78c9827ea299e79
Summary: As per title. Target mode and Alignment mode doesn't make sense for archived devices.
Reviewed By: danielbuechele
Differential Revision: D14407780
fbshipit-source-id: cf6f56456674ad8fec422d6f84d58c6d5b211c25
Summary:
Bug: On search, the accessibility views didn't used to expand.Look at the following video to understand the bug
{F153135892}
Reviewed By: danielbuechele
Differential Revision: D14407511
fbshipit-source-id: 011bf31b5bd10f5a7dad3d5d30703ec3bdeaf9c1
Summary: Enables Import and Export for all the nodes for android. Also search and Accessibility feature works
Reviewed By: danielbuechele
Differential Revision: D14406016
fbshipit-source-id: 8976db66d1ca91e98c52983a31ea584764bde0f6
Summary: Flow tells me these too are unnecessary now. Yay!
Reviewed By: danielbuechele
Differential Revision: D14406869
fbshipit-source-id: c09c11fd548798a3fe97c74d23d3b2e9637e5f3a
Summary: Reference has been deprecated for a while. This diff completely removes it in favor of using ComparableDrawable everywhere.
Reviewed By: astreet
Differential Revision: D14241428
fbshipit-source-id: a986f34fda3a05c85d3d57b1e806c5e48c3f485e
Summary:
Enables search on the imported layout data. The way search is implemented is that the Flipper app asks for the search results from the mobile clients. Since mobile client will not exist in the archived case, the search won't work. To solve this problem I added a proxy client which will get all the messages fired by the Layout Inspector and it will accordingly revert back with the responses. In the case of search, it will give back the search result tree for a particular query.
Also added extensive tests for the proxy client
Reviewed By: danielbuechele
Differential Revision: D14281856
fbshipit-source-id: 651436084ebacd57f86e4fe9bb2036e7f666880c
Summary:
== Bugfix Release ==
Fixes#394 in which using the network inspector can cause the plugin view to crash. Also fixes an issue where native background plugins can fail to connect (d720b20870).
Reviewed By: danielbuechele
Differential Revision: D14384823
fbshipit-source-id: 7cee49d22ec2ed8f076cf3aeb980d4ba3a273a3f
Summary:
The graphql plugin gets injected after the client is connected. In this case, earlier we didn't use to call `didconnect` assuming that it will be called when the plugin gets clicked by the user in the UI. But that is not true anymore as GraphQL plugin is a background plugin, And we don't call `didConnect` for the background plugins on the user click in the UI, as we assume that background plugins should have already received the call before.
This diff fixes the issue by calling didConnect on the background plugin which gets added after the `FlipperClient` is initialised.
{F152780726}
Look at the bug:
Reviewed By: danielbuechele
Differential Revision: D14369587
fbshipit-source-id: f75bf4e4463a31fa4735e90245c46632858a32b7
Summary:
For gzipped requests, the decoding of unicode characters was failing, because it was was done, before decompressing the response payload.
In this diff, the payload is first decompressed and decoded afterwards. For the calculation of the response size, this is removed, because it doesn't matter for the calculation of the size to correctly decode unicode characters. However, there might be a problem with displaying the correct size. This is tracked in T41427687.
Reviewed By: jknoxville
Differential Revision: D14366841
fbshipit-source-id: e375df1ec44505f6315dedbe71b3b62eac0f281a
Summary:
Extended the linter to check for the title attribute, too, and fixed
all violations. Linter will follow in next diff.
Reviewed By: jknoxville
Differential Revision: D14366410
fbshipit-source-id: b4de3592f2537e2bb16d4c2af231e5bee45346e4
Summary:
Having previously run `yarn build` can otherwise
cause your devserver to stop working.
Caveat: If you have a Flipper checkout and it's called neither `sonar` nor `flipper`, you're still screwed.
Reviewed By: danielbuechele
Differential Revision: D14364984
fbshipit-source-id: 1652c94a95b1dcb6d34bb9040a9cd4cd70c6df55
Summary:
Remove a broken link and some outdated information
Pull Request resolved: https://github.com/facebook/flipper/pull/391
Reviewed By: danielbuechele
Differential Revision: D14342219
Pulled By: passy
fbshipit-source-id: ab915618fe2ad3f955c465c091a636f9ea19ba33
Summary:
Fixes a bug which happened when the selected plugin was layout and the flipper trace was imported. While importing the trace in the mentioned scenario, the redux store didn't used to get updated in the first render but got updated in the second render. Due to which the persisted state passed in the props was undefined. Look at the attached video to understand the bug.
BUG:
{F152642401}
Reviewed By: passy
Differential Revision: D14343465
fbshipit-source-id: 59110fd6ee5839f2e3944792e1c288d2388d3340
Summary:
we only include in the inspector hierarchy the sections which are visible on screen. If as a result of a UI change the hierarchy of visible sections changes (for example when scrolling to a section that wasn't previously visible) this forces the section hierarchy to be recreated.
passy not sure if there's an easier way of making the children of a node invalidate, let me know if you have any suggestions
Depends on D14300298
Reviewed By: passy
Differential Revision: D14301404
fbshipit-source-id: 551e1910d0a80238027e32417aab8d42ed1c00b3
Summary:
as title, enables section name matching in the flipper search bar
Depends on D14300283
Reviewed By: passy
Differential Revision: D14300298
fbshipit-source-id: 33caefccf04b833c8606a083a13f3bffea6c419d
Summary:
these are not nullable. returning a non-null value
Depends on D14300226
Reviewed By: passy
Differential Revision: D14300283
fbshipit-source-id: bbc37161d2e01d94998cb287377742d8c5952bd1
Summary: Only show scrollbars in sidebar when necessary.
Reviewed By: jknoxville, passy
Differential Revision: D14341446
fbshipit-source-id: e75f02b9de7796fc9ed8a42618ade3be015a1889
Summary: This is required on linux or it isn't found. It's already done elsewhere this way.
Reviewed By: passy
Differential Revision: D14303606
fbshipit-source-id: 8b3fca776d43076cdc2f814de19b0b381350dcc9
Summary:
- The Android library now uses AndroidX instead of the support-library.
- Folly and RSocket dependencies uploaded to cocoapods (f8bd473828).
- Improved Unicode support in the Network Inspector plugin (f4b2ce9a2b).
- Fixed MacOS release creation.
- Several UI fixes regarding in-app search and the toolbar.
Reviewed By: passy
Differential Revision: D14269567
fbshipit-source-id: 2d2f965316bd1ddfb375a2db48fb715095693c43
Summary: When a node was invalidated, not only the node itself needs to be refetched, but also its children.
Reviewed By: jknoxville
Differential Revision: D14280318
fbshipit-source-id: a262a2c95347dc9bf72f83b6a9eba9d3f9badb5a
Summary:
Exports Flipper trace along with bug report. I was not able to upload `.flipper` file, thus I have uploaded `.json` file. One can download the json file from the portal and then can rename it to `.flipper` inorder to open it into flipper app.
I am looking into downloading `.flipper` directly, instead of `.json`. But that change, if it happens, will be done in other diff. I think having flipper trace on the bug report will be helpful to debug the issues.
Reviewed By: danielbuechele
Differential Revision: D14266218
fbshipit-source-id: fb7cf4c9773fb355f3569ce8d08b83bd736ab1ca
Summary:
This diff adds filter for cold start in the Images plugin.
I also moved the Loading indicator as a sibling of filter bar, because it used to show up when the images to display were zero. Earlier zero images case used to happen only at the start, but now with the options to apply filter, this case may happen often, so user should have access to filter bar to change the filters in order to reset it.
Look at the video for more information
Reviewed By: danielbuechele
Differential Revision: D14269064
fbshipit-source-id: cbab5a62fd62c5a98f8728c33c1a0dbfc6f454cc
