jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Prepare for Fresco stable release (#385)

Browse Source 
Summary:
This unblocks our open source releases.

Pull Request resolved: https://github.com/facebook/flipper/pull/385

Reviewed By: danielbuechele

Differential Revision: D14299867

Pulled By: passy

fbshipit-source-id: d9ce29d0d0713cd54f6d8bed03e7a919f443f44b
This commit is contained in:
Pascal Hartig
2019-03-04 09:00:23 -08:00
committed by Facebook Github Bot
parent f4b2ce9a2b
commit fbe9e3a086
3 changed files with 8 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
android/build.gradle
View File

@@ -53,10 +53,9 @@ android {
implementation deps.lithoSectionsDebug
implementation deps.lithoWidget
implementation deps.rhino
// TODO(T40752310): Should be depending on a stable version.
compileOnly('com.github.facebook:fresco:0ff379c262') {
exclude group: 'com.squareup.okhttp3'
}
implementation deps.fresco
implementation deps.frescoFlipper
implementation deps.frescoStetho
compileOnly deps.leakcanary
testImplementation deps.mockito

11
android/sample/build.gradle
View File

@@ -30,20 +30,13 @@ dependencies {
implementation deps.lithoWidget
implementation deps.lithoAnnotations
// TODO(T40752310): Temporary while we depend on the jitpack artifact with a different group.
implementation(deps.lithoFresco) {
exclude group: 'com.facebook.fresco'
}
implementation deps.lithoFresco
annotationProcessor deps.lithoProcessor
// Third-party
implementation deps.soloader
implementation deps.okhttp3
// TODO(T40752310): Temporary till Fresco has a stable release.
implementation('com.github.facebook:fresco:0ff379c262') {
exclude group: 'com.squareup.okhttp3'
exclude group: 'com.github.facebook.fresco', module: 'animated-base-test'
exclude group: 'com.github.facebook.fresco', module: 'imagepipeline-test'
}
implementation deps.fresco
// Integration test
androidTestImplementation deps.testCore

5
build.gradle
View File

@@ -27,8 +27,6 @@ subprojects {
if (isSnapshot()) {
maven { url 'https://oss.sonatype.org/content/repositories/snapshots/' }
// TODO(T40752310): Remove this once Fresco is stable.
maven { url 'https://jitpack.io' }
}
}
}
@@ -82,4 +80,7 @@ ext.deps = [
testRules : 'androidx.test:rules:1.1.0',
// Plugin dependencies
rhino : 'org.mozilla:rhino:1.7.10',
frescoFlipper : 'com.facebook.fresco:flipper:1.13.0',
frescoStetho : 'com.facebook.fresco:stetho:1.13.0',
fresco : 'com.facebook.fresco:fresco:1.13.0'
]