Summary: It's getting really tedious to turn these off one by one.
Reviewed By: jknoxville
Differential Revision: D17366198
fbshipit-source-id: 25443d7a18c81cd18edea21d75cfa70e4fbf4171
Summary: This got really badly mauled by a codemod I reckon.
Reviewed By: jknoxville
Differential Revision: D17366199
fbshipit-source-id: 6f1863e5e3d3ed26753723cf666b70655601a8de
Summary: Finally we are able to switch back from our adbkit-fb fork to the original `adbkit`. Replacing all imports
Reviewed By: jknoxville
Differential Revision: D17343236
fbshipit-source-id: e6dd328f1a956544e8be2ab768aa270972463c6b
Summary: Replace the custom call to ADB with using this.device.adb`.
Reviewed By: jknoxville
Differential Revision: D17343234
fbshipit-source-id: c83fe295ec2c3f994e545a93aa580f44e91291fb
Summary:
moving logic for screen recordings to the respective devices, instead of having it in the button component.
This is part of my wider effort to unify our use of adb/adbkit and upgrade to the latest version of adbkit.
Reviewed By: passy
Differential Revision: D17318702
fbshipit-source-id: cff4459047d7a197ed6cb8ee8c290b4eaab41479
Summary:
Not ideal to just assert a type based on JSON output
but better than the `ts-ignore` because complete
misuse of the functions is still caught.
Reviewed By: jknoxville
Differential Revision: D17346265
fbshipit-source-id: 52d8109a11f552b912b67b1074cb906cb2cc161b
Summary: This diff was a joy to draft.
Reviewed By: jknoxville
Differential Revision: D17344676
fbshipit-source-id: 0694d0393fa243edef61408ecfee92912fbbfa32
Summary: This will block us from landing eslint-failing tests.
Reviewed By: jknoxville
Differential Revision: D17342861
fbshipit-source-id: a42e3bc3fffe8f24420203f399fb702907069132
Summary:
Gets the rating popover to appear automatically after 30s for selected users, according to ITSR constraints.
The ITSR constraints are to stop it annoying people, such as only happening once a month, and global throttling.
Reviewed By: passy
Differential Revision: D17343435
fbshipit-source-id: c06aa10263a64249f7e2c48b8752c37e4314ac24
Summary: Dismissing the popover will stiop the user from being prompted for a while, so we only want to send this event when the user was proactively prompted in the first place - which is when we're using the eligibility check.
Reviewed By: passy
Differential Revision: D17343227
fbshipit-source-id: 95a071e34ce318fe49640c6ee9f68127957f390c
Summary:
Behind a gk.
This uses a hidden webview to check if a user is eligible for star ratings. This means you can practively ask the user, and makes sure you'll get an unbiased distribution.
Reviewed By: danielbuechele
Differential Revision: D17343118
fbshipit-source-id: fe7471416aef947ec10f4734e4136868ab5ab3e5
Summary:
There's probably a more elegant way for doing this
so please let me know if you can think of something.
Reviewed By: danielbuechele
Differential Revision: D17318727
fbshipit-source-id: 9afcc30205171cfb07f0a749c552692cb40a3ced
Summary:
This is a bit embarrassing. It seems like I never wired this up which is
why the update indicator keeps coming up even if the app was started
by the Launcher.
This actually makes sure that we proxy the yargs flag through to
`processConfig`.
Reviewed By: jknoxville
Differential Revision: D17341896
fbshipit-source-id: 73602e2035c26fb0d03e853a4e94065af3986757
Summary:
Unnecessary and very broad - effectively disabling
all of tsc for the class.
Reviewed By: jknoxville
Differential Revision: D17342993
fbshipit-source-id: 609ce2cbd69bd83749111f64b1784fd4965c9704
Summary:
This is a pretty broad ignore which doesn't seem required
but could hide real bugs.
Reviewed By: jknoxville
Differential Revision: D17342033
fbshipit-source-id: c7941e383936e44e39eff3fb7eced1d85a0d6417
Summary: Hmm, how did this land despite the formatting error?
Reviewed By: jknoxville
Differential Revision: D17342057
fbshipit-source-id: 514be1548feb024cc107139ac962b0d69ff42198
Summary:
Previously url's were displayed only for the Android app even if the user was using the iOS app.
This commit displays the url's for the iOS app if the user is using the iOS app.
Reviewed By: danielbuechele
Differential Revision: D17318175
fbshipit-source-id: 3bd8be4de55ea5b3ce634c2c6b713cba14ffcccd
Summary:
I didn't update the render logic accordingly after figuring
out how the internal update endpoint works. This closes
that gap.
Reviewed By: danielbuechele
Differential Revision: D17316892
fbshipit-source-id: 1e6c4dd17b342b2a062cea90d763be01ed6fc1ec
Summary: Mostly exclaming here, but it's a test so ... �
Reviewed By: danielbuechele
Differential Revision: D17314463
fbshipit-source-id: 84a4cb9d5b91865b7f723c883dc4840479db9aa3
Summary:
Icon names including the -outline suffix get stripped out so the local path becomes the filled variant by default.
But it's only observable in release builds, because they are the only ones that use local icons.
This should fix that by keeping the variant in the local icon path as well.
Reviewed By: danielbuechele
Differential Revision: D17314646
fbshipit-source-id: b8402d85b1cc690caef7870194e60f22d17dca05
Summary:
This is an interesting invariant that TS caught here. We
expect `getDevice()` to always return a device but it
cannot because it's set lazily. John Knox suggested we instead
set up a promise in the constructor and resolve it instead of
overriding the stateful promise later.
Reviewed By: jknoxville
Differential Revision: D17313468
fbshipit-source-id: 8fd75f2720546abf67beead23db56216f1a5e0df
Summary: And remove one migration warning that no longer applies.
Reviewed By: danielbuechele
Differential Revision: D17313469
fbshipit-source-id: f29a096a0da7c14735d1d5666a54a3351df54821
Summary: Plugin is moved up as soon as it gets clicked because of the same array reference
Reviewed By: jknoxville
Differential Revision: D17285335
fbshipit-source-id: c4413844fe07a9aed77e4b0e9fb5f5e025d722ca
