Summary: When copying elements from the layout inspector its much more useful to copy all associated attributes rather than just the name and an implementation detail id.
Reviewed By: jknoxville
Differential Revision: D17727520
fbshipit-source-id: 8ac1828059cc10f7f9faf0bdc72eb3d57c881121
Summary:
These are the only four errors currently happening when upgrading to the 3.7 beta.
Luckily, these are all forwards-compatible changes.
Reviewed By: jknoxville
Differential Revision: D17711797
fbshipit-source-id: 429036e90300c81848cc3252b67bb89871ff2e32
Summary:
- Introduce new base protocol `CKMountable`
- Contains Layout & Mount methods that have been extracted from `CKComponent`
- This will allows us to introduce a new lighter version of `CKComponent`, which doesn't rely on Scope/State/Controllers/etc
- Refactor `CKComponentLayout` to work with `CKMountable` instead of `CKComponent`, which will allows us to interop between `CKComponent` and a new type of components.
- Refactor the codebase to support this change
Reviewed By: kevin0571
Differential Revision: D17668253
fbshipit-source-id: 13db5ff4acb37b338e291ca2dd7d67cd25dbc6d2
Summary: Shows status messages for the Support Form
Reviewed By: passy
Differential Revision: D17601944
fbshipit-source-id: a2a8ad392dfbaf467625eb809020d687d066da57
Summary:
This diff adds a status bar, which can be used to show the status messages, for example for Litho Support Form.
The logic for the status bar is as follows:
It maintains the array of the messages. At any point it shows the last pushed message. It will keep showing that message until it is being removed, once removed it will show second last message. The messages will be removed as and when its corresponding task/Promise is fulfilled.
Reviewed By: danielbuechele
Differential Revision: D17551495
fbshipit-source-id: 96b2f401599b9ee8a472607e6a2f027e63b3b807
Summary:
the name of the plugin into documentation is not correct.
## Changelog
chore: plugin-name
Pull Request resolved: https://github.com/facebook/flipper/pull/562
Differential Revision: D17709629
Pulled By: passy
fbshipit-source-id: ce6233ce9cac67c42b0501bd969c46114d74365a
Summary:
There were two issues with the previous approach:
1) We didn't block the shell process, so we would immediately
start pulling the video from the device as soon as we **started**
recording it. This meant, you'd usually get the previous recording
or just an empty file.
2) The stop side doesn't know when it's actually safe to start displaying
the video as pulling takes time. So we need access to the process
promise there.
Reviewed By: jknoxville
Differential Revision: D17687827
fbshipit-source-id: 6ad5da52442f1888dd491b2a4c7f7a6b5a7885dd
Summary: Now emits a warning if api version doesn't match expected one.
Reviewed By: cekkaewnumchai
Differential Revision: D17685261
fbshipit-source-id: 2a01d64e2e160d411d7a58125b5bb45437476f8f
Summary:
D14932994 changes the layout, but we did not update the snapshot.
Another option is to disable a test for now.
Reviewed By: jknoxville
Differential Revision: D17548543
fbshipit-source-id: 455e5047eab0044cabd503cae7cbc386443f376e
Summary: I noticed every time you open a sheet it feels laggy and unresponsive. This removes the wait time to make it immediate.
Reviewed By: passy
Differential Revision: D17684407
fbshipit-source-id: f918bf8ca3bb0ef68c3fe01991c67d50f3967d68
Summary: This diff migrates the Mobile config plugin to typescript. In the later diffs, I will refactor the logic of the plugin to use persisted state as it can then be used to export the data, which is required for the litho support form.
Reviewed By: jknoxville
Differential Revision: D17628276
fbshipit-source-id: b48d4fb346b582408774ef08ffbead23adc7aaac
Summary:
Some repositories disable using .gitignore files with ripgrep. This adds an explicit .ignore symlink so that it is always used.
Vastly speeds up using ripgrep in VS code.
Reviewed By: passy
Differential Revision: D17664864
fbshipit-source-id: cd798a41b813e32f64e8e75b6100445ace6b00d8
Summary: My hypothesis is that on hot reloads / `Ctrl+R`s calls to `this.log` from within the proxy would call the proxy itself. So the only truly relevant change here should be the `.bind(this)` removal. But I'm still not 100% sure that this was the reason for the stack overflow error. Let's keep an eye on this.
Reviewed By: jknoxville
Differential Revision: D17664509
fbshipit-source-id: c9e1c5fe32048b04ef0585f7162bd00ad5ccf18a
Summary: Turns out Windows really doesn't like colons in filenames. Sigh.
Reviewed By: jknoxville
Differential Revision: D17664236
fbshipit-source-id: 664885308815d862007c8a9a9d1278c426b4e756
Summary:
Instead of our ad-hoc mechanism. There's quite a bit
of trickery involved to make this work reliably on Windows
so I'd rather take an off-the-shelf solution than reimplement this
myself.
Reviewed By: jknoxville
Differential Revision: D17628949
fbshipit-source-id: 98806b60a107231d9ee07b721ebb70f2cbd8aec1
Summary:
D17629896 was intended to fix this in ovrsource, but it turns out these changes should be made on fbsource first then get synced.
The MSVC build of OculusPCSDK has numerous warnings, including these low-hanging fruit:
```
c:\open\ovrsource\xplat\omnistore\client\common\reportsubscriptionstatetiming.cpp(28): warning C4101: 'e': unreferenced local variable
c:\open\ovrsource\xplat\omnistore\client\common\databaseanalyticsmetadatatiming.cpp(23): warning C4101: 'e': unreferenced local variable
c:\open\ovrsource\xplat\omnistore\client\common\sendqueuereportbacklogtiming.cpp(32): warning C4101: 'e': unreferenced local variable
c:\open\ovrsource\xplat\omnistore\client\common\omnistore.cpp(192): warning C4101: 'e': unreferenced local variable
c:\open\ovrsource\xplat\omnistore\client\common\omnistore.cpp(907): warning C4101: 'e': unreferenced local variable
c:\open\ovrsource\xplat\omnistore\client\common\omnistore.cpp(934): warning C4101: 'e': unreferenced local variable
c:\open\ovrsource\xplat\omnistore\client\common\omnistore.cpp(946): warning C4101: 'e': unreferenced local variable
```
Clang doesn't complain, but the code is just as clear without the 'e' so best to remove.
Reviewed By: vener91
Differential Revision: D17631747
fbshipit-source-id: 0190a48e640311b40c9d1b988b0c07cfbdcfd7e5
Summary:
This can quite easily happen if you manually edit it and
aren't careful. The least we can do is tell the user about it,
because it be a bit surprising otherwise.
Reviewed By: jknoxville
Differential Revision: D17626760
fbshipit-source-id: 8c7d64b041fa4b97ce2753116800d0e855442dd9
Summary: Introduces basic KaiOSDevice class. Since kaios phones support adb, it is inherited from AndroidDevice
Reviewed By: jknoxville
Differential Revision: D17608605
fbshipit-source-id: 6b2c5834a1f5862b864c8e76202d0d401e58cbcc
Summary:
The build-release script was using different logic to construct the local url, than the lookup file.
Changed so they both use the same function.
And unit tests added.
Reviewed By: passy
Differential Revision: D17602476
fbshipit-source-id: 6aaedd58eafb2cc59adcdc0ebb4dd329bf99c33a
Summary:
I noticed this didn't have the node prefix so isn't run during `yarn test`.
Now it runs and passes :)
Also checked `ls **/__tests__/*.js` for any similar files and found none.
Reviewed By: passy
Differential Revision: D17601931
fbshipit-source-id: cf45a0ba578d5d0000ba1d25ae4fb26a4f7fc7af
Summary:
**Highlights**
- Android: Leakcanary is no longer part of the core distribution but a separate artifact: `com.facebook.flipper:flipper-leakcanary-plugin`.
Reviewed By: priteshrnandgaonkar
Differential Revision: D17601074
fbshipit-source-id: 862fc44d45b4ddc95059deb3959476af162b1cb0
Summary:
In the previous implementation plugins were downloaded from npm, but dependencies weren't. This diff uses the `live-plugin-manager` which does mostly what we want. It install a package from NPM with all its dependencies.
live-plugin-manager puts the plugin and its dependencies in the same folder. We expect the plugins to be in `node_modules`. For this reason, we are installing the plugin into `$pluginName/node_modules` and move the plugin after the installation out of the `node_modules` folder.
* Fixed plugin loading path for thirdparty plugins.
* Disabled hot reloading for plugins in the flipper folder to prevent reloads when moving around files and installing dependencies here.
* an empty `.watchmanconfig` is created, because metro requires it
* tsx files are added to the list of supported extensions for metro
Reviewed By: passy
Differential Revision: D17570413
fbshipit-source-id: ecbedc60841b36188fec9c83da41ef1f27e5e155
Summary:
Background plugins are initialised when flipper connects.
But there's no isolation, so if any fail to initialize, then we don't carry on initializing the rest.
This fixes that by skipping failed ones only.
Reviewed By: passy
Differential Revision: D17600854
fbshipit-source-id: 2ef04cbcecda78ca448c2f4d56639ba63792e2f7
Summary: This diff sets up Flipper to attach flipper trace to the support form. This diff adds a property named `exportResult` in the redux store. This will hold the export url or the path of the export, depending on the type of the flipper export. Once the exportResult is populated, we listen for this change and update the button style and fill the comment box.
Reviewed By: passy
Differential Revision: D17478491
fbshipit-source-id: 10dd5e130a9e3df5f41afde42b92b08959d9ed9e
Summary: Just updating the apparently copy-pasted comment about the `options` prop.
Reviewed By: passy
Differential Revision: D17567256
fbshipit-source-id: ed4ff93ad42ef8bdcadb5371fe11ae90dba47ca3
Summary: 0.8.0 is required for compatibility of our sample app with new fbjni.
Reviewed By: jknoxville
Differential Revision: D17547812
fbshipit-source-id: 5ad98fe5629cd63be8a253c881e20e8df4d0df74
Summary:
The test is failing right now because D14932994 changed the layout manipulation.
Disable the snapshot test for now and will be re-enabled in D17548543
Reviewed By: jknoxville
Differential Revision: D17549122
fbshipit-source-id: 8bf7a89594206e32cece150c8057ee03d190d2e5
Summary: Fix for p-map error at startup and `fbjni` dependency on Android.
Reviewed By: danielbuechele
Differential Revision: D17528600
fbshipit-source-id: db0fd2e99bd35645ceef63500312b3ad16c04d57
Summary:
This is now published to Maven Central and doesn't require a
separate repository.
Pull Request resolved: https://github.com/facebook/flipper/pull/557
Test Plan: CI
Reviewed By: danielbuechele
Differential Revision: D17526448
Pulled By: passy
fbshipit-source-id: 169b5bc5f6568d40697e5e48a9873f8a64bd5e00
