Summary:
Relies heavily on types (not) defined in other modules,
so right now it's mostly sprinkling more `any`s in.
My type declaration is based on `dts-gen` output and some
manual fixes. This is the same level as the old flow-typed
definition we had.
Reviewed By: jknoxville
Differential Revision: D17282739
fbshipit-source-id: 0e5015d3b61044615a03c50fefade908041310a8
Summary:
Could use a closer look. *Shouldn't* change semantics,
but there are some assumptions baked into the code
which I don't fully grasp.
Reviewed By: jknoxville
Differential Revision: D17282310
fbshipit-source-id: af8e6bcd188bd12180a7b2eeafee7ced4f44d1aa
Summary: Per title. Somehow both typecheck, but importing the module like this doesn't work.
Reviewed By: jknoxville
Differential Revision: D17285507
fbshipit-source-id: 40a38db5dfb52213e0407f8bda83f2ebad5c50c7
Summary:
This has been tripping up the release builds, luckily caught by
Circle: https://circleci.com/gh/facebook/flipper/1480
Reviewed By: jknoxville
Differential Revision: D17282130
fbshipit-source-id: a17adb18bc75e4fa5d645a062343622167785fa6
Summary: Show info about the event which triggered a new changeset generation; in case of a state update, also show the name of the method which triggered the state update.
Reviewed By: pasqualeanatriello
Differential Revision: D17162202
fbshipit-source-id: ebf218f8ce71799e4dd452f54b1621af7f83cc51
Summary: Use the string sent from the client to show which section triggered a state update.
Reviewed By: pasqualeanatriello
Differential Revision: D17162190
fbshipit-source-id: a72eea1c6fc0fba851028aa050f0c6772a590e8d
Summary:
Show the section which triggered the state update in the tree hierarchy.
We can't use the attribution param that was being passed from SectionTree because it contains the key of the section, not the global key.
Reviewed By: pasqualeanatriello
Differential Revision: D17161730
fbshipit-source-id: bae5e509c378ffdf210acac6564212c873c5855b
Summary: These strings be provided by the api.
Reviewed By: passy
Differential Revision: D17282133
fbshipit-source-id: a818f915c0a21f84894a6073d2cc08669647caaa
Summary: The persistedState of the Layout (and potentially other plugins) wasn't updated. It turned out that the updated state value never got passed to `setPluginState`, but accidentally when adding a type declaration, the `Object` constructor was passed as value to the state.
Reviewed By: jknoxville, passy
Differential Revision: D17282822
fbshipit-source-id: 6fc64960ee2405ea5a705504969c36a27ac62f2c
Summary: And also increase the time-to-disappear from 1s to 1.5s.
Reviewed By: passy
Differential Revision: D17281904
fbshipit-source-id: df0f3e1a40949f5a518bf05d89b6ac0ecf92c5bb
Summary: One of the last releases before 6.0 with more deprecation warnings.
Reviewed By: jknoxville
Differential Revision: D17259063
fbshipit-source-id: c31e9dc46071deae601489cc51d9af0d569d270d
Summary:
This one is in TS, so we get types for free.
`promisify` makes it rather awkward to work with overloaded
functions like `spawn`, so there's still value in having
a proper library for this.
Reviewed By: jknoxville
Differential Revision: D17204471
fbshipit-source-id: 3d07edfe2bb8c1e4c4f3134b53a0c4a0d9be383b
Summary: OS must always be defined.
Reviewed By: jknoxville
Differential Revision: D17204398
fbshipit-source-id: 0d84111c382af623843a41360bcb472394daf3f1
Summary:
This diff solves the problem where the export for the graphql plugin was super super super sloooooowwww...... The reason being that the graphql plugin had chunky graphql responses which were json blob which was being serialized by our custom serializer. Instead of serializing those with custom serializer we can directly serialize them as they won't have any map's, sets, classes etc.
This diff adds the two static functions on the plugin which will provide the serialized and deserialized object for the persistedstate. As the plugin knows the structure of its state it can optimize the serialization and deserialization of its data.
This change solves the slow export issue and makes it blazing fast..... 🏎
Bug:
{F206550514}
Reviewed By: danielbuechele
Differential Revision: D17166054
fbshipit-source-id: 058b903c03c12c9194702162c46763ef5b5e7283
Summary: It appears the certificate provider is generating a deviceId which is then sent down to the flipper client to store (under CONNECTION_CONFIG_FILE). For MacOS, this ends up being "unknown". Yet when we attempt to connect to the flipper app, it expects empty string. This diff ensures that for MacOS, we're not sending down "unknown" for the client to store into its config file.
Reviewed By: danielbuechele
Differential Revision: D17190130
fbshipit-source-id: e0d9825f1f0330a03bcb3cf8d606d5bd9fcc1d7f
Summary: It looks a lot better now, but the input is only single line, so entering more than one line would not be good right now.
Reviewed By: danielbuechele
Differential Revision: D17210091
fbshipit-source-id: 9313b6a67731cfa944394962cdc09be915a07720
Summary: To keep it in sync with the JS implementation.
Reviewed By: danielbuechele
Differential Revision: D17208786
fbshipit-source-id: 8d89f33bfef22317266a0ad1e0c5689540d54f9e
Summary:
This isn't ready to release yet, it's still behind a GK so noone will see it.
There has been no styling applied to the popover so it looks bad but is fully functional.
What it also doesn't have yet:
* Get the prompt text from the API (including the predefined selectable comments)
* Check with the server whether it should pop up proactively, it's completely passive at the moment.
Reviewed By: passy
Differential Revision: D17206158
fbshipit-source-id: f1734f3d6bc555c860ebbaad7515d4675e1700cb
Summary:
Yesterday I saw someone try to open the xcode executable with the File > Open function.
This made me realise it's not clear what this is for, and you might think it can open all kinds of things.
Reviewed By: danielbuechele
Differential Revision: D17225496
fbshipit-source-id: 893360a1f450a8db25be34fce6c288e8db8f9626
Summary: Moving FlipperKitLayoutPlugin/FlipperKitPluginUtils/SKHighlightOverlay to shared folder, so Layout and WorkingRange plugins can depend on it
Reviewed By: kevin0571
Differential Revision: D17156396
fbshipit-source-id: 3f17371f2ab4818924d61e6cfb243f60ad1f2892
Summary:
**Highlights**
1. Windows builds should publish on the release page now.
2. We have x86_64 support on Android.
3. React DevTools are now publicly available.
Reviewed By: danielbuechele
Differential Revision: D17204023
fbshipit-source-id: 41aaa1c884e1f251216423a8b08cec6e8802fd80
Summary:
The navigation plugin supports logging of a date and the class name. This addition adds that support.
I have kept the previoius method which I will remove once I update the fb4a navigation plugin integration.
Reviewed By: danielbuechele
Differential Revision: D17202996
fbshipit-source-id: eac95328a6e2278c3a27ca608b9b675c8efe4528
