Summary: Removes the symlink files and copies the actual files. The OSS build is broken as its not able to access those files.It used to work before as the ship it config used to sync thos files from fbobjc. But that approach is fragile as it broke our OSS build recently, because of this diff D16829348
Reviewed By: jknoxville
Differential Revision: D16891051
fbshipit-source-id: b5146129adc8628d336fbca5936539d2e1131ba2
Summary: Since I've published docs for the Nav Plugin, might as well remove the Gate Keeper. When integrating the Nav Plugin in our sample app, I've observed that the Plugin is stable.
Reviewed By: passy
Differential Revision: D16857344
fbshipit-source-id: c4b0b5828ae82f6e43cfcb000e7f003c5ccce568
Summary:
Added docs for the Navigation Plugin.
I've added instructions on how to use the plugin with vanilla Android, or how to integrate it with a third party solution.
Reviewed By: danielbuechele
Differential Revision: D16856614
fbshipit-source-id: e99cb94318820bd926f50bd4ba205fb11396a9d8
Summary:
Here I have an early version of the Navigation Plugin (Android) for Open Source.
A lot of apps will be using there own Navigation framework for handling deep links. In order to keep things as simple as possible, recording navigation events is done through a single function that can be called from anywhere in the app. This will allow users to place this function in there own navigation frameworks and use there own logic with it.
Seperately, I have shown how this can be used with our Android sample app. I use the built in Android intent-filters to provide a demo of how this can potentially be used, and to form the basis of the docs that I will write.
Reviewed By: passy, danielbuechele
Differential Revision: D16828049
fbshipit-source-id: 22765f63ca0c471689d2ec5865fdfc155b92697f
Summary: I added the height css style to align the sheet. In this revision, I removed the height to recenter the text, but I've had to nudge the sheet up 3 pixels.
Reviewed By: danielbuechele
Differential Revision: D16855746
fbshipit-source-id: 14b4b83abeb74c01c3706c5b81921f30c8d7e2d3
Summary: This target was bloating. Split it in two. Migrate to autotests.
Reviewed By: joshleibsly
Differential Revision: D16829348
fbshipit-source-id: 17f2a10371293ddb850c4556abeecee99a9d7bef
Summary:
Without this, our build will break with the next Litho release
because the `DoNotStrip` annotation will no longer be exported
as part of `litho-annotations`.
Reviewed By: jknoxville
Differential Revision: D16828144
fbshipit-source-id: f9a78b331678882025732498f18a3443d148ef4d
Summary:
Convert serialization to typescript.
I tried to type the deserialize function but don't know enough about the expected format to be able to tell what the types should be.
Reviewed By: passy
Differential Revision: D16785945
fbshipit-source-id: 45de7ee1c8972314a52abcf20d428ba44f031a00
Summary: T46426056: Add utility to convert nlohmann::json to NSDictionary. Use same in instagram logging module.
Differential Revision: D16798341
fbshipit-source-id: 88923fcbcd1ffbed5a468cee4ba2f9482ba81a97
Summary: Booleans must also be validated. These are denoted by {!boolParam}, as in they have a '!' symbol in front.
Reviewed By: danielbuechele
Differential Revision: D16802996
fbshipit-source-id: c03b858f0872dea0610e1d28aa9b48936f1117a6
Summary: Taking on the feedback from the demo yesterday, I've improved the required parameter's dialog by showing where specific errors occur in the form and adding live editing to the URI displayed.
Reviewed By: danielbuechele
Differential Revision: D16802921
fbshipit-source-id: 2e729549306a8efb79ca76d3da6f70632ccd9212
Summary:
Here I've added the LocationsButton to the TitleBar in Flipper. This allows the user to navigate to saved bookmarks, or display the current page URI without ever opening the Navigation Plugin (Except to add bookmarks). The challenge of this diff was having a TitleBar child be controlled by a plugin.
The LocationsButton pulls bookmarks straight from the database whenever a mouseDown event is called on the button. (The Electron popup menu does not respond to props changes, so the menu is opened on mouse up and getting the bookmarks from the database occurs on mouse down... This seems to work fine).
The nav plugin on the Android side will now also send a welcome message alerting the app to created a persisted state for the navigation plugin, which shows the button in the TitleBar.
Let me know if I can answer any questions.
Reviewed By: danielbuechele
Differential Revision: D16786330
fbshipit-source-id: afc95348d9b7ec4ee041f42bb4d022f58c6bb969
Summary:
Had to mess with the tagged union we had, to distinguish based on
a string rather a bool which is a bit rubbish.
Reviewed By: danielbuechele
Differential Revision: D16764797
fbshipit-source-id: c33536f17b0705ca40abef8448802f9961c4c114
Summary:
Initial commit for Flipper API for JS apps:
1) Plugin, Connection, Client
2) a bridge to work with WebView proxy app
3) examples of ported plugins: AnalyticsLogging and Fury
Reviewed By: danielbuechele
Differential Revision: D16753405
fbshipit-source-id: cdd4b863db236b2043f09833aed130035f6738de
Summary: These get generated by VSCode if you have java installed and open the flipper project.
Reviewed By: danielbuechele
Differential Revision: D16763411
fbshipit-source-id: 40c7d943ee2ee32cf70f9aea080f5e44716e5651
Summary: N.B. There was one duplicate definition which TS rightfully complained about.
Reviewed By: danielbuechele
Differential Revision: D16764036
fbshipit-source-id: 498e4703c2363b19a3bdfa44527bde5000034095
Summary: Currently cancelling the flipper export logs the event as a failure. This diff introduces one more event log type called cancelled.
Reviewed By: jknoxville
Differential Revision: D16711110
fbshipit-source-id: 308b7e64974610dbb17bd14b2425f6d939c99313
Summary:
When a user enters a uri with optional parameters in the nav bar, I chose to automatically filter these out, yet still show the parameters in the nav bar.
The device receive uri's with no optional parameters, but the user will still see the parameters in the UI.
Reviewed By: danielbuechele
Differential Revision: D16762529
fbshipit-source-id: e3bbdf886dca7fba793b140b5fb303c4a77926ba
Summary:
Pritesh and I both decided to re-add these functions without knowing that the other person had already re-added them.
Got through to master and now master won't build.
Reviewed By: priteshrnandgaonkar
Differential Revision: D16762774
fbshipit-source-id: 4a05d9e03cb043a6f398f57f2652a3ec15bd8985
Summary: Fixed issue with the timeline not having a key prop, and added some text when there are no navigation events.
Reviewed By: jknoxville, passy
Differential Revision: D16762034
fbshipit-source-id: 8f4618c8365c1a8b5a18b6176e1d80fc401f3ca5
