Minor improvements to Timeline view

Summary: Fixed issue with the timeline not having a key prop, and added some text when there are no navigation events.

Reviewed By: jknoxville, passy

Differential Revision: D16762034

fbshipit-source-id: 8f4618c8365c1a8b5a18b6176e1d80fc401f3ca5
This commit is contained in:
Benjamin Elo
2019-08-12 05:51:56 -07:00
committed by Facebook Github Bot
parent 4305aba816
commit 13fc0bec27

View File

@@ -6,7 +6,7 @@
* @flow strict-local
*/
import {styled} from 'flipper';
import {colors, FlexCenter, styled} from 'flipper';
import {NavigationInfoBox} from './';
import type {Bookmark, NavigationEvent} from '../flow-types';
@@ -23,13 +23,23 @@ const TimelineContainer = styled('div')({
flexGrow: 1,
});
const NoData = styled(FlexCenter)({
height: '100%',
fontSize: 18,
backgroundColor: colors.macOSTitleBarBackgroundBlur,
color: colors.macOSTitleBarIcon,
});
export default (props: Props) => {
const {bookmarks, events, onNavigate, onFavorite} = props;
return (
return events.length === 0 ? (
<NoData>No Navigation Events to Show</NoData>
) : (
<TimelineContainer>
{events.map((event: NavigationEvent) => {
{events.map((event: NavigationEvent, idx) => {
return (
<NavigationInfoBox
key={idx}
isBookmarked={event.uri != null ? bookmarks.has(event.uri) : false}
uri={event.uri}
onNavigate={onNavigate}