Summary: Adding the new "Identity" section to CK root views' description.
Reviewed By: cuva
Differential Revision: D19948784
fbshipit-source-id: f5e7fe51afd387a476f6500db32b8b5149594007
Summary:
Discussed that we want this to be both a library and a CLI
tool. Also added a README stub.
Reviewed By: nikoant
Differential Revision: D19969788
fbshipit-source-id: 2c54935ce5953d2053c7bdf601debe0e5e911647
Summary: Enabling greenkeeper in the next diff.
Reviewed By: nikoant
Differential Revision: D19969790
fbshipit-source-id: 9a81c0505429512dc2e70523ab0b87eb0c6a2050
Summary:
Device management was inconsistent so far, this diff addresses the following issues
* pending a subtle timing issue, a physical android device might also show up as emulator, so effectively the device would be shown twice, but with the same content
* Metro devices now behave more like the android devices: offline devices are replaced if it comes online again
* Generalized this logic; the reducer now forces serials to be unique
* Fixed issue where a Metro device that disconnected due to a connection failure would be archived twice
* Use the metro connection url as serial, to have a slightly more future proof serial
Reviewed By: jknoxville
Differential Revision: D19996385
fbshipit-source-id: 0f6e3ddc6444542553d25cc3b592591652d688f2
Summary:
Nested subobjects work but aren't very well typed in the layout plugin.
So changing it to help flipper work with it.
From:
```
positionOnScreen: {x: 234, y: 456},
```
to
```
positionOnScreenX: 234,
positionOnScreenY: 456,
```
Reviewed By: passy
Differential Revision: D19998161
fbshipit-source-id: 4e4d7ced3cb37c527bbdf65549ec436311a8c2b8
Summary: Fixed a bunch of key errors in the network plugin, when a plugin is selected
Reviewed By: passy
Differential Revision: D19980275
fbshipit-source-id: 0ae61ed3b655c03d11c848d3502f455a409dcdcf
Summary:
This issue fixes a bunch of performance issues:
* The introduction of a context menu around every _row_ in D18808544 breaks the internal contract between lists and rows that react-window has, causing empty element to appear during scrolling, and some optimizations not working. Fixed by wrapping the context menu at the right level
* Every time a new row is created for the listview, it gets fresh event handlers and column configurations. THis has been fixed by precomputing the column configuration and avoiding the need to close over the row data in the event handlers
* Added some stricter immutable typings to make sure we don't break the immutable contract somewhere
* Fix the introduction of on the fly styling generation, which isn't needed
Reviewed By: passy
Differential Revision: D19853595
fbshipit-source-id: dc82b6586889f4e8c7a437cfdc27a50dc33ba2a2
Summary:
If the browser makes a network request, and it fails, this is _always_ logged to the console, despite any error handling being in place. (see https://stackoverflow.com/questions/43012334/silence-neterr-connection-refused)
This diffs doesn't use the browser network stack, but the node network stack instead, which doesn't suffer from the same fate.
Reviewed By: passy
Differential Revision: D19995684
fbshipit-source-id: 4ffc12b820620c5310c140c1a3af63e5d2053a50
Summary: This will query for and display all of the associated theme information for each of the descriptors.
Reviewed By: passy
Differential Revision: D19987003
fbshipit-source-id: c9b51311d28712a1af76c45a434bfb25d28d5c54
Summary:
Hovering a tooltip container would cause the full application to re-render. (Even if there isn't an actual tooltip!).
Fixed it by killing legacy context code, and using proper fragments rather than returning arrays.
Reviewed By: priteshrnandgaonkar
Differential Revision: D19969775
fbshipit-source-id: 59f6470d03b6c476305681fde7bbe3f0dca063aa
Summary:
# Summary
Folly became once again incompatible with the Android NDK, which caused our CI to fail to produce sample APK builds on release. I managed to repro this on my machine and it's working again now.
Sadly, I had to patch another file manually because something about the template parameter inference wasn't working ...
# Notes
This was done by first bumping the version, then going through the compiler errors and simply removing the lines that the C++ compiler in the NDK had trouble inferring the types for. We were lucky in that the exported symbols this affected weren't actually used, so I copied over the file to `overrides/Folly/` and set up another copy rule in Gradle.
# Meta
Pull Request resolved: https://github.com/facebook/flipper/pull/809
Test Plan:
```
./gradlew :sample:assembleDebug
```
Internal, external CI.
Reviewed By: mweststrate
Differential Revision: D19948797
Pulled By: passy
fbshipit-source-id: b2e98d3a5c89b0fc77c157683cde90997232fee0
Summary:
Getting really pissed off with Travis and this has significantly shorter queue times.
Mind that this probably won't work until the Folly PR is merged.
Pull Request resolved: https://github.com/facebook/flipper/pull/810
Test Plan: CI
Reviewed By: mweststrate
Differential Revision: D19951126
Pulled By: passy
fbshipit-source-id: ed51ad5ec6d4df3a59784dbd31e7c1667593d04f
Summary:
This diff fixes the warnings raised from FlipperKit. Also this diff updates the deployement target of FlipperKit to iOS 10. Even wilde assumes the min deployment OS version to be iOS 10. In layout plugin we use [UIAccessibiltyTraiTabBar](https://developer.apple.com/documentation/uikit/uiaccessibility/uiaccessibilitytraits/1648592-tabbar), which assumes iOS 10 and above.
Partially fixes https://github.com/facebook/flipper/issues/803
Still there are some warnings which are coming from the dependencies outside of Flipper.
Reviewed By: passy
Differential Revision: D19941558
fbshipit-source-id: 31809fedb9aa297bc318b5af72e29e8444f0142f
Summary:
As per title.
Ran `arc lint -a --take CLANGFORMAT --paths-cmd 'hg files ./'` from xplat/sonar
Reviewed By: zertosh
Differential Revision: D19943131
fbshipit-source-id: c1dc10b27389fd6f54f055803519dac6bf0e7997
Summary: This diff runs CLANGFORMAT lint on SonarKitTests. I have added CLANGFORMAT as the lint engined for objc files in xplat/sonar. Right now the iOS folder is not formatted according to CLANGFORMAT.
Reviewed By: cekkaewnumchai
Differential Revision: D19942169
fbshipit-source-id: d4a51dd4ffba3acb30177345c51eb469124f9f5f
Summary: This diff runs CLANGFORMAT lint on sample. I have added CLANGFORMAT as the lint engined for objc files in xplat/sonar. Right now the iOS folder is not formatted according to CLANGFORMAT.
Reviewed By: passy
Differential Revision: D19942174
fbshipit-source-id: bef3e67bf31f13bb52417c81c4c330d6c258872d
Summary:
This diff runs CLANGFORMAT lint on plugins. I have added CLANGFORMAT as the lint engined for objc files in xplat/sonar. Right now the iOS folder is not formatted according to CLANGFORMAT.
Ran `arc lint -a --paths-cmd "find ./iOS/Plugins -type f" --verbose`
Reviewed By: passy
Differential Revision: D19942173
fbshipit-source-id: 8b975b0a344df073b02d69cd1f9ee5629af2799d
Summary:
This diff runs CLANGFORMAT lint on FlipperKitTestUtils. I have added CLANGFORMAT as the lint engined for objc files in xplat/sonar. Right now the iOS folder is not formatted according to CLANGFORMAT.
Ran `arc lint -a --paths-cmd "find ./iOS/FlipperKitTestUtils -type f" --verbose`
Reviewed By: passy
Differential Revision: D19942175
fbshipit-source-id: a5067100e604aad438fef1842157217a8cd1734c
Summary:
This diff runs CLANGFORMAT lint on FlipperKitTestUtils. I have added CLANGFORMAT as the lint engined for objc files in xplat/sonar. Right now the iOS folder is not formatted according to CLANGFORMAT.
Ran `arc lint -a --paths-cmd "find ./iOS/FlipperKitTests -type f" --verbose`
Reviewed By: passy
Differential Revision: D19942172
fbshipit-source-id: 58322ef6a3a93f9666b3114e872a3a81a3c1cb35
Summary:
This diff runs CLANGFORMAT lint on FlipperKitTestUtils. I have added CLANGFORMAT as the lint engined for objc files in xplat/sonar. Right now the iOS folder is not formatted according to CLANGFORMAT.
Ran `arc lint -a --paths-cmd "find ./iOS/FBDefines -type f" --verbose`
Reviewed By: passy
Differential Revision: D19942171
fbshipit-source-id: a5e33c7dce2bee8ed29a58f72f5cf5935391f499
Summary:
This diff runs CLANGFORMAT lint on FlipperKit. I have added CLANGFORMAT as the lint engined for objc files in xplat/sonar. Right now the iOS folder is not formatted according to CLANGFORMAT.
Ran `arc lint -a --paths-cmd "find ./iOS/FlipperKit -type f" --verbose`
Reviewed By: passy
Differential Revision: D19942170
fbshipit-source-id: af677323af4edb761f61f8f7e289cab743aa31f2
Summary:
## The dependency [fix-path](https://github.com/sindresorhus/fix-path) was updated from `2.1.0` to `3.0.0`.
This version is **not covered** by your **current version range**.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
---
**Publisher:** [sindresorhus](https://www.npmjs.com/~sindresorhus)
**License:** MIT
<details>
<summary>Release Notes for v3.0.0</summary>
<h3>Breaking</h3>
<ul>
<li>Require Node.js 10 <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="41133a9fa6/hovercard" href="41133a9fa6"><tt>41133a9</tt></a></li>
</ul>
<h3>Enhancements</h3>
<ul>
<li>Add TypeScript definition (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="522596993" data-permission-text="Issue title is private" data-url="https://github.com/sindresorhus/fix-path/issues/12" data-hovercard-type="pull_request" data-hovercard-url="/sindresorhus/fix-path/pull/12/hovercard" href="https://urls.greenkeeper.io/sindresorhus/fix-path/pull/12">https://github.com/facebook/flipper/issues/12</a>) <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="096036c297/hovercard" href="096036c297"><tt>096036c</tt></a></li>
</ul>
<p><a class="commit-link" href="https://urls.greenkeeper.io/sindresorhus/fix-path/compare/v2.1.0...v3.0.0"><tt>v2.1.0...v3.0.0</tt></a></p>
</details>
<details>
<summary>Commits</summary>
<p>The new version differs by 5 commits.</p>
<ul>
<li><a href="8f12bec72e"><code>8f12bec</code></a> <code>3.0.0</code></li>
<li><a href="41133a9fa6"><code>41133a9</code></a> <code>Require Node.js 10</code></li>
<li><a href="096036c297"><code>096036c</code></a> <code>Add TypeScript definition (https://github.com/facebook/flipper/issues/12)</code></li>
<li><a href="df806209a2"><code>df80620</code></a> <code>Require Node.js 8</code></li>
<li><a href="e208dd064d"><code>e208dd0</code></a> <code>Create funding.yml</code></li>
</ul>
<p>See the <a href="b9fa7c4ce9...8f12bec72e">full diff</a></p>
</details>
---
<details>
<summary>FAQ and help</summary>
There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>
---
Your [Greenkeeper](https://greenkeeper.io) bot 🌴
Pull Request resolved: https://github.com/facebook/flipper/pull/804
Reviewed By: mweststrate
Differential Revision: D19938234
Pulled By: passy
fbshipit-source-id: b012360396d476d610e79136904052ec7395076d
Summary: Releasing Flipper 0.31.2 as preview for the improved React Native support (blog post will follow)
Reviewed By: cekkaewnumchai
Differential Revision: D19939346
fbshipit-source-id: 20f352e5f2d700a6e02b7562d228732525b192a4
Summary: Releasing Flipper 0.31.2 as preview for the improved React Native support (blog post will follow)
Reviewed By: cekkaewnumchai
Differential Revision: D19939347
fbshipit-source-id: 4bff1aabdd4e63003de9c9c0af2002ed67504da1
Summary:
Going through the `Getting Started` tutorial with `"react-native": "0.61.5"` makes the app crash when you build it, in order to get it working you must add a `.swift` file to the project.
## Changelog
Add troubleshooting content about swift errors in React Native build
Pull Request resolved: https://github.com/facebook/flipper/pull/794
Reviewed By: passy
Differential Revision: D19852986
Pulled By: mweststrate
fbshipit-source-id: 16bc44ad573dc20b90f57777ea1c9cfca7c7c4c9
Summary:
This diff exposes the Hermes debugger as a device plugin, for similar reasons as we did with React Devtools.
Also replaced an ugly hack with another just as ugly hack (rendering outside the React tree to preserve the state of the chrome devtools when switching to another plugin and coming back), that behaves at least correctly when resizing etc instead of doing absolute styling
Reviewed By: passy
Differential Revision: D19905082
fbshipit-source-id: 1e80c55fc9c5b1f8a9292f0ba1ef66b0b007b7fc
Summary:
This diff turns the DevTools plugin from a normal plugin in a device plugin. The reason for that can be seen at the end of the test plan in the first stack of this diff: Regardless on which client you open the devtools, you are always looking at the react tree of the app that happens to listen at the appropriate port, unrelated to the actively selected app. This diff moves the plugin from being a client plugin to a device plugin, a Metro device plugin to be precisely, as of the latter there is only one and they should typically correspond (which is why we can trigger reload as done in the previous diff)
Currently we have a Flipper plugin inside the iOS / Android apps with one purpose: to select different ports to listen to on different devices. But this functionality was never implemented, nor seems there to be much demand for. So these plugin don't offer any actual value. The widely used standalone version of the react devtools (https://www.npmjs.com/package/react-devtools) doesn't offer port customization either, so this limitation seems to be acceptable.
To make sure that this change is backward compatible, we make sure to show the metro device if we find metro, regardless whether it is new enough to support log forwarding and reload commands (previously we only showed the device if it has the /events endpoint).
The only case I can think of we are killing with this approach is where people are debugging a RN app, but with having metro running. I doubt that is an actual case, but probably rickhanlonii knows more about that.
Furthermore this diff makes sure that the devTools can connect to physical android devices. Also, making it to the end of this explanation means that you have done most of the reviewing for this diff. The actual code diff is shorter.
Reviewed By: passy
Differential Revision: D19878605
fbshipit-source-id: 3f33e59d4f6e4cce39102420f38afee10018999f
Summary:
To connect to the React Devtools, the app has to be reload (or the dev menu opened).
This diff does force a reload if the React Devtools don't connect timely
Reviewed By: passy
Differential Revision: D19878172
fbshipit-source-id: 0b3e22f70c9d24dae1fdbf0cc351d23367654ae1
Summary: In many cases the React DevTools fail to show up for RN. usually that is because the app didn't enter devMode yet. This diff adds the necessary logic to query the state of the DevTools and communicate back the current connection status
Reviewed By: passy
Differential Revision: D19878127
fbshipit-source-id: f5c3f5a92b23c87c87d778a468122210325eed17
Summary: This diff selects both required and default plugins in the plugin selection menu
Reviewed By: mweststrate
Differential Revision: D19905737
fbshipit-source-id: 86fb308f8f189350cc035d14174b34fac14a2cd1
Summary: uncrustify was not recommended to add in xplat thus I have added clangformat for xplat/sonar/iOS
Reviewed By: zertosh
Differential Revision: D19879977
fbshipit-source-id: 76f6dadf5d55a61a5342802cfde2821cbff38525
Summary:
Implement the react-native-flipper native module on iOS. Uses very similar abstractions as on Android.
## Changelog
[react-native-flipper] Support iOS
Pull Request resolved: https://github.com/facebook/flipper/pull/795
Test Plan:
Tested using the RN TicTacToe example app
{F228406333}
Reviewed By: mweststrate
Differential Revision: D19853017
Pulled By: priteshrnandgaonkar
fbshipit-source-id: d93d35ff984b9ba75f812c4c8e3c82e4d550f0c0
Summary: To verify that the infra is working.
Reviewed By: mweststrate
Differential Revision: D19881083
fbshipit-source-id: 92d5f55ecbef84003b6000b4c95df1fe0518719c
Summary: Gets flipper to open up a websocket server for web browser connections.
Reviewed By: passy, priteshrnandgaonkar
Differential Revision: D19501123
fbshipit-source-id: e506f35d7ddce622128932494e8bb10802d3747b
Summary: No changes that should impact us in any way.
Reviewed By: priteshrnandgaonkar
Differential Revision: D19856578
fbshipit-source-id: 35113b4b9e56b6c0b09681ac5649705cf840f60c
Summary: Client implementation for the flipper send data lispy api
Reviewed By: adamjernst
Differential Revision: D19862378
fbshipit-source-id: 7a5cc8b47772bdbc0e89d723d0099ff824a81ed5
