jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Improve error logs readability

Browse Source 
Summary:
Setting the background to red for error logs has a lot of implications for all text colouring inside of its container.

Instead, set the error border to red, which gives a clear error indication whilst making things easier to read.

changelog: Improve console error logs readability

Reviewed By: mweststrate

Differential Revision: D45861604

fbshipit-source-id: 51f557451ac16269b69ff830a26328552e134ee5
This commit is contained in:
Lorenzo Blasa
2023-05-15 05:35:32 -07:00
committed by Facebook GitHub Bot
parent cd67ce59f7
commit 47a4c10c67
1 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
desktop/flipper-ui-core/src/chrome/ConsoleLogs.tsx
View File

@@ -141,18 +141,15 @@ function buildTheme(): Styles {
LOG_INFO_BACKGROUND: 'transparent',
LOG_COMMAND_BACKGROUND: 'transparent',
LOG_RESULT_BACKGROUND: 'transparent',
LOG_WARN_BACKGROUND: theme.warningColor,
LOG_ERROR_BACKGROUND: theme.errorColor,
LOG_INFO_COLOR: theme.textColorPrimary,
LOG_COMMAND_COLOR: theme.textColorSecondary,
LOG_RESULT_COLOR: theme.textColorSecondary,
LOG_WARN_COLOR: 'white',
LOG_ERROR_COLOR: 'white',
LOG_ERROR_COLOR: theme.textColorPrimary,
LOG_INFO_BORDER: theme.dividerColor,
LOG_COMMAND_BORDER: theme.dividerColor,
LOG_RESULT_BORDER: theme.dividerColor,
LOG_WARN_BORDER: theme.dividerColor,
LOG_ERROR_BORDER: theme.dividerColor,
LOG_WARN_BORDER: theme.warningColor,
LOG_ERROR_BORDER: theme.errorColor,
LOG_BORDER: theme.dividerColor,
};
}