From 47a4c10c679da1004962f36435f1a10efae7bbdf Mon Sep 17 00:00:00 2001 From: Lorenzo Blasa Date: Mon, 15 May 2023 05:35:32 -0700 Subject: [PATCH] Improve error logs readability Summary: Setting the background to red for error logs has a lot of implications for all text colouring inside of its container. Instead, set the error border to red, which gives a clear error indication whilst making things easier to read. changelog: Improve console error logs readability Reviewed By: mweststrate Differential Revision: D45861604 fbshipit-source-id: 51f557451ac16269b69ff830a26328552e134ee5 --- desktop/flipper-ui-core/src/chrome/ConsoleLogs.tsx | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/desktop/flipper-ui-core/src/chrome/ConsoleLogs.tsx b/desktop/flipper-ui-core/src/chrome/ConsoleLogs.tsx index b1f345c16..c02d66a62 100644 --- a/desktop/flipper-ui-core/src/chrome/ConsoleLogs.tsx +++ b/desktop/flipper-ui-core/src/chrome/ConsoleLogs.tsx @@ -141,18 +141,15 @@ function buildTheme(): Styles { LOG_INFO_BACKGROUND: 'transparent', LOG_COMMAND_BACKGROUND: 'transparent', LOG_RESULT_BACKGROUND: 'transparent', - LOG_WARN_BACKGROUND: theme.warningColor, - LOG_ERROR_BACKGROUND: theme.errorColor, LOG_INFO_COLOR: theme.textColorPrimary, LOG_COMMAND_COLOR: theme.textColorSecondary, LOG_RESULT_COLOR: theme.textColorSecondary, - LOG_WARN_COLOR: 'white', - LOG_ERROR_COLOR: 'white', + LOG_ERROR_COLOR: theme.textColorPrimary, LOG_INFO_BORDER: theme.dividerColor, LOG_COMMAND_BORDER: theme.dividerColor, LOG_RESULT_BORDER: theme.dividerColor, - LOG_WARN_BORDER: theme.dividerColor, - LOG_ERROR_BORDER: theme.dividerColor, + LOG_WARN_BORDER: theme.warningColor, + LOG_ERROR_BORDER: theme.errorColor, LOG_BORDER: theme.dividerColor, }; }