Files
flipper/desktop/patches/metro+0.59.0.patch
Anton Nikolaev ec7cbd7f14 Fixed the patch disabling warnings for cyclic dependencies inside node_modules
Summary: Fixed the patch disabling warnings for cyclic dependencies inside node_modules. It broke after I changed the way of bundling plugins.

Reviewed By: passy

Differential Revision: D21065488

fbshipit-source-id: f8891f007d14d2475df517b28452dc0b8346f113
2020-04-16 09:52:27 -07:00

24 lines
1015 B
Diff

diff --git a/node_modules/metro/src/lib/polyfills/require.js b/node_modules/metro/src/lib/polyfills/require.js
index 8c04756..3610bba 100644
--- a/node_modules/metro/src/lib/polyfills/require.js
+++ b/node_modules/metro/src/lib/polyfills/require.js
@@ -114,11 +114,13 @@ function metroRequire(moduleId) {
.map(id => (modules[id] ? modules[id].verboseName : "[unknown]")); // We want to show A -> B -> A:
cycle.push(cycle[0]);
- console.warn(
- `Require cycle: ${cycle.join(" -> ")}\n\n` +
- "Require cycles are allowed, but can result in uninitialized values. " +
- "Consider refactoring to remove the need for a cycle."
- );
+ if (!cycle.every(path => path.includes('/node_modules/'))) {
+ console.warn(
+ `Require cycle: ${cycle.join(" -> ")}\n\n` +
+ "Require cycles are allowed, but can result in uninitialized values. " +
+ "Consider refactoring to remove the need for a cycle."
+ );
+ }
}
}