Summary: This diff introduces the logic for queueing incoming messages rather then directly processing them you are behind the `flipper_event_queue` GK. The reason the queue processing is a bit complicated is to make the queue can be processed non-blocking, can be cancelled, and is safe to concurrency issues. The idea here is that the queue is processed when we switch to a plugin, report it's progress, and abort the process when switching to another plugin without loosing any work. This diff does not include [x] updates to the UI (**SO DON"T LAND IN ISOLATION**) [x] metrics to see the effect The effect of the changes can be seen when profiling the application, before this change there are very regular CPU spikes (see the small yellow bar on the top): https://pxl.cl/TQtl These go away when the events are no longer processed https://pxl.cl/TQtp Reviewed By: nikoant Differential Revision: D19095564 fbshipit-source-id: 0b8c3421acc4a4f240bf2aab5c1743132f69aa6e
77 lines
1.8 KiB
JavaScript
77 lines
1.8 KiB
JavaScript
/**
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*
|
|
* @format
|
|
*/
|
|
|
|
import {Idler, TestIdler} from '../Idler.tsx';
|
|
import {sleep} from '../promiseTimeout.tsx';
|
|
|
|
test('Idler should interrupt', async () => {
|
|
const idler = new Idler();
|
|
let i = 0;
|
|
try {
|
|
for (; i < 500; i++) {
|
|
if (i == 100) {
|
|
expect(idler.shouldIdle()).toBe(false);
|
|
idler.cancel();
|
|
expect(idler.isCancelled()).toBe(true);
|
|
expect(idler.shouldIdle()).toBe(true);
|
|
}
|
|
await idler.idle();
|
|
}
|
|
expect('error').toBe('thrown');
|
|
} catch (e) {
|
|
expect(i).toEqual(100);
|
|
}
|
|
});
|
|
|
|
test('Idler should want to idle', async () => {
|
|
const idler = new Idler();
|
|
expect(idler.shouldIdle()).toBe(false);
|
|
await sleep(10);
|
|
expect(idler.shouldIdle()).toBe(false);
|
|
await sleep(200);
|
|
expect(idler.shouldIdle()).toBe(true);
|
|
await idler.idle();
|
|
expect(idler.shouldIdle()).toBe(false);
|
|
});
|
|
|
|
test('TestIdler can be controlled', async () => {
|
|
const idler = new TestIdler();
|
|
|
|
expect(idler.shouldIdle()).toBe(false);
|
|
expect(idler.shouldIdle()).toBe(true);
|
|
let resolved = false;
|
|
idler.idle().then(() => {
|
|
resolved = true;
|
|
});
|
|
expect(resolved).toBe(false);
|
|
await idler.next();
|
|
expect(resolved).toBe(true);
|
|
|
|
expect(idler.shouldIdle()).toBe(false);
|
|
expect(idler.shouldIdle()).toBe(true);
|
|
idler.idle();
|
|
await idler.next();
|
|
|
|
expect(idler.isCancelled()).toBe(false);
|
|
idler.cancel();
|
|
expect(idler.isCancelled()).toBe(true);
|
|
expect(idler.shouldIdle()).toBe(true);
|
|
|
|
let threw = false;
|
|
const p = idler.idle().catch(e => {
|
|
threw = true;
|
|
expect(e).toMatchInlineSnapshot(
|
|
`[CancelledPromiseError: Idler got killed]`,
|
|
);
|
|
});
|
|
|
|
await p;
|
|
expect(threw).toBe(true);
|
|
});
|