Summary:
Quick notes:
- This looks worse than it is. It adds mandatory parentheses to single argument lambdas. Lots of outrage on Twitter about it, personally I'm {emoji:1f937_200d_2642} about it.
- Space before function, e.g. `a = function ()` is now enforced. I like this because both were fine before.
- I added `eslint-config-prettier` to the config because otherwise a ton of rules conflict with eslint itself.
Close https://github.com/facebook/flipper/pull/915
Reviewed By: jknoxville
Differential Revision: D20594929
fbshipit-source-id: ca1c65376b90e009550dd6d1f4e0831d32cbff03
35 lines
776 B
JavaScript
35 lines
776 B
JavaScript
/**
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*
|
|
* @format
|
|
*/
|
|
|
|
function isDynamicRequire(node) {
|
|
return (
|
|
node.type === 'CallExpression' &&
|
|
node.callee.type === 'Identifier' &&
|
|
node.callee.name === 'require' &&
|
|
(node.arguments.length !== 1 || node.arguments[0].type !== 'StringLiteral')
|
|
);
|
|
}
|
|
|
|
module.exports = function (babel) {
|
|
const t = babel.types;
|
|
|
|
return {
|
|
name: 'replace-dynamic-requires',
|
|
visitor: {
|
|
CallExpression(path) {
|
|
if (!isDynamicRequire(path.node)) {
|
|
return;
|
|
}
|
|
|
|
path.replaceWith(t.identifier('triggerDynamicRequireError'));
|
|
},
|
|
},
|
|
};
|
|
};
|