Summary:
This seems to only encourage snark. I've yet to see this being used productively.
Pull Request resolved: https://github.com/facebook/flipper/pull/871
Reviewed By: mweststrate
Differential Revision: D20283096
Pulled By: passy
fbshipit-source-id: 1f5d8553505eb41ef8d4000e55cacf510e46949b
Summary:
We're no longer building this internally because it requires a Mac to build and we only use it in OSS.
Pull Request resolved: https://github.com/facebook/flipper/pull/852
Reviewed By: mweststrate
Differential Revision: D20250521
Pulled By: passy
fbshipit-source-id: c1691c62b2db3bc22cb0231040f593a35ec4f17e
Summary:
The script introduced here finds the last auto released diff in the history, and scans all diffs in between, in the `xplat/sonar` directory for `CHANGELOG: `entries.
Didn't make a distinction between internal and external commits at this point, as plugins are moving to their independent release process, in which case we have to revisit this anyway, and this will probably not result in too much noise.
Will perform some additional tests to see everything works out nicely with the release process, and post instructions in UI Tools group and wiki once this has landed.
(lol, meta:)
CHANGELOG: Flipper will now generate a changelog during release
Reviewed By: passy
Differential Revision: D20190698
fbshipit-source-id: e3b87cd986a17873c06b5f97b2ebffaf197ed0bf
Summary: ts-jest is unhappy with us using an old version. Let's bump it.
Reviewed By: mweststrate
Differential Revision: D20191204
fbshipit-source-id: d6ed4ad9bf20c4011ae9be1048a116ddc5ee6028
Summary:
There's a lot going on here:
- I'm moving over to android build hosts. They're are faster and more plentiful. They seem to work just fine for what we do. We already have a tenant capacity for them. *Edit:* Even more importantly, we need `adb` for certain tasks. The Android SDK isn't installed on Lego.
- I'm splitting our `sandcastle_setup` up into a pure yarn setup and an electron setup. The latter downloads from LFS and installs Wine (on Linux) which takes some time. This isn't needed unless we actually run Electron. That's for builds and Electron tests only.
- There were so, so many weird little edge cases. One of them is that `electron-builder`'s `app-builder` (a go app) switches between an x86 and an x86_64 version of wine to use for signing Windows apps, but only on Mac. On Linux it's hard-coded to 32bits. So we need to manually override the binary in the cache. I do this in the script rather in the cache because this is impossible to remember when upgrading.
- Wine is only bundled for Mac. On Linux you have to get it somewhere else. Luckily, we run as root, so we can do that.
- `$HOME` is set to `/var/twscsvc` which isn't owned by `root` but by `twscsvc`. Wine no happy. So we have to manually set this to a path that `root` owns. Hence the `export HOME`.
Reviewed By: nikoant
Differential Revision: D20223753
fbshipit-source-id: 0b2b09d19409ce172f395a7d1f85ec601654c6f6
Summary:
This works now with the Electron update. Wine doesn't work there so the app signing step needs to be disabled. I'm not entirely sure if this has other consequences than disabling signing - which we don't use.
We also can't build `.dmg`s on Linux because it relies on a CLI tool that only exists on Macs. But we can quite easily move this to GitHub Actions, which I set up with https://github.com/facebook/flipper/pull/852
Reviewed By: nikoant
Differential Revision: D20160545
fbshipit-source-id: a888c8b0e8f7dbe8bec818d57f5f22bcf800322c
Summary:
The target selector was broken on iOS. The overlay view which has the gesture recognizer, was never added to the window, due to which the gestures were not registered and the feature broke.
This diff adds the overlay view in the window object as the subview and then discards it in its view descriptor as otherwise we will capture all our touches in this view.
This was the most popular bug in our research trip and almost everyone reported it.
Reviewed By: fabiomassimo
Differential Revision: D20225594
fbshipit-source-id: af4041859d7e662152b2575d1eb258dd0c2d990e
Summary: We still use `flow` internally. The script to generate Electron API doesn't work as expected.
Reviewed By: passy
Differential Revision: D20224009
fbshipit-source-id: 371e5e857537811c863d81e5bafa0ec6a912c9fe
Summary:
This PR fixes https://github.com/facebook/flipper/issues/798 by adding customizable hotkeys to reload and/or open developer menu in React Native apps.
#### TODO:
- [x] Add correct icon for removing content of the hotkey input (currently using `undo`) - cc passy 😄
## Changelog
Add customizable hotkeys to reload and/or open developer menu in React Native apps.
Pull Request resolved: https://github.com/facebook/flipper/pull/822
Test Plan:
- Run React Native on version `0.62.0-rc.2` (you can use this app: https://github.com/lucasbento/RNWithFlipper);
- Open the Preferences window (`⌘,`);
- Customise the React Native hotkeys to whatever you want;
- Test them out with Flipper's window active and inactive.
> **Note**: this has been tested only in macOS.
Reviewed By: jknoxville
Differential Revision: D20061833
Pulled By: passy
fbshipit-source-id: 601d29e07d7de2683d2c70c7c87f0d841aa3559e
Summary: It's handy to copy images URI to paste it in other tools
Reviewed By: mweststrate
Differential Revision: D20221861
fbshipit-source-id: 09074b434d5c1277bb83daa7846b885717c5ee8d
Summary:
We use them implicitly right now which causes problems
with upgrades. See https://github.com/facebook/flipper/compare/master...facebook:greenkeeper%2Fpkg-4.4.4
where a patch upgrade removes the dependency and breaks the build.
Glob is used in the new TypeScript-ified plugin building process.
Reviewed By: nikoant
Differential Revision: D20189781
fbshipit-source-id: 3b2af349f64a470e1f3e5a78d69b94d7f28e1332
Summary:
The platform check is a side-effect and shouldn't be in the UI component
itself.
Reviewed By: mweststrate
Differential Revision: D20159799
fbshipit-source-id: c5fa99e0b915a140f10056283671cf5b7368e9c9
Summary: Updated keytar to match electron 8.0.1
Reviewed By: passy
Differential Revision: D20160252
fbshipit-source-id: fee8aaf152c7a95a62f5b9985c3615c99b5ed0d9
Summary:
This diff fixes the broken export which is being made [here](https://fb.workplace.com/groups/graphqlandroid/permalink/3319822971399628/). In the import there is no client and plugin states. The fact that the validation succeeded on submit button click suggests that the app got disconnected between the click on submit button and the initiation of export, thus exporting the store with no plugin data and client.
I have added a validation after exporting the store and before the trace is uploaded.
Also in the support request details page, we assumed that client can't be null, relaxed this assumption as the flipper should still open even the above broken export instead of crashing.
Reviewed By: mweststrate
Differential Revision: D20136295
fbshipit-source-id: f589d01f8ff0ec0b23d53ad5099e11ebbd0930cd
Summary:
## The devDependency [flow-bin](https://github.com/flowtype/flow-bin) was updated from `0.118.0` to `0.119.0`.
This version is **not covered** by your **current version range**.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
---
**Publisher:** [jbrown215](https://www.npmjs.com/~jbrown215)
**License:** MIT
[Find out more about this release](https://github.com/flowtype/flow-bin).
---
<details>
<summary>FAQ and help</summary>
There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>
---
Your [Greenkeeper](https://greenkeeper.io) bot 🌴
Pull Request resolved: https://github.com/facebook/flipper/pull/829
Reviewed By: nikoant
Differential Revision: D20139183
Pulled By: passy
fbshipit-source-id: fca3711e4299e02cc138e370ade8376c374a6f40
Summary: Adds the theme information relating to a Litho component in the layout inspector
Reviewed By: sjkirby
Differential Revision: D20133889
fbshipit-source-id: 93acb745f47c1ff9ce37be35a05b4a6269193a47
Summary:
Make sure that we can pass with the combinations of eslint/tslint
rules.
Reviewed By: nikoant
Differential Revision: D20067199
fbshipit-source-id: 40e208f75f09a1eff584f111fbb9bc1be87dba01
Summary: Remove asan checker, we can use `BuildConfig.IS_ASAN_BUILD` to check whether it's a asan build to instead of invoking a JNI api.
Differential Revision: D20088093
fbshipit-source-id: f26d367430a983fbe7b630919a4131fdf2e2d510
Summary: When running tests locally, some are quite flaky, and there is a lot of error logging noise. This diff doesn't remove all of it, but does reduce it significantly.
Reviewed By: nikoant
Differential Revision: D20034619
fbshipit-source-id: 183f74475b644f803b2f92b1b1301f4d0f6e193a
