Chaiwat Ekkaewnumchai
b9e0aae1e4
Add Warning for FB Employee
...
Summary: Add warning dialog when FB employee uses OSS Flipper
Reviewed By: passy, danielbuechele
Differential Revision: D16783408
fbshipit-source-id: 3e7e533c5b96d4204fc38570a4e65c23ac0aaa25
2019-08-14 06:14:16 -07:00
Benjamin Elo
1ae3b90019
Added LocationsButton when Navigation Plugin is active
...
Summary:
Here I've added the LocationsButton to the TitleBar in Flipper. This allows the user to navigate to saved bookmarks, or display the current page URI without ever opening the Navigation Plugin (Except to add bookmarks). The challenge of this diff was having a TitleBar child be controlled by a plugin.
The LocationsButton pulls bookmarks straight from the database whenever a mouseDown event is called on the button. (The Electron popup menu does not respond to props changes, so the menu is opened on mouse up and getting the bookmarks from the database occurs on mouse down... This seems to work fine).
The nav plugin on the Android side will now also send a welcome message alerting the app to created a persisted state for the navigation plugin, which shows the button in the TitleBar.
Let me know if I can answer any questions.
Reviewed By: danielbuechele
Differential Revision: D16786330
fbshipit-source-id: afc95348d9b7ec4ee041f42bb4d022f58c6bb969
2019-08-14 05:27:43 -07:00
Pascal Hartig
2a34125413
Migrate metrics
...
Summary:
Had to mess with the tagged union we had, to distinguish based on
a string rather a bool which is a bit rubbish.
Reviewed By: danielbuechele
Differential Revision: D16764797
fbshipit-source-id: c33536f17b0705ca40abef8448802f9961c4c114
2019-08-14 04:43:50 -07:00
Pritesh Nandgaonkar
9a513ebd99
Do not update state when the component is unmounted
...
Summary:
Bug:
{F176561921}
Reviewed By: danielbuechele
Differential Revision: D16763611
fbshipit-source-id: 93b95877f4818a9d2b2c7ba1b27eabaec41d4e95
2019-08-12 14:52:00 -07:00
Benjamin Elo
4305aba816
Migrate Sheet from js to ts
...
Summary: Migrated Sheet.js to Sheet.tsx
Reviewed By: passy
Differential Revision: D16735685
fbshipit-source-id: f910b38c9d0a8ac5d77203385599a03d0a4bc5bd
2019-08-12 06:06:43 -07:00
Benjamin Elo
7fd7a26d7d
Migrate SignInSheet from js to ts
...
Summary: Migrated SignInSheet.js to SignInSheet.tsx
Reviewed By: danielbuechele
Differential Revision: D16735194
fbshipit-source-id: a7e039bf34b2784c55e6ebd4c8c17298a2f380cf
2019-08-12 06:06:43 -07:00
Benjamin Elo
4f47f73e5e
Migrated ShareSheetExportFile from js to ts
...
Summary: Migrated ShareSheetExportFile.js to ShareSheetExportFile.tsx
Reviewed By: danielbuechele
Differential Revision: D16734995
fbshipit-source-id: 4528b27be0bfbefe9ddbd371c0bfc8950be6fe1f
2019-08-12 06:06:43 -07:00
Benjamin Elo
223cfe53d7
Migrate ShareSheetErrorList from js to ts
...
Summary: Migrated ShareSheetErrorList.js to ShareSheetErrorList.tsx
Reviewed By: jknoxville
Differential Revision: D16734553
fbshipit-source-id: ed608d5b171deda1caa284c27527e2f63af67ebb
2019-08-12 06:06:43 -07:00
Benjamin Elo
3e11e8887d
Migrate ShareSheet from js to ts
...
Summary: Migrated ShareSheet.js to ShareSheet.tsx
Reviewed By: jknoxville
Differential Revision: D16734361
fbshipit-source-id: a6c050be19892f1650c1652536a62e4324ad949a
2019-08-12 06:06:42 -07:00
Benjamin Elo
d9cb55c8ae
Migrate SelectPluginSheet from js to tsx
...
Summary: Migrated SelectPluginSheet.js to SelectPluginSheet.tsx
Reviewed By: jknoxville
Differential Revision: D16733361
fbshipit-source-id: c48e921761f4008a76a5000dd58aa2dd1aa42d2c
2019-08-12 06:06:42 -07:00
Benjamin Elo
11e817e1f2
Migrate ScreenCaptureButtons from js to ts
...
Summary: Migrated ScreenCaptureButtons.js to ScreenCaptureButtons.ts
Reviewed By: jknoxville
Differential Revision: D16733189
fbshipit-source-id: aabb7a82746609797c0448e441bbc79e65249191
2019-08-12 06:06:42 -07:00
Benjamin Elo
5c8be8f360
Migrate RatingButton from js to ts
...
Summary: Migrated RatingButton from RatingButton.js to RatingButton.tsx
Reviewed By: jknoxville
Differential Revision: D16732775
fbshipit-source-id: 380c8916f628115f474b575aef1b8a6e0c8863f9
2019-08-12 06:06:41 -07:00
Benjamin Elo
afe8ba65f0
Migrate Popover from js to ts
...
Summary: Migrated Popover.js to Popover.tsx
Reviewed By: passy
Differential Revision: D16732630
fbshipit-source-id: a7d44c7191972cd15ecb9530f6a146e7118c2b15
2019-08-12 06:06:41 -07:00
Benjamin Elo
e4b071e867
Migrate PluginDebugger from js to tsx
...
Summary: Migrated PluginDebugger.js to PluginDebugger.tsx
Reviewed By: passy
Differential Revision: D16732025
fbshipit-source-id: c4ff5586f823e90eba14eef5a8dac114a058763b
2019-08-12 06:06:41 -07:00
Benjamin Elo
8bbc03e138
Migrate MainSidebar from JS to TS
...
Summary: Migrated MainSidebar.js to MainSidebar.tsx
Reviewed By: passy
Differential Revision: D16731621
fbshipit-source-id: 57be95bf96c63105d05562cf0175e46c7f83aafa
2019-08-12 06:06:41 -07:00
Benjamin Elo
46b032d5ed
Migrated ExportDataPluginSheet from js to ts
...
Summary: Migrated ExportDataPluginSheet.js to ExportDataPluginSheet.tsx
Reviewed By: passy
Differential Revision: D16731274
fbshipit-source-id: 5025f6eb34465d84e276f21855ee78cb98e8cd8d
2019-08-12 06:06:40 -07:00
Benjamin Elo
b5c01bdf36
Migrated BugReporterDialog from js to ts
...
Summary: Migrated BugReporterDialog.js to BugReporterDialog.tsx
Reviewed By: passy
Differential Revision: D16731216
fbshipit-source-id: 9ba70feed170eb1d017db88b980a3b449527f043
2019-08-12 06:06:40 -07:00
Benjamin Elo
dcda5741b9
Migrated LocationsButton from js to ts
...
Summary:
This isn't used anywher at the moment but I plan to add it in once we are finished with TS migration.
Migrated this file from LocationsButton.js to LocationsButton.ts
Reviewed By: jknoxville
Differential Revision: D16730904
fbshipit-source-id: d357785c462b1f5f6017b4c00a2d2467d905b895
2019-08-12 06:06:40 -07:00
Benjamin Elo
beaf4997fe
Migrated DevicesButton from js to ts
...
Summary: Migrated DevicesButton from JS to TS
Reviewed By: passy
Differential Revision: D16730841
fbshipit-source-id: 3bfdb7945d82661f03d6a5b44b5404541a1b2c33
2019-08-12 06:06:39 -07:00
Benjamin Elo
c07fdd0485
Remove DevicesList as it is not used anywhere
...
Summary: This file is not used in the project and has been replaced by different logic in the DevicesButton.
Reviewed By: passy
Differential Revision: D16730618
fbshipit-source-id: b41c9dcef44690fee1331da2e3d66aa9e1394bad
2019-08-12 06:06:39 -07:00
Benjamin Elo
f7896a1f2b
Migrate ErrorBar from .js to .tsx
...
Summary: Migrated the ErrorBar from JS to TS.
Reviewed By: passy
Differential Revision: D16730539
fbshipit-source-id: 3fd8c90f218f7a1d666c3d47380d56868c1cd23f
2019-08-12 06:06:39 -07:00
Benjamin Elo
12704269d7
Migrate DetailSidebar from js to tsx
...
Summary: Migrated DetailSidebar.js to DetailSidebar.tsx
Reviewed By: passy
Differential Revision: D16708503
fbshipit-source-id: 13090d6d44dbd01b162194c66724059d8e86a4c8
2019-08-12 06:06:39 -07:00
Benjamin Elo
8344b79fd4
Migrated CancellableExportStatus from js to ts
...
Summary: Moved CancellableExportStatus.js to CancellableExportStatus.tsx
Reviewed By: passy
Differential Revision: D16708431
fbshipit-source-id: 11eb4f5dbb851a9690a6abd136c1f144ed8a4b1a
2019-08-12 06:06:38 -07:00
Pascal Hartig
99ca6aa7e8
Migrate exportData
...
Summary: _typescript_
Reviewed By: jknoxville
Differential Revision: D16711940
fbshipit-source-id: 2e0e5cd0440fe1cdb7bd29af94e22c7f6b9137f8
2019-08-12 03:53:15 -07:00
Pascal Hartig
fcf99fda4b
Migrate is{Headless,Production}
...
Summary: _typescript_
Reviewed By: jknoxville
Differential Revision: D16711115
fbshipit-source-id: 174e1d3057182c35a6e3493612ddcb3d6ba1ee54
2019-08-12 03:53:14 -07:00
John Knox
ce34c20506
Convert utils/pluginUtils to TS
...
Reviewed By: danielbuechele
Differential Revision: D16710689
fbshipit-source-id: 8da309810f633af27759286521c784ac665531b9
2019-08-12 03:11:16 -07:00
John Knox
882d7e1a39
Convert utils/processConfig to TS
...
Reviewed By: danielbuechele
Differential Revision: D16710602
fbshipit-source-id: 3dbccdb0aedd3d5415487d690fb943aafdafa0f0
2019-08-12 03:11:16 -07:00
Pascal Hartig
b292ecec71
Migrate argvUtils
...
Summary:
_typescript_
Quite happy that the stupid check for `remote` can finally go away.
Reviewed By: jknoxville
Differential Revision: D16709217
fbshipit-source-id: 94bc035d2a7bbc3131e35febd48723760841f6b4
2019-08-09 10:47:13 -07:00
Pascal Hartig
b42abcbb59
Migrate logger
...
Summary:
Removed defunct log filtering functionality, but we probably want to rebuild that.
Funny that tsc caught this as non functioning but Flow happily accepted it.
Reviewed By: danielbuechele
Differential Revision: D16690959
fbshipit-source-id: b079dd6faba83ca0c443d00cbb69c8ff95c4fa69
2019-08-09 10:47:12 -07:00
Pascal Hartig
e56d3a4c6d
Migrate user
...
Summary: Migrate user and introduce a global declarations file.
Reviewed By: danielbuechele
Differential Revision: D16690480
fbshipit-source-id: be4e5218715dcae4b403b24cdbc2f3e89728dd59
2019-08-09 10:47:12 -07:00
John Knox
6da09fa381
Convert plugins dispatcher to TS
...
Summary: Convert plugins dispatcher to TS
Reviewed By: passy
Differential Revision: D16689874
fbshipit-source-id: afdac7960e267ebed350fcb170795689bd327807
2019-08-09 09:05:10 -07:00
Pritesh Nandgaonkar
f408f3f949
Migrate the iOSDevice from js to tsx
...
Summary: As per the title.
Reviewed By: jknoxville
Differential Revision: D16668086
fbshipit-source-id: c246fcaf117802cf1d3c6b3959bf0d0c2761fdce
2019-08-09 07:56:53 -07:00
Pritesh Nandgaonkar
eb26a74327
Migrate AndroidDevice from js to tsx
...
Summary: As per the title
Reviewed By: jknoxville
Differential Revision: D16667269
fbshipit-source-id: d213f4ebacf8050ae55a8e3268909da8535f2d93
2019-08-09 07:56:53 -07:00
Pritesh Nandgaonkar
47a55b0f26
Migrate BaseDevice from js to tsx
...
Summary: As per the title
Reviewed By: passy
Differential Revision: D16687261
fbshipit-source-id: a9d85424fb0a08fada7edd0355c356907518d366
2019-08-09 06:56:54 -07:00
Pascal Hartig
c5563be56b
Migrate BugReporter
...
Summary: _typescript_
Reviewed By: danielbuechele
Differential Revision: D16666761
fbshipit-source-id: 7dc1c21c5c9bdf56908af4e251de16dad14cae38
2019-08-09 04:02:45 -07:00
Pascal Hartig
e602e1ccae
Migrate config
...
Summary:
Very mechanical migration. No syntactic changes, only moves and
file name changes.
Reviewed By: danielbuechele
Differential Revision: D16665891
fbshipit-source-id: afb1f2418f55bf6c5370b8a2b1d2c35ac5986dc3
2019-08-09 03:25:05 -07:00
Pascal Hartig
fc0966a133
Migrate GK
...
Summary: _typescript_
Reviewed By: jknoxville
Differential Revision: D16647882
fbshipit-source-id: a5a7053379cd9468e1da9ab0ac2098be3443dda7
2019-08-08 14:32:20 -07:00
John Knox
3bfb7faf0a
Convert plugin.js to plugin.tsx
...
Summary:
* Deletes plugin.js
* Adds plugin.tsx
* Adds plugin flow-typed module that has the old flow types
Reviewed By: passy
Differential Revision: D16668067
fbshipit-source-id: b2f0ce47c4cf7125b4e352821e921b97675d12a9
2019-08-08 12:06:11 -07:00
Daniel Büchele
5f53087c7e
client server
...
Summary: Migrating Server, Client and UninitializedClient to TypeScript
Reviewed By: passy
Differential Revision: D16687855
fbshipit-source-id: 402e4dbcd5d283d3e280d4d8b312662829457886
2019-08-08 11:00:38 -07:00
Daniel Büchele
64cefd0f84
migrate redux store
...
Summary: Migrating redux stores to TypeScript
Reviewed By: passy
Differential Revision: D16579796
fbshipit-source-id: e3e507f17f1bdd57eb45e30cb0b28aaee6c4521c
2019-08-08 08:07:21 -07:00
Benjamin Elo
d9209113be
Migrated UpdateIndicator
...
Summary: Migrated UpdateIndicator.js to UpdateIndicator.tsx
Reviewed By: passy
Differential Revision: D16668962
fbshipit-source-id: 32861327daa926b9dd53ff2c7c46ade164c09ccb
2019-08-08 06:03:25 -07:00
Benjamin Elo
48db6b7b58
Migrate UserAccount
...
Summary: Migrated UserAccount.js to UserAccount.tsx
Reviewed By: passy
Differential Revision: D16668833
fbshipit-source-id: 723f2c2d7e68cda0076dd46aebe4b8e6ba392c24
2019-08-08 06:03:25 -07:00
Benjamin Elo
7aaecf61ce
Migrate WelcomeScreen
...
Summary: Migrated WelcomeScreen.js to WelcomeScreen.tsx
Reviewed By: passy
Differential Revision: D16667903
fbshipit-source-id: 86814d52175e611961733d608c34ef1cdbf8db1a
2019-08-08 04:00:58 -07:00
Benjamin Elo
d39ac338a4
Migrated AutoUpdateVersion to ts
...
Summary: Migrated AutoUpdateVersion.js to AutoUpdateVersion.tsx
Reviewed By: jknoxville
Differential Revision: D16667729
fbshipit-source-id: a8f05b39be412f9ece1d1e56961fd87c88deb76a
2019-08-08 02:36:36 -07:00
Pascal Hartig
6a43b0cc88
Revert D16648356: Migration of Basedevice from js to tsx
...
Differential Revision:
D16648356
Original commit changeset: 12954532acf9
fbshipit-source-id: 76754f427e7ccac0f0b0030c3a0af02d036c1a8b
2019-08-06 08:50:32 -07:00
Pritesh Nandgaonkar
604e6d761f
Migration of Basedevice from js to tsx
...
Summary: Converted BaseDevice from js to tsx
Reviewed By: passy
Differential Revision: D16648356
fbshipit-source-id: 12954532acf91930ab8c5f995bb94f6f9fe44015
2019-08-06 05:12:20 -07:00
Benjamin Elo
5aadbde4b9
Added missing key props
...
Summary: This was an error appearing in the console that was bugging me. About how arrays of React nodes should have a key prop.
Reviewed By: passy
Differential Revision: D16646487
fbshipit-source-id: b61841c001eb4a93f0a071557b921ca7365e2ac3
2019-08-05 09:39:06 -07:00
Pritesh Nandgaonkar
3ed71680a1
Remove the unwanted parantheses
...
Summary:
Bug:
{F173026649}
Reviewed By: danielbuechele
Differential Revision: D16583186
fbshipit-source-id: 277a81fbabf0c93d1a69b7f35dcb9d8d06ca4fce
2019-07-31 11:13:24 -07:00
Pritesh Nandgaonkar
8c9eb30060
Run export flipper trace in background
...
Summary: Adds the capability to run the export in the background along with the display of the status in the title bar.
Reviewed By: danielbuechele
Differential Revision: D16567026
fbshipit-source-id: 3955243cd7f094a7ee33eef3511804ff6e6476be
2019-07-31 10:44:26 -07:00
Daniel Büchele
2c7371d264
typescript eslint plugin
...
Summary: This is required to properly run eslint in Atom/VSCode on TypeScript files
Reviewed By: jknoxville
Differential Revision: D16201418
fbshipit-source-id: 31da04c2d313e9147e0f868c1af15bf3115e6d6a
2019-07-29 06:39:11 -07:00