Summary: This diff refactors the Select plugin sheet to have multi select and single select options. Also renamed the class names and variables, as its business logic is quite generic.
Reviewed By: jknoxville
Differential Revision: D18118359
fbshipit-source-id: 2f1a6840032b81c5fdd9af9f6e69ea2ff611bf13
Summary:
D17877108 inadvertently introduced a bug because `fs` and `fs-extra` behave differently and apparently wrapping `exists` which is already async in another `promisify` ends up raising the result as an exception (in this case throwing "true" or "false" as an error instead of yielding it back). Annoyingly, TypeScript's type system doesn't catch this. :/
This fixes the invocation and restores the install/remove functionality.
Reviewed By: jknoxville
Differential Revision: D18199958
fbshipit-source-id: f5835d8912bfe1191a12a318103bfc1fb7d776a3
Summary:
This PR introduces the possibility to group plugins in categories.
The category can be determined by setting the `category` field in `package.json`.
Categories are sorted alphabetically.
Categories are shown below all uncategorized items.
Within categories, items are sorted as before: by last recently usage.
Design wise, the category name might now look more prominent than the app name, this is to be addressed in a follow up PR.
Reviewed By: jknoxville
Differential Revision: D18169459
fbshipit-source-id: 77deb0f27a0462a0d449944ddc262396160687a2
Summary:
Some of the tests need to mock behavior of fb-internal dependencies.
These fb deps get swapped out with a babel transform and it's become hard to maintain now that we're mocking them as well.
For simplicity of mocking, moving them out of the public repo, they'll get run on PRs.
Reviewed By: priteshrnandgaonkar
Differential Revision: D18086247
fbshipit-source-id: 001e258e00da67a112cb754e851253e5480e578a
Summary:
It's already a promise. With the next upgrade this otherwise causes
some nasty type errors due to overloading.
Reviewed By: jknoxville
Differential Revision: D18059641
fbshipit-source-id: 93cee95d7bbf767ff6276a0946262bf83587c728
Summary: This diff fixes an issue where error messages that are to long pushed the buttons out of view, or the other rows too much down.
Reviewed By: passy
Differential Revision: D18083659
fbshipit-source-id: 54bdae682e6e756c9dad1a8cd247dd694ae0eef2
Summary:
When a toggled section is frozen, it already has a greyed out overlay over the whole thing.
So there's no need for another one covering the indented section.
Reviewed By: passy
Differential Revision: D18063767
fbshipit-source-id: a4d5992ecf61f036a23f619e9cf64d59150a41d6
Summary: Improved the display of error messages. Where previously only one error message could be displayed (quite obtrusively), with this change multiple errors can now be displayed and stack traces and further info can be hidden.
Reviewed By: passy
Differential Revision: D18036569
fbshipit-source-id: 2bc3dfa7a5196f931370a6e6dbf27c55b6cfb2bf
Summary: Allows users to override the GK status of prefetching. It is implemented as a Tri-State. "Unset" means that the local Flipper config won't take precedent over the GK setting and will leave it unchanged. If a user interacts with the setting, it gets persisted into the config and will from then-on override the GK, meaning that the user has an opt-in mechanism and if we open the GK to more people, they effectively have an opt-out.
Reviewed By: jknoxville
Differential Revision: D18008259
fbshipit-source-id: bdfde9a8b9acf43aa60c84800a7979a29a4e9364
Summary:
The config fields do some async validity checking and possibly update their own state after render. So their renders need to be wrapped in `act()` so that it includes their updates too.
This fixes those tests, and also adds mocking for valid and invalid file paths.
Reviewed By: passy
Differential Revision: D18036449
fbshipit-source-id: 7eec2992313c77e539da0c375966c7c65c30732d
Summary:
Centralizes the restart logic.
And adds ability for it to work in dev mode as well.
Reviewed By: passy
Differential Revision: D18008197
fbshipit-source-id: b76ac7935d5859dfdbb8cf593462f8ac02348181
Summary:
Planning to add some FB-only modules to it and is the easiest
way to prevent it from breaking in OSS.
Following commit is also already quite large and this makes it a little more manageable.
Reviewed By: priteshrnandgaonkar
Differential Revision: D18009280
fbshipit-source-id: 73f2488c352547b3e489272960efa4d6e017f294
Summary: This diff shows the support form option for the deeplink users too even if they are not part of GK. As I discovered a bug where the user opened the Flipper app thru deeplink and then the screen showed temporarily till the device connected and then the default plugin was displayed. In this case there is no way to navigate back to the form.
Reviewed By: jknoxville
Differential Revision: D17978648
fbshipit-source-id: 23ae3660e499a959733753b49cc987f2e381bf6b
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/592
Finally we can join the 21st century and use `jest.mock` in tests!
I'm enabling the ts-jest transform to `*/__tests__/*.tsx` files. This takes care of transforming the typescript, and preserves jest mock capabilities.
I have left the existing custom transform on all other files, so they will continue to work as usual.
Caveats:
* Our existing custom transforms will no longer be applied in tests.
* With our current suite this makes no difference. But bear in mind things like importing directly from 'flipper' instead of the actual files, won't work. However, I don't see this being a problem, as I think they'll only be needed inside the actual product code.
Reviewed By: passy
Differential Revision: D17978753
fbshipit-source-id: df7b312b5dd5592e4aa4f8df605f5952ea3158e9
Summary:
Instead of replacing the buttons, this shows an error next to
them and gives the opportunity to retry.
Reviewed By: jknoxville
Differential Revision: D17907389
fbshipit-source-id: 15b27802671b39c53b32d01f1d2bcf8c67fd2647
Summary:
Close https://github.com/facebook/flipper/pull/580
This enables Greenkeeper with some caveats:
- I disabled a bunch of upgrades we know currently break:
- React
- Emotion
- Electron/Electron-Builder
- The bot isn't CLA-whitelisted yet, so we won't be able to directly import yet.
- It might actually be better to have automatic tasks created for the dependencies above breaking.
- Something changed in the prop types and required `StatusBar` to have its signature changed.
allow-large-files
Reviewed By: jknoxville
Differential Revision: D17906693
fbshipit-source-id: f73fe231518f56a6f6114f761d5e5e5528d0d487
Summary: This diff adds the support to close the dialog automatically for the support form.
Reviewed By: passy
Differential Revision: D17899862
fbshipit-source-id: 9d9cd14556a4cebe60f8cc1d082be3e439998e9c
Summary: Not a fan of the long lines, but if that's where prettier is going, let's roll with it.
Reviewed By: jknoxville
Differential Revision: D17905599
fbshipit-source-id: c4232d46d2ec0b7c743f6afd8349106c85f013b9
Summary:
Noticed a bunch of failures [here](https://our.intern.facebook.com/intern/scuba/query/?dataset=flipper_session_event_stats_scuba&drillstate=%7B%22sampleCols%22%3A[%22errors%22%2C%22event%22]%2C%22cols%22%3A[]%2C%22derivedCols%22%3A[%7B%22name%22%3A%22perfect_session%22%2C%22sql%22%3A%22CAST_AS_DOUBLE(no_failures)%22%2C%22type%22%3A%22Numeric%22%7D]%2C%22mappedCols%22%3A[]%2C%22enumCols%22%3A[]%2C%22return_remainder%22%3Afalse%2C%22should_pivot%22%3Afalse%2C%22is_timeseries%22%3Atrue%2C%22hideEmptyColumns%22%3Afalse%2C%22start%22%3A%22-90%20days%22%2C%22samplingRatio%22%3A1%2C%22compare%22%3A%22comparison%22%2C%22axes%22%3A%22linked%22%2C%22bucket%22%3A%221%22%2C%22overlay_types%22%3A[]%2C%22minBucketSamples%22%3A%22%22%2C%22dimensions%22%3A[%22time%22%2C%22event%22]%2C%22scale_type%22%3A%22absolute%22%2C%22num_samples%22%3A%22100%22%2C%22metric%22%3A%22avg%22%2C%22fill_missing_buckets%22%3A%22connect%22%2C%22smoothing_bucket%22%3A%221%22%2C%22top%22%3A20%2C%22markers%22%3A%22%22%2C%22timezone%22%3A%22America%2FLos_Angeles%22%2C%22end%22%3A%22now%22%2C%22time_bucket%22%3A%22604800%22%2C%22compare_mode%22%3A%22normal%22%2C%22aggregateList%22%3A[]%2C%22param_dimensions%22%3A[]%2C%22modifiers%22%3A[]%2C%22order%22%3A%22none%22%2C%22order_desc%22%3Atrue%2C%22filterMode%22%3A%22DEFAULT%22%2C%22constraints%22%3A[[%7B%22column%22%3A%22plugin%22%2C%22op%22%3A%22eq%22%2C%22value%22%3A[%22[%5C%22null%5C%22]%22]%7D%2C%7B%22column%22%3A%22is_headless%22%2C%22op%22%3A%22!substr%22%2C%22value%22%3A[%22[%5C%22true%5C%22]%22]%7D%2C%7B%22column%22%3A%22event%22%2C%22op%22%3A%22substr%22%2C%22value%22%3A[%22[%5C%22getInstalledPlugins%5C%22]%22]%7D]]%2C%22c_constraints%22%3A[[]]%2C%22b_constraints%22%3A[[]]%2C%22metrik_view_params%22%3A%7B%22xaxis_type%22%3A%22auto%22%2C%22should_use_legacy_colors%22%3Afalse%2C%22view%22%3A%22Samples%22%2C%22width%22%3A%222126%22%2C%22height%22%3A%221132%22%2C%22y_max_hint%22%3A%221%22%2C%22yaxis_settings%22%3A[%7B%22yaxis_title%22%3A%22%22%2C%22yaxis_series_name%22%3A%22%22%2C%22yaxis_width%22%3A%220%22%2C%22yaxis_format%22%3A%22%25P%22%7D]%2C%22tooltip_outside%22%3Atrue%2C%22state%22%3A%22published%22%2C%22use_y_axis_hints_as_limits%22%3Atrue%2C%22legend_mode%22%3A%22nongrid%22%2C%22connect_nulls%22%3Atrue%2C%22yaxismin%22%3A0%2C%22title%22%3A%22Operation%20success%20rate%20over%20time%20(human)%22%2C%22tooltip_disabled%22%3Atrue%2C%22timezone_offset%22%3A420%2C%22y_min_hint%22%3A0%2C%22legend_position%22%3A%22none%22%2C%22title_use_v2%22%3Atrue%7D%7D&pool=uber&view=Samples&dashboard_id&tab_id&widget_id&widget_piece_id).
This fixes it.
Reviewed By: passy
Differential Revision: D17877108
fbshipit-source-id: 85586a1ce65033b98d793746c611b44f68e13eff
Summary: Take a snapshot with each field adjusted to prevent accidental changes.
Reviewed By: priteshrnandgaonkar
Differential Revision: D17832181
fbshipit-source-id: 016f99ec032036993a40fea310c6fd9887da6c38
Summary:
Adds an iOS "setting" to the settings, but it's automatically set based on xcode-select for minimum required effort.
Helpful text added to tell you how to enable it if it's disabled.
Reviewed By: passy
Differential Revision: D17830940
fbshipit-source-id: 53e1e40c5b96e29b30036259cc774ab14097a1da
Summary:
The UI could do with a bit more fine tuning, but it's a start.
Fully functional with updating the settings file. But nothing actually uses that setting yet.
Reviewed By: priteshrnandgaonkar
Differential Revision: D17810588
fbshipit-source-id: 791ee60616f3ee73f41813a5a442b08a5e395458
Summary:
This diff shows the error screen when one of the following condition is met:
- Selected device is not android
- No clients are active for selected device
- At least there is one client which supports inspector plugin.
For this I have added a SupportRequestManager class which loads the error screen or the litho form based on the above condition.
The UI is super basic. Will improve the design based on your feedback in the coming diffs.
Reviewed By: jknoxville
Differential Revision: D17790596
fbshipit-source-id: 2afc917c93c6e7321399633c5bf9d27a703742ee
Summary: Earlier we used to show the support form only when selected device was android. But this won't work because, I am planning to add a deeplink support for the form, so that the user can directly open flipper from workplace. Because of this we will have to show the litho support form always. In case when the selected device is not android, we will show an error screen with possible solutions to open the litho support form.
Reviewed By: passy
Differential Revision: D17787686
fbshipit-source-id: 13e15041238d8746f947563bb3c2ea3cec205a5e
Summary:
- Made side-effecting elements injectable via props.
- Added default props so usage doesn't change.
- Added testing-library/react snapshot test that waits for test data to appear in the list.
One slightly annoying part here is that this now that we have an `autoHeight` prop which is only useful for testing it as it prevents a problem with a height-detection in the test runner. We could even change the default as it doesn't affect the display in prod, but this still feels slightly cleaner.
Reviewed By: jknoxville
Differential Revision: D17808510
fbshipit-source-id: 2ae70886c58282d5bdc98ba4215e8248e4c7f159
Summary:
Added some notes to T55169042.
Also limited the acceptable result types.
Reviewed By: jknoxville
Differential Revision: D17787130
fbshipit-source-id: 19cefdde5ab195080281e9f2e26f5a236dd59629
Summary:
This is a programming error, not something that users
should ever be exposed to. This logs an error instead
and just doesn't show anything.
The big benefit is that the component no longer
needs to deal with `file` potentially being undefined.
Reviewed By: jknoxville
Differential Revision: D17786913
fbshipit-source-id: 32a357381e64cd9237ad4a0112c346d7121634ef
Summary:
The benefits of having things nicely encapsulated.
Not super sophisticated, but better than nothing.
Reviewed By: jknoxville
Differential Revision: D17786832
fbshipit-source-id: 0b321e8a4e56188b0eab86515bd777ed3e3e8cb7
Summary: It's copied apart from the status message, so let's centralise it.
Reviewed By: jknoxville
Differential Revision: D17786691
fbshipit-source-id: d5f7a5dccf56b96a58a9c1fc61652d7f9d1786d3
Summary:
From the name it's not clear that this is actually a fork off the "Share File"
variant of this. I'm planning to bring the two together as they share most of
the code, but for now this makes it a bit clearer.
Reviewed By: jknoxville
Differential Revision: D17786570
fbshipit-source-id: 8def3301ee4f79741391dc7e0b6a33a5fd7aa2c3
Summary:
Following https://developer.apple.com/design/human-interface-guidelines/macos/buttons/push-buttons/,
the primary button should be highlighted and the affirmative action be to the right.
Clicked a few times on the wrong one myself.
Reviewed By: priteshrnandgaonkar
Differential Revision: D17762516
fbshipit-source-id: 6be35cfde26ca10142c2c98df30672c0f739c17e
Summary:
- Make sure it's "cancel" in all cases.
- Move cancel buttons to the left.
- Rename the callback to clarify purpose.
Reviewed By: jknoxville
Differential Revision: D17762466
fbshipit-source-id: 0f6a9d83ff0cab139f926fb5a512be4618471ee8
Summary:
Wanted to make a small change and found it a bit difficult to
follow, so I tried to make it a bit more TypeScript-y.
Logic should be unchanged.
Reviewed By: priteshrnandgaonkar
Differential Revision: D17762346
fbshipit-source-id: d0d8b2e25b532b7b10079907d6da86bdd878a75c
Summary: It's a bit nicer to be able to see if there are any changes made, and save restarting flipper when nothing has changed.
Reviewed By: passy
Differential Revision: D17738036
fbshipit-source-id: 3d7cdc5be1bf948094c3df54439625e5052a9a2f
Summary:
Gets flipper to restart when settings are updated.
In theory most settings should not need this, but the current only one does (android home) because the path is set at startup only, and this modifies the input to it.
It would be a bit awkward to modify the path more than once, but doable.
Reviewed By: passy
Differential Revision: D17737582
fbshipit-source-id: d4669dcc7acc95469f15783fc6a5ba6794750234
Summary: A settings screen has been added where android home can be set. This changes the downstream code to use this value rather than the `env.PATH` variable.
Reviewed By: passy
Differential Revision: D17713288
fbshipit-source-id: 51551652c9c2f468e1117c18785123348e4b4576
Summary:
Moves the settings state from electron local storage into a json file in the users configured config location.
Unless modified by the user, this will usually be `~/.config/flipper/settings.json`
Settings will now persist across re-installs, and can now be easily inspected and backed up.
Reviewed By: passy
Differential Revision: D17712687
fbshipit-source-id: 1e778063e41d0a1a86145817b9797bf0458121da
Summary:
Adds a simple UI for editing settings, a reducer and persistance config for the data.
These values aren't yet used for anything.
Reviewed By: passy
Differential Revision: D17684490
fbshipit-source-id: e76ac43ffa17d3606e59f4a1ccb940e8d9fbd9e8
Summary:
Adds some very basic error handling. It's not great
because once you hit an error, you're basically stuck
and there's no retry yet, but it's still strictly
an improvement over being stuck with the looping
spinner, so I think it's worth shipping it in this state.
Reviewed By: jknoxville
Differential Revision: D17763467
fbshipit-source-id: b5b7996554dd1dce682fba87f96e3806432a475a
Summary:
Add some usage and failure rate stats to the PluginInstaller. Small
typo fix and added a helper to the metrics utils to make simple
usage tracking a little more intuitive.
Reviewed By: jknoxville
Differential Revision: D17760511
fbshipit-source-id: 957031d428f3124435925415619b1555a0c2dc2a
Summary:
These are the only four errors currently happening when upgrading to the 3.7 beta.
Luckily, these are all forwards-compatible changes.
Reviewed By: jknoxville
Differential Revision: D17711797
fbshipit-source-id: 429036e90300c81848cc3252b67bb89871ff2e32
Summary:
This diff adds a status bar, which can be used to show the status messages, for example for Litho Support Form.
The logic for the status bar is as follows:
It maintains the array of the messages. At any point it shows the last pushed message. It will keep showing that message until it is being removed, once removed it will show second last message. The messages will be removed as and when its corresponding task/Promise is fulfilled.
Reviewed By: danielbuechele
Differential Revision: D17551495
fbshipit-source-id: 96b2f401599b9ee8a472607e6a2f027e63b3b807
