Summary: Adds telemetry for the export time and also logs the selected plugins.
Reviewed By: jknoxville
Differential Revision: D18244843
fbshipit-source-id: 36a3e8b9b456b59187918d19075a2c1ea0caef25
Summary:
**Highlights**
- Sample Android APK now available as download on this very release page.
- Memory usage viewer available for KaiOS devices.
Full changelog: https://github.com/facebook/flipper/compare/v0.26.0...master
Reviewed By: jknoxville
Differential Revision: D18245037
fbshipit-source-id: 0d49012c1ebd11b406a2bf81e5b41e823ced0c05
Summary:
Uses a slightly modified version of the deep expansion. In testing, there were a few issues due to the function in Inspector::onElementExpanded is essentially a toggle. I added an optional parameter to override this toggle behavior for child elements, and also flipped the order of root and child actions during collapsing, as the child state otherwise didn't persist properly (due to the component being unmounted, would be my guess?) This change should be non-breaking to other uses of the method that don't use the `deep: true` parameter
close https://github.com/facebook/flipper/issues/223
Reviewed By: passy
Differential Revision: D18225057
fbshipit-source-id: 53e840f07bf648249b5a4b36d115918dba215ff8
Summary:
Now on every new release, a sample app will be built and added to the Github release artifacts.
Adds a Github action to automatically build and attach the android sample app for every flipper release.
This will allow potential users to try out flipper without having to go to the trouble of building their own app.
Pull Request resolved: https://github.com/facebook/flipper/pull/615
Test Plan:
Tested on my private repo:
https://github.com/jknoxville/flipper/releases/tag/v0.1.john
Reviewed By: passy
Differential Revision: D18224747
Pulled By: jknoxville
fbshipit-source-id: 25d2905bd7539faa91974b23a33678168aef29d8
Summary:
This didn't look quite right to me, "Download Mac", "Linux", "Windows".
Changed it to a separate "Download for", with "Mac", "Linux" and "Windows" buttons.
Reviewed By: passy
Differential Revision: D18225271
fbshipit-source-id: d644570d072029fc792cd9d9c18d8616ada0017b
Summary: If the `crash.reason` assumes the default value of "Cannot figure out the cause", we don't show a notification in the hub. The crash is still visible in the Crash plugin, but the superfluous Reason row is hidden there, as we can't say anything useful there anyways
Reviewed By: passy
Differential Revision: D18223910
fbshipit-source-id: c033085badbf633b58f95c495c6d3a22bc7fb163
Summary:
Moves the Fresco plugin to TypeScript, including fixing any typing/nullable warnings following this.
Note that parameters of event handlers previously using the SyntheticInputEvent flow type now accept a parameter of type `any`. This is done since the InputEvent api is not covered by ts bindings, as the interface is deemed experimental and not fully covered by browsers (see https://fettblog.eu/typescript-react/events/#wheres-inputevent for more info)
Reviewed By: passy
Differential Revision: D18201893
fbshipit-source-id: 41d1e5fc1ceaa8f8453c0f5929e754b7c32c0eb8
Summary: Minimal change to be able to filter crashes in the notifications tab, to filter out recurring/irrelevant crashes such as the one in https://github.com/facebook/flipper/issues/609
Reviewed By: passy
Differential Revision: D18223356
fbshipit-source-id: 8cf2187d53c9fec98c9a35edefb0da5783fe7c8e
Summary: This diff calls JSON.stringify on the final export object instead of the custom serializer. As the custom serializer is slower, because it has to check for different types on its children before serializing it. Which adds to the complexity. The time gain which we get is 3x, that is with this change the export is 3 times faster. We required custom serializer, because the logs had `Date` which is not serializable. So that is being taken care while importing it.
Reviewed By: jknoxville
Differential Revision: D18171202
fbshipit-source-id: cd1b59b74dabb4c35a032dc7b54f183a68e37823
Summary: Before this diff whenever one called serialize method it showed `Serializing Flipper ` msg without showing the explicit details of which data we are serializing. Thus with this diff one can pass the status msg as an argument which will be displayed while serializing.
Reviewed By: jknoxville
Differential Revision: D18173024
fbshipit-source-id: a4e7e073498993626204061d4e774099f00b8c5a
Summary: This diff refactors the Select plugin sheet to have multi select and single select options. Also renamed the class names and variables, as its business logic is quite generic.
Reviewed By: jknoxville
Differential Revision: D18118359
fbshipit-source-id: 2f1a6840032b81c5fdd9af9f6e69ea2ff611bf13
Summary:
D18169584 introduced state error which I didn't notice. This diff reverted the diff.
`hg backout D18169584`
Original commit changeset: 77a8b034c5e4
Reviewed By: jknoxville
Differential Revision: D18203354
fbshipit-source-id: 3e281f1e8c7e1d2bf41665adfa5ce5f13daca3a1
Summary:
This was removed because it's implicitly required by the library now.
However, Buck doesn't pick this up by default and requires further
configuration. It's easiest just to declare this twice now.
Reviewed By: jknoxville
Differential Revision: D18202459
fbshipit-source-id: 48c6a91c2fca0d932950a81c092b78b90a24c27b
Summary:
D17877108 inadvertently introduced a bug because `fs` and `fs-extra` behave differently and apparently wrapping `exists` which is already async in another `promisify` ends up raising the result as an exception (in this case throwing "true" or "false" as an error instead of yielding it back). Annoyingly, TypeScript's type system doesn't catch this. :/
This fixes the invocation and restores the install/remove functionality.
Reviewed By: jknoxville
Differential Revision: D18199958
fbshipit-source-id: f5835d8912bfe1191a12a318103bfc1fb7d776a3
Summary: Update and include `react-redux` to Greenkeeper
Reviewed By: passy
Differential Revision: D18169584
fbshipit-source-id: 77a8b034c5e4a13a2ba6c82895e1aee9d852375e
Summary:
This PR introduces the possibility to group plugins in categories.
The category can be determined by setting the `category` field in `package.json`.
Categories are sorted alphabetically.
Categories are shown below all uncategorized items.
Within categories, items are sorted as before: by last recently usage.
Design wise, the category name might now look more prominent than the app name, this is to be addressed in a follow up PR.
Reviewed By: jknoxville
Differential Revision: D18169459
fbshipit-source-id: 77deb0f27a0462a0d449944ddc262396160687a2
Summary:
## The devDependency [flow-bin](https://github.com/flowtype/flow-bin) was updated from `0.110.0` to `0.110.1`.
This version is **not covered** by your **current version range**.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
---
**Publisher:** [gabelevi](https://www.npmjs.com/~gabelevi)
**License:** MIT
[Find out more about this release](https://github.com/flowtype/flow-bin).
---
<details>
<summary>FAQ and help</summary>
There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>
---
Your [Greenkeeper](https://greenkeeper.io) bot 🌴
Pull Request resolved: https://github.com/facebook/flipper/pull/602
Reviewed By: jknoxville
Differential Revision: D18169249
Pulled By: passy
fbshipit-source-id: bdffb1c439dbe3daf2120bf77027209080fb6213
Summary: FlipperState may be updated from multiple threads, so it needs synchronization. Note the comments in the diff about why we drop the lock before calling out to the update listener -- this can be changed if necessary in the future.
Reviewed By: jknoxville
Differential Revision: D18095471
fbshipit-source-id: 95d558394ae1a9b7583e5a61969e1eeda6448cff
Summary:
This diff fixes the broken UI of advertising bar when window size is too small
Bug:
{F219320329}
Reviewed By: jknoxville
Differential Revision: D18114230
fbshipit-source-id: fda321af761f9707077ded5d53a51e79f4cd26d6
Summary:
This plugin simply plots a graph of RAM usage per app (with some built-in apps are excluded).
Can be useful for debugging memory spikes.
{F218362880}
Reviewed By: jknoxville
Differential Revision: D18013073
fbshipit-source-id: 93e2f87280a734d1d05f4f5b600f7b81024bd348
Summary: This diff shows marketing bar for support feature when someone inspects the litho view. Once it is inspected it will shown for the rest of the time till the plugin is unmounted.
Reviewed By: jknoxville
Differential Revision: D18086347
fbshipit-source-id: cb906614f571e8ece2293b028f809d1aa5c211e5
Summary:
Some of the tests need to mock behavior of fb-internal dependencies.
These fb deps get swapped out with a babel transform and it's become hard to maintain now that we're mocking them as well.
For simplicity of mocking, moving them out of the public repo, they'll get run on PRs.
Reviewed By: priteshrnandgaonkar
Differential Revision: D18086247
fbshipit-source-id: 001e258e00da67a112cb754e851253e5480e578a
Summary:
## There have been updates to the *react* monorepo:
- The `dependency` [react](https://github.com/facebook/react) was updated from `16.10.2` to `16.11.0`.
- The `dependency` [react-dom](https://github.com/facebook/react) was updated from `16.10.2` to `16.11.0`.
- The `dependency` [react-test-renderer](https://github.com/facebook/react) was updated from `16.10.2` to `16.11.0`.
These versions are **not covered** by your **current version range**.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
This monorepo update includes releases of one or more dependencies which all belong to the [react group definition](https://github.com/greenkeeperio/monorepo-definitions).
---
**Publisher:** [acdlite](https://www.npmjs.com/~acdlite)
**License:** MIT
[Find out more about this release](https://github.com/facebook/react).
---
<details>
<summary>FAQ and help</summary>
There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>
---
Your [Greenkeeper](https://greenkeeper.io) bot 🌴
Pull Request resolved: https://github.com/facebook/flipper/pull/598
Reviewed By: jknoxville
Differential Revision: D18083376
Pulled By: passy
fbshipit-source-id: aeec94f1fa1c2d097b525824bf38b1db65f90401
Summary:
Another attempt of D17736468. This time all the breaking
deps should have been found and fixed by greenkeeper.
Reviewed By: jknoxville
Differential Revision: D18059567
fbshipit-source-id: c7f1225af6d7d2842f0a1488637f52651b341598
Summary:
It's already a promise. With the next upgrade this otherwise causes
some nasty type errors due to overloading.
Reviewed By: jknoxville
Differential Revision: D18059641
fbshipit-source-id: 93cee95d7bbf767ff6276a0946262bf83587c728
Summary: This diff fixes an issue where error messages that are to long pushed the buttons out of view, or the other rows too much down.
Reviewed By: passy
Differential Revision: D18083659
fbshipit-source-id: 54bdae682e6e756c9dad1a8cd247dd694ae0eef2
Summary:
It shouldn't make a difference which one we import because they're
both mocked but only one works in the GitHub export.
Pull Request resolved: https://github.com/facebook/flipper/pull/599
Test Plan: yarn test; CI
Reviewed By: jknoxville
Differential Revision: D18083321
Pulled By: passy
fbshipit-source-id: 6d04390b4403bf291c201d3c17902304ea9b1c6e
Summary:
## The devDependency [flow-bin](https://github.com/flowtype/flow-bin) was updated from `0.109.0` to `0.110.0`.
This version is **not covered** by your **current version range**.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
---
**Publisher:** [gabelevi](https://www.npmjs.com/~gabelevi)
**License:** MIT
[Find out more about this release](https://github.com/flowtype/flow-bin).
---
<details>
<summary>FAQ and help</summary>
There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>
---
Your [Greenkeeper](https://greenkeeper.io) bot 🌴
Pull Request resolved: https://github.com/facebook/flipper/pull/597
Reviewed By: jknoxville
Differential Revision: D18058618
Pulled By: passy
fbshipit-source-id: 725a80e04df811a7e2d6ed7161cf8a940002694c
Summary: To make (accidental) errors more visible to developers of Flipper, all uncaught and FBLogger logged errors will be shown in the UI and prefixed with `[DEV]`. This is only done in non-production builds
Reviewed By: jknoxville
Differential Revision: D18061174
fbshipit-source-id: 9dab0e8d34396b0cb421a4d4e6fc14c81447d190
Summary:
When a toggled section is frozen, it already has a greyed out overlay over the whole thing.
So there's no need for another one covering the indented section.
Reviewed By: passy
Differential Revision: D18063767
fbshipit-source-id: a4d5992ecf61f036a23f619e9cf64d59150a41d6
Summary: Added a slug a while ago and it looks a bit better when shown in the bugnub.
Reviewed By: cekkaewnumchai
Differential Revision: D18083274
fbshipit-source-id: 5a9c8c126b5dcee92a697096ac3393a93a1690c3
Summary: Following the existing installation instructions for VSCode, TypeScript code was not formatted or linted out of the box
Reviewed By: passy
Differential Revision: D18061117
fbshipit-source-id: bedb57de47f4e880449d859b0dce2dd18f5f2995
Summary: Improved the display of error messages. Where previously only one error message could be displayed (quite obtrusively), with this change multiple errors can now be displayed and stack traces and further info can be hidden.
Reviewed By: passy
Differential Revision: D18036569
fbshipit-source-id: 2bc3dfa7a5196f931370a6e6dbf27c55b6cfb2bf
Summary: This got broken during TS migration. Plugin failures were being logged as platform failures, and showing up in the wrong graphs.
Reviewed By: passy
Differential Revision: D18059046
fbshipit-source-id: 8209a0e852f62e221bf64cb5091115e3cac09fd9
Summary: This makes use of the previously set up new settings. The logic is a tiny bit difficult to follow so I wanted to make sure it's not lost in the noise of the previous diff.
Reviewed By: jknoxville
Differential Revision: D18036538
fbshipit-source-id: db3bbce4361862cee479aed70578a4bcbde2c46d
Summary: Allows users to override the GK status of prefetching. It is implemented as a Tri-State. "Unset" means that the local Flipper config won't take precedent over the GK setting and will leave it unchanged. If a user interacts with the setting, it gets persisted into the config and will from then-on override the GK, meaning that the user has an opt-in mechanism and if we open the GK to more people, they effectively have an opt-out.
Reviewed By: jknoxville
Differential Revision: D18008259
fbshipit-source-id: bdfde9a8b9acf43aa60c84800a7979a29a4e9364
Summary:
The config fields do some async validity checking and possibly update their own state after render. So their renders need to be wrapped in `act()` so that it includes their updates too.
This fixes those tests, and also adds mocking for valid and invalid file paths.
Reviewed By: passy
Differential Revision: D18036449
fbshipit-source-id: 7eec2992313c77e539da0c375966c7c65c30732d
Summary:
Centralizes the restart logic.
And adds ability for it to work in dev mode as well.
Reviewed By: passy
Differential Revision: D18008197
fbshipit-source-id: b76ac7935d5859dfdbb8cf593462f8ac02348181
