Summary:
## There have been updates to the *react* monorepo:
- The `dependency` [react](https://github.com/facebook/react) was updated from `16.10.2` to `16.11.0`.
- The `dependency` [react-dom](https://github.com/facebook/react) was updated from `16.10.2` to `16.11.0`.
- The `dependency` [react-test-renderer](https://github.com/facebook/react) was updated from `16.10.2` to `16.11.0`.
These versions are **not covered** by your **current version range**.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
This monorepo update includes releases of one or more dependencies which all belong to the [react group definition](https://github.com/greenkeeperio/monorepo-definitions).
---
**Publisher:** [acdlite](https://www.npmjs.com/~acdlite)
**License:** MIT
[Find out more about this release](https://github.com/facebook/react).
---
<details>
<summary>FAQ and help</summary>
There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>
---
Your [Greenkeeper](https://greenkeeper.io) bot 🌴
Pull Request resolved: https://github.com/facebook/flipper/pull/598
Reviewed By: jknoxville
Differential Revision: D18083376
Pulled By: passy
fbshipit-source-id: aeec94f1fa1c2d097b525824bf38b1db65f90401
Summary:
Another attempt of D17736468. This time all the breaking
deps should have been found and fixed by greenkeeper.
Reviewed By: jknoxville
Differential Revision: D18059567
fbshipit-source-id: c7f1225af6d7d2842f0a1488637f52651b341598
Summary:
It's already a promise. With the next upgrade this otherwise causes
some nasty type errors due to overloading.
Reviewed By: jknoxville
Differential Revision: D18059641
fbshipit-source-id: 93cee95d7bbf767ff6276a0946262bf83587c728
Summary: This diff fixes an issue where error messages that are to long pushed the buttons out of view, or the other rows too much down.
Reviewed By: passy
Differential Revision: D18083659
fbshipit-source-id: 54bdae682e6e756c9dad1a8cd247dd694ae0eef2
Summary:
It shouldn't make a difference which one we import because they're
both mocked but only one works in the GitHub export.
Pull Request resolved: https://github.com/facebook/flipper/pull/599
Test Plan: yarn test; CI
Reviewed By: jknoxville
Differential Revision: D18083321
Pulled By: passy
fbshipit-source-id: 6d04390b4403bf291c201d3c17902304ea9b1c6e
Summary:
## The devDependency [flow-bin](https://github.com/flowtype/flow-bin) was updated from `0.109.0` to `0.110.0`.
This version is **not covered** by your **current version range**.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
---
**Publisher:** [gabelevi](https://www.npmjs.com/~gabelevi)
**License:** MIT
[Find out more about this release](https://github.com/flowtype/flow-bin).
---
<details>
<summary>FAQ and help</summary>
There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>
---
Your [Greenkeeper](https://greenkeeper.io) bot 🌴
Pull Request resolved: https://github.com/facebook/flipper/pull/597
Reviewed By: jknoxville
Differential Revision: D18058618
Pulled By: passy
fbshipit-source-id: 725a80e04df811a7e2d6ed7161cf8a940002694c
Summary: To make (accidental) errors more visible to developers of Flipper, all uncaught and FBLogger logged errors will be shown in the UI and prefixed with `[DEV]`. This is only done in non-production builds
Reviewed By: jknoxville
Differential Revision: D18061174
fbshipit-source-id: 9dab0e8d34396b0cb421a4d4e6fc14c81447d190
Summary:
When a toggled section is frozen, it already has a greyed out overlay over the whole thing.
So there's no need for another one covering the indented section.
Reviewed By: passy
Differential Revision: D18063767
fbshipit-source-id: a4d5992ecf61f036a23f619e9cf64d59150a41d6
Summary: Added a slug a while ago and it looks a bit better when shown in the bugnub.
Reviewed By: cekkaewnumchai
Differential Revision: D18083274
fbshipit-source-id: 5a9c8c126b5dcee92a697096ac3393a93a1690c3
Summary: Following the existing installation instructions for VSCode, TypeScript code was not formatted or linted out of the box
Reviewed By: passy
Differential Revision: D18061117
fbshipit-source-id: bedb57de47f4e880449d859b0dce2dd18f5f2995
Summary: Improved the display of error messages. Where previously only one error message could be displayed (quite obtrusively), with this change multiple errors can now be displayed and stack traces and further info can be hidden.
Reviewed By: passy
Differential Revision: D18036569
fbshipit-source-id: 2bc3dfa7a5196f931370a6e6dbf27c55b6cfb2bf
Summary: This got broken during TS migration. Plugin failures were being logged as platform failures, and showing up in the wrong graphs.
Reviewed By: passy
Differential Revision: D18059046
fbshipit-source-id: 8209a0e852f62e221bf64cb5091115e3cac09fd9
Summary: This makes use of the previously set up new settings. The logic is a tiny bit difficult to follow so I wanted to make sure it's not lost in the noise of the previous diff.
Reviewed By: jknoxville
Differential Revision: D18036538
fbshipit-source-id: db3bbce4361862cee479aed70578a4bcbde2c46d
Summary: Allows users to override the GK status of prefetching. It is implemented as a Tri-State. "Unset" means that the local Flipper config won't take precedent over the GK setting and will leave it unchanged. If a user interacts with the setting, it gets persisted into the config and will from then-on override the GK, meaning that the user has an opt-in mechanism and if we open the GK to more people, they effectively have an opt-out.
Reviewed By: jknoxville
Differential Revision: D18008259
fbshipit-source-id: bdfde9a8b9acf43aa60c84800a7979a29a4e9364
Summary:
The config fields do some async validity checking and possibly update their own state after render. So their renders need to be wrapped in `act()` so that it includes their updates too.
This fixes those tests, and also adds mocking for valid and invalid file paths.
Reviewed By: passy
Differential Revision: D18036449
fbshipit-source-id: 7eec2992313c77e539da0c375966c7c65c30732d
Summary:
Centralizes the restart logic.
And adds ability for it to work in dev mode as well.
Reviewed By: passy
Differential Revision: D18008197
fbshipit-source-id: b76ac7935d5859dfdbb8cf593462f8ac02348181
Summary:
## The dependency [ws](https://github.com/websockets/ws) was updated from `7.1.2` to `7.2.0`.
This version is **not covered** by your **current version range**.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
---
**Publisher:** [lpinca](https://www.npmjs.com/~lpinca)
**License:** MIT
[Find out more about this release](https://github.com/websockets/ws).
---
<details>
<summary>FAQ and help</summary>
There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>
---
Your [Greenkeeper](https://greenkeeper.io) bot 🌴
Pull Request resolved: https://github.com/facebook/flipper/pull/595
Reviewed By: jknoxville
Differential Revision: D18036025
Pulled By: passy
fbshipit-source-id: fc897470cbd05fb6605a7816fc8bd72476192957
Summary:
## The devDependency [uglify-js](https://github.com/mishoo/UglifyJS2) was updated from `3.6.2` to `3.6.3`.
This version is **not covered** by your **current version range**.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
---
**Publisher:** [alexlamsl](https://www.npmjs.com/~alexlamsl)
**License:** BSD-2-Clause
<details>
<summary>Release Notes for v3.6.3</summary>
<p> </p>
</details>
<details>
<summary>Commits</summary>
<p>The new version differs by 18 commits.</p>
<ul>
<li><a href="6b4886c908"><code>6b4886c</code></a> <code>v3.6.3</code></li>
<li><a href="0201cb4b52"><code>0201cb4</code></a> <code>fix corner case in <code>unused</code> (#3499)</code></li>
<li><a href="cd072317d0"><code>cd07231</code></a> <code>fix corner case in <code>unused</code> (#3496)</code></li>
<li><a href="0785a15ace"><code>0785a15</code></a> <code>fix corner case in <code>dead_code</code> & <code>ie8</code> (#3494)</code></li>
<li><a href="b1279a46d9"><code>b1279a4</code></a> <code>fix corner case in <code>sequences</code> (#3491)</code></li>
<li><a href="b571619d31"><code>b571619</code></a> <code>handle <code>throw</code> of non-<code>Error</code>s gracefully (#3492)</code></li>
<li><a href="7b5350b459"><code>7b5350b</code></a> <code>tweak Travis CI execution environment (#3489)</code></li>
<li><a href="1549db70e6"><code>1549db7</code></a> <code>fix corner case in <code>ie8</code> (#3487)</code></li>
<li><a href="8ff9a3c8fb"><code>8ff9a3c</code></a> <code>fix corner cases in <code>ie8</code> (#3485)</code></li>
<li><a href="91cae51d8f"><code>91cae51</code></a> <code>fix corner case in <code>evaluate</code> & <code>ie8</code> (#3483)</code></li>
<li><a href="8af2f5fbcf"><code>8af2f5f</code></a> <code>fix corner case in <code>rename</code> (#3481)</code></li>
<li><a href="86a8016323"><code>86a8016</code></a> <code>fix corner case in <code>ie8</code> & <code>mangle</code> (#3479)</code></li>
<li><a href="009dcdae01"><code>009dcda</code></a> <code>avoid mangling of <code>MutationObserver</code> properties (#3477)</code></li>
<li><a href="f86f615d83"><code>f86f615</code></a> <code>fix corner case in <code>ie8</code> & <code>mangle</code> (#3476)</code></li>
<li><a href="d3d1d11926"><code>d3d1d11</code></a> <code>fix corner case in <code>ie8</code> & <code>rename</code> (#3474)</code></li>
</ul>
<p>There are 18 commits in total.</p>
<p>See the <a href="c3ca293e6b...6b4886c908">full diff</a></p>
</details>
---
<details>
<summary>FAQ and help</summary>
There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>
---
Your [Greenkeeper](https://greenkeeper.io) bot 🌴
Pull Request resolved: https://github.com/facebook/flipper/pull/594
Reviewed By: jknoxville
Differential Revision: D18035631
Pulled By: passy
fbshipit-source-id: 0de12654bd434ccf29e67907febeb1aca85558c9
Summary:
Planning to add some FB-only modules to it and is the easiest
way to prevent it from breaking in OSS.
Following commit is also already quite large and this makes it a little more manageable.
Reviewed By: priteshrnandgaonkar
Differential Revision: D18009280
fbshipit-source-id: 73f2488c352547b3e489272960efa4d6e017f294
Summary:
## The dependency [ws](https://github.com/websockets/ws) was updated from `7.1.2` to `7.2.0`.
This version is **not covered** by your **current version range**.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
---
**Publisher:** [lpinca](https://www.npmjs.com/~lpinca)
**License:** MIT
[Find out more about this release](https://github.com/websockets/ws).
---
<details>
<summary>FAQ and help</summary>
There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>
---
Your [Greenkeeper](https://greenkeeper.io) bot 🌴
Pull Request resolved: https://github.com/facebook/flipper/pull/596
Differential Revision: D18032150
Pulled By: passy
fbshipit-source-id: 44f6156cecb879f523dbe93d22f8b65dbe13646a
Summary:
Headless flipper is getting an infinite recursion problem after the console proxy was changed to an in-place method swap.
This uses an in-place method swap in headless too, so they don't conflict with each other.
Reviewed By: passy, priteshrnandgaonkar
Differential Revision: D18007638
fbshipit-source-id: 62dce7fa94f4ce6b90da4f3c6ec6e8d9ed15fbe7
Summary:
Replacing our custom electron-stubs transform with a mocked module.
This will now be the default impl for tests, and we can override it by mocking as needed.
Reviewed By: passy
Differential Revision: D17979659
fbshipit-source-id: a26994158d439fa7dc1ca38225294106fc4e1559
Summary:
**Highlights**
- New settings panel for configuring Android SDK paths and iOS support.
- Support for taking screenshots and recording videos on Windows.
- Copying an element name in the layout inspector now copies the attributes instead of just a numeric identifier.
Full changelog at https://github.com/facebook/flipper/compare/v0.25.0...v0.26.0
Reviewed By: jknoxville
Differential Revision: D18007369
fbshipit-source-id: ad4069da59f5b2b96090a14c17d57d37a0ca64be
Summary: This diff shows the support form option for the deeplink users too even if they are not part of GK. As I discovered a bug where the user opened the Flipper app thru deeplink and then the screen showed temporarily till the device connected and then the default plugin was displayed. In this case there is no way to navigate back to the form.
Reviewed By: jknoxville
Differential Revision: D17978648
fbshipit-source-id: 23ae3660e499a959733753b49cc987f2e381bf6b
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/592
Finally we can join the 21st century and use `jest.mock` in tests!
I'm enabling the ts-jest transform to `*/__tests__/*.tsx` files. This takes care of transforming the typescript, and preserves jest mock capabilities.
I have left the existing custom transform on all other files, so they will continue to work as usual.
Caveats:
* Our existing custom transforms will no longer be applied in tests.
* With our current suite this makes no difference. But bear in mind things like importing directly from 'flipper' instead of the actual files, won't work. However, I don't see this being a problem, as I think they'll only be needed inside the actual product code.
Reviewed By: passy
Differential Revision: D17978753
fbshipit-source-id: df7b312b5dd5592e4aa4f8df605f5952ea3158e9
Summary:
If we move the permissions into the library itself, the manifest
merger will take care of adding them to consuming applications,
making setup instructions easier.
## Changelog
Move required permission declarations into flipper-core
Pull Request resolved: https://github.com/facebook/flipper/pull/593
Test Plan:
Using aapt we can dump the permissions of a sample app.
`$ANDROID_HOME/build-tools/29.0.2/aapt d permissions sample-debug.apk `
```
package: com.facebook.flipper.sample
uses-permission: name='android.permission.WRITE_EXTERNAL_STORAGE'
uses-permission: name='android.permission.INTERNET'
uses-permission: name='android.permission.ACCESS_WIFI_STATE'
uses-permission: name='android.permission.READ_EXTERNAL_STORAGE'
uses-permission: name='android.permission.FOREGROUND_SERVICE
```
Reviewed By: priteshrnandgaonkar
Differential Revision: D18006323
Pulled By: passy
fbshipit-source-id: c4cf28ee698faa3e2b631462f2953976135b299c
Summary: Defines custom protocol in the package json. This adds the custom protocol definition in the Info.plist file.
Reviewed By: passy
Differential Revision: D17983382
fbshipit-source-id: 48d74e676e07ba9cf8c7baaac27d8f74042336a1
Summary:
Base64 encoding can easily cause OOMs for large payloads.
In the long-term, it would be great to have a way of streaming these
responses so we don't allocate 50MB chunks of memory at once.
Reviewed By: jknoxville
Differential Revision: D17951353
fbshipit-source-id: a5d7b8242892518590ac95c1d9751f24d20dc40e
Summary:
Let’s get started with automated dependency management for flipper 💪🔒 Greenkeeper has found a `yarn.lock` file in this repository. Greenkeeper supports lockfile updates for public packages. If you use private packages in your repository, please use [greenkeeper-lockfile](https://github.com/greenkeeperio/greenkeeper-lockfile) to make sure these can get updated as well.
This pull request **updates all your dependencies to their latest version**. Having them all up to date really is the best starting point for keeping up with new releases. Greenkeeper will look out for further dependency updates and make sure to handle them in isolation and in real-time, but only after **you merge this pull request**.
**Important: Greenkeeper will only start watching this repository’s dependency updates after you merge this initial pull request**.
📦📦 Greenkeeper has detected multiple `package.json` files. Since this repo already has a `greenkeeper.json` config file with defined groups, Greenkeeper has only checked whether they’re still valid.
---
<details>
<summary>🏷 How to check the status of this repository</summary>
Greenkeeper adds a badge to your README which indicates the status of this repository.
This is what your badge looks like right now 👉 
</details>
<details>
<summary>🙈 How to ignore certain dependencies</summary>
You may have good reasons for not wanting to update to a certain dependency right now. In this case, you can [change the dependency’s version string in the `package.json` file back to whatever you prefer](https://github.com/facebook/flipper/edit/greenkeeper/initial/package.json).
To make sure Greenkeeper doesn’t nag you again on the next update, add a `greenkeeper.ignore` field to your `package.json`, containing a list of dependencies you don’t want to update.
```js
// package.json
{
…
"greenkeeper": {
"ignore": [
"package-names",
"you-want-me-to-ignore"
]
}
}
```
</details>
<details>
<summary>👩💻 How to update this pull request</summary>
```bash
# Change into your repository’s directory
git fetch --all
git checkout greenkeeper/initial
npm install-test
# Adapt your code until everything works again
git commit -m 'chore: adapt code to updated dependencies'
git push https://github.com/facebook/flipper.git greenkeeper/initial
```
</details>
<details>
<summary>✨ How do dependency updates work with Greenkeeper?</summary>
After you merge this pull request, **Greenkeeper will create a new branch whenever a dependency is updated**, with the new version applied. The branch creation should trigger your testing services and check whether your code still works with the new dependency version. Depending on the the results of these tests Greenkeeper will try to open meaningful and helpful pull requests and issues, so your dependencies remain working and up-to-date.
```diff
- "underscore": "^1.6.0"
+ "underscore": "^1.7.0"
```
The above example shows an in-range update. `1.7.0` is included in the old `^1.6.0` range, because of the [caret `^` character ](https://docs.npmjs.com/misc/semver#ranges).
When the test services report success Greenkeeper will silently delete the branch again, because no action needs to be taken – everything is fine.
However, should the tests fail, Greenkeeper will create an issue to inform you about the problem immediately.
This way, you’ll never be surprised by a dependency breaking your code. As long as everything still works, Greenkeeper will stay out of your way, and as soon as something goes wrong, you’ll be the first to know.
```diff
- "lodash": "^3.0.0"
+ "lodash": "^4.0.0"
```
In this example, the new version `4.0.0` is _not_ included in the old `^3.0.0` range.
For version updates like these – let’s call them “out of range” updates – you’ll receive a pull request.
This means that **you no longer need to check for new versions manually** – Greenkeeper will keep you up to date automatically.
These pull requests not only serve as reminders to update: If you have solid tests and good coverage, and the pull requests passes those tests, you can very likely just merge it and release a new version of your software straight away :shipit:
To get a better idea of which ranges apply to which releases, check out the extremely useful [semver calculator](https://semver.npmjs.com/) provided by npm.
</details>
<details>
<summary>FAQ and help</summary>
There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>
---
Good luck with your project and see you soon ✨
Your [Greenkeeper](https://greenkeeper.io) bot 🌴
Pull Request resolved: https://github.com/facebook/flipper/pull/591
Reviewed By: jknoxville
Differential Revision: D17951583
Pulled By: passy
fbshipit-source-id: 6ad2bfe7d4a9f7ed4920e50af36e194dc5b1cb93
Summary:
Last one blocking Greenkeeper.
Only change affecting us appears to be where to import from.
Reviewed By: jknoxville
Differential Revision: D17932089
fbshipit-source-id: b913defdabd99721886557d7c92afb8181ca1803
Summary:
We were losing the first argument of every console.error call during tests.
This happens to be useful stuff, like react telling you how to do better testing etc, and explains the weird looking error output from the ConfigField tests.
Reviewed By: passy
Differential Revision: D17931532
fbshipit-source-id: cfeb834a4646ef68ac55f81a269bcfef7a25ea31
Summary:
Newer rsocket packages are borked; don't have a `main` attribute anymore.
Need to be looked into separately. This is to unblock greenkeeper activation.
Based on https://github.com/facebook/flipper/pull/587/files
Reviewed By: jknoxville
Differential Revision: D17928918
fbshipit-source-id: 3ec38c5740f115883e8534776a96d8a8d6ea6b1e
Summary: This diff adds the telemetry to track the source of the support form being launched.
Reviewed By: passy
Differential Revision: D17908752
fbshipit-source-id: 275812992884a471844fda40d1f636815a4a2346
Summary:
The previous one was a bit outdated. It's only used in low-res
environments otherwise where that's fine, but let's a more recent
one for the README header.
Pull Request resolved: https://github.com/facebook/flipper/pull/585
Test Plan: eyes
Reviewed By: jknoxville
Differential Revision: D17908742
Pulled By: passy
fbshipit-source-id: 81e3ccf9e1b94bd57d162dd59b0a4dfb8e4366ea
Summary:
Instead of replacing the buttons, this shows an error next to
them and gives the opportunity to retry.
Reviewed By: jknoxville
Differential Revision: D17907389
fbshipit-source-id: 15b27802671b39c53b32d01f1d2bcf8c67fd2647
Summary:
Close https://github.com/facebook/flipper/pull/580
This enables Greenkeeper with some caveats:
- I disabled a bunch of upgrades we know currently break:
- React
- Emotion
- Electron/Electron-Builder
- The bot isn't CLA-whitelisted yet, so we won't be able to directly import yet.
- It might actually be better to have automatic tasks created for the dependencies above breaking.
- Something changed in the prop types and required `StatusBar` to have its signature changed.
allow-large-files
Reviewed By: jknoxville
Differential Revision: D17906693
fbshipit-source-id: f73fe231518f56a6f6114f761d5e5e5528d0d487
Summary:
This should just work, but let's see what CI says.
Pull Request resolved: https://github.com/facebook/flipper/pull/583
Reviewed By: jknoxville
Differential Revision: D17906598
Pulled By: passy
fbshipit-source-id: 5de686c8c9b23b101999da938d6e8f9baff7bc86
Summary: We still use it in some places. Up to 109 before we get kicked off Sandcastle.
Reviewed By: jknoxville
Differential Revision: D17906687
fbshipit-source-id: 391e29add37b6cf5c5dbb9dd9c0743e130cc4381
Summary: This diff adds the support to close the dialog automatically for the support form.
Reviewed By: passy
Differential Revision: D17899862
fbshipit-source-id: 9d9cd14556a4cebe60f8cc1d082be3e439998e9c
Summary: A significant proportion of CPU time when doing a target selection in the layout plugin, was spent rendering Glyphs. They shouldn't really be doing anything expensive in render, but since they already are, this will make sure they don't re-render unnecessarily.
Reviewed By: passy
Differential Revision: D17906723
fbshipit-source-id: ece143f65fd46d8582e21455732049368f301186
Summary: Not a fan of the long lines, but if that's where prettier is going, let's roll with it.
Reviewed By: jknoxville
Differential Revision: D17905599
fbshipit-source-id: c4232d46d2ec0b7c743f6afd8349106c85f013b9
