Commit Graph

5686 Commits

Author SHA1 Message Date
Pascal Hartig
f515df1c01 Restructure iOS dispatcher initialization
Summary:
Avoid nested promises and log errors during initialization that were
previously thrown away.

Reviewed By: mweststrate

Differential Revision: D30247859

fbshipit-source-id: 1d9ef871d1861a25a64ed4e895978b04f5b51c7b
2021-08-11 11:03:45 -07:00
dependabot[bot]
cf3ab869f8 Bump path-parse from 1.0.6 to 1.0.7 in /react-native/react-native-flipper (#2679)
Summary:
Bumps [path-parse](https://github.com/jbgutierrez/path-parse) from 1.0.6 to 1.0.7.
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a href="https://github.com/jbgutierrez/path-parse/commits/v1.0.7">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=path-parse&package-manager=npm_and_yarn&previous-version=1.0.6&new-version=1.0.7)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/facebook/flipper/network/alerts).

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/2679

Reviewed By: mweststrate

Differential Revision: D30246993

Pulled By: passy

fbshipit-source-id: 792799ef00a875d0e246f89df5e3d02d7f526197
2021-08-11 11:03:45 -07:00
dependabot[bot]
4ca1227522 Bump path-parse from 1.0.6 to 1.0.7 in /desktop (#2681)
Summary:
Bumps [path-parse](https://github.com/jbgutierrez/path-parse) from 1.0.6 to 1.0.7.
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a href="https://github.com/jbgutierrez/path-parse/commits/v1.0.7">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=path-parse&package-manager=npm_and_yarn&previous-version=1.0.6&new-version=1.0.7)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/facebook/flipper/network/alerts).

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/2681

Reviewed By: mweststrate

Differential Revision: D30246996

Pulled By: passy

fbshipit-source-id: 00e1e3a0a6530e4ac7dbc198a7a4b80ded11c054
2021-08-11 11:03:45 -07:00
Pascal Hartig
a630020ea0 Remove promisify use
Summary:
The results are often unpredictable, poorly typed and we have
dependencies that do the wrapping for us.

Listen, I'll get to writing some real code soon, I promise,
but I need to clean up my workspace first, okay?

Reviewed By: mweststrate

Differential Revision: D30247484

fbshipit-source-id: f5326ff71ff43af2dc64ab85ca1368f95fe87083
2021-08-11 11:03:45 -07:00
Pascal Hartig
4e17fb9c48 Extract temp path util
Summary:
`electron.remote` access is slow so we can cache this
like we do in other places. Also means one fewer `electron`
import which is gonna add up for Flipper Decap.

Reviewed By: mweststrate

Differential Revision: D30247431

fbshipit-source-id: 90f0e8df99af8bed40fbebcfd445abaca2965b7c
2021-08-11 11:03:45 -07:00
Pascal Hartig
11c1c39bdc Improve screen recording logging
Summary:
Error is handled, doesn't need a task. Also, prefix is wrong here
as it's used.

Reviewed By: mweststrate

Differential Revision: D30247416

fbshipit-source-id: 049490cb7e45b7ce6f433bf7366eb94893947625
2021-08-11 11:03:45 -07:00
Pascal Hartig
8223051905 Mute eslint rule
Summary:
A few drive-by changes ahead of the sustainathon.
(More to come.)

Reviewed By: mweststrate

Differential Revision: D30247395

fbshipit-source-id: e707377a1169eb634a42f08c3d27fe3e065b63bb
2021-08-11 11:03:45 -07:00
dependabot[bot]
bc4a998ac2 Bump jszip from 3.3.0 to 3.7.1 in /desktop (#2680)
Summary:
Bumps [jszip](https://github.com/Stuk/jszip) from 3.3.0 to 3.7.1.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/Stuk/jszip/blob/master/CHANGES.md">jszip's changelog</a>.</em></p>
<blockquote>
<h3>v3.7.1 2021-08-05</h3>
<ul>
<li>Fix build of <code>dist</code> files.
<ul>
<li>Note: this version ensures the changes from 3.7.0 are actually included in the <code>dist</code> files. Thanks to Evan W for reporting.</li>
</ul>
</li>
</ul>
<h3>v3.7.0 2021-07-23</h3>
<ul>
<li>Fix: Use a null prototype object for this.files  (see <a href="https://github-redirect.dependabot.com/Stuk/jszip/pull/766">https://github.com/facebook/flipper/issues/766</a>)
<ul>
<li>This change might break existing code if it uses prototype methods on the <code>.files</code> property of a zip object, for example <code>zip.files.toString()</code>. This approach is taken to prevent files in the zip overriding object methods that would exist on a normal object.</li>
</ul>
</li>
</ul>
<h3>v3.6.0 2021-02-09</h3>
<ul>
<li>Fix: redirect main to dist on browsers (see <a href="https://github-redirect.dependabot.com/Stuk/jszip/pull/742">https://github.com/facebook/flipper/issues/742</a>)</li>
<li>Fix duplicate require DataLengthProbe, utils (see <a href="https://github-redirect.dependabot.com/Stuk/jszip/pull/734">https://github.com/facebook/flipper/issues/734</a>)</li>
<li>Fix small error in read_zip.md (see <a href="https://github-redirect.dependabot.com/Stuk/jszip/pull/703">https://github.com/facebook/flipper/issues/703</a>)</li>
</ul>
<h3>v3.5.0 2020-05-31</h3>
<ul>
<li>Fix 'End of data reached' error when file extra field is invalid (see <a href="https://github-redirect.dependabot.com/Stuk/jszip/pull/544">https://github.com/facebook/flipper/issues/544</a>).</li>
<li>Typescript definitions: Add null to return types of functions that may return null (see <a href="https://github-redirect.dependabot.com/Stuk/jszip/pull/669">https://github.com/facebook/flipper/issues/669</a>).</li>
<li>Typescript definitions: Correct nodeStream's type (see <a href="https://github-redirect.dependabot.com/Stuk/jszip/pull/682">https://github.com/facebook/flipper/issues/682</a>)</li>
<li>Typescript definitions: Add string output type (see <a href="https://github-redirect.dependabot.com/Stuk/jszip/pull/666">https://github.com/facebook/flipper/issues/666</a>)</li>
</ul>
<h3>v3.4.0 2020-04-19</h3>
<ul>
<li>Add Typescript type definitions (see <a href="https://github-redirect.dependabot.com/Stuk/jszip/pull/601">https://github.com/facebook/flipper/issues/601</a>).</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="3f2f0da8b2"><code>3f2f0da</code></a> 3.7.1</li>
<li><a href="9f9c33b66b"><code>9f9c33b</code></a> Updates for 3.7.1</li>
<li><a href="5639745878"><code>5639745</code></a> Merge branch 'fix-build'</li>
<li><a href="e08003ec71"><code>e08003e</code></a> Fix lint</li>
<li><a href="79f7691e51"><code>79f7691</code></a> Revert &quot;Disable proto assert that fails in browsers&quot;</li>
<li><a href="89298b9f26"><code>89298b9</code></a> Update gitignore for Mac, and sort</li>
<li><a href="81cb5eb244"><code>81cb5eb</code></a> Temporarily update docs for building dist correctly</li>
<li><a href="e5b3f0ddaa"><code>e5b3f0d</code></a> 3.7.0</li>
<li><a href="e88ba4b367"><code>e88ba4b</code></a> Update for version 3.7.0</li>
<li><a href="90464873e3"><code>9046487</code></a> Disable proto assert that fails in browsers</li>
<li>Additional commits viewable in <a href="https://github.com/Stuk/jszip/compare/v3.3.0...v3.7.1">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=jszip&package-manager=npm_and_yarn&previous-version=3.3.0&new-version=3.7.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/facebook/flipper/network/alerts).

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/2680

Reviewed By: mweststrate

Differential Revision: D30246994

Pulled By: passy

fbshipit-source-id: b507ab24054ebfe905b092f0ca9da0c43ea37d16
2021-08-11 11:03:45 -07:00
dependabot[bot]
2633b4c8cb Bump react-native-flipper from 0.100.0 to 0.102.0 in /react-native/ReactNativeFlipperExample (#2670)
Summary:
Bumps [react-native-flipper](https://github.com/facebook/flipper) from 0.100.0 to 0.102.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/facebook/flipper/releases">react-native-flipper's releases</a>.</em></p>
<blockquote>
<h2>v0.102.0</h2>
<p>See <a href="https://github.com/facebook/flipper/blob/master/desktop/static/CHANGELOG.md">https://github.com/facebook/flipper/blob/master/desktop/static/CHANGELOG.md</a>
for full notes.</p>
<h2>v0.101.0</h2>
<p>See <a href="https://github.com/facebook/flipper/blob/master/desktop/static/CHANGELOG.md">https://github.com/facebook/flipper/blob/master/desktop/static/CHANGELOG.md</a>
for full notes.</p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="7b577f77c8"><code>7b577f7</code></a> Flipper Release: v0.102.0</li>
<li><a href="798239507a"><code>7982395</code></a> Automated: Update Podfile.lock (<a href="https://github-redirect.dependabot.com/facebook/flipper/issues/2662">https://github.com/facebook/flipper/issues/2662</a>)</li>
<li><a href="4f9408c8af"><code>4f9408c</code></a> Bump tar from 6.1.0 to 6.1.6 in /react-native/ReactNativeFlipperExample (<a href="https://github-redirect.dependabot.com/facebook/flipper/issues/2663">https://github.com/facebook/flipper/issues/2663</a>)</li>
<li><a href="cc4064ec9f"><code>cc4064e</code></a> Force Sec-Fetch-Site header to 'none'</li>
<li><a href="0df3a19e98"><code>0df3a19</code></a> Update package version on Flipper site.</li>
<li><a href="b280f75b06"><code>b280f75</code></a> Fix Vulnerability</li>
<li><a href="ab2988dd67"><code>ab2988d</code></a> Flipper Snapshot Bump: v0.101.1-SNAPSHOT</li>
<li><a href="5dbb0b7a24"><code>5dbb0b7</code></a> Flipper Release: v0.101.0</li>
<li><a href="43179a7ef4"><code>43179a7</code></a> ConnectionContext to expose client certificate in PKCS <a href="https://github-redirect.dependabot.com/facebook/flipper/issues/12">https://github.com/facebook/flipper/issues/12</a> format</li>
<li><a href="a5b83dc148"><code>a5b83dc</code></a> Add tracking for usage statistics</li>
<li>Additional commits viewable in <a href="https://github.com/facebook/flipper/compare/v0.100.0...v0.102.0">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=react-native-flipper&package-manager=npm_and_yarn&previous-version=0.100.0&new-version=0.102.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/2670

Reviewed By: mweststrate

Differential Revision: D30226365

Pulled By: passy

fbshipit-source-id: ab7640c42154f0469d6bcd97495861c50d768b32
2021-08-11 11:03:45 -07:00
dependabot[bot]
5cf86a8f6e Bump eslint-plugin-import from 2.23.4 to 2.24.0 in /desktop (#2671)
Summary:
Bumps [eslint-plugin-import](https://github.com/import-js/eslint-plugin-import) from 2.23.4 to 2.24.0.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/import-js/eslint-plugin-import/blob/master/CHANGELOG.md">eslint-plugin-import's changelog</a>.</em></p>
<blockquote>
<h2>[2.24.0] - 2021-08-08</h2>
<h3>Added</h3>
<ul>
<li>[<code>no-dynamic-require</code>]: add option <code>esmodule</code> (<a href="https://github-redirect.dependabot.com/import-js/eslint-plugin-import/issues/1223">https://github.com/facebook/flipper/issues/1223</a>, thanks [<a href="https://github.com/vikr01"><code>@​vikr01</code></a>])</li>
<li>[<code>named</code>]: add <code>commonjs</code> option (<a href="https://github-redirect.dependabot.com/import-js/eslint-plugin-import/issues/1222">https://github.com/facebook/flipper/issues/1222</a>, thanks [<a href="https://github.com/vikr01"><code>@​vikr01</code></a>])</li>
<li>[<code>no-namespace</code>]: Add <code>ignore</code> option (<a href="https://github-redirect.dependabot.com/import-js/eslint-plugin-import/issues/2112">https://github.com/facebook/flipper/issues/2112</a>, thanks [<a href="https://github.com/aberezkin"><code>@​aberezkin</code></a>])</li>
<li>[<code>max-dependencies</code>]: add option <code>ignoreTypeImports</code> (<a href="https://github-redirect.dependabot.com/import-js/eslint-plugin-import/issues/1847">https://github.com/facebook/flipper/issues/1847</a>, thanks [<a href="https://github.com/rfermann"><code>@​rfermann</code></a>])</li>
</ul>
<h3>Fixed</h3>
<ul>
<li>[<code>no-duplicates</code>]: ensure autofix avoids excessive newlines (<a href="https://github-redirect.dependabot.com/import-js/eslint-plugin-import/issues/2028">https://github.com/facebook/flipper/issues/2028</a>, thanks [<a href="https://github.com/ertrzyiks"><code>@​ertrzyiks</code></a>])</li>
<li>[<code>extensions</code>]: avoid crashing on partially typed import/export statements (<a href="https://github-redirect.dependabot.com/import-js/eslint-plugin-import/issues/2118">https://github.com/facebook/flipper/issues/2118</a>, thanks [<a href="https://github.com/ljharb"><code>@​ljharb</code></a>])</li>
<li>[<code>no-extraneous-dependencies</code>]: add ESM intermediate package.json support] (<a href="https://github-redirect.dependabot.com/import-js/eslint-plugin-import/issues/2121">https://github.com/facebook/flipper/issues/2121</a>, thanks [<a href="https://github.com/paztis"><code>@​paztis</code></a>])</li>
<li>Use <code>context.getPhysicalFilename()</code> when available (ESLint 7.28+) (<a href="https://github-redirect.dependabot.com/import-js/eslint-plugin-import/issues/2160">https://github.com/facebook/flipper/issues/2160</a>, thanks [<a href="https://github.com/pmcelhaney"><code>@​pmcelhaney</code></a>])</li>
<li>[<code>extensions</code>]/<code>importType</code>: fix isScoped treating @/abc as scoped module (<a href="https://github-redirect.dependabot.com/import-js/eslint-plugin-import/issues/2146">https://github.com/facebook/flipper/issues/2146</a>, thanks [<a href="https://github.com/rperello"><code>@​rperello</code></a>])</li>
</ul>
<h3>Changed</h3>
<ul>
<li>[Docs] [<code>extensions</code>]: removed incorrect cases (<a href="https://github-redirect.dependabot.com/import-js/eslint-plugin-import/issues/2138">https://github.com/facebook/flipper/issues/2138</a>, thanks [<a href="https://github.com/wenfangdu"><code>@​wenfangdu</code></a>])</li>
<li>[Tests] [<code>order</code>]: add tests for <code>pathGroupsExcludedImportTypes: ['type']</code> (<a href="https://github-redirect.dependabot.com/import-js/eslint-plugin-import/issues/2158">https://github.com/facebook/flipper/issues/2158</a>, thanks [<a href="https://github.com/atav32"><code>@​atav32</code></a>])</li>
<li>[Docs] [<code>order</code>]:  improve the documentation for the <code>pathGroupsExcludedImportTypes</code> option (<a href="https://github-redirect.dependabot.com/import-js/eslint-plugin-import/issues/2156">https://github.com/facebook/flipper/issues/2156</a>, thanks [<a href="https://github.com/liby"><code>@​liby</code></a>])</li>
<li>[Tests] [<code>no-cycle</code>]: Restructure test files (<a href="https://github-redirect.dependabot.com/import-js/eslint-plugin-import/issues/1517">https://github.com/facebook/flipper/issues/1517</a>, thanks [<a href="https://github.com/soryy708"><code>@​soryy708</code></a>])</li>
<li>[Docs] add description how to use plugin with yarn berry (<a href="https://github-redirect.dependabot.com/import-js/eslint-plugin-import/issues/2179">https://github.com/facebook/flipper/issues/2179</a>, thanks [<a href="https://github.com/KostyaZgara"><code>@​KostyaZgara</code></a>])</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="202e5e02db"><code>202e5e0</code></a> Bump to v2.24.0</li>
<li><a href="546f87f6c7"><code>546f87f</code></a> utils: v2.6.2</li>
<li><a href="74fa6c99cc"><code>74fa6c9</code></a> [resolvers/node] v0.3.5</li>
<li><a href="32bf645563"><code>32bf645</code></a> [Docs] add description how to use plugin with yarn berry</li>
<li><a href="794e869757"><code>794e869</code></a> [meta] update repo URLs</li>
<li><a href="429f3f6023"><code>429f3f6</code></a> [Tests] <code>no-cycle</code>: Restructure test files</li>
<li><a href="b743a650e9"><code>b743a65</code></a> [New] <code>max-dependencies</code>: add option <code>ignoreTypeImports</code></li>
<li><a href="bba59c4848"><code>bba59c4</code></a> [New] <code>no-namespace</code>: Add <code>ignore</code> option</li>
<li><a href="54d86c8a64"><code>54d86c8</code></a> [New] <code>named</code>: add <code>commonjs</code> option</li>
<li><a href="7626a14851"><code>7626a14</code></a> [Refactor] <code>named</code>: clean up formatting</li>
<li>Additional commits viewable in <a href="https://github.com/import-js/eslint-plugin-import/compare/v2.23.4...v2.24.0">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=eslint-plugin-import&package-manager=npm_and_yarn&previous-version=2.23.4&new-version=2.24.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/2671

Reviewed By: mweststrate

Differential Revision: D30226888

Pulled By: passy

fbshipit-source-id: 5245244f87de76a0d51acc90b0ff43a1cd98b085
2021-08-11 11:03:45 -07:00
Pascal Hartig
dd536b9d1a Gracefully handle socket closures
Summary:
Got my first auto-created crashbot task. {emoji:1f973}

We do have some pretty granular handling for errors during disconnects but this one has fallen through the cracks.

I'm not 100% sure if this is the right way to handle it which is why I added mweststrate. :)

Reviewed By: mweststrate

Differential Revision: D30218833

fbshipit-source-id: 2b4c9201ee7faf1c278b1cc5268ad2648dc4c820
2021-08-10 16:12:02 -07:00
Michel Weststrate
8d7caa9dd4 Introduce Dialog.alert
Summary: Introduce `Dialog.alert` to show users a FYI message, and be able to wait for it to be handled, as utility around several `Modal` utilities.

Reviewed By: jknoxville

Differential Revision: D29875484

fbshipit-source-id: 5d2ea83e486631ac18a81800b467f97dfaac6d34
2021-08-10 13:24:23 -07:00
Michel Weststrate
4b892e7373 Check Flipper version when handling deeplinks
Summary: Check if Flipper is up to date before handling deeplink.

Reviewed By: nikoant

Differential Revision: D29846236

fbshipit-source-id: 011d05958346c3d18c76cf0ae63c3cb087f5933c
2021-08-10 13:24:23 -07:00
Michel Weststrate
b757bff9f6 Document the new deeplink format [2/n]
Summary:
Added docs on how to use deeplink.

Note that not all features are implemented yet.

Reviewed By: fabiomassimo

Differential Revision: D29845044

fbshipit-source-id: 835fba8ce97c2106d160f347675e11d1ed749fba
2021-08-10 13:24:23 -07:00
Michel Weststrate
38473121ba Check connection & user login when entering deeplink [1/n]
Summary: First steps in smoother deeplink flow, where connection and login status is being checked before trying to handle the deeplink.

Reviewed By: lblasa

Differential Revision: D29790461

fbshipit-source-id: e1e42ceb5db59c695077f316e836f1f216c7204a
2021-08-10 13:24:23 -07:00
Pascal Hartig
47faeade61 Patch dep bump
Summary: Excluding `react-virtual` which seems to include a breaking change with the patch release.

Reviewed By: jknoxville

Differential Revision: D30189687

fbshipit-source-id: b40cb5edd407fd03009ee38c0af5202c8deaaa26
2021-08-10 11:08:22 -07:00
Pascal Hartig
fc73e0d4ec Revert "Improve protobuf support (#2513)" (#2665)
Summary:
This reverts commit efd75ea435.

Sorry hbmartin! We're running into Kotlin compatibility problems. Your latest library release isn't compatible with Kotlin 1.3 and we can't upgrade just yet because Litho hasn't been able to release in a while. :(

Pull Request resolved: https://github.com/facebook/flipper/pull/2665

Test Plan: _eyes

Differential Revision: D30189360

Pulled By: passy

fbshipit-source-id: c1edbbc496742938579f4e2032a78debe08fcc26
2021-08-09 04:15:49 -07:00
dependabot[bot]
9e0a5484e7 Bump constraintlayout from 2.0.4 to 2.1.0 (#2656)
Summary:
Bumps [constraintlayout](https://github.com/androidx/constraintlayout) from 2.0.4 to 2.1.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/androidx/constraintlayout/releases">constraintlayout's releases</a>.</em></p>
<blockquote>
<h2>2.1.0</h2>
<p>No release notes provided.</p>
<h2>2.1.0-rc01</h2>
<p>No release notes provided.</p>
<h2>2.1.0-beta02</h2>
<p>MotionLayout</p>
<p>A few new features:</p>
<ul>
<li>OnSwipe enhancement including spring (stiffness, damping, mass etc) &amp; never complete</li>
<li>jumpToState function</li>
<li>ViewTransition downUp mode where on touch Down it plays to 100 and on up reverses to 0</li>
</ul>
<p>Various fixes, notably:</p>
<p>Fix problem in MotionLayout with vertical scroll (<a href="https://github-redirect.dependabot.com/androidx/constraintlayout/issues/173">https://github.com/facebook/flipper/issues/173</a>)
Perf improvements on nested MotionLayout (<a href="https://github-redirect.dependabot.com/androidx/constraintlayout/issues/189">https://github.com/facebook/flipper/issues/189</a>)
Fast transition with NestedScrollView in MotionLayout (<a href="https://github-redirect.dependabot.com/androidx/constraintlayout/issues/189">https://github.com/facebook/flipper/issues/189</a>)
ConstraintSet gone in MotionLayout (<a href="https://github-redirect.dependabot.com/androidx/constraintlayout/issues/189">https://github.com/facebook/flipper/issues/189</a>)
Support downUp ViewTransitions in MotionLayout (<a href="https://github-redirect.dependabot.com/androidx/constraintlayout/issues/190">https://github.com/facebook/flipper/issues/190</a>)
Fix in ImageFilter when reusing drawables (<a href="https://github-redirect.dependabot.com/androidx/constraintlayout/issues/192">https://github.com/facebook/flipper/issues/192</a>)
Add spring support in MotionLayout (<a href="https://github-redirect.dependabot.com/androidx/constraintlayout/issues/199">https://github.com/facebook/flipper/issues/199</a>)
Performance improvement to CircularFlow (<a href="https://github-redirect.dependabot.com/androidx/constraintlayout/issues/200">https://github.com/facebook/flipper/issues/200</a>)
Fixes in derived constraints / constraint override (<a href="https://github-redirect.dependabot.com/androidx/constraintlayout/issues/212">https://github.com/facebook/flipper/issues/212</a>)</p>
<h2>2.1.0-beta01</h2>
<h1>ConstraintLayout</h1>
<ul>
<li>android:layout_width and android:layout_height are back being non-optional due to compatibility issues.</li>
</ul>
<h1>Helpers</h1>
<ul>
<li>added a way to animate or jump directly to a given item of a Carousel</li>
<li>new CircularFlow helper</li>
</ul>
<h1>MotionLayout</h1>
<ul>
<li>Programmatic support for inserting and removing onSwipe and onClick on Transitions</li>
<li>Experimental Support for Transitions through screen rotation</li>
<li>support duration argument to transitions</li>
<li>Better support for customAttributes that are boolean or References</li>
</ul>
<h2>2.1.0 alpha 2</h2>
<p>Many new features added in alpha 2, see the wiki</p>
<h2>2.1.0 alpha 1</h2>
<p>New features in MotionLayout (view transition etc) and new Carousel helper</p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="343db8d806"><code>343db8d</code></a> bump constraintlayout-compose to 1.0 beta 2</li>
<li><a href="d10b5b3167"><code>d10b5b3</code></a> bump version number of compose to 1.0 \o/</li>
<li><a href="a60d9868c2"><code>a60d986</code></a> Update README.md</li>
<li><a href="115f9f6802"><code>115f9f6</code></a> Merge branch 'main' of <a href="https://github.com/androidx/constraintlayout">https://github.com/androidx/constraintlayout</a> into main</li>
<li><a href="a9af02fb2b"><code>a9af02f</code></a> bump to 2.1.0</li>
<li><a href="ad6cd328d4"><code>ad6cd32</code></a> Move basic transitions on single constraintset to ConstraintLayout instead of...</li>
<li><a href="d7e308ff75"><code>d7e308f</code></a> Add a MotionLayout that animates between changing constraint sets (<a href="https://github-redirect.dependabot.com/androidx/constraintlayout/issues/359">https://github.com/facebook/flipper/issues/359</a>)</li>
<li><a href="4880da5605"><code>4880da5</code></a> Fix in json parser (<a href="https://github-redirect.dependabot.com/androidx/constraintlayout/issues/358">https://github.com/facebook/flipper/issues/358</a>)</li>
<li><a href="85991a3c51"><code>85991a3</code></a> viewTransition Example (<a href="https://github-redirect.dependabot.com/androidx/constraintlayout/issues/357">https://github.com/facebook/flipper/issues/357</a>)</li>
<li><a href="9fb9da89a6"><code>9fb9da8</code></a> Fix build of tools library (<a href="https://github-redirect.dependabot.com/androidx/constraintlayout/issues/355">https://github.com/facebook/flipper/issues/355</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/androidx/constraintlayout/compare/2.0.4...2.1.0">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=androidx.constraintlayout:constraintlayout&package-manager=gradle&previous-version=2.0.4&new-version=2.1.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/2656

Reviewed By: mweststrate

Differential Revision: D30162301

Pulled By: passy

fbshipit-source-id: 5ca76c7e205f564973b55d1a1f2b1b27a4b4c3e1
2021-08-09 03:04:49 -07:00
Harold Martin
efd75ea435 Improve protobuf support (#2513)
Summary:
* Update protobuf library to support map types
* Improved usage messaging in UI
* Always attempt to decode requests with a protobuf definition
## Changelog
Improved protobuf support

Pull Request resolved: https://github.com/facebook/flipper/pull/2513

Reviewed By: mweststrate

Differential Revision: D30162379

Pulled By: passy

fbshipit-source-id: 201fb06045822641be5840b121da180a201be974
2021-08-09 02:42:35 -07:00
dependabot[bot]
410445a1ed Bump runner from 1.3.0 to 1.4.0 (#2563)
Summary:
Bumps runner from 1.3.0 to 1.4.0.

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=androidx.test:runner&package-manager=gradle&previous-version=1.3.0&new-version=1.4.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/2563

Reviewed By: muraziz

Differential Revision: D29992992

Pulled By: passy

fbshipit-source-id: 4e72fc3a21fead198b1842269116d0e1e8348359
2021-08-06 10:25:45 -07:00
Adam Ernst
91ca7557e8 Daily arc lint --take UNCRUSTIFY
Reviewed By: zertosh

Differential Revision: D30155603

fbshipit-source-id: ffbfc083952ad00eb22270507a694c9b5a800d27
2021-08-06 09:39:53 -07:00
Ananya Arun
025ca05d62 Enrich plugin metadata on what apps they support and add unit tests
Summary:
- This Diff is part 1 of 2 of milestone 1 of my internship project flipper self sufficiency. The task can be found here - https://www.internalfb.com/tasks?q=958574791613645&t=91334896

- I have extended the plugin package meta data format to support a "supportedApps" field that consists of appID (facebook, instagram, messenger etc) along with OS and type that were previously defined in supportedDevices as well.

- The diff also adds unit tests for this new format to ensure addition of the supportedApps field does not break anything.

Reviewed By: nikoant

Differential Revision: D30133225

fbshipit-source-id: 6ef0d1cadd61c0d69640cf61793322acb4cd65f4
2021-08-06 07:14:44 -07:00
facebook-flipper-bot
1a7e3b9b00 Automated: Update Podfile.lock (#2664)
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)

Pull Request resolved: https://github.com/facebook/flipper/pull/2664

Test Plan:
Imported from GitHub, without a `Test Plan:` line.

|[Site Preview: flipper](https://our.intern.facebook.com/intern/staticdocs/eph/D30156476/V2/flipper/)

Reviewed By: passy

Differential Revision: D30156476

Pulled By: nikoant

fbshipit-source-id: 04d3ea60a59fc2fe0507319bd6261376388ec31a
2021-08-06 04:02:35 -07:00
Flipper Bot
57b340bf79 Flipper Snapshot Bump: v0.102.1-SNAPSHOT
Summary: Releasing snapshot version 0.102.1-SNAPSHOT

Reviewed By: nikoant

Differential Revision: D30131830

fbshipit-source-id: 543c9fdac0f166b008f8f626f61d4c593bfc4aba
2021-08-05 09:43:40 -07:00
Flipper Bot
7b577f77c8 Flipper Release: v0.102.0
Summary: Releasing version 0.102.0

Reviewed By: nikoant

Differential Revision: D30131831

fbshipit-source-id: 05ffa592f0ae9e123dffed6a3c8c5c0e22daacf4
2021-08-05 09:43:40 -07:00
facebook-flipper-bot
798239507a Automated: Update Podfile.lock (#2662)
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)

Pull Request resolved: https://github.com/facebook/flipper/pull/2662

Test Plan:
Imported from GitHub, without a `Test Plan:` line.

|[Site Preview: flipper](https://our.intern.facebook.com/intern/staticdocs/eph/D30131497/V2/flipper/)

Reviewed By: nikoant

Differential Revision: D30131497

Pulled By: passy

fbshipit-source-id: f321dc0187da2660f585d5f3d47531d7aa19d818
2021-08-05 07:11:13 -07:00
dependabot[bot]
4f9408c8af Bump tar from 6.1.0 to 6.1.6 in /react-native/ReactNativeFlipperExample (#2663)
Summary:
Bumps [tar](https://github.com/npm/node-tar) from 6.1.0 to 6.1.6.
<details>
<summary>Commits</summary>
<ul>
<li><a href="9bc1729939"><code>9bc1729</code></a> 6.1.6</li>
<li><a href="bdf4f51713"><code>bdf4f51</code></a> fix: properly prefix hard links</li>
<li><a href="94b2a74011"><code>94b2a74</code></a> chore: remove benchmarks from git repo</li>
<li><a href="ecaafb4777"><code>ecaafb4</code></a> update deps</li>
<li><a href="bd4691c904"><code>bd4691c</code></a> 6.1.5</li>
<li><a href="d694c4f810"><code>d694c4f</code></a> ci: test on node 16</li>
<li><a href="84acbd3128"><code>84acbd3</code></a> fix(unpack): fix hang on large file on open() fail</li>
<li><a href="97c46fcee7"><code>97c46fc</code></a> fix(unpack): always resume parsing after an entry error</li>
<li><a href="488ab8c01d"><code>488ab8c</code></a> chore: WriteEntry cleaner write() handling</li>
<li><a href="be89aafd95"><code>be89aaf</code></a> WriteEntry backpressure</li>
<li>Additional commits viewable in <a href="https://github.com/npm/node-tar/compare/v6.1.0...v6.1.6">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=tar&package-manager=npm_and_yarn&previous-version=6.1.0&new-version=6.1.6)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/facebook/flipper/network/alerts).

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/2663

Reviewed By: lblasa

Differential Revision: D30131500

Pulled By: passy

fbshipit-source-id: 0cd2145d6dd82feb63405e1fbbc72d3b0fa7fa7f
2021-08-05 07:03:18 -07:00
Anton Nikolaev
cc4064ec9f Force Sec-Fetch-Site header to 'none'
Reviewed By: bartoszniemczura

Differential Revision: D30047497

fbshipit-source-id: 0d9376c09d63176031291f19bfe82a56d5677641
2021-08-05 02:40:41 -07:00
Adetomiwa Adesanya
0df3a19e98 Update package version on Flipper site.
Summary: Update flipper to use latest docusaurus-plugin-internaldocs-fb package version.

Reviewed By: nikoant

Differential Revision: D30107938

fbshipit-source-id: 42ec4614d3e1292171b2d1a26378a1bd6ab1853c
2021-08-04 15:44:56 -07:00
Chaiwat Ekkaewnumchai
b280f75b06 Fix Vulnerability
Summary:
per title

For `xmldom`, npm can't push the update as mentioned in https://github.com/xmldom/xmldom/releases/tag/0.7.0

Reviewed By: lblasa

Differential Revision: D30101848

fbshipit-source-id: 0d84a302b845708787d5cae01643dba9963f0330
2021-08-04 09:36:14 -07:00
Flipper Bot
ab2988dd67 Flipper Snapshot Bump: v0.101.1-SNAPSHOT
Summary: Releasing snapshot version 0.101.1-SNAPSHOT

Reviewed By: lblasa

Differential Revision: D30098057

fbshipit-source-id: a01d34ef7926dac6f07fc0b00467135c4b0ecf55
2021-08-04 07:37:17 -07:00
Flipper Bot
5dbb0b7a24 Flipper Release: v0.101.0
Summary: Releasing version 0.101.0

Reviewed By: lblasa

Differential Revision: D30098058

fbshipit-source-id: f6e6ed1942a30e492e66ed42aec6dc35d1cddd24
2021-08-04 07:37:17 -07:00
Lorenzo Blasa
43179a7ef4 ConnectionContext to expose client certificate in PKCS #12 format
Summary:
RSocket plays nicely with Folly and OpenSSL.

Flipper WebSocket-client uses SocketRocket which instead relies on Apple's NSInputStream and NSOutputStream types.

SSL options can be set to secure the communication in both.

Unfortunately, Apple APIs are a bit limited on the supported cryptographic formats it can accept as arguments.

SSL options require the client certificate to be set in PKCS #12 format, contrary to the existing PEM format used by RSocket.

This change adds a method to the ConnectionContext which converts and saves the client certificate in PKCS #12 format.

The method is always expected to succeed as it will only be called once a valid client certificate is available. An unlikely failure will raise an exception.

Reviewed By: fabiomassimo

Differential Revision: D30074334

fbshipit-source-id: 91a475d080569cc339b649c7302b1f28793c7de7
2021-08-04 06:34:18 -07:00
Ananya Arun
a5b83dc148 Add tracking for usage statistics
Summary:
- This diff adds usage statistics for
    - How often was the troubleshooting button opened
    - What were its end states ( Problem solved or file a support request)

- I am using the tracked flipper plugin to obtain and analyse the stats on Infinity analytics events dev in Scuba backend.
(Since this is not yet productionized we are using the dev version now )

Reviewed By: nikoant

Differential Revision: D30098054

fbshipit-source-id: 871cc18872bccf70a829dc1dd173a337b02ec6e6
2021-08-04 04:16:52 -07:00
Ananya Arun
84ec5813b6 Add modal dialogue for the end screen
Summary:
- Added a dialogue with 2 possible end state buttons
    - Problem Solved
    - File Support Request
- This diff is the start of the implementation of the troubleshooting wizard.
- The previously implemented troubleshooting button (D29993355 (921a65bc17)) now links to a modal dialogue box.
- This is essentially the last screen of the troubleshooting guide to be implemented.
- We have options for a user to either select file a support request if the issue persists after navigating the guide or click on problem solved if the guide helped them solve it.
- Selecting option 2 (file support request) links to the pre-existing form

The modal has been implemented as an independent reusable component and can be easily extended.

Reviewed By: passy

Differential Revision: D30069270

fbshipit-source-id: f61bf8c03de786e11b7f06194328dbee703abf8b
2021-08-03 12:49:49 -07:00
Lorenzo Blasa
4e6b895fc9 WebSocket server GK
Summary:
This change enables a WebSocket server if the user is on the 'flipper_websocket_server' GK.

I don't expect this change to make it as the final product of the entire solution. Instead, it can be used to quickly enable/disable WebSocket during development/testing without requiring any code changes.

Reviewed By: passy

Differential Revision: D30069694

fbshipit-source-id: 75daac75e6dad7f63cf194d8287971c33d3abb61
2021-08-03 09:34:57 -07:00
Lorenzo Blasa
b76ce357eb Addresses an issue with Flipper message identifier
Summary:
This change addresses a problem with using data.id straight into the if statement.

If `data.id` is not undefined but has a value of 0 then the expression evaluates to false.

Right now, that wasn't the intended usage.

Using this change to also export some types from Client.

Reviewed By: passy

Differential Revision: D30069746

fbshipit-source-id: 04a8d161efceadf7a38ee556be70c15b45c11056
2021-08-03 09:30:47 -07:00
Pascal Hartig
6791b29e45 Big dep bump
Summary: The markdown bump required ignoring another prop, the rest was smooth.

Reviewed By: timur-valiev

Differential Revision: D30067682

fbshipit-source-id: 6038ffe29d2e0041c81bac132eed747cbfe40f54
2021-08-03 05:18:34 -07:00
Andrey
6349ebe05d Fixed plugin installer overflow (#2652)
Summary:
https://user-images.githubusercontent.com/33036510/127777930-34ede219-0fb9-4486-8f2e-3d73ff8cb84d.mov

Content of plugin installer modal has no scroll and it is overflowing

## Changelog

- Fixed PluginInstaller table overflow

Pull Request resolved: https://github.com/facebook/flipper/pull/2652

Test Plan:
The video, demonstrating how the problem was fixed:
https://user-images.githubusercontent.com/33036510/127777930-34ede219-0fb9-4486-8f2e-3d73ff8cb84d.mov

Reviewed By: passy

Differential Revision: D30044703

Pulled By: cekkaewnumchai

fbshipit-source-id: 6d00ef766aaa295cc43fd944ca3b849371192a79
2021-08-02 14:30:46 -07:00
dependabot[bot]
7dfb510e1e Bump eslint from 7.31.0 to 7.32.0 in /flipper-js-client-sdk (#2654)
Summary:
Bumps [eslint](https://github.com/eslint/eslint) from 7.31.0 to 7.32.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/eslint/eslint/releases">eslint's releases</a>.</em></p>
<blockquote>
<h2>v7.32.0</h2>
<ul>
<li><a href="3c78a7bff6"><code>3c78a7b</code></a> Chore: Adopt <code>eslint-plugin/prefer-message-ids</code> rule internally (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14841">#14841</a>) (Bryan Mishkin)</li>
<li><a href="faecf56cdb"><code>faecf56</code></a> Update: change reporting location for <code>curly</code> rule (refs <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/12334">#12334</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14766">#14766</a>) (Nitin Kumar)</li>
<li><a href="d7dc07a15e"><code>d7dc07a</code></a> Fix: ignore lines with empty elements (fixes <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/12756">#12756</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14837">#14837</a>) (Soufiane Boutahlil)</li>
<li><a href="1bfbefdaaf"><code>1bfbefd</code></a> New: Exit on fatal error (fixes <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/13711">#13711</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14730">#14730</a>) (Antonios Katopodis)</li>
<li><a href="ed007c82ee"><code>ed007c8</code></a> Chore: Simplify internal <code>no-invalid-meta</code> rule (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14842">#14842</a>) (Bryan Mishkin)</li>
<li><a href="d53d9064b9"><code>d53d906</code></a> Docs: Prepare data for website to indicate rules with suggestions (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14830">#14830</a>) (Bryan Mishkin)</li>
<li><a href="d28f2ffb98"><code>d28f2ff</code></a> Docs: Reference eslint-config-eslint to avoid potential for staleness (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14805">#14805</a>) (Brett Zamir)</li>
<li><a href="8be8a36010"><code>8be8a36</code></a> Chore: Adopt <code>eslint-plugin/require-meta-docs-url</code> rule internally (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14823">#14823</a>) (Bryan Mishkin)</li>
<li><a href="f9c164f7b7"><code>f9c164f</code></a> Docs: New syntax issue template (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14826">#14826</a>) (Nicholas C. Zakas)</li>
<li><a href="eba0c4595c"><code>eba0c45</code></a> Chore: assertions on reporting loc in <code>unicode-bom</code> (refs <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/12334">#12334</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14809">#14809</a>) (Nitin Kumar)</li>
<li><a href="ed945bd662"><code>ed945bd</code></a> Docs: fix multiple broken links (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14833">#14833</a>) (Sam Chen)</li>
<li><a href="60df44c79b"><code>60df44c</code></a> Chore: use <code>actions/setup-node@v2</code> (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14816">#14816</a>) (Nitin Kumar)</li>
<li><a href="6641d88e17"><code>6641d88</code></a> Docs: Update README team and sponsors (ESLint Jenkins)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/eslint/eslint/blob/master/CHANGELOG.md">eslint's changelog</a>.</em></p>
<blockquote>
<p>v7.32.0 - July 30, 2021</p>
<ul>
<li><a href="3c78a7bff6"><code>3c78a7b</code></a> Chore: Adopt <code>eslint-plugin/prefer-message-ids</code> rule internally (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14841">#14841</a>) (Bryan Mishkin)</li>
<li><a href="faecf56cdb"><code>faecf56</code></a> Update: change reporting location for <code>curly</code> rule (refs <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/12334">#12334</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14766">#14766</a>) (Nitin Kumar)</li>
<li><a href="d7dc07a15e"><code>d7dc07a</code></a> Fix: ignore lines with empty elements (fixes <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/12756">#12756</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14837">#14837</a>) (Soufiane Boutahlil)</li>
<li><a href="1bfbefdaaf"><code>1bfbefd</code></a> New: Exit on fatal error (fixes <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/13711">#13711</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14730">#14730</a>) (Antonios Katopodis)</li>
<li><a href="ed007c82ee"><code>ed007c8</code></a> Chore: Simplify internal <code>no-invalid-meta</code> rule (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14842">#14842</a>) (Bryan Mishkin)</li>
<li><a href="d53d9064b9"><code>d53d906</code></a> Docs: Prepare data for website to indicate rules with suggestions (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14830">#14830</a>) (Bryan Mishkin)</li>
<li><a href="d28f2ffb98"><code>d28f2ff</code></a> Docs: Reference eslint-config-eslint to avoid potential for staleness (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14805">#14805</a>) (Brett Zamir)</li>
<li><a href="8be8a36010"><code>8be8a36</code></a> Chore: Adopt <code>eslint-plugin/require-meta-docs-url</code> rule internally (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14823">#14823</a>) (Bryan Mishkin)</li>
<li><a href="f9c164f7b7"><code>f9c164f</code></a> Docs: New syntax issue template (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14826">#14826</a>) (Nicholas C. Zakas)</li>
<li><a href="eba0c4595c"><code>eba0c45</code></a> Chore: assertions on reporting loc in <code>unicode-bom</code> (refs <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/12334">#12334</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14809">#14809</a>) (Nitin Kumar)</li>
<li><a href="ed945bd662"><code>ed945bd</code></a> Docs: fix multiple broken links (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14833">#14833</a>) (Sam Chen)</li>
<li><a href="60df44c79b"><code>60df44c</code></a> Chore: use <code>actions/setup-node@v2</code> (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14816">#14816</a>) (Nitin Kumar)</li>
<li><a href="6641d88e17"><code>6641d88</code></a> Docs: Update README team and sponsors (ESLint Jenkins)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="83cc8a6823"><code>83cc8a6</code></a> 7.32.0</li>
<li><a href="f10218d554"><code>f10218d</code></a> Build: changelog update for 7.32.0</li>
<li><a href="3c78a7bff6"><code>3c78a7b</code></a> Chore: Adopt <code>eslint-plugin/prefer-message-ids</code> rule internally (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14841">#14841</a>)</li>
<li><a href="faecf56cdb"><code>faecf56</code></a> Update: change reporting location for <code>curly</code> rule (refs <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/12334">#12334</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14766">#14766</a>)</li>
<li><a href="d7dc07a15e"><code>d7dc07a</code></a> Fix: ignore lines with empty elements (fixes <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/12756">#12756</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14837">#14837</a>)</li>
<li><a href="1bfbefdaaf"><code>1bfbefd</code></a> New: Exit on fatal error (fixes <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/13711">#13711</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14730">#14730</a>)</li>
<li><a href="ed007c82ee"><code>ed007c8</code></a> Chore: Simplify internal <code>no-invalid-meta</code> rule (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14842">#14842</a>)</li>
<li><a href="d53d9064b9"><code>d53d906</code></a> Docs: Prepare data for website to indicate rules with suggestions (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14830">#14830</a>)</li>
<li><a href="d28f2ffb98"><code>d28f2ff</code></a> Docs: Reference eslint-config-eslint to avoid potential for staleness (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14805">#14805</a>)</li>
<li><a href="8be8a36010"><code>8be8a36</code></a> Chore: Adopt <code>eslint-plugin/require-meta-docs-url</code> rule internally (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14823">#14823</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/eslint/eslint/compare/v7.31.0...v7.32.0">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=eslint&package-manager=npm_and_yarn&previous-version=7.31.0&new-version=7.32.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/2654

Reviewed By: passy

Differential Revision: D30044698

Pulled By: cekkaewnumchai

fbshipit-source-id: 0866dfbb6dcb93766e25c1f975b34dd6d497d45c
2021-08-02 14:08:04 -07:00
dependabot[bot]
20f4cfe70c Bump metro-cache from 0.66.1 to 0.66.2 in /desktop (#2660)
Summary:
Bumps [metro-cache](https://github.com/facebook/metro) from 0.66.1 to 0.66.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/facebook/metro/releases">metro-cache's releases</a>.</em></p>
<blockquote>
<h2>Release v0.66.2</h2>
<ul>
<li><strong>[Fix]</strong> Fix crash in React Native 0.65.0-rc.2. (f7c6325)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="c21daba415"><code>c21daba</code></a> Bump metro to 0.66.2</li>
<li><a href="4972832419"><code>4972832</code></a> Deploy Flow v0.155.1</li>
<li><a href="f0247a811b"><code>f0247a8</code></a> Deploy Flow v0.155.1</li>
<li><a href="f7c6325cbe"><code>f7c6325</code></a> fix(metro): cannot read property 'toUpperCase' of undefined (<a href="https://github-redirect.dependabot.com/facebook/metro/issues/687">https://github.com/facebook/flipper/issues/687</a>)</li>
<li><a href="48b5b1eaa8"><code>48b5b1e</code></a> Update xplat to Flow v0.155.0</li>
<li>See full diff in <a href="https://github.com/facebook/metro/compare/v0.66.1...v0.66.2">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=metro-cache&package-manager=npm_and_yarn&previous-version=0.66.1&new-version=0.66.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/2660

Reviewed By: passy

Differential Revision: D30044649

Pulled By: cekkaewnumchai

fbshipit-source-id: fbd9c77eb93accf8db241b37076dfdef75c82a4e
2021-08-02 14:08:04 -07:00
dependabot[bot]
82792af99b Bump chalk from 4.1.1 to 4.1.2 in /desktop (#2655)
Summary:
Bumps [chalk](https://github.com/chalk/chalk) from 4.1.1 to 4.1.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/chalk/chalk/releases">chalk's releases</a>.</em></p>
<blockquote>
<h2>v4.1.2</h2>
<ul>
<li>Readme updates</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="95d74cbe8d"><code>95d74cb</code></a> 4.1.2 - Readme updates</li>
<li>See full diff in <a href="https://github.com/chalk/chalk/compare/v4.1.1...v4.1.2">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=chalk&package-manager=npm_and_yarn&previous-version=4.1.1&new-version=4.1.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/2655

Reviewed By: passy

Differential Revision: D30044697

Pulled By: cekkaewnumchai

fbshipit-source-id: 3e322863cc8f03f997783b90768a63edf6245c18
2021-08-02 14:08:04 -07:00
dependabot[bot]
66e8e2a375 Bump @babel/preset-env from 7.14.8 to 7.14.9 in /desktop (#2659)
Summary:
Bumps [babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.14.8 to 7.14.9.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/babel/babel/releases"><code>@​babel/preset-env</code>'s releases</a>.</em></p>
<blockquote>
<h2>v7.14.9 (2021-08-01)</h2>
<p>Thanks <a href="https://github.com/SCLeoX"><code>@​SCLeoX</code></a> for your first PR!</p>
<h4>🐛 Bug Fix</h4>
<ul>
<li><code>babel-traverse</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13596">#13596</a> Fix completion record for variable declarations (<a href="https://github.com/addaleax"><code>@​addaleax</code></a>)</li>
</ul>
</li>
<li><code>babel-plugin-proposal-class-properties</code>, <code>babel-plugin-transform-classes</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13600">#13600</a> Extract computed keys from the class closure (<a href="https://github.com/nicolo-ribaudo"><code>@​nicolo-ribaudo</code></a>)</li>
</ul>
</li>
<li><code>babel-plugin-transform-react-jsx-development</code>, <code>babel-plugin-transform-react-jsx-self</code>, <code>babel-plugin-transform-react-jsx</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13552">#13552</a> Don't insert <code>__self: this</code> within constructors of derived classes (<a href="https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env/issues/13550">#13550</a>) (<a href="https://github.com/SCLeoX"><code>@​SCLeoX</code></a>)</li>
</ul>
</li>
<li><code>babel-parser</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13581">#13581</a> [ts] Check if param is assignable when parsing arrow return type (<a href="https://github.com/nicolo-ribaudo"><code>@​nicolo-ribaudo</code></a>)</li>
</ul>
</li>
<li><code>babel-generator</code>, <code>babel-traverse</code>, <code>babel-types</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13577">#13577</a> add 12 missing NODE_FIELDS (<a href="https://github.com/jedwards1211"><code>@​jedwards1211</code></a>)</li>
</ul>
</li>
<li><code>babel-plugin-proposal-async-generator-functions</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13491">#13491</a> Fix <code>_step.value</code> access in <code>for await</code> (<a href="https://github.com/nicolo-ribaudo"><code>@​nicolo-ribaudo</code></a>)</li>
</ul>
</li>
</ul>
<h4>🏠 Internal</h4>
<ul>
<li>Other
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13614">#13614</a> Update Rollup to <code>~2.54.0</code> (<a href="https://github.com/nicolo-ribaudo"><code>@​nicolo-ribaudo</code></a>)</li>
</ul>
</li>
<li><code>babel-generator</code>, <code>babel-helper-validator-identifier</code>, <code>babel-parser</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13606">#13606</a> chore: reorganize benchmarks (<a href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
</ul>
</li>
</ul>
<h4>🏃‍♀️ Performance</h4>
<ul>
<li><code>babel-parser</code>, <code>babel-traverse</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13611">#13611</a> Replace generic __clone call by specific methods (<a href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
</ul>
</li>
<li><code>babel-generator</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13593">#13593</a> Generator performance (<a href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
</ul>
</li>
</ul>
<h4>Committers: 8</h4>
<ul>
<li>Andy Edwards (<a href="https://github.com/jedwards1211"><code>@​jedwards1211</code></a>)</li>
<li>Anna Henningsen (<a href="https://github.com/addaleax"><code>@​addaleax</code></a>)</li>
<li>Babel Bot (<a href="https://github.com/babel-bot"><code>@​babel-bot</code></a>)</li>
<li>Henry Zhu (<a href="https://github.com/hzoo"><code>@​hzoo</code></a>)</li>
<li>Huáng Jùnliàng (<a href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
<li>Nicolò Ribaudo (<a href="https://github.com/nicolo-ribaudo"><code>@​nicolo-ribaudo</code></a>)</li>
<li>Rin Tepis (<a href="https://github.com/SCLeoX"><code>@​SCLeoX</code></a>)</li>
<li>王清雨 (<a href="https://github.com/colinaaa"><code>@​colinaaa</code></a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/babel/babel/blob/main/CHANGELOG.md"><code>@​babel/preset-env</code>'s changelog</a>.</em></p>
<blockquote>
<h2>v7.14.9 (2021-08-01)</h2>
<h4>🐛 Bug Fix</h4>
<ul>
<li><code>babel-traverse</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13596">#13596</a> Fix completion record for variable declarations (<a href="https://github.com/addaleax"><code>@​addaleax</code></a>)</li>
</ul>
</li>
<li><code>babel-plugin-proposal-class-properties</code>, <code>babel-plugin-transform-classes</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13600">#13600</a> Extract computed keys from the class closure (<a href="https://github.com/nicolo-ribaudo"><code>@​nicolo-ribaudo</code></a>)</li>
</ul>
</li>
<li><code>babel-plugin-transform-react-jsx-development</code>, <code>babel-plugin-transform-react-jsx-self</code>, <code>babel-plugin-transform-react-jsx</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13552">#13552</a> Don't insert <code>__self: this</code> within constructors of derived classes (<a href="https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env/issues/13550">#13550</a>) (<a href="https://github.com/SCLeoX"><code>@​SCLeoX</code></a>)</li>
</ul>
</li>
<li><code>babel-parser</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13581">#13581</a> [ts] Check if param is assignable when parsing arrow return type (<a href="https://github.com/nicolo-ribaudo"><code>@​nicolo-ribaudo</code></a>)</li>
</ul>
</li>
<li><code>babel-generator</code>, <code>babel-traverse</code>, <code>babel-types</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13577">#13577</a> add 12 missing NODE_FIELDS (<a href="https://github.com/jedwards1211"><code>@​jedwards1211</code></a>)</li>
</ul>
</li>
<li><code>babel-plugin-proposal-async-generator-functions</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13491">#13491</a> Fix <code>_step.value</code> access in <code>for await</code> (<a href="https://github.com/nicolo-ribaudo"><code>@​nicolo-ribaudo</code></a>)</li>
</ul>
</li>
</ul>
<h4>🏠 Internal</h4>
<ul>
<li>Other
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13614">#13614</a> Update Rollup to <code>~2.54.0</code> (<a href="https://github.com/nicolo-ribaudo"><code>@​nicolo-ribaudo</code></a>)</li>
</ul>
</li>
<li><code>babel-generator</code>, <code>babel-helper-validator-identifier</code>, <code>babel-parser</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13606">#13606</a> chore: reorganize benchmarks (<a href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
</ul>
</li>
</ul>
<h4>🏃‍♀️ Performance</h4>
<ul>
<li><code>babel-parser</code>, <code>babel-traverse</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13611">#13611</a> Replace generic __clone call by specific methods (<a href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
</ul>
</li>
<li><code>babel-generator</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13593">#13593</a> Generator performance (<a href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
</ul>
</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="aa2cac5edc"><code>aa2cac5</code></a> v7.14.9</li>
<li><a href="93bade2a71"><code>93bade2</code></a> Update <code>core-js@3</code> packages (<a href="https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env/issues/13621">#13621</a>)</li>
<li>See full diff in <a href="https://github.com/babel/babel/commits/v7.14.9/packages/babel-preset-env">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=@babel/preset-env&package-manager=npm_and_yarn&previous-version=7.14.8&new-version=7.14.9)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/2659

Reviewed By: passy

Differential Revision: D30044650

Pulled By: cekkaewnumchai

fbshipit-source-id: fb6c02ff3a710e76b91cbb11ab46159a17b73496
2021-08-02 14:08:04 -07:00
dependabot[bot]
533fd7e39e Bump @babel/traverse from 7.14.8 to 7.14.9 in /desktop (#2657)
Summary:
Bumps [babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.14.8 to 7.14.9.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/babel/babel/releases"><code>@​babel/traverse</code>'s releases</a>.</em></p>
<blockquote>
<h2>v7.14.9 (2021-08-01)</h2>
<p>Thanks <a href="https://github.com/SCLeoX"><code>@​SCLeoX</code></a> for your first PR!</p>
<h4>🐛 Bug Fix</h4>
<ul>
<li><code>babel-traverse</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13596">#13596</a> Fix completion record for variable declarations (<a href="https://github.com/addaleax"><code>@​addaleax</code></a>)</li>
</ul>
</li>
<li><code>babel-plugin-proposal-class-properties</code>, <code>babel-plugin-transform-classes</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13600">#13600</a> Extract computed keys from the class closure (<a href="https://github.com/nicolo-ribaudo"><code>@​nicolo-ribaudo</code></a>)</li>
</ul>
</li>
<li><code>babel-plugin-transform-react-jsx-development</code>, <code>babel-plugin-transform-react-jsx-self</code>, <code>babel-plugin-transform-react-jsx</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13552">#13552</a> Don't insert <code>__self: this</code> within constructors of derived classes (<a href="https://github.com/babel/babel/tree/HEAD/packages/babel-traverse/issues/13550">#13550</a>) (<a href="https://github.com/SCLeoX"><code>@​SCLeoX</code></a>)</li>
</ul>
</li>
<li><code>babel-parser</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13581">#13581</a> [ts] Check if param is assignable when parsing arrow return type (<a href="https://github.com/nicolo-ribaudo"><code>@​nicolo-ribaudo</code></a>)</li>
</ul>
</li>
<li><code>babel-generator</code>, <code>babel-traverse</code>, <code>babel-types</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13577">#13577</a> add 12 missing NODE_FIELDS (<a href="https://github.com/jedwards1211"><code>@​jedwards1211</code></a>)</li>
</ul>
</li>
<li><code>babel-plugin-proposal-async-generator-functions</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13491">#13491</a> Fix <code>_step.value</code> access in <code>for await</code> (<a href="https://github.com/nicolo-ribaudo"><code>@​nicolo-ribaudo</code></a>)</li>
</ul>
</li>
</ul>
<h4>🏠 Internal</h4>
<ul>
<li>Other
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13614">#13614</a> Update Rollup to <code>~2.54.0</code> (<a href="https://github.com/nicolo-ribaudo"><code>@​nicolo-ribaudo</code></a>)</li>
</ul>
</li>
<li><code>babel-generator</code>, <code>babel-helper-validator-identifier</code>, <code>babel-parser</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13606">#13606</a> chore: reorganize benchmarks (<a href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
</ul>
</li>
</ul>
<h4>🏃‍♀️ Performance</h4>
<ul>
<li><code>babel-parser</code>, <code>babel-traverse</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13611">#13611</a> Replace generic __clone call by specific methods (<a href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
</ul>
</li>
<li><code>babel-generator</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13593">#13593</a> Generator performance (<a href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
</ul>
</li>
</ul>
<h4>Committers: 8</h4>
<ul>
<li>Andy Edwards (<a href="https://github.com/jedwards1211"><code>@​jedwards1211</code></a>)</li>
<li>Anna Henningsen (<a href="https://github.com/addaleax"><code>@​addaleax</code></a>)</li>
<li>Babel Bot (<a href="https://github.com/babel-bot"><code>@​babel-bot</code></a>)</li>
<li>Henry Zhu (<a href="https://github.com/hzoo"><code>@​hzoo</code></a>)</li>
<li>Huáng Jùnliàng (<a href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
<li>Nicolò Ribaudo (<a href="https://github.com/nicolo-ribaudo"><code>@​nicolo-ribaudo</code></a>)</li>
<li>Rin Tepis (<a href="https://github.com/SCLeoX"><code>@​SCLeoX</code></a>)</li>
<li>王清雨 (<a href="https://github.com/colinaaa"><code>@​colinaaa</code></a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/babel/babel/blob/main/CHANGELOG.md"><code>@​babel/traverse</code>'s changelog</a>.</em></p>
<blockquote>
<h2>v7.14.9 (2021-08-01)</h2>
<h4>🐛 Bug Fix</h4>
<ul>
<li><code>babel-traverse</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13596">#13596</a> Fix completion record for variable declarations (<a href="https://github.com/addaleax"><code>@​addaleax</code></a>)</li>
</ul>
</li>
<li><code>babel-plugin-proposal-class-properties</code>, <code>babel-plugin-transform-classes</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13600">#13600</a> Extract computed keys from the class closure (<a href="https://github.com/nicolo-ribaudo"><code>@​nicolo-ribaudo</code></a>)</li>
</ul>
</li>
<li><code>babel-plugin-transform-react-jsx-development</code>, <code>babel-plugin-transform-react-jsx-self</code>, <code>babel-plugin-transform-react-jsx</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13552">#13552</a> Don't insert <code>__self: this</code> within constructors of derived classes (<a href="https://github.com/babel/babel/tree/HEAD/packages/babel-traverse/issues/13550">#13550</a>) (<a href="https://github.com/SCLeoX"><code>@​SCLeoX</code></a>)</li>
</ul>
</li>
<li><code>babel-parser</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13581">#13581</a> [ts] Check if param is assignable when parsing arrow return type (<a href="https://github.com/nicolo-ribaudo"><code>@​nicolo-ribaudo</code></a>)</li>
</ul>
</li>
<li><code>babel-generator</code>, <code>babel-traverse</code>, <code>babel-types</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13577">#13577</a> add 12 missing NODE_FIELDS (<a href="https://github.com/jedwards1211"><code>@​jedwards1211</code></a>)</li>
</ul>
</li>
<li><code>babel-plugin-proposal-async-generator-functions</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13491">#13491</a> Fix <code>_step.value</code> access in <code>for await</code> (<a href="https://github.com/nicolo-ribaudo"><code>@​nicolo-ribaudo</code></a>)</li>
</ul>
</li>
</ul>
<h4>🏠 Internal</h4>
<ul>
<li>Other
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13614">#13614</a> Update Rollup to <code>~2.54.0</code> (<a href="https://github.com/nicolo-ribaudo"><code>@​nicolo-ribaudo</code></a>)</li>
</ul>
</li>
<li><code>babel-generator</code>, <code>babel-helper-validator-identifier</code>, <code>babel-parser</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13606">#13606</a> chore: reorganize benchmarks (<a href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
</ul>
</li>
</ul>
<h4>🏃‍♀️ Performance</h4>
<ul>
<li><code>babel-parser</code>, <code>babel-traverse</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13611">#13611</a> Replace generic __clone call by specific methods (<a href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
</ul>
</li>
<li><code>babel-generator</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13593">#13593</a> Generator performance (<a href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
</ul>
</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="aa2cac5edc"><code>aa2cac5</code></a> v7.14.9</li>
<li><a href="d3a7cd5e8d"><code>d3a7cd5</code></a> Replace generic <code>__clone</code> call by specific methods (<a href="https://github.com/babel/babel/tree/HEAD/packages/babel-traverse/issues/13611">#13611</a>)</li>
<li><a href="d45ad500e7"><code>d45ad50</code></a> Improve <code>path.get</code> typings with TS template literal types (<a href="https://github.com/babel/babel/tree/HEAD/packages/babel-traverse/issues/13588">#13588</a>)</li>
<li><a href="d1f908924c"><code>d1f9089</code></a> Fix completion record for variable declarations (<a href="https://github.com/babel/babel/tree/HEAD/packages/babel-traverse/issues/13596">#13596</a>)</li>
<li><a href="e0dc925bbe"><code>e0dc925</code></a> feat(traverse): specific return type for virtual types' validators (<a href="https://github.com/babel/babel/tree/HEAD/packages/babel-traverse/issues/13578">#13578</a>)</li>
<li><a href="1d48bb0d8c"><code>1d48bb0</code></a> add 12 missing NODE_FIELDS (<a href="https://github.com/babel/babel/tree/HEAD/packages/babel-traverse/issues/13577">#13577</a>)</li>
<li>See full diff in <a href="https://github.com/babel/babel/commits/v7.14.9/packages/babel-traverse">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=@babel/traverse&package-manager=npm_and_yarn&previous-version=7.14.8&new-version=7.14.9)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/2657

Reviewed By: passy

Differential Revision: D30044695

Pulled By: cekkaewnumchai

fbshipit-source-id: f724c61e1da92afdf39d0b72f3544ee201c658ec
2021-08-02 14:08:04 -07:00
dependabot[bot]
2dd914b648 Bump @babel/generator from 7.14.5 to 7.14.9 in /desktop (#2661)
Summary:
Bumps [babel/generator](https://github.com/babel/babel/tree/HEAD/packages/babel-generator) from 7.14.5 to 7.14.9.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/babel/babel/releases"><code>@​babel/generator</code>'s releases</a>.</em></p>
<blockquote>
<h2>v7.14.9 (2021-08-01)</h2>
<p>Thanks <a href="https://github.com/SCLeoX"><code>@​SCLeoX</code></a> for your first PR!</p>
<h4>🐛 Bug Fix</h4>
<ul>
<li><code>babel-traverse</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13596">#13596</a> Fix completion record for variable declarations (<a href="https://github.com/addaleax"><code>@​addaleax</code></a>)</li>
</ul>
</li>
<li><code>babel-plugin-proposal-class-properties</code>, <code>babel-plugin-transform-classes</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13600">#13600</a> Extract computed keys from the class closure (<a href="https://github.com/nicolo-ribaudo"><code>@​nicolo-ribaudo</code></a>)</li>
</ul>
</li>
<li><code>babel-plugin-transform-react-jsx-development</code>, <code>babel-plugin-transform-react-jsx-self</code>, <code>babel-plugin-transform-react-jsx</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13552">#13552</a> Don't insert <code>__self: this</code> within constructors of derived classes (<a href="https://github.com/babel/babel/tree/HEAD/packages/babel-generator/issues/13550">#13550</a>) (<a href="https://github.com/SCLeoX"><code>@​SCLeoX</code></a>)</li>
</ul>
</li>
<li><code>babel-parser</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13581">#13581</a> [ts] Check if param is assignable when parsing arrow return type (<a href="https://github.com/nicolo-ribaudo"><code>@​nicolo-ribaudo</code></a>)</li>
</ul>
</li>
<li><code>babel-generator</code>, <code>babel-traverse</code>, <code>babel-types</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13577">#13577</a> add 12 missing NODE_FIELDS (<a href="https://github.com/jedwards1211"><code>@​jedwards1211</code></a>)</li>
</ul>
</li>
<li><code>babel-plugin-proposal-async-generator-functions</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13491">#13491</a> Fix <code>_step.value</code> access in <code>for await</code> (<a href="https://github.com/nicolo-ribaudo"><code>@​nicolo-ribaudo</code></a>)</li>
</ul>
</li>
</ul>
<h4>🏠 Internal</h4>
<ul>
<li>Other
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13614">#13614</a> Update Rollup to <code>~2.54.0</code> (<a href="https://github.com/nicolo-ribaudo"><code>@​nicolo-ribaudo</code></a>)</li>
</ul>
</li>
<li><code>babel-generator</code>, <code>babel-helper-validator-identifier</code>, <code>babel-parser</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13606">#13606</a> chore: reorganize benchmarks (<a href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
</ul>
</li>
</ul>
<h4>🏃‍♀️ Performance</h4>
<ul>
<li><code>babel-parser</code>, <code>babel-traverse</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13611">#13611</a> Replace generic __clone call by specific methods (<a href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
</ul>
</li>
<li><code>babel-generator</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13593">#13593</a> Generator performance (<a href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
</ul>
</li>
</ul>
<h4>Committers: 8</h4>
<ul>
<li>Andy Edwards (<a href="https://github.com/jedwards1211"><code>@​jedwards1211</code></a>)</li>
<li>Anna Henningsen (<a href="https://github.com/addaleax"><code>@​addaleax</code></a>)</li>
<li>Babel Bot (<a href="https://github.com/babel-bot"><code>@​babel-bot</code></a>)</li>
<li>Henry Zhu (<a href="https://github.com/hzoo"><code>@​hzoo</code></a>)</li>
<li>Huáng Jùnliàng (<a href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
<li>Nicolò Ribaudo (<a href="https://github.com/nicolo-ribaudo"><code>@​nicolo-ribaudo</code></a>)</li>
<li>Rin Tepis (<a href="https://github.com/SCLeoX"><code>@​SCLeoX</code></a>)</li>
<li>王清雨 (<a href="https://github.com/colinaaa"><code>@​colinaaa</code></a>)</li>
</ul>
<h2>v7.14.8 (2021-07-20)</h2>
<p>Thanks <a href="https://github.com/colinaaa"><code>@​colinaaa</code></a>, <a href="https://github.com/jaeseokk"><code>@​jaeseokk</code></a> and <a href="https://github.com/nme077"><code>@​nme077</code></a> for your first PRs!</p>
<h4>👓 Spec Compliance</h4>
<ul>
<li><code>babel-helper-create-class-features-plugin</code>, <code>babel-plugin-proposal-class-static-block</code>, <code>babel-plugin-transform-new-target</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13560">#13560</a> fix(class-properties): replace <code>new.target</code> in static properties with <code>undefined</code> (<a href="https://github.com/colinaaa"><code>@​colinaaa</code></a>)</li>
</ul>
</li>
<li><code>babel-parser</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13088">#13088</a> Fix await binding error within static block (<a href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13531">#13531</a> fix: disallow computed <code>async</code>/<code>get</code>/<code>set</code> keyword (<a href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
</ul>
</li>
</ul>

</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/babel/babel/blob/main/CHANGELOG.md"><code>@​babel/generator</code>'s changelog</a>.</em></p>
<blockquote>
<h2>v7.14.9 (2021-08-01)</h2>
<h4>🐛 Bug Fix</h4>
<ul>
<li><code>babel-traverse</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13596">#13596</a> Fix completion record for variable declarations (<a href="https://github.com/addaleax"><code>@​addaleax</code></a>)</li>
</ul>
</li>
<li><code>babel-plugin-proposal-class-properties</code>, <code>babel-plugin-transform-classes</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13600">#13600</a> Extract computed keys from the class closure (<a href="https://github.com/nicolo-ribaudo"><code>@​nicolo-ribaudo</code></a>)</li>
</ul>
</li>
<li><code>babel-plugin-transform-react-jsx-development</code>, <code>babel-plugin-transform-react-jsx-self</code>, <code>babel-plugin-transform-react-jsx</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13552">#13552</a> Don't insert <code>__self: this</code> within constructors of derived classes (<a href="https://github.com/babel/babel/tree/HEAD/packages/babel-generator/issues/13550">#13550</a>) (<a href="https://github.com/SCLeoX"><code>@​SCLeoX</code></a>)</li>
</ul>
</li>
<li><code>babel-parser</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13581">#13581</a> [ts] Check if param is assignable when parsing arrow return type (<a href="https://github.com/nicolo-ribaudo"><code>@​nicolo-ribaudo</code></a>)</li>
</ul>
</li>
<li><code>babel-generator</code>, <code>babel-traverse</code>, <code>babel-types</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13577">#13577</a> add 12 missing NODE_FIELDS (<a href="https://github.com/jedwards1211"><code>@​jedwards1211</code></a>)</li>
</ul>
</li>
<li><code>babel-plugin-proposal-async-generator-functions</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13491">#13491</a> Fix <code>_step.value</code> access in <code>for await</code> (<a href="https://github.com/nicolo-ribaudo"><code>@​nicolo-ribaudo</code></a>)</li>
</ul>
</li>
</ul>
<h4>🏠 Internal</h4>
<ul>
<li>Other
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13614">#13614</a> Update Rollup to <code>~2.54.0</code> (<a href="https://github.com/nicolo-ribaudo"><code>@​nicolo-ribaudo</code></a>)</li>
</ul>
</li>
<li><code>babel-generator</code>, <code>babel-helper-validator-identifier</code>, <code>babel-parser</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13606">#13606</a> chore: reorganize benchmarks (<a href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
</ul>
</li>
</ul>
<h4>🏃‍♀️ Performance</h4>
<ul>
<li><code>babel-parser</code>, <code>babel-traverse</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13611">#13611</a> Replace generic __clone call by specific methods (<a href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
</ul>
</li>
<li><code>babel-generator</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13593">#13593</a> Generator performance (<a href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
</ul>
</li>
</ul>
<h2>v7.14.8 (2021-07-20)</h2>
<h4>👓 Spec Compliance</h4>
<ul>
<li><code>babel-helper-create-class-features-plugin</code>, <code>babel-plugin-proposal-class-static-block</code>, <code>babel-plugin-transform-new-target</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13560">#13560</a> fix(class-properties): replace <code>new.target</code> in static properties with <code>undefined</code> (<a href="https://github.com/colinaaa"><code>@​colinaaa</code></a>)</li>
</ul>
</li>
<li><code>babel-parser</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13088">#13088</a> Fix await binding error within static block (<a href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13531">#13531</a> fix: disallow computed <code>async</code>/<code>get</code>/<code>set</code> keyword (<a href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
</ul>
</li>
<li><code>babel-helper-module-transforms</code>, <code>babel-helper-simple-access</code>, <code>babel-plugin-transform-modules-commonjs</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13258">#13258</a> Fix const violations in ESM imports when transformed to CJS (<a href="https://github.com/overlookmotel"><code>@​overlookmotel</code></a>)</li>
</ul>
</li>
</ul>
<h4>🐛 Bug Fix</h4>
<ul>
<li><code>babel-parser</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13575">#13575</a> Update babel-parser.d.ts (<a href="https://github.com/sosukesuzuki"><code>@​sosukesuzuki</code></a>)</li>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13548">#13548</a> Fix  parser <code>strictMode</code> option (<a href="https://github.com/overlookmotel"><code>@​overlookmotel</code></a>)</li>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13573">#13573</a> Fix issue to allow module block in member expression (<a href="https://github.com/nme077"><code>@​nme077</code></a>)</li>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13521">#13521</a> Overhaul comment attachment (<a href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13534">#13534</a> Async do expression should start at async (<a href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
</ul>
</li>
<li><code>babel-plugin-transform-arrow-functions</code>, <code>babel-traverse</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/12344">#12344</a> Fix arrow transformation when <code>arguments</code> is defined as variable (<a href="https://github.com/snitin315"><code>@​snitin315</code></a>)</li>
</ul>
</li>
<li><code>babel-traverse</code>
<ul>
<li><a href="https://github-redirect.dependabot.com/babel/babel/pull/13527">#13527</a> fix: accept duplicated import/variable in different module (<a href="https://github.com/colinaaa"><code>@​colinaaa</code></a>)</li>
</ul>
</li>
<li><code>babel-types</code></li>
</ul>

</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="aa2cac5edc"><code>aa2cac5</code></a> v7.14.9</li>
<li><a href="e4de256cdd"><code>e4de256</code></a> chore: reorganize benchmarks (<a href="https://github.com/babel/babel/tree/HEAD/packages/babel-generator/issues/13606">#13606</a>)</li>
<li><a href="1d48bb0d8c"><code>1d48bb0</code></a> add 12 missing NODE_FIELDS (<a href="https://github.com/babel/babel/tree/HEAD/packages/babel-generator/issues/13577">#13577</a>)</li>
<li><a href="03e8476b27"><code>03e8476</code></a> Generator performance (<a href="https://github.com/babel/babel/tree/HEAD/packages/babel-generator/issues/13593">#13593</a>)</li>
<li><a href="e591780244"><code>e591780</code></a> v7.14.8</li>
<li><a href="9bad558d13"><code>9bad558</code></a> [babel 8] Use an identifier for <code>TSTypeParameter.name</code> (<a href="https://github.com/babel/babel/tree/HEAD/packages/babel-generator/issues/12829">#12829</a>)</li>
<li>See full diff in <a href="https://github.com/babel/babel/commits/v7.14.9/packages/babel-generator">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=@babel/generator&package-manager=npm_and_yarn&previous-version=7.14.5&new-version=7.14.9)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/2661

Reviewed By: passy

Differential Revision: D30044639

Pulled By: cekkaewnumchai

fbshipit-source-id: 402ed864952611a88409659d59d179ad04cf39ef
2021-08-02 14:08:04 -07:00
dependabot[bot]
e87675af86 Bump serde from 1.0.126 to 1.0.127 in /packer (#2653)
Summary:
Bumps [serde](https://github.com/serde-rs/serde) from 1.0.126 to 1.0.127.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/serde-rs/serde/releases">serde's releases</a>.</em></p>
<blockquote>
<h2>v1.0.127</h2>
<ul>
<li>Resolve warning in rustc nightly-2021-07-31+ compiling serde_test</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="e2f85681fe"><code>e2f8568</code></a> Release 1.0.127</li>
<li><a href="8b840c3030"><code>8b840c3</code></a> Resolve semicolon_in_expressions_from_macros warning in serde_test</li>
<li><a href="9c39115f82"><code>9c39115</code></a> Ignore buggy nonstandard_macro_braces clippy lint</li>
<li><a href="89342af71e"><code>89342af</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/serde-rs/serde/issues/2047">https://github.com/facebook/flipper/issues/2047</a> from jsoref/spelling</li>
<li><a href="3c5e2d11f6"><code>3c5e2d1</code></a> spelling: implicitly</li>
<li><a href="3805c037a8"><code>3805c03</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/serde-rs/serde/issues/2040">https://github.com/facebook/flipper/issues/2040</a> from dtolnay/test</li>
<li><a href="7045fee260"><code>7045fee</code></a> Fix outdated test instructions in CONTRIBUTING.md</li>
<li><a href="9d81532e41"><code>9d81532</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/serde-rs/serde/issues/2039">https://github.com/facebook/flipper/issues/2039</a> from dtolnay/test</li>
<li><a href="5e47432ef0"><code>5e47432</code></a> Update documented test command for the serde directory</li>
<li><a href="7b840897a9"><code>7b84089</code></a> Resolve needless_borrow clippy lints</li>
<li>Additional commits viewable in <a href="https://github.com/serde-rs/serde/compare/v1.0.126...v1.0.127">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=serde&package-manager=cargo&previous-version=1.0.126&new-version=1.0.127)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/2653

Reviewed By: passy

Differential Revision: D30044701

Pulled By: cekkaewnumchai

fbshipit-source-id: fc1583c22eb7cdb2727d8b88d47a80394de6e339
2021-08-02 14:04:30 -07:00
Ananya Arun
19f6b29879 Remove cyclic dependancy on components
Summary:
- Minor change on Diff - D30040808
- Removed cyclic dependancy on AppSelector
- Previous dependancy chain : AppSelector -> TroubleshootingGuide -> AppSelector
- Now the NoDevices component that troubleshooting guide was importing has been moved to an independent file.

Reviewed By: passy

Differential Revision: D30041820

fbshipit-source-id: 17856aad7d2a569ec4e0f19e63f458472b22dcf8
2021-08-02 09:43:03 -07:00
Ananya Arun
921a65bc17 Add troubleshooting button and a GK
Summary:
- Added a troubleshooting guide button which on clicking will open the expert chat bot system of flipper. ( Will be implemented in future diffs)
- This has been added only in the internal version of flipper available to FB.
- The public version shall continue to link to the troubleshooting guide for now.
- Also a new gatekeeper flipper_self_sufficiency was set up.
- This currently gives access to ongoing changes only to a few team members.
- In the future access shall be extended to the entire team, followed by the entire org and then finally all internal FB users in the final stages of the project.

Reviewed By: passy

Differential Revision: D29993355

fbshipit-source-id: afdb76baef6fde2c785c50ad6530ea2f76ce7284
2021-08-02 09:16:48 -07:00
dependabot[bot]
210fc36460 Bump eslint-plugin-flowtype from 5.7.2 to 5.8.2 in /flipper-js-client-sdk (#2634)
Summary:
Bumps [eslint-plugin-flowtype](https://github.com/gajus/eslint-plugin-flowtype) from 5.7.2 to 5.8.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/gajus/eslint-plugin-flowtype/releases">eslint-plugin-flowtype's releases</a>.</em></p>
<blockquote>
<h2>v5.8.2</h2>
<h2><a href="https://github.com/gajus/eslint-plugin-flowtype/compare/v5.8.1...v5.8.2">5.8.2</a> (2021-07-26)</h2>
<h3>Bug Fixes</h3>
<ul>
<li>enforceLineBreak now handles <code>export type</code> correctly (<a href="https://github-redirect.dependabot.com/gajus/eslint-plugin-flowtype/issues/488">https://github.com/facebook/flipper/issues/488</a>) (<a href="c40937a4da">c40937a</a>)</li>
</ul>
<h2>v5.8.1</h2>
<h2><a href="https://github.com/gajus/eslint-plugin-flowtype/compare/v5.8.0...v5.8.1">5.8.1</a> (2021-07-22)</h2>
<h3>Bug Fixes</h3>
<ul>
<li>support CRLF line breaks in generic-spacing (<a href="https://github-redirect.dependabot.com/gajus/eslint-plugin-flowtype/issues/485">https://github.com/facebook/flipper/issues/485</a>) (<a href="https://github-redirect.dependabot.com/gajus/eslint-plugin-flowtype/issues/486">https://github.com/facebook/flipper/issues/486</a>) (<a href="79267bb466">79267bb</a>)</li>
</ul>
<h2>v5.8.0</h2>
<h1><a href="https://github.com/gajus/eslint-plugin-flowtype/compare/v5.7.2...v5.8.0">5.8.0</a> (2021-06-29)</h1>
<h3>Features</h3>
<ul>
<li>add new rule enforce-line-break (<a href="https://github-redirect.dependabot.com/gajus/eslint-plugin-flowtype/issues/484">https://github.com/facebook/flipper/issues/484</a>) (<a href="417068cb33">417068c</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="c40937a4da"><code>c40937a</code></a> fix: enforceLineBreak now handles <code>export type</code> correctly (<a href="https://github-redirect.dependabot.com/gajus/eslint-plugin-flowtype/issues/488">https://github.com/facebook/flipper/issues/488</a>)</li>
<li><a href="79267bb466"><code>79267bb</code></a> fix: support CRLF line breaks in generic-spacing (<a href="https://github-redirect.dependabot.com/gajus/eslint-plugin-flowtype/issues/485">https://github.com/facebook/flipper/issues/485</a>) (<a href="https://github-redirect.dependabot.com/gajus/eslint-plugin-flowtype/issues/486">https://github.com/facebook/flipper/issues/486</a>)</li>
<li><a href="417068cb33"><code>417068c</code></a> feat: add new rule enforce-line-break (<a href="https://github-redirect.dependabot.com/gajus/eslint-plugin-flowtype/issues/484">https://github.com/facebook/flipper/issues/484</a>)</li>
<li>See full diff in <a href="https://github.com/gajus/eslint-plugin-flowtype/compare/v5.7.2...v5.8.2">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=eslint-plugin-flowtype&package-manager=npm_and_yarn&previous-version=5.7.2&new-version=5.8.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/2634

Reviewed By: timur-valiev

Differential Revision: D30012642

Pulled By: passy

fbshipit-source-id: af4619da5a71ff7345ef9d13c3f9984aa036764d
2021-08-02 09:02:59 -07:00
Pascal Hartig
754100d9ed Revert D30012637: Bump antd from 4.16.8 to 4.16.9 in /desktop
Differential Revision:
D30012637 (069af92d12)

Original commit changeset: 5ebdb3f8bb6c

fbshipit-source-id: ac7c1f165ae401fdbaa66c1746fefe1ae634c323
2021-08-02 08:34:08 -07:00