f13f7529d3425f77411479d5059a3874b0850c5c
6594 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
facebook-flipper-bot
|
f13f7529d3 |
Automated: Update Podfile.lock (#3393)
Summary: This is an automated PR to update the Podfile.lock. - Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions. - Also make sure that all the dependencies are updated to the latest one. - This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request) Pull Request resolved: https://github.com/facebook/flipper/pull/3393 Test Plan: Imported from GitHub, without a `Test Plan:` line. **Static Docs Preview: flipper** |[Full Site](https://our.intern.facebook.com/intern/staticdocs/eph/D33975290/V2/flipper/)| |**Modified Pages**| |[docs/getting-started/ios-native](https://our.intern.facebook.com/intern/staticdocs/eph/D33975290/V2/flipper/docs/getting-started/ios-native/)| Reviewed By: aigoncharov Differential Revision: D33975290 Pulled By: mweststrate fbshipit-source-id: fd5b2e06011f53f292b3124021b6d52dc4adc23e |
||
Bartosz Kaszubowski
|
6639b547dd |
UI: fix hover effect of LeftRail icons with badge (#3372)
Summary: This PR fixes the missing hover effect for the `LeftRail` component buttons, when they have included the badge. To fix the issue, I had to wrap the whole `Button` with `Badge` component (instead wrapping only around icon). However, this solution required to added `offset` property to the `Badge` which moves the indicator to the position prior change (otherwise indicator was moved to the right corner of the button). The file has been formatted after the changes with ESLint. **Edit:** I have also spotted that this change fixes the icon placement inside the button, when badge is present. Earlier, as seen below, the log icon was moved towards the top of the button: <img width="111" alt="Screenshot 2022-01-31 at 00 57 49" src="https://user-images.githubusercontent.com/719641/151723422-0ffb83ee-5806-412e-9191-f9953f78532e.png"> ## Changelog [desktop] UI: fix hover effect of LeftRail icons with badge Pull Request resolved: https://github.com/facebook/flipper/pull/3372 Test Plan: The change has been testes by running the desktop Flipper app locally from source. ## Preview (before & after) #### Before <img width="1339" alt="Screenshot 2022-01-31 at 00 24 23" src="https://user-images.githubusercontent.com/719641/151722800-a2f3dd44-aa24-4858-b43e-0620b1f2ae65.png"> #### After > I have used mocked indicator values locally to ensure that the Badges are displayed correctly. <img width="1339" alt="Screenshot 2022-01-31 at 00 26 10" src="https://user-images.githubusercontent.com/719641/151722795-745b04ac-9ee4-49a8-8217-206d8d7456e6.png"> <img width="1339" alt="Screenshot 2022-01-31 at 00 45 08" src="https://user-images.githubusercontent.com/719641/151722940-aaaf0e9b-f2d1-4245-8b2b-cfc11052b39e.png"> Reviewed By: aigoncharov Differential Revision: D33975324 Pulled By: mweststrate fbshipit-source-id: fe4773b4825b9f22e01821e45259747d319233aa |
||
Michel Weststrate
|
a31494f321 |
Fix unnecessary 'still authorizing' error
Summary: When connection to Android, I always get an error popup with 'device still authorizing', which disappears itself and the device connects fine. It seems that this was a case we handled gracefully before, but the error message we check for has changed. Also updated the log message so that we get it in our monitoring I don't silently get stuck in this state. Changelog: Fixed 'device still authorizing' errors showing up while connecting to an Android device Reviewed By: aigoncharov Differential Revision: D33976028 fbshipit-source-id: dbb055bbbd43bad129b10ffee4a8dbb50be8e87a |
||
|
Michel Weststrate
|
ccea9058ef |
Fix build failure on OSS master (#3394)
Summary: Pull Request resolved: https://github.com/facebook/flipper/pull/3394 This diff caused OSS builds failing due to a FB plugin that requires emotion, instead of using it as peer dep. This introduced a duplicate dep, which doesn't get installed in OSS, causing patch-package for that package to fail. Changed it to a peer dep and removed the patch. Reviewed By: aigoncharov Differential Revision: D33975202 fbshipit-source-id: 1e82964988e944a28ecb46a10127ad9e13f743f7 |
||
Andrey Goncharov
|
7376774a95 |
Add RSocket deprecation warning
Reviewed By: lblasa Differential Revision: D33976369 fbshipit-source-id: c100c145d7c77369347200d32448015ad971d585 |
||
Harold Martin
|
cdb72db5a9 |
Fix LeakCanary plugin UI, Upgrade LC dependency and make it compile only (#3367)
Summary: **Currently, the Leak Canary plugins is broken, see this screenshot (unable to expand):** <img width="1359" alt="Screen Shot 2022-01-29 at 2 06 33 PM" src="https://user-images.githubusercontent.com/745166/151679662-9d8e8eb6-c19c-4008-9821-1c2c1af92351.png"> **This fix repairs and improves the UI:** <img width="1350" alt="Screen Shot 2022-01-29 at 2 06 03 PM" src="https://user-images.githubusercontent.com/745166/151679677-7965604c-dd04-4ee5-bc8e-d53a82da1bd7.png"> ## Changelog - Fixes UI to enable showing leak trace - Upgrades LackCanary dependency from 2.6 to 2.8.1 - Makes Kotlin and LC `compileOnly` dependencies in order to prevent conflict for the users - Updates documentation Pull Request resolved: https://github.com/facebook/flipper/pull/3367 Test Plan: See demo at https://github.com/hbmartin/leakcanary/tree/flipper-demo/leakcanary-android-sample **Static Docs Preview: flipper** |[Full Site](https://our.intern.facebook.com/intern/staticdocs/eph/D33915179/V3/flipper/)| |**Modified Pages**| Reviewed By: passy Differential Revision: D33915179 Pulled By: cekkaewnumchai fbshipit-source-id: 9698dba23ab475c8cd84e4c222dfc41712b05a1e |
||
dependabot[bot]
|
6bd134d624 |
Bump eslint from 8.7.0 to 8.8.0 in /js/js-flipper (#3385)
Summary: Bumps [eslint](https://github.com/eslint/eslint) from 8.7.0 to 8.8.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/eslint/eslint/releases">eslint's releases</a>.</em></p> <blockquote> <h2>v8.8.0</h2> <h2>Features</h2> <ul> <li><a href=" |
||
|
dependabot[bot]
|
e8571f5a73 |
Bump @typescript-eslint/parser from 5.10.0 to 5.10.1 in /js/js-flipper (#3387)
Summary:
Bumps [typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 5.10.0 to 5.10.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/releases"><code>@typescript-eslint/parser</code>'s releases</a>.</em></p>
<blockquote>
<h2>v5.10.1</h2>
<h2><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v5.10.0...v5.10.1">5.10.1</a> (2022-01-24)</h2>
<p><strong>Note:</strong> Version bump only for package <code>@typescript-eslint/typescript-eslint</code></p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md"><code>@typescript-eslint/parser</code>'s changelog</a>.</em></p>
<blockquote>
<h2><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v5.10.0...v5.10.1">5.10.1</a> (2022-01-24)</h2>
<p><strong>Note:</strong> Version bump only for package <code>@typescript-eslint/parser</code></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="
|
||
|
dependabot[bot]
|
9e41c7ff57 |
Bump @typescript-eslint/eslint-plugin from 5.10.0 to 5.10.1 in /js/js-flipper (#3386)
Summary:
Bumps [typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 5.10.0 to 5.10.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/releases"><code>@typescript-eslint/eslint-plugin</code>'s releases</a>.</em></p>
<blockquote>
<h2>v5.10.1</h2>
<h2><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v5.10.0...v5.10.1">5.10.1</a> (2022-01-24)</h2>
<p><strong>Note:</strong> Version bump only for package <code>@typescript-eslint/typescript-eslint</code></p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md"><code>@typescript-eslint/eslint-plugin</code>'s changelog</a>.</em></p>
<blockquote>
<h2><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v5.10.0...v5.10.1">5.10.1</a> (2022-01-24)</h2>
<p><strong>Note:</strong> Version bump only for package <code>@typescript-eslint/eslint-plugin</code></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="
|
||
|
dependabot[bot]
|
eb4ececb9f |
Bump typescript from 4.5.4 to 4.5.5 in /desktop (#3375)
Summary: Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.5.4 to 4.5.5. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/Microsoft/TypeScript/releases">typescript's releases</a>.</em></p> <blockquote> <h2>TypeScript 4.5.5</h2> <p>This <a href="https://github.com/microsoft/TypeScript/issues?q=is%3Aissue+milestone%3A%22TypeScript+4.5.5%22+is%3Aclosed">patch release</a> includes a number of fixes to language service crashes and assertion violations, along with improvements to JSX attribute snippets.</p> <p>For the complete list of fixed issues, check out the</p> <ul> <li><a href="https://github.com/microsoft/TypeScript/issues?q=milestone%3A%22TypeScript+4.5.0%22+">fixed issues query for Typescript 4.5.0 (Beta)</a>.</li> <li><a href="https://github.com/microsoft/TypeScript/issues?q=milestone%3A%22TypeScript+4.5.1%22+">fixed issues query for Typescript 4.5.1 (RC)</a>.</li> <li><a href="https://github.com/microsoft/TypeScript/issues?q=milestone%3A%22TypeScript+4.5.2%22+">fixed issues query for Typescript 4.5.2 (Stable)</a>.</li> <li><a href="https://github.com/microsoft/TypeScript/issues?q=milestone%3A%22TypeScript+4.5.3%22+">fixed issues query for Typescript 4.5.3 (Stable)</a>.</li> <li><a href="https://github.com/microsoft/TypeScript/issues?q=milestone%3A%22TypeScript+4.5.4%22+">fixed issues query for Typescript 4.5.4 (Stable)</a>.</li> <li><a href="https://github.com/microsoft/TypeScript/issues?q=milestone%3A%22TypeScript+4.5.5%22+">fixed issues query for Typescript 4.5.5 (Stable)</a>.</li> </ul> <p>Downloads are available on:</p> <ul> <li><a href="https://www.npmjs.com/package/typescript">npm</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
dependabot[bot]
|
5253d0750e |
Bump @typescript-eslint/experimental-utils from 5.9.1 to 5.10.1 in /desktop (#3380)
Summary: Bumps [typescript-eslint/experimental-utils](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/experimental-utils) from 5.9.1 to 5.10.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/releases"><code>@typescript-eslint/experimental-utils</code>'s releases</a>.</em></p> <blockquote> <h2>v5.10.1</h2> <h2><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v5.10.0...v5.10.1">5.10.1</a> (2022-01-24)</h2> <p><strong>Note:</strong> Version bump only for package <code>@typescript-eslint/typescript-eslint</code></p> <h2>v5.10.0</h2> <h1><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v5.9.1...v5.10.0">5.10.0</a> (2022-01-17)</h1> <h3>Bug Fixes</h3> <ul> <li><strong>eslint-plugin:</strong> [explicit-function-return-type] support AllowTypedFunctionExpression within AllowHigherOrderFunction (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/4250">#4250</a>) (<a href=" |
||
|
dependabot[bot]
|
1f41f1dc2d |
Bump @adobe/node-fetch-retry from 2.0.0 to 2.1.0 in /desktop (#3384)
Summary: Bumps [adobe/node-fetch-retry](https://github.com/adobe/node-fetch-retry) from 2.0.0 to 2.1.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/adobe/node-fetch-retry/releases"><code>@adobe/node-fetch-retry</code>'s releases</a>.</em></p> <blockquote> <h2>v2.1.0</h2> <h1><a href="https://github.com/adobe/node-fetch-retry/compare/v2.0.0...v2.1.0">2.1.0</a> (2022-01-24)</h1> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
dependabot[bot]
|
a0ec82c981 |
Bump @emotion/react from 11.6.0 to 11.7.1 in /desktop (#3388)
Summary: Bumps [emotion/react](https://github.com/emotion-js/emotion) from 11.6.0 to 11.7.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/emotion-js/emotion/releases"><code>@emotion/react</code>'s releases</a>.</em></p> <blockquote> <h2><code>@emotion/react</code><a href="https://github.com/11"><code>@11</code></a>.7.1</h2> <h3>Patch Changes</h3> <ul> <li> <p><a href="https://github-redirect.dependabot.com/emotion-js/emotion/pull/2577">https://github.com/facebook/flipper/issues/2577</a> <a href=" |
||
|
dependabot[bot]
|
e26540ddd7 |
Bump axios from 0.24.0 to 0.25.0 in /desktop (#3383)
Summary: Bumps [axios](https://github.com/axios/axios) from 0.24.0 to 0.25.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/axios/axios/releases">axios's releases</a>.</em></p> <blockquote> <h2>v0.25.0</h2> <h3>0.25.0 (January 18, 2022)</h3> <p>Breaking changes:</p> <ul> <li>Fixing maxBodyLength enforcement (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3786">#3786</a>)</li> <li>Don't rely on strict mode behaviour for arguments (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3470">#3470</a>)</li> <li>Adding error handling when missing url (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3791">#3791</a>)</li> <li>Update isAbsoluteURL.js removing escaping of non-special characters (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3809">#3809</a>)</li> <li>Use native Array.isArray() in utils.js (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3836">#3836</a>)</li> <li>Adding error handling inside stream end callback (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3967">#3967</a>)</li> </ul> <p>Fixes and Functionality:</p> <ul> <li>Added aborted even handler (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3916">#3916</a>)</li> <li>Header types expanded allowing <code>boolean</code> and <code>number</code> types (<a href="https://github-redirect.dependabot.com/axios/axios/pull/4144">#4144</a>)</li> <li>Fix cancel signature allowing cancel message to be <code>undefined</code> (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3153">https://github.com/facebook/flipper/issues/3153</a>)</li> <li>Updated type checks to be formulated better (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3342">https://github.com/facebook/flipper/issues/3342</a>)</li> <li>Avoid unnecessary buffer allocations (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3321">https://github.com/facebook/flipper/issues/3321</a>)</li> <li>Adding a socket handler to keep TCP connection live when processing long living requests (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3422">#3422</a>)</li> <li>Added toFormData helper function (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3757">#3757</a>)</li> <li>Adding responseEncoding prop type in AxiosRequestConfig (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3918">#3918</a>)</li> </ul> <p>Internal and Tests:</p> <ul> <li>Adding axios-test-instance to ecosystem (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3786">#3786</a>)</li> <li>Optimize the logic of isAxiosError (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3546">#3546</a>)</li> <li>Add tests and documentation to display how multiple inceptors work (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3564">#3564</a>)</li> <li>Updating follow-redirects to version 1.14.7 (<a href="https://github-redirect.dependabot.com/axios/axios/pull/4379">#4379</a>)</li> </ul> <p>Documentation:</p> <ul> <li>Fixing changelog to show corrext pull request (<a href="https://github-redirect.dependabot.com/axios/axios/pull/4219">#4219</a>)</li> <li>Update upgrade guide for https proxy setting (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3604">#3604</a>)</li> </ul> <p>Huge thanks to everyone who contributed to this release via code (authors listed below) or via reviews and triaging on GitHub:</p> <ul> <li><a href="https://github.com/axios/axios/blob/HEAD/mailto:jasonsaayman@gmail.com">Jay</a></li> <li><a href="https://github.com/rijkvanzanten">Rijk van Zanten</a></li> <li><a href="https://github.com/koh110">Kohta Ito</a></li> <li><a href="https://github.com/bfaulk96">Brandon Faulkner</a></li> <li><a href="https://github.com/NoriSte">Stefano Magni</a></li> <li><a href="https://github.com/fanguangyi">enofan</a></li> <li><a href="https://github.com/puzpuzpuz">Andrey Pechkurov</a></li> <li><a href="https://github.com/doowonee">Doowonee</a></li> <li><a href="https://github.com/emilbroman-eqt">Emil Broman</a></li> <li><a href="https://github.com/remcohaszing">Remco Haszing</a></li> <li><a href="https://github.com/BlackHole1">Black-Hole</a></li> <li><a href="https://github.com/wolframkriesing">Wolfram Kriesing</a></li> <li><a href="https://github.com/repl-andrew-ovens">Andrew Ovens</a></li> <li><a href="https://github.com/PauloRSF">Paulo Renato</a></li> <li><a href="https://github.com/carpben">Ben Carp</a></li> <li><a href="https://github.com/wafuwafu13">Hirotaka Tagawa</a></li> </ul> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/axios/axios/blob/master/CHANGELOG.md">axios's changelog</a>.</em></p> <blockquote> <h3>0.25.0 (January 18, 2022)</h3> <p>Breaking changes:</p> <ul> <li>Fixing maxBodyLength enforcement (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3786">#3786</a>)</li> <li>Don't rely on strict mode behaviour for arguments (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3470">#3470</a>)</li> <li>Adding error handling when missing url (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3791">#3791</a>)</li> <li>Update isAbsoluteURL.js removing escaping of non-special characters (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3809">#3809</a>)</li> <li>Use native Array.isArray() in utils.js (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3836">#3836</a>)</li> <li>Adding error handling inside stream end callback (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3967">#3967</a>)</li> </ul> <p>Fixes and Functionality:</p> <ul> <li>Added aborted even handler (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3916">#3916</a>)</li> <li>Header types expanded allowing <code>boolean</code> and <code>number</code> types (<a href="https://github-redirect.dependabot.com/axios/axios/pull/4144">#4144</a>)</li> <li>Fix cancel signature allowing cancel message to be <code>undefined</code> (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3153">https://github.com/facebook/flipper/issues/3153</a>)</li> <li>Updated type checks to be formulated better (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3342">https://github.com/facebook/flipper/issues/3342</a>)</li> <li>Avoid unnecessary buffer allocations (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3321">https://github.com/facebook/flipper/issues/3321</a>)</li> <li>Adding a socket handler to keep TCP connection live when processing long living requests (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3422">#3422</a>)</li> <li>Added toFormData helper function (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3757">#3757</a>)</li> <li>Adding responseEncoding prop type in AxiosRequestConfig (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3918">#3918</a>)</li> </ul> <p>Internal and Tests:</p> <ul> <li>Adding axios-test-instance to ecosystem (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3786">#3786</a>)</li> <li>Optimize the logic of isAxiosError (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3546">#3546</a>)</li> <li>Add tests and documentation to display how multiple inceptors work (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3564">#3564</a>)</li> <li>Updating follow-redirects to version 1.14.7 (<a href="https://github-redirect.dependabot.com/axios/axios/pull/4379">#4379</a>)</li> </ul> <p>Documentation:</p> <ul> <li>Fixing changelog to show corrext pull request (<a href="https://github-redirect.dependabot.com/axios/axios/pull/4219">#4219</a>)</li> <li>Update upgrade guide for https proxy setting (<a href="https://github-redirect.dependabot.com/axios/axios/pull/3604">#3604</a>)</li> </ul> <p>Huge thanks to everyone who contributed to this release via code (authors listed below) or via reviews and triaging on GitHub:</p> <ul> <li><a href="https://github.com/axios/axios/blob/master/mailto:jasonsaayman@gmail.com">Jay</a></li> <li><a href="https://github.com/rijkvanzanten">Rijk van Zanten</a></li> <li><a href="https://github.com/koh110">Kohta Ito</a></li> <li><a href="https://github.com/bfaulk96">Brandon Faulkner</a></li> <li><a href="https://github.com/NoriSte">Stefano Magni</a></li> <li><a href="https://github.com/fanguangyi">enofan</a></li> <li><a href="https://github.com/puzpuzpuz">Andrey Pechkurov</a></li> <li><a href="https://github.com/doowonee">Doowonee</a></li> <li><a href="https://github.com/emilbroman-eqt">Emil Broman</a></li> <li><a href="https://github.com/remcohaszing">Remco Haszing</a></li> <li><a href="https://github.com/BlackHole1">Black-Hole</a></li> <li><a href="https://github.com/wolframkriesing">Wolfram Kriesing</a></li> <li><a href="https://github.com/repl-andrew-ovens">Andrew Ovens</a></li> <li><a href="https://github.com/PauloRSF">Paulo Renato</a></li> <li><a href="https://github.com/carpben">Ben Carp</a></li> <li><a href="https://github.com/wafuwafu13">Hirotaka Tagawa</a></li> <li><a href="https://github.com/lzxb">狼族小狈</a></li> </ul> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
dependabot[bot]
|
a63f3d9ee5 |
Bump @typescript-eslint/eslint-plugin from 5.10.0 to 5.10.1 in /desktop (#3382)
Summary:
Bumps [typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 5.10.0 to 5.10.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/releases"><code>@typescript-eslint/eslint-plugin</code>'s releases</a>.</em></p>
<blockquote>
<h2>v5.10.1</h2>
<h2><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v5.10.0...v5.10.1">5.10.1</a> (2022-01-24)</h2>
<p><strong>Note:</strong> Version bump only for package <code>@typescript-eslint/typescript-eslint</code></p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md"><code>@typescript-eslint/eslint-plugin</code>'s changelog</a>.</em></p>
<blockquote>
<h2><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v5.10.0...v5.10.1">5.10.1</a> (2022-01-24)</h2>
<p><strong>Note:</strong> Version bump only for package <code>@typescript-eslint/eslint-plugin</code></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="
|
||
Anton Kastritskiy
|
f2abbf63db |
ban interface usage for component props and state
Summary: another eslint rule for flipper codebase Reviewed By: passy Differential Revision: D33917213 fbshipit-source-id: e60b867d359ef5b94a481edf0eda318ecff17eee |
||
Flipper Bot
|
59b11c5f12 |
Flipper Snapshot Bump: v0.132.1-SNAPSHOT
Summary: Releasing snapshot version 0.132.1-SNAPSHOT Reviewed By: mweststrate Differential Revision: D33939898 fbshipit-source-id: f7509f7f737a68da237e08816c63a56c32d2b04c |
||
|
Flipper Bot
|
34d2a5fa59 |
Flipper Release: v0.132.0
Summary: Releasing version 0.132.0 Reviewed By: mweststrate Differential Revision: D33939899 fbshipit-source-id: 54617c126600230b41e45bed6cea449b67b81503 |
||
|
Andrey Goncharov
|
c238cef5b0 |
Verify certificate provider medium
Reviewed By: antonk52 Differential Revision: D33917041 fbshipit-source-id: 91a9554397063d53a903a5b1406b46ddf07360b2 |
||
|
Andrey Goncharov
|
c7492a83c7 |
Remove global access to adb client and idb config
Summary: Idb and adb sholuld not really be accessed out side of Adnroid and iOS device managers Reviewed By: lawrencelomax Differential Revision: D33915162 fbshipit-source-id: 0d1bb028b9a53254cf5b0ce6289ae76339c5a254 |
||
|
Andrey Goncharov
|
51ef1810b2 |
Defer initialization of Android and iOS device managers
Summary: Remove hidden async initialization of adb and idb. Make it explicit. Remove nullable fields in Android and iOS device managers. Reviewed By: lawrencelomax Differential Revision: D33915177 fbshipit-source-id: 882f79310410e0dfde6169abf343ab808644e4a2 |
||
|
Andrey Goncharov
|
fd13399cb9 |
Extract WWW certificate provider
Summary: Extract WWW certificate provider from the iOS certificate provider. Hide its implementation from OSS since it is not relevant for OSS folks. Reviewed By: mweststrate Differential Revision: D33895378 fbshipit-source-id: 376afda3b5fa3857c0eb280b92555314eb1a0d1f |
||
|
Andrey Goncharov
|
29f6d0e711 |
Add device-specific Certificate Providers
Reviewed By: mweststrate Differential Revision: D33821880 fbshipit-source-id: c75c71db4d7dc680f75cf41ba2d5dad009a5fd03 |
||
|
Andrey Goncharov
|
b9aeaa9339 |
Enhance iOS device manager tests
Reviewed By: lawrencelomax Differential Revision: D33915694 fbshipit-source-id: fc4bfd30b8f504f2f242f94e61967ee68cc83100 |
||
|
Andrey Goncharov
|
7bf89a840a |
Remove a circular dependency between KeytarManager and FlipperServerImpl
Reviewed By: passy Differential Revision: D33846051 fbshipit-source-id: c83f5609308ad732a02b2ee55466f5ed0918d733 |
||
|
Andrey Goncharov
|
b1f19ecd68 |
Extract certificate utils
Summary: Extract utilities for certificate server-side certificate handling Reviewed By: lawrencelomax Differential Revision: D33820263 fbshipit-source-id: 21f1a9ed5f3b83b8350151bdf6d8862aa0b18e8f |
||
|
Andrey Goncharov
|
e686766e5f |
Simplify CertificateProvider setup
Summary:
Currently, certificateSetup is called in two places:
- processCertificateSigningRequest
- loadSecureServerConfig
`loadSecureServerConfig` is a mandatory step of Flipper server initialization ([ServerController.init](https://www.internalfb.com/code/flipper/[24785758018a2ffbd4751ad2b9093b5ef97c611d]/src/fbsource/xplat/sonar/desktop/flipper-server-core/src/comms/ServerController.tsx?lines=118)). Flipper cannot start without executing it.
As a result, calling `certificateSetup` in `processCertificateSigningRequest` always results in the early return.
This diff removes executing `certificateSetup` from `processCertificateSigningRequest`. Since it's called only during server setup (so only once), it no longer makes sense to use `didCertificateSetup`.
Next steps:
- Extract Android and iOS certificate utils. Remove the dependency on accessing adb/idb dynamically. See D33711652 (
|
||
|
dependabot[bot]
|
cb66520d55 |
Bump mockito-core from 4.3.0 to 4.3.1 (#3378)
Summary:
Bumps [mockito-core](https://github.com/mockito/mockito) from 4.3.0 to 4.3.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/mockito/mockito/releases">mockito-core's releases</a>.</em></p>
<blockquote>
<h2>v4.3.1</h2>
<p><!-- raw HTML omitted --><!-- raw HTML omitted --><em>Changelog generated by <a href="https://github.com/shipkit/shipkit-changelog">Shipkit Changelog Gradle Plugin</a></em><!-- raw HTML omitted --><!-- raw HTML omitted --></p>
<h4>4.3.1</h4>
<ul>
<li>2022-01-25 - <a href="https://github.com/mockito/mockito/compare/v4.3.0...v4.3.1">1 commit(s)</a> by Stefano Cordio</li>
<li>Add <code>mockito-core</code> to the BOM [(<a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2550">https://github.com/facebook/flipper/issues/2550</a>)](<a href="https://github-redirect.dependabot.com/mockito/mockito/pull/2550">mockito/mockito#2550</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="
|
||
|
dependabot[bot]
|
9d3c93253f |
Bump gradle from 7.0.4 to 7.1.0 (#3376)
Summary: Bumps gradle from 7.0.4 to 7.1.0. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `dependabot rebase` will rebase this PR - `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `dependabot merge` will merge this PR after your CI passes on it - `dependabot squash and merge` will squash and merge this PR after your CI passes on it - `dependabot cancel merge` will cancel a previously requested merge and block automerging - `dependabot reopen` will reopen this PR if it is closed - `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Pull Request resolved: https://github.com/facebook/flipper/pull/3376 Reviewed By: passy Differential Revision: D33892189 Pulled By: cekkaewnumchai fbshipit-source-id: 9f31be1128342175234b07436cf462fe58e76845 |
||
Chaiwat Ekkaewnumchai
|
ecd7269848 |
Upgrade Gradle Runner(?) (#3390)
Summary: Pull Request resolved: https://github.com/facebook/flipper/pull/3390 In [D33892189 V3 Android OSS job](https://www.internalfb.com/intern/sandcastle/job/36028797581234803/artifact/runsandcastle), it failed saying that it needs version 7.2 or later. Hence, upgrading this Reviewed By: antonk52 Differential Revision: D33917841 fbshipit-source-id: 3ccc912b6aa5aa611840e917646870b8bceb0843 |
||
|
Anton Kastritskiy
|
05a3bb69dc |
rename left ts files to tsx and ban ts file extension
Summary: mass files rename Reviewed By: passy Differential Revision: D33890304 fbshipit-source-id: c057ac9fe87dd7659597c85d640619b93e1ff0e6 |
||
|
dependabot[bot]
|
e98b34a407 |
Bump metro-react-native-babel-preset from 0.66.2 to 0.67.0 in /react-native/ReactNativeFlipperExample (#3374)
Summary: Bumps [metro-react-native-babel-preset](https://github.com/facebook/metro) from 0.66.2 to 0.67.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/facebook/metro/releases">metro-react-native-babel-preset's releases</a>.</em></p> <blockquote> <h2>Release v0.67.0</h2> <ul> <li><strong>[Breaking]</strong> Use custom resolvers (<code>resolver.resolveRequest</code>) before checking the Haste map. (96fb6e904e1660b37f4d1f5353ca1e5477c4afbf)</li> <li><strong>[Feature]</strong> Update React Native lazy imports list with the removal of <code>StatusBarIOS</code>. (2a0f77925e3299e01c2bfe82d0356145a643adc0)</li> <li><strong>[Feature]</strong> Allow configuring the path of the canonical empty module, which now lives in <code>metro-runtime</code> by default. (bd5f9323337b03a77bc219636937bb75cd8c18ca, 6e3e789b685b95ea59a58364a751e8010d536e8b, 7723be545795c936cb81cad214ee202f72e169b3)</li> <li><strong>[Feature]</strong> Add <code>initialize_done</code>, <code>transformer_loading</code>, and <code>transformer_loaded</code> events to the <code>Reporter</code> interface. (d19cf5d7e88207a8d46c17b570f14a239dae8926)</li> <li><strong>[Feature]</strong> Add <code>waitForBundler</code> option to the <code>runServer()</code> and <code>runMetro()</code> APIs. (57d8a92583185a97dffcdc1c95fef7780be9104d)</li> <li><strong>[Feature]</strong> Add <code>resolver.disableHierarchicalLookup</code> option. (01416f1bc41a3d557b24e4b508fed5f158990108)</li> <li><strong>[Feature]</strong> Remove confusing troubleshooting steps from missing module errors. (1fa45c21f7508cc3a852071b775f592873700ad0)</li> <li><strong>[Feature]</strong> Infer names for anonymous functions in optional calls. (4ced2a1be8a42a9c7df71b566918a457bad207c1)</li> <li><strong>[Feature]</strong> Infer names for anonymous functions memoized with useCallback. (2611f618b245fd2bd2c3558d2536011269bb5a68)</li> <li><strong>[Feature]</strong> Update terser to v5 in <code>metro-minify-terser</code>. (<a href="https://github-redirect.dependabot.com/facebook/metro/pull/754">facebook/metro#754</a> by <a href="https://github.com/rockwotj"><code>@rockwotj</code></a>, <a href="https://github-redirect.dependabot.com/facebook/metro/pull/606">facebook/metro#606</a> by <a href="https://github.com/janicduplessis"><code>@janicduplessis</code></a>)</li> <li><strong>[Fix]</strong> Fix a caching issue with custom resolvers. (793b1a03c1f0b5e63869b471adab3f1ad61b199b)</li> <li><strong>[Fix]</strong> Specify UTF-8 encoding when serving bundles. (<a href="https://github-redirect.dependabot.com/facebook/metro/pull/695">facebook/metro#695</a> by <a href="https://github.com/zhiqingchen"><code>@zhiqingchen</code></a>)</li> <li><strong>[Fix]</strong> Support <a href="https://github.com/defunctzombie/package-browser-field-spec#replace-specific-files---advanced">package.json module replacements</a> for requires with implicit extensions. (41522a25bec9325d1df5981b55d4672db7126895)</li> <li><strong>[Fix]</strong> Resolve <a href="https://github.com/defunctzombie/package-browser-field-spec#replace-specific-files---advanced">package.json module replacements</a> when the replaced module isn't a physical file. (171393a6319e507935eeb3d40561e908c1a2abfe)</li> <li><strong>[Fix]</strong> Fix stack trace symbolication when input files have non-Unix line endings. (<a href="https://github-redirect.dependabot.com/facebook/metro/pull/691">facebook/metro#691</a> by <a href="https://github.com/danielsmc"><code>@danielsmc</code></a>)</li> <li><strong>[Fix]</strong> Decrease the precedence of <code>resolver.nodeModulesPaths</code> to respect transitive dependencies. (<a href="https://github-redirect.dependabot.com/facebook/metro/pull/738">facebook/metro#738</a> by <a href="https://github.com/sharmilajesupaul"><code>@sharmilajesupaul</code></a>)</li> <li><strong>[Fix]</strong> Respect <code>mangle: false</code> & <code>sourceMap: false</code> in <code>minifierConfig</code>. (<a href="https://github-redirect.dependabot.com/facebook/metro/pull/749">facebook/metro#749</a> by <a href="https://github.com/mfbx9da4"><code>@mfbx9da4</code></a>)</li> <li><strong>[Fix]</strong> Update hash function from MD4 to MD5 for Node 17 compatibility. (<a href="https://github-redirect.dependabot.com/facebook/metro/pull/752">facebook/metro#752</a> by <a href="https://github.com/tobua"><code>@tobua</code></a>)</li> </ul> <blockquote> <p>NOTE: Experimental features are not covered by semver and can change at any time.</p> </blockquote> <ul> <li><strong>[Experimental]</strong> Add <code>server.unstable_serverRoot</code> option to allow serving bundles from folders outside the project root. (026a66cf40df1bd05da2afc1660efa1d9605c55a, ca86682012eb836e2b6aeb001f2b3112129e38c3, e061cf342505f3d07fb21f85f22925e3d05557c9, 70e98882ad24d7c25c9b73eaf347e60f2a74c8ca, baacea28635dae7fea3bd30dd485252ae59a937e)</li> <li><strong>[Experimental]</strong> Update <code>metro-hermes-compiler</code>. (e80434cf329619e1a0c6c56ae7be6c88cb350c99)</li> <li><strong>[Experimental]</strong> Provide safe access to assets outside the project root using <code>/assets?unstable_path=...</code>. (f3d1157bacc341dff82efea2f70b634141105fc0)</li> <li><strong>[Experimental]</strong> Add <code>resolver.unstable_hasteMapModulePath</code> option. (e8c0de0411148bd31e3decb6a5c4c1dc1d645666)</li> </ul> <p>Thanks to all the contributors mentioned above for helping improve Metro! 🚇</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
Lawrence Lomax
|
ed03f1b107 |
Use idb to record devices
Summary: `idb` has supported video recording on devices for quite some time now. We even have the implementation in `iOSDevice`, but it's currently unused. As a result, we just need to remove the check within `iOSDevice` that the target is an "emulator" and it will use the `idb` implementation. Removing this check means that the button is now selectable within the UI. Reviewed By: passy Differential Revision: D33913383 fbshipit-source-id: b3d6b4c480c79b54f0d2c206c68092ab62bf71ed |
||
|
Lawrence Lomax
|
3a9c875e03 |
Avoid double recording in iOSDevice
Summary: This should in theory never happen since the state of the recording is also managed within the UI. However, it's better to ensure that if `startRecording` is called twice, without calling `stopRecording` first it will error rather than leak a recording (the first process will still run but the object representing it is oprhaned) Reviewed By: passy Differential Revision: D33913298 fbshipit-source-id: f8fa6b0e4fdbdf4282633fa29a736d3e7dedf3bb |
||
|
Lawrence Lomax
|
7d34c86f78 |
Remove recording invariants
Summary: The state of the destination and the process are coupled together. As a result it makes sense to move these to an object type. This prevents destination and process being independently settable. No change in behaviour, just a removal of invariants that need to be checked Reviewed By: passy Differential Revision: D33913213 fbshipit-source-id: ed18650cac4f72d40e82d20254674f7fa12cbb48 |
||
|
dependabot[bot]
|
d807183eb6 |
Bump serde from 1.0.135 to 1.0.136 in /packer (#3373)
Summary: Bumps [serde](https://github.com/serde-rs/serde) from 1.0.135 to 1.0.136. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/serde-rs/serde/releases">serde's releases</a>.</em></p> <blockquote> <h2>v1.0.136</h2> <ul> <li>Improve default error message when <code>Visitor</code> fails to deserialize a u128 or i128 (<a href="https://github-redirect.dependabot.com/serde-rs/serde/issues/2167">https://github.com/facebook/flipper/issues/2167</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
Lawrence Lomax
|
a9b9a1bff4 |
Remove redundant xcodeCommandLineToolsDetected
Summary: This is public but never read, no need for it to exist Reviewed By: passy Differential Revision: D33893097 fbshipit-source-id: aa423464f9cc0c35768a549fd5cb481784d8bcd6 |
||
|
Lawrence Lomax
|
9cbdc3038f |
Remove mising iOS Bridge invariant in iOSDeviceManager
Summary: There's no need for us to have a property that can be undefined, since we can use the magic of *passing arguments* to achieve the same end result. The unit test a bit more precarious, but it's left here for posterity or until we decide to kill it otherwise. Reviewed By: passy Differential Revision: D33892407 fbshipit-source-id: 3b499511189862e2265d8d6d29f849a7b813050e |
||
|
Lawrence Lomax
|
757b82757e |
Use polymorphic IOSBridge to perform iOS target listing
Summary: Bulding on the work from prior diffs we can use the created bridge directly. No need to have if statements calling out to sub-functions, just use the base type itself which will use the appropriate implementation. There's no behavioural change here. Either idb was queried for sims/devices or simctl was queried for just sims, they were always mutually exclusive. Reviewed By: passy Differential Revision: D33842604 fbshipit-source-id: 0bf63ffc34368c70df31c105ea0ba5df941e72cc |
||
|
Lawrence Lomax
|
b0046c8ddb |
Check for xcode mismatch once and only once
Summary: We perform this *repeatedly* (every 2s!!!). Which is clearly excessive. Let's perform this check once to avoid noise and a waste of system resources Reviewed By: passy Differential Revision: D33844194 fbshipit-source-id: 226dc9d67bb83b167afa8e28ade8e1911470ef8a |
||
|
Lawrence Lomax
|
e16662a28f |
Improve xcode version mismatch messaging
Summary: This runs in a very hot loop (which I will change shortly) However, there's also some simplification that we can do here: - Only look for `Simulator.app` processes instead of all the processes. This limits the amount of string comparison to do. If there's a `Simulator.app` running, then we know a sim is running for that Xcode. - Use piping to extract the launch path of the process, instead of then regex'ing this out. - Use a simpler substring match to determine if paths have a different start. Reviewed By: passy Differential Revision: D33891296 fbshipit-source-id: e37d5f260fc6c6113be9c5268b7c8cffb4057b9a |
||
|
dependabot[bot]
|
1e309ddd5c |
Bump protobuf-java from 3.19.3 to 3.19.4 (#3377)
Summary: Bumps [protobuf-java](https://github.com/protocolbuffers/protobuf) from 3.19.3 to 3.19.4. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/protocolbuffers/protobuf/releases">protobuf-java's releases</a>.</em></p> <blockquote> <h2>Protocol Buffers v3.19.4</h2> <h1>Python</h1> <ul> <li>Make libprotobuf symbols local on OSX to fix issue <a href="https://github-redirect.dependabot.com/protocolbuffers/protobuf/issues/9395">#9395</a> (<a href="https://github-redirect.dependabot.com/protocolbuffers/protobuf/issues/9435">#9435</a>)</li> </ul> <h1>Ruby</h1> <ul> <li>Fixed a data loss bug that could occur when the number of <code>optional</code> fields in a message is an exact multiple of 32. (<a href="https://github-redirect.dependabot.com/protocolbuffers/protobuf/issues/9440">#9440</a>).</li> </ul> <h1>PHP</h1> <ul> <li>Fixed a data loss bug that could occur when the number of <code>optional</code> fields in a message is an exact multiple of 32. (<a href="https://github-redirect.dependabot.com/protocolbuffers/protobuf/issues/9440">#9440</a>).</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
facebook-flipper-bot
|
a694ea3b35 |
Automated: Update Podfile.lock (#3369)
Summary: This is an automated PR to update the Podfile.lock. - Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions. - Also make sure that all the dependencies are updated to the latest one. - This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request) Pull Request resolved: https://github.com/facebook/flipper/pull/3369 Test Plan: Imported from GitHub, without a `Test Plan:` line. **Static Docs Preview: flipper** |[Full Site](https://our.intern.facebook.com/intern/staticdocs/eph/D33892491/V3/flipper/)| |**Modified Pages**| |[docs/getting-started/ios-native](https://our.intern.facebook.com/intern/staticdocs/eph/D33892491/V3/flipper/docs/getting-started/ios-native/)| Reviewed By: passy Differential Revision: D33892491 Pulled By: cekkaewnumchai fbshipit-source-id: 486ea3af518488866e2f5e955a6e3b98e86c4db8 |
||
|
Anton Kastritskiy
|
c5dd1fc350 |
rename files from ts to tsx in flipper-* packages
Summary: mass files rename Reviewed By: nikoant Differential Revision: D33890252 fbshipit-source-id: d5afaa60af7340313a97d8e4967fe37f00abd9db |
||
|
Anton Kastritskiy
|
2476472344 |
eslint plugin files rename from ts to tsx
Summary: mass rename files Reviewed By: nikoant Differential Revision: D33890201 fbshipit-source-id: ac73fb040519a566447981bad37b8c78878a5c3d |
||
|
Andrey Goncharov
|
a474a0c2f2 |
Fallback to RSockets if cert exchange fails
Summary: Changelog: Fallback to RSockets if cert exchange fails even if the connection was successful. Currently, we fallback to RSockets only if the connected is rejected. It turns out that WS server does not reject connection from our RSocket client. Instead, it rejects the messages. As result, requestSignedCertFromFlipper fails, but it never triggers the change of protocol. With this diff we start evaluating if we need to change our protocol for every socket error. Reviewed By: lblasa Differential Revision: D33890235 fbshipit-source-id: f79b5c6992f01f8a93e0793e180a5cbd4a105619 |
||
|
Lawrence Lomax
|
ccae37aa71 |
Extract idb device querying to IOSBridge
Summary: Again this is just a code move for now. However, we now have a common method between simctl and idb cases. This means that the next diff can call an `IOSBridge` with polymorpism taking over. This is still delegated out, but there's an argument to be made to move `iosUtil` functionality back so that this all lives in the same place. Reviewed By: passy Differential Revision: D33843093 fbshipit-source-id: 5cd884140817df851cccf63e5780582b16d4231c |
||
|
Lawrence Lomax
|
aeb0b5f317 |
Extract getSimulators to IOSBridge
Summary: Extracts `getSimulator` interrnals to `SimctlBridge`. This allows this functionality to be used independently of things like the the flipper server. For now this just moves the functionality, but future diffs will build on top of this. Reviewed By: passy Differential Revision: D33842986 fbshipit-source-id: bae26a9bd5c21c9813f8a2b10c3b3e3efc1c5929 |
||
|
Lawrence Lomax
|
959a2a77d7 |
Extract launchSimulator to IOSBridge
Summary: This is related to `simctl` functionality, so can be extracted there. This will aid in future changes whereby we can hide `getDeviceSetPath` in the IOSBridge module Reviewed By: passy Differential Revision: D33842987 fbshipit-source-id: de292ce5afba3e7d79d8ba27c2b8852909d7e6f3 |
||
|
dependabot[bot]
|
8316a00ef7 |
Bump react-native from 0.66.4 to 0.67.1 in /react-native/react-native-flipper (#3338)
Summary: Bumps [react-native](https://github.com/facebook/react-native) from 0.66.4 to 0.67.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/facebook/react-native/releases">react-native's releases</a>.</em></p> <blockquote> <h2>0.67.1</h2> <p>A patch release including fixes to unblock Detox and Android JSC builds</p> <ul> <li>Remove alert's window when call to <code>hide</code>. (<a href=" |
