Summary: Adds expanding functionality to ax tree when click-to-inspect is used. Highlight/selection priority is given to the ax tree if in ax mode and the main tree otherwise.
Reviewed By: danielbuechele
Differential Revision: D9206028
fbshipit-source-id: 364b3cfc2e68dbce6006c36002353295aa7cdd07
Summary: Now we won't need the shipit config to exclude it anymore
Reviewed By: passy
Differential Revision: D9049518
fbshipit-source-id: 983bc28fc3dce7543c9100992f2daff1dd783ea3
Summary: These will be displayed in the sonar diagnostics screen, for troubleshooting connection issues.
Reviewed By: danielbuechele
Differential Revision: D9150552
fbshipit-source-id: c6d65fba86e7564fbb004aaa7b0303a1d5952e5d
Summary:
Open the screen by running adb shell
am start -n com.facebook.samples.litho/com.facebook.sonar.android.diagnostics.SonarDiagnosticActivity
Reviewed By: danielbuechele
Differential Revision: D9150556
fbshipit-source-id: 534583cfa5e90af6fd0d2a50572e3763b8888da2
Summary:
The plan is to add such state annotations around all core sonar tasks, so the diagnostic screen can show a useful up to date picture of what's going on.
This is the first batch of such annotaions, to act as a tracer while putting the rest of the diagnostics code in place.
Reviewed By: passy
Differential Revision: D9150555
fbshipit-source-id: 5c25205ecc690f0101b444681be48b823b0cb052
Summary:
The plan is to get SonarState to take update events and aggregate them into an object, that can be displayed in the UI so you can see what sonar is currently trying to do, and what if anything is failing.
This is pretty rubbish right now, as it just uses a single string to represent state, this is just the initial version I'll iterate on.
I also need to pass the SonarState into the SonarWebSocketImpl, since that's where a lot of the heavy lifting is done, but as long as something is logging state updates here, it proves the concept.
SonarStateUpdateListener is the interface that will be implemented by android and iOS implementations. These implementations will notify an activity or screen that the state has changed and they should reflect that.
Reviewed By: danielbuechele
Differential Revision: D9150551
fbshipit-source-id: 8dd585ca503d32e684ff843d66a59a50a420b4c0
Summary: Puts an accessibility icon next to any elements in the ax tree that may be focused on when talkback is running to show that they are "accessibility-focusable". When any sidebar values are changed, the icon will show up/disappear accordingly.
Reviewed By: danielbuechele
Differential Revision: D9171781
fbshipit-source-id: f3b42624988aaef22040ac3325d745a12f0622db
Summary: Allow user to open the context menu on an element in the ax tree and request accessibility focus to that element. If the element is focusable (and talkback or another accessibility service is running), accessibility focus will change to that element, if not, it will not change anything.
Differential Revision: D9162382
fbshipit-source-id: 5dda9b87a2cc6eba4130e3feee978b5fa38ac9f1
Summary: Releases a new iOS version 0.6.16. After landing this I will release 0.6.16 tag on github
Reviewed By: danielbuechele
Differential Revision: D9194965
fbshipit-source-id: 13d5e346d6d34a7bf7b6dfb568ca622d97660132
Summary: With the new swift support for network plugin, the sample swift app was not compiling as it didn't have the location of plublic header files
Reviewed By: danielbuechele
Differential Revision: D9194964
fbshipit-source-id: 210da3b4a921febc95a3ee8a6dc7788278c5db96
Summary:
Prior to this diff the OSS sonar project depended on folly's master branch instead of tags, which is not good as things can break, which broke recently. So this diff adds the folly dependency thru tags to avoid any future failures.
This diff releases a new folly dependency which relies on a tag
Reviewed By: danielbuechele
Differential Revision: D9194966
fbshipit-source-id: 0a0956f0bd457e375fcbb86b3fec412aeb759a47
Summary: We're now on JCenter with the new package name.
Reviewed By: danielbuechele
Differential Revision: D9195254
fbshipit-source-id: 948f1abe557746de349cd4138fa98658e43184d0
Summary:
Without the newline, this gets interpreted as a headline, which looks a bit weird.
Pull Request resolved: https://github.com/facebook/flipper/pull/208
Reviewed By: danielbuechele
Differential Revision: D9194566
Pulled By: passy
fbshipit-source-id: 67d63e072f4f8d0e86f3a2a0a48886e7e5716b40
Summary:
To make the transition from the old to the new name as smooth as possible, we want to allow people to launch the app using its old name via Spotlight.
Therefore, we set a comment on the executable with the old name. These comments are indexed by Spotlight and the app can be launched with the old name.
Reviewed By: passy, priteshrnandgaonkar
Differential Revision: D9149323
fbshipit-source-id: b812776350b3fc57dc3a193bcd96c343a13a039f
Summary:
[Step 1 of a protocol change between desktop app and flipper agent]
The flipper agent periodically tries to connect.
When it doesn't have the required certs, instead of trying to connect, it requests them from the desktop.
After requesting, it just continues the loop, trying to request.
The problem with that is
a) the desktop can take longer than one cycle to generate and provide the certs, meaning the agent will make overlapping requests, causing confusion and it to take longer than necessary.
b) the desktop can take less time than a retry cycle, but the agent will still wait before trying to connect.
Fixing a) by making the agent wait for a response from the desktop before continuing attempting to reconnect.
This means on the next connection attempt, it's guaranteed that the desktop is finished processing the CSR.
b) remains unfixed for now, but can be dealt with separately.
This is step 1 which adds an extra responder to the desktop app. It won't change anything until the agent starts
sending requestResponse messages instead of fireAndForgets. The plan is to leave this in place for a while to give users time to update, after that, we'll roll out the change to the agent.
Reviewed By: passy
Differential Revision: D9179392
fbshipit-source-id: 9a8021253dcd28c15cceeec23630a67aec219fd5
Summary:
Sometimes you want to get the sonar client without necessarily wanting to initialize it, for example if you don't have a context object, but still want to get hold of a particular plugin object.
Adds a getInstance method that returns null if not initialized.
Reviewed By: passy
Differential Revision: D9154423
fbshipit-source-id: 65cb46684bc35d9a953dbd958c7cf72aba0015e2
Summary:
Device connection didn't work on Linux due to netcat behaving differently.
I also played around with the `nc` and `node-netcat` packages, but they would
either crash the node stack or fail to compile with Babel. Oh glorious
JavaScript world.
Reviewed By: danielbuechele
Differential Revision: D9194591
fbshipit-source-id: 58e5b8d6b4a66e791e750de2f1449dcb8fc338ae
Summary: Allow click to inspect to work when Talkback is running (normal tree expands as usual although ax tree doesn't expand yet). Override onHover of Touchoverlay and onRequestSendAccessibilityEvent in viewRoot to prevent talkback focus when in Click to Inspect mode. Also update layout inspector to persist isSearchActive to prevent build up of TouchOverlayViews when navigating between plugins (which happened if leaving the layout inspector while in Click to Inspect mode).
Reviewed By: danielbuechele
Differential Revision: D9153446
fbshipit-source-id: f76982e8f8cea1e7b7e4c6b9bf73632d101222ef
Summary:
Rename artifacts and release on Bintray. Public release
will be delayed by the manual review by JFrog.
Reviewed By: danielbuechele
Differential Revision: D9179646
fbshipit-source-id: 84c11d545940d1d52b9de9f87b4eb26901290108
Summary: Fix a small issue we had with our mascot.
Reviewed By: danielbuechele
Differential Revision: D9180345
fbshipit-source-id: de1c34768b4f75202d78bd4404798a7549aa0457
Summary:
Solves #173
- [x] Add plugins in the sonarkit xcodeproj so that its easy to debug
- [x] Get rid off the c++ in the headers
- [x] Add example to hit network requests and validate
Have a look at the screen shot below ✨⭐️⚡️
<img width="1677" alt="screen shot 2018-08-02 at 12 46 07 pm" src="https://user-images.githubusercontent.com/3865908/43581809-22efe4fe-9652-11e8-9424-f279d07c5c81.png">
Pull Request resolved: https://github.com/facebook/flipper/pull/201
Reviewed By: danielbuechele
Differential Revision: D9132157
Pulled By: priteshrnandgaonkar
fbshipit-source-id: 2b425506961f02eb2bf629c2bcab0da6e7ce5bb0
Summary: rename all visible references of Sonar to Flipper. Changes endpoint URLs to the new repo address.
Reviewed By: passy
Differential Revision: D9082100
fbshipit-source-id: 2ab8b680a19c23d80050e8e768379c29d66acfca
Summary:
Add a Button to toggle alignment lines on Sonar interface.
Call sonar plugin in java, sending isAlignmentMode flag.
Changed API for setHighlighted to include alignment mode flag.
Button design to be added in future diffs by @[100003260904633:maximg]
Reviewed By: danielbuechele
Differential Revision: D9123749
fbshipit-source-id: 01c299f299be30dbb695bfb1d8007d63c27643d5
Summary: Sidebar is now scrollable, when showing too many plugins.
Reviewed By: jknoxville
Differential Revision: D9179312
fbshipit-source-id: bfcd4655a0fbbe91424b88378db3713e68e2cb7f
Summary: Previously, accidentally all action payloads have been written to the application reducer, because it didn't check the action type. Now, this diff makes sure, the application reducer checks for the action type and only writes actions to the store which are meant for the reducer.
Reviewed By: jknoxville
Differential Revision: D9179305
fbshipit-source-id: 833776468ed32e0385058571130e81eff06c370e
Summary: Logs plugin was not showing sidebar after switching to new sidebar API.
Reviewed By: jknoxville
Differential Revision: D9179249
fbshipit-source-id: 922be402dbbb1096343489f6027cd543010b694f
Summary: Some columns in logs plugin where showing scrollbars since the update to electron 3. This hides scrollbars on all columns
Reviewed By: passy
Differential Revision: D9179242
fbshipit-source-id: bdf2e1a6f77d2a7e25cb34792b980afe7571e643
Summary:
`innerHTML` seems unnecessarily dangerous, rendering unescaped content from the network in an execution context. It can also raise exceptions if the HTML received is invalid, so let's not do this?
Pull Request resolved: https://github.com/facebook/flipper/pull/199
Reviewed By: danielbuechele
Differential Revision: D9179150
Pulled By: passy
fbshipit-source-id: 911b2686150be73c8e9e42b94b2a96da62fd6ae7
Summary:
Part of a hackathon project. (https://fb.facebook.com/groups/230455004101832/permalink/454928784987785/)
We're adding an alignment mode for Sonar that shows the pixel level alignment.
Reviewed By: danielbuechele
Differential Revision: D9121197
fbshipit-source-id: 21af36fd7eeea631d580ccebff8e648fa276bf35
Summary:
Made sure it builds with both buck and Gradle.
Follow-up to D8865149.
Reviewed By: danielbuechele
Differential Revision: D9178885
fbshipit-source-id: 46efaa532efdc1d59ce76e04be6680e233084881
Summary:
fs.unlink() requires a callback and we weren't passing one.
Using synchronous version instead.
Reviewed By: passy
Differential Revision: D9148214
fbshipit-source-id: 8a3c1103d93fced5e3c25c38775badb72c23e48a
Summary:
The script installing the plugin dependencies is executed by yarn itself. This means a yarn instance is running while the script is trying to create another yarn instance to install plugin dependencies. The second yarn instance is waiting for the first to finish, while the second can't start as long as the first hasn't finished. Deadlock.
This is why we use a port dirrerent from yarn's default port (31997) for the mutex.
Reviewed By: jknoxville
Differential Revision: D9149973
fbshipit-source-id: 69790021460fd8ddea9ed84ca8130c77be0a62a9
Summary: These will be displayed in the sonar diagnostics screen, for troubleshooting connection issues.
Reviewed By: passy
Differential Revision: D9117508
fbshipit-source-id: 6481f127b908fa539fe1fed1e268a28fa357d6f8
Summary:
Open the screen by running adb shell
am start -n com.facebook.wakizashi/com.facebook.sonar.android.diagnostics.SonarDiagnosticActivity
Reviewed By: passy
Differential Revision: D8954095
fbshipit-source-id: b4a638bc0ba2f69a69c121c7c1c00fbe47476ee3
Summary:
The plan is to add such state annotations around all core sonar tasks, so the diagnostic screen can show a useful up to date picture of what's going on.
This is the first batch of such annotaions, to act as a tracer while putting the rest of the diagnostics code in place.
Reviewed By: passy
Differential Revision: D8954014
fbshipit-source-id: 864156b0d3f51eeb05c2c8916c1765e834f1dc8e
Summary:
The plan is to get SonarState to take update events and aggregate them into an object, that can be displayed in the UI so you can see what sonar is currently trying to do, and what if anything is failing.
This is pretty rubbish right now, as it just uses a single string to represent state, this is just the initial version I'll iterate on.
I also need to pass the SonarState into the SonarWebSocketImpl, since that's where a lot of the heavy lifting is done, but as long as something is logging state updates here, it proves the concept.
SonarStateUpdateListener is the interface that will be implemented by android and iOS implementations. These implementations will notify an activity or screen that the state has changed and they should reflect that.
Reviewed By: passy
Differential Revision: D8932114
fbshipit-source-id: fb03babfe92be53771eb4d8f10de7ecdc7f1a6d8
Summary:
Solves #203
- [x] Sample Objc and Swift apps now have default configs(i.e non-recursive header search paths)
- [x] Fix for the cocoapods default config by adding FBMacros.h file in `Core` subspec
- [x] Updated the Spec(0.6.15) so that 0.6.15 works for default configs
- [x] Updated the doc
Pull Request resolved: https://github.com/facebook/flipper/pull/205
Reviewed By: passy
Differential Revision: D9148358
Pulled By: priteshrnandgaonkar
fbshipit-source-id: e6d32d9cde7b100573bd9a9996f0ec850b269d28
Summary:
- making website deployment and desktop app builds two different travis jobs, so if one fails, the other is still working
- running website builds on linux, because, we don't need macOS for this
- making dependency installs serial instead of parallel to avoid problems of multiple yarn instances running at the same time
- removing duplicate postinstall script which breaks for electron 3 builds
Reviewed By: passy
Differential Revision: D9148342
fbshipit-source-id: 22f3a0fe59aff066c04fb964621604efc46aab8a
Summary:
Overall plan to modify Future<T>::then to be r-value qualified and use Future<T>::thenTry or Future<T>::thenValue.
The goal is to disambiguate folly::Future and to improve type and lifetime safety of Future and its methods.
4/n: Codemod:
* rvalue-future<T>.then(callable with operator()(not-a-try)) to rvalue-future<T>.thenValue(callable with operator()(not-a-try)).
* rvalue-future<T>.then(callable with operator()()) to rvalue-future<T>.thenValue(callable with operator()(auto&&)).
* rvalue-future<T>.then(callable with operator()(auto)) to rvalue-future<T>.thenValue(callable with operator()(auto)).
Applied to xplat.
Reviewed By: marshallcline
Differential Revision: D9133114
fbshipit-source-id: 30cc4f0480ca04b3abda54af3aafd9fc4dfdf0e0
