Use textContent for showing dev error message (#199)
Summary: `innerHTML` seems unnecessarily dangerous, rendering unescaped content from the network in an execution context. It can also raise exceptions if the HTML received is invalid, so let's not do this? Pull Request resolved: https://github.com/facebook/flipper/pull/199 Reviewed By: danielbuechele Differential Revision: D9179150 Pulled By: passy fbshipit-source-id: 911b2686150be73c8e9e42b94b2a96da62fd6ae7
This commit is contained in:
committed by
Facebook Github Bot
parent
4e5122d664
commit
3a657ed46a
@@ -75,14 +75,14 @@
|
||||
suppressErrors = true;
|
||||
});
|
||||
|
||||
function openError(html) {
|
||||
function openError(text) {
|
||||
if (suppressErrors) {
|
||||
return;
|
||||
}
|
||||
|
||||
const box = document.querySelector('.__infinity-dev-box-error');
|
||||
box.removeAttribute('hidden');
|
||||
box.innerHTML = html;
|
||||
box.textContent = text;
|
||||
onLoad();
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user