Summary: This can be provided as an override, but is not needed for regular usage.
Reviewed By: antonk52
Differential Revision: D50405097
fbshipit-source-id: 7238f99ef08bfdf5c7adda0e8c3294341ae86e89
Summary: You can now descriminate based on `hasProblem`. Thus removing asserting operator
Reviewed By: LukeDefeo
Differential Revision: D50366398
fbshipit-source-id: a16a5419ce946831bd2d1624b1baa75c89a47aa3
Summary:
I am working in Horizon Worlds and I would like to integrate Flipper with HzW app.
Currently FlipperPlugin C++ code won't compile on Windows since it uses Linux-only headers like `netdb.h` and `sys/fcntl.h`, I posted here and looks like it is not currently supported: https://fb.workplace.com/groups/flippersupport/posts/1704837183330266
The problem seem to be in only in `FlipperConnectionEndpointVerifier.cpp`, and I'm updating it to make it compatible with Windows.
Also apparently there's some issue with `#include` of few files and namespaces, leading to "struct redefinition" errors where `#pragma once` does not help https://fb.workplace.com/groups/474291069286180/posts/25313067014981908/
Solving it with manual #define
Reviewed By: lblasa
Differential Revision: D50337573
fbshipit-source-id: affdf1aee2b9dfe615227827fedf324a5f17d8b0
Summary: This is the immediate follow-up from the previous diff which aims to integrate the MacOS app into our release build script, meta only.
Reviewed By: antonk52, aigoncharov
Differential Revision: D50301369
fbshipit-source-id: 23a4842666c3a7aa9616c6237e16b71bae87ba36
Summary: If the server is offline, the fetch request will fail and this was not properly handled.
Reviewed By: antonk52
Differential Revision: D50299455
fbshipit-source-id: dab8336dedaf93db049dc703a23f9e33935212be
Summary: Changelog: When requesting Keychain Access, you will now see "flipper-runtime" instead of a generic "node" process.
Reviewed By: lblasa
Differential Revision: D50261830
fbshipit-source-id: ef6fd7d5099c4ff7370f0401a5de3fde1659f1f3
Summary: Do not use mutex for device listing.
Reviewed By: antonk52
Differential Revision: D50265112
fbshipit-source-id: 9b3bf4f9351e28dfb6366b6b787ec8b466b9bc47
Summary: This is more reliable and follows redirect which we need for GitHub downloads.
Reviewed By: antonk52
Differential Revision: D50263976
fbshipit-source-id: d001b6eb460510b0b673ea66651e7c39cac3092f
Summary:
Copying files will randomly fail with something akin to
```
Error: Cannot copy '../acirb/bin/acorn' to a subdirectory of itself, '../acorn/bin/acorn'.
```
See https://github.com/jprichardson/node-fs-extra/issues/708
Reviewed By: antonk52
Differential Revision: D50263977
fbshipit-source-id: 39091ef57b79c692ec89e7a250595509839e2af8
Summary:
**Issue**
From passy:
when one of the app server ports is occupied, Flipper PWA is stuck at the loading screen
Reviewed By: passy
Differential Revision: D50261985
fbshipit-source-id: 8ce90cd6d515c26a824645f642dacbe92e7f4105
Summary:
As discussed with lblasa. This solves a few issues:
- Confusing names in `ps` and Activity Monitor related to Flipper.
- Permission requests for the Keychain from "node" lead users to deny it.
- Seeing "node" as allowed apps for an entry in Keychain is confusing.
Reviewed By: lblasa
Differential Revision: D50232337
fbshipit-source-id: 3bc92aae0ca31d1a80582fb8a794bbc64fc2f2e5
Summary:
Even though node docs state
> Assigning a value to process.title might not result in an accurate label within process manager applications such as macOS Activity Monitor or Windows Services Manager.
Locally this worked for me on M1 machine. Will test on intel as well.
Reviewed By: lblasa
Differential Revision: D50228844
fbshipit-source-id: 69937ded7da259e05335df50332ea114ff566f21
Summary:
Use an URLProvider paired with a token provider for attempts to establish a websocket connection.
This gives extra flexibility whenever a token is not available or changes as the ReconnectingWebSocket will call the URLProvider after each unsuccessful connection.
Reviewed By: antonk52
Differential Revision: D50220329
fbshipit-source-id: f53993a90c9c0f64bf213019b6b8af5fa818048d
Summary:
The logs written to the file shouldn't be JSON.
It just makes it hard to read and there's no tool to process this either.
Instead, write the logs as seeing in the console for easier reading.
Reviewed By: antonk52
Differential Revision: D50219806
fbshipit-source-id: a07fb53a10b36e1a3c2992a133b8c0c818bd816b
Summary:
This will automatically invoke the "Start" button if Flipper detect it is offline, to automate that step. It will do so only once
(safe for the reload logic that also triggers on server errors, not sure if that was intentionally?)
Reviewed By: lblasa
Differential Revision: D50074673
fbshipit-source-id: 2c11e80429a2c4ed0e43e62cb2f6057fad5eb410
Summary: This should help us to make flipper more reliable and avoid failing loading plugins if they are loaded from cache(old ones)
Reviewed By: lblasa
Differential Revision: D50081726
fbshipit-source-id: edef9999ad44660331153a082e15c6f3f5de9b05
Summary:
This change will allow us to display correct stack traces in flipper UI as well as send them to scuba.
Currently correct stack traces are only displayed in the console and we do not have access to them.
Reviewed By: ivanmisuno
Differential Revision: D50015827
fbshipit-source-id: 2a60315dd5c06b2635ce0414f612ff1fdca0e489
Summary:
There used to be a flag to control whether we wanted to replace an existing running instance.
No longer in use so safe to delete.
Reviewed By: antonk52
Differential Revision: D50077975
fbshipit-source-id: 8d7bad1f85e4520fd006cdcabe6e9899468688cc
