Summary:
Setup Doctor can be used to discover installation issues. I've seen numerous times when there's a setup issue but users didn't check / bother with using the tool.
Instead, if there's an issue, show the screen regardless.
Reviewed By: mweststrate
Differential Revision: D50642080
fbshipit-source-id: 10eb7a758a61765a5b06d398f5041897fff6280e
Summary:
In the new sidebar design complex types are behind a preview. before states was an array under the key states.
Now we create a top level attribute according to its index
Reviewed By: lblasa
Differential Revision: D50654698
fbshipit-source-id: 410c50c5f1ab14efc77184a5b147d9bdf70761d4
Summary:
Allows more content on screen. Final diff of stack
Changelog: UIDebugger, new sidebar design
Reviewed By: lblasa
Differential Revision: D50595987
fbshipit-source-id: 436af4191dba37f7a0f41dca23ab6349856358cd
Summary: This filtering scheme is extremely basic, we only filter based on top level fields. Other schemes I considered were somewhat confusing and this works well in most if not all cases
Reviewed By: lblasa
Differential Revision: D50595986
fbshipit-source-id: 90cb82f8fc482fd4c6f996ff9e857f27766df544
Summary: This was not handled and arrays were not properly transformed
Reviewed By: lblasa
Differential Revision: D50595983
fbshipit-source-id: cae8777c653cc9fc2a1ea8cab05b3df476121855
Summary:
This is only really an issue in theUIDebugger where we have a dynamic number of tabs. on some nodes you have 3 tabs, on others you have 2. if you select the 3rd tab and move to a node with 2 tabs nothing will be selected.
With this fix we will fallback to the first tab
Reviewed By: lblasa
Differential Revision: D50595977
fbshipit-source-id: 25c36a5609f774c2d3fd650eb6520104864fbe95
Summary:
Complex nested arrays and objects are displayed in a modal since there isnt enough space to it practically.
Not many attributes in practice fall into this category
Reviewed By: lblasa
Differential Revision: D50595981
fbshipit-source-id: b1eda93c448de19c8803d64eb4cf105e2b6636a8
Summary: we show rbga on one line, and hex + preview on second line
Reviewed By: lblasa
Differential Revision: D50595979
fbshipit-source-id: 86015ceeb5e64e67fb85e3431f85916f7d175ca2
Summary:
in the figma design we have the concept of subsections which are single level deep objects shown inline
{F1126292520}
More complex nested objects are shown a a preview that you have to click on and will come later
Reviewed By: lblasa
Differential Revision: D50595984
fbshipit-source-id: ea831731b87ce9968516129cf177953e200cf4d5
Summary: This seems to be (no longer) in use.
Reviewed By: lblasa
Differential Revision: D50659072
fbshipit-source-id: 0fde643711ee4859a5d270a878d858694337d6a5
Summary: This seems to be (no longer) in use.
Reviewed By: lblasa
Differential Revision: D50645304
fbshipit-source-id: 6d8e89a376f57e9dccafe899cfb2be85271329c9
Summary: This seems to be (no longer) in use.
Reviewed By: lblasa
Differential Revision: D50645270
fbshipit-source-id: 69cf276f97d960a16ffd3e48342420b33fa646da
Summary:
A few fixes.
1. We were ignoring start and end inputs, they are now sent to desktop
2. we were computing our own version of the resolved (computed ) values for border padding and margin. We are now using the correct about from litho getLayoutX
Removed some code duplication
Unfortunatley getLayoutBorderWidth is not available in open source yet so will need to land that first
Reviewed By: adityasharat
Differential Revision: D50496369
fbshipit-source-id: 7960a5d338adb40175f48982150665e046688fe1
Summary: No need to show this for Electron releases. Also, this becomes important once we make the final Electron release.
Reviewed By: aigoncharov
Differential Revision: D50557052
fbshipit-source-id: 803a9c9ad21fbff39147ac06add74888b9ee4091
Summary: Turns out this can be null in some rare circumstances and can cause a crash in the fragment tracker
Reviewed By: aigoncharov
Differential Revision: D50562123
fbshipit-source-id: 4dfaecfde69359a85b778fc5ff0a4a3a8165a875
Summary: Previously I had created a RN build, locally, with a few minor differences. That had to be reverted. Instead of reverting and re-applying changes, I'm introducing a flag that can be used in the interim to produce the RN-only builds.
Reviewed By: LukeDefeo
Differential Revision: D50555055
fbshipit-source-id: edface9a1587fb51e54eebe73724032baf985c83
Summary: Log as console . error so we get a log view and inform the user
Reviewed By: lblasa
Differential Revision: D50450794
fbshipit-source-id: 0eb1877eec4d602d6673dd2815af2692e89b2523
Summary:
Preparing for next Robolectric version which drops support for SDK 16-18.
`MemoryToolsFlipperPluginTest` relies on JSON serialization order which changes when running on the latest SDK (33).
`InspectorFlipperPluginTest` has multiple issues when running on the latest SDK, so just bump it to 19.
Reviewed By: jiawei-lyu
Differential Revision: D50558702
fbshipit-source-id: 9724d8e699b703a9e0af12559c41e7053d820150
Summary:
`tempdir` has been deprecated since 2018:
https://github.com/rust-lang-deprecated/tempdir/pull/46
It's functionality was merged into `tempfile` with minor tweaks:
- Methods names: `new` -> `with_prefix`, `new_in` -> `with_prefix_in`.
- `with_prefix_in`'s args order is reversed.
- Temp dirs no longer have a period between the prefix and the random
name (before `foo.123abc`, now `foo123abc`).
Reviewed By: shayne-fletcher
Differential Revision: D50526255
fbshipit-source-id: bdb3b53a6b09a09c70c8e2533ad2cea46ee2842b
Summary:
The current '--mac' arg builds all supported architectures. This is great when generating release builds but not so much when testing a release for the current architecture.
Not modifying the existing '--mac' arg as to not update our current CI.
Reviewed By: antonk52
Differential Revision: D50497211
fbshipit-source-id: 3e4d9728adc822c48788556e2ea47f4dd1c21b05
Summary:
Currently we download a bunch of FB icons and we normally use the smallest one available.
In this diff I change the download logic so we try to download from the largest to the smallest icon and use the first one available. One the client we no longer provide the icon of the same size that is requested, instead we provide the only one we have which will typically be larger than needed. This is a good thing because
1. flipper is a local application and we do not need to worry about icons take up broadband and downloading
2. People have high density displayed
I also stopped using density(rest of related code removed in the next diff) for icons as it the icons themselves did not support it.
Reviewed By: lblasa
Differential Revision: D50495194
fbshipit-source-id: f569c2f3b8ee424a67c6d21136e7e113868b8f6a
