ee013e29fca1c1ac31d341a26c275c6ebba000eb
123 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
Pascal Hartig
|
39317adfb7 |
Disable flaky PluginContainer test (#3693)
Summary: Keeps flaking out: https://github.com/facebook/flipper/runs/6308722109?check_suite_focus=true Pull Request resolved: https://github.com/facebook/flipper/pull/3693 Reviewed By: aigoncharov Differential Revision: D36170437 Pulled By: passy fbshipit-source-id: 471e702243d68d927287aad5d1fc1d8c392b059c |
||
|
Pascal Hartig
|
342e22bd87 |
Upgrade more /desktop deps
Summary: More bumps for patch and minor releases. allow-large-files Reviewed By: aigoncharov Differential Revision: D36104098 fbshipit-source-id: 6db995e660afbe4febd72aa70ed8150cc16a8c93 |
||
Anton Nikolaev
|
46340fa30a |
Fix UI freezes on popup opening by upgrading back React app creation from "createRoot" to "ReactDOM.render"
Summary: Fix UI freezes on popup opening by upgrading back React app creation from "createRoot" to "ReactDOM.render". These UI freezes started to happen after React upgrade because the issue in integration of Antd with React 18: https://github.com/react-component/trigger/issues/288 Reviewed By: aigoncharov Differential Revision: D35359129 fbshipit-source-id: eb0ad979443ecf67eb2acc2e219196c9fefcff62 |
||
Andrey Goncharov
|
ba9a80545d |
Support globally installed React DevTools
Summary: - Support loading globally installed DevTools Background: 1. Initially, I wanted to use react-devtools-core as before. react-devtools-core standalone contains quite a few imports of node.js APIs. After [a conversation with Brian](https://fb.workplace.com/groups/react.devtools/permalink/3131548550392044), I pivoted to react-devtools-inline 2. Technical design doc of react-devtools-inline integration: https://docs.google.com/document/d/1STUSUhXzrW_KkvqSu7Ge-rxjVFF7oU3_NbwzimkO_Z4 3. We support usage of globally installed devtools. Code of react-devtools-inline is not ready to be used by the browser as is. We need to bundle it and substitute React and ReactDOM imports with the globals. 4. As we can't pre-compile what users install globally, we need to bundle global devtools on demand, 5. I tried re-using our Metro bundling pipeline initially, but gave up after fighting it for 2 days. Included, `rollup` instead. 6. Size of a `tgz` archive with a plugin is 2.1MB allow-large-files Reviewed By: mweststrate Differential Revision: D34968770 fbshipit-source-id: 352299964ccc195b8677dbda47db84ffaf38737b |
||
|
Andrey Goncharov
|
1f83b4b414 |
Migrate to React 18
Summary: Sadly, we have to use the experimental version of React to decapitate React Devtools. See https://fb.workplace.com/groups/react.devtools/posts/3135684459978453/?comment_id=3135711763309056&reply_comment_id=3135760513304181 On the bright side, Replay.io and Code Sandbox also use experimental React without any problem. Reviewed By: lblasa Differential Revision: D34926473 fbshipit-source-id: 5cd63cc065c2535f0583464c7b5e37891dadaf14 |
||
dependabot[bot]
|
e42d232132 |
Bump react-player from 2.9.0 to 2.10.0 in /desktop (#3565)
Summary: Bumps [react-player](https://github.com/CookPete/react-player) from 2.9.0 to 2.10.0. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/cookpete/react-player/blob/master/CHANGELOG.md">react-player's changelog</a>.</em></p> <blockquote> <h4><a href="https://github.com/cookpete/react-player/compare/v2.9.0...v2.10.0">v2.10.0</a></h4> <ul> <li>Added .m4b extension to AUDIO_EXTENSIONS <a href="https://github-redirect.dependabot.com/cookpete/react-player/pull/1415"><code>[https://github.com/facebook/flipper/issues/1415](https://github.com/CookPete/react-player/issues/1415)</code></a></li> <li>Adjust listener for kaltura <a href="https://github-redirect.dependabot.com/cookpete/react-player/pull/1226"><code>[https://github.com/facebook/flipper/issues/1226](https://github.com/CookPete/react-player/issues/1226)</code></a></li> <li>update default HLS version to latest release <a href="https://github-redirect.dependabot.com/cookpete/react-player/pull/1402"><code>[https://github.com/facebook/flipper/issues/1402](https://github.com/CookPete/react-player/issues/1402)</code></a></li> <li>Make pre-publish.js ES5 compatible <a href="https://github-redirect.dependabot.com/cookpete/react-player/pull/1393"><code>[https://github.com/facebook/flipper/issues/1393](https://github.com/CookPete/react-player/issues/1393)</code></a></li> <li>fix: Add exception handling when seekTo is called with amount value 0 <a href="https://github-redirect.dependabot.com/cookpete/react-player/pull/1372"><code>[https://github.com/facebook/flipper/issues/1372](https://github.com/CookPete/react-player/issues/1372)</code></a></li> <li>Add onSeek support to Twitch player <a href="https://github-redirect.dependabot.com/cookpete/react-player/pull/1354"><code>[https://github.com/facebook/flipper/issues/1354](https://github.com/CookPete/react-player/issues/1354)</code></a></li> <li>Add attributes in FacebookConfig type <a href="https://github-redirect.dependabot.com/cookpete/react-player/pull/1351"><code>[https://github.com/facebook/flipper/issues/1351](https://github.com/CookPete/react-player/issues/1351)</code></a></li> <li>handle setPlaybackRate error <a href="https://github-redirect.dependabot.com/cookpete/react-player/pull/1223"><code>[https://github.com/facebook/flipper/issues/1223](https://github.com/CookPete/react-player/issues/1223)</code></a></li> <li>Add onPlaybackRateChange callback prop <a href="https://github-redirect.dependabot.com/cookpete/react-player/pull/1224"><code>[https://github.com/facebook/flipper/issues/1224](https://github.com/CookPete/react-player/issues/1224)</code></a></li> <li>Ability to pass null to previewTabIndex <a href="https://github-redirect.dependabot.com/cookpete/react-player/pull/1256"><code>[https://github.com/facebook/flipper/issues/1256](https://github.com/CookPete/react-player/issues/1256)</code></a></li> <li>Add media attribute to source tag in file player <a href="https://github-redirect.dependabot.com/cookpete/react-player/pull/1269"><code>[https://github.com/facebook/flipper/issues/1269](https://github.com/CookPete/react-player/issues/1269)</code></a></li> <li>fix: don't defer MediaStream <a href="https://github-redirect.dependabot.com/cookpete/react-player/pull/1230"><code>[https://github.com/facebook/flipper/issues/1230](https://github.com/CookPete/react-player/issues/1230)</code></a></li> <li>add title attribute to vimeo iframe <a href="https://github-redirect.dependabot.com/cookpete/react-player/pull/1229"><code>[https://github.com/facebook/flipper/issues/1229](https://github.com/CookPete/react-player/issues/1229)</code></a></li> <li>Add oEmbedUrl as changeable prop <a href="https://github-redirect.dependabot.com/cookpete/react-player/pull/1333"><code>[https://github.com/facebook/flipper/issues/1333](https://github.com/CookPete/react-player/issues/1333)</code></a></li> <li>update video extenstions to accept media fragments for time <a href="https://github-redirect.dependabot.com/cookpete/react-player/pull/1213"><code>[https://github.com/facebook/flipper/issues/1213](https://github.com/CookPete/react-player/issues/1213)</code></a></li> <li>Add type for wrapper in base.d.ts <a href="https://github-redirect.dependabot.com/cookpete/react-player/pull/1234"><code>[https://github.com/facebook/flipper/issues/1234](https://github.com/CookPete/react-player/issues/1234)</code></a></li> <li>Make facebook config type properties optional <a href="https://github-redirect.dependabot.com/cookpete/react-player/pull/1314"><code>[https://github.com/facebook/flipper/issues/1314](https://github.com/CookPete/react-player/issues/1314)</code></a></li> <li>Add disableDeferredLoading prop <a href="https://github-redirect.dependabot.com/cookpete/react-player/issues/1396"><code>[https://github.com/facebook/flipper/issues/1396](https://github.com/CookPete/react-player/issues/1396)</code></a></li> <li>Support new vimeo external link format <a href="https://github-redirect.dependabot.com/cookpete/react-player/issues/1399"><code>[https://github.com/facebook/flipper/issues/1399](https://github.com/CookPete/react-player/issues/1399)</code></a></li> <li>Tweak Vidyard pattern <a href="https://github-redirect.dependabot.com/cookpete/react-player/issues/1373"><code>[https://github.com/facebook/flipper/issues/1373](https://github.com/CookPete/react-player/issues/1373)</code></a></li> <li>Adjust listener for kaltura (<a href="https://github-redirect.dependabot.com/CookPete/react-player/issues/1226">https://github.com/facebook/flipper/issues/1226</a>) <a href="https://github-redirect.dependabot.com/cookpete/react-player/issues/1202"><code>[https://github.com/facebook/flipper/issues/1202](https://github.com/CookPete/react-player/issues/1202)</code></a></li> <li>Update caniuse-lite <a href=" |
||
Michel Weststrate
|
011c5eeafa |
Fix expired tokens showing as being correctly logged in
Summary: In the category "how did this ever work", we had quite some reports of Flipper features not working while users are seemingly logged in. The cause of that is because the user info gets stored in the user reducer, so even when the network requests fail, the users appear to be logged in. Reviewed By: nikoant Differential Revision: D35114048 fbshipit-source-id: b8c09cb4e3fd7cd0cbe87ecb06dafca88716b689 |
||
|
dependabot[bot]
|
7f68a4d673 |
Bump antd from 4.18.5 to 4.19.2 in /desktop (#3551)
Summary: Pull Request resolved: https://github.com/facebook/flipper/pull/3551 Bumps [antd](https://github.com/ant-design/ant-design) from 4.18.5 to 4.19.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ant-design/ant-design/releases">antd's releases</a>.</em></p> <blockquote> <h2>4.19.2</h2> <ul> <li>🐞 Fix Dropdown not auto adjust placement when position on the edge of window. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34390">#34390</a></li> <li>💄 Change PageHeader elements margin from <code>12px</code> to <code>8px</code> inside <code>extra</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34428">#34428</a></li> <li>🛠 Export css variable function in <code>antd/es/config-provider</code> folder to enable ssr requirement. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34436">#34436</a></li> <li>🛠 Refactor Menu with React hooks. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34433">#34433</a></li> <li>Input <ul> <li>💄 Fix Input font-size when <code>size</code> is large. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34381">#34381</a></li> <li>💄 Fix Input.Group wrong border when status is error. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34412">#34412</a></li> </ul> </li> <li>Form <ul> <li>🐞 Fix Form.Item removed in <code>form.validateFields</code> throw <code>Can't perform a React state update on an unmounted component</code> warning. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34405">#34405</a></li> <li>🐞 Fix to Form that <code>initialValues</code> would change if <code>preserve</code> is false. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34411">#34411</a></li> </ul> </li> <li>Tooltip <ul> <li>💄 Fix Tooltip width in Safari. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34415">#34415</a> <a href="https://github.com/jiandandkl"><code>@jiandandkl</code></a></li> <li>💄 Fix arrow size of Tooltip/Popover/Popconfirm. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34407">#34407</a></li> </ul> </li> <li>💄 Remove Collapse bottom border in simple style. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34366">#34366</a> <a href="https://github.com/PanStar"><code>@PanStar</code></a></li> <li>TypeScript <ul> <li>� Fix Input <code>data-*</code> type definition. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34410">#34410</a> <a href="https://github.com/GitKou"><code>@GitKou</code></a></li> <li>� Fix Transfer <code>footer</code> type definition. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34337">#34337</a> <a href="https://github.com/zomixi"><code>@zomixi</code></a></li> </ul> </li> </ul> <hr /> <ul> <li>🐞 修复 Dropdown 在边界情况下不会自动调整展示位置的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34390">#34390</a></li> <li>💄 缩小 PageHeader <code>extra</code> 内元素间距为 <code>8px</code>。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34428">#34428</a></li> <li>🛠 导出 antd/es/config-provider 目录下的 css variable 函数以支持 ssr 的需求。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34436">#34436</a></li> <li>🛠 使用 React hooks 重构 Menu。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34433">#34433</a></li> <li>Input <ul> <li>💄 修复大尺寸 Input 的字号问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34381">#34381</a></li> <li>💄 修复 Input.Group 多余的错误边框样式。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34412">#34412</a></li> </ul> </li> <li>Form <ul> <li>🐞 修复 Form.Item 在 <code>form.validateFields</code> 中移除时抛出 <code>Can't perform a React state update on an unmounted component</code> 警告的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34405">#34405</a></li> <li>🐞 修复 Form 组件当 <code>preserve</code> 为 <code>false</code> 时 <code>initialValues</code> 会被更改的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34411">#34411</a></li> </ul> </li> <li>Tooltip <ul> <li>💄 修复 Tooltip 在 Safari 下的内容宽度问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34415">#34415</a> <a href="https://github.com/jiandandkl"><code>@jiandandkl</code></a></li> <li>💄 修复 Tooltip/Popover/Popconfirm 等组件箭头大小问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34407">#34407</a></li> </ul> </li> <li>💄 优化 Collapse 简洁模式的底边框。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34366">#34366</a> <a href="https://github.com/PanStar"><code>@PanStar</code></a></li> <li>TypeScript <ul> <li>� 修复 Input 不支持 <code>data-*</code> TS 定义的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34410">#34410</a> <a href="https://github.com/GitKou"><code>@GitKou</code></a></li> <li>� 修复 Transfer 的 <code>footer</code> 类型定义。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34337">#34337</a> <a href="https://github.com/zomixi"><code>@zomixi</code></a></li> </ul> </li> </ul> <h2>4.19.1</h2> <ul> <li>🐞 Fix less compile error related to custom status. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34350">#34350</a> <ul> <li>🐞 Fix error <code>ReferenceError: colorPalette is not defined</code> when customize theme.</li> <li>🐞 Fix error <code>Error: Invalid class or id selector syntax</code> when import <code>antd/dist/antd.css</code>.</li> </ul> </li> <li>🐞 Fix Input.Passowrd icon color in site. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34354">#34354</a></li> <li>🐞 Fix ConfigProvider <code>csp</code> sometime not effect on Icon. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34356">#34356</a></li> </ul> <hr /> <ul> <li>🐞 修复自定义状态相关的 less 编译错误 <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34350">#34350</a> <ul> <li>🐞 修复使用定制主题时 less 编译提示 <code>ReferenceError: colorPalette is not defined</code> 错误。</li> <li>🐞 修复引入 <code>antd/dist/antd.css</code> 时提示 <code>Error: Invalid class or id selector syntax</code> 错误。</li> </ul> </li> <li>🐞 修复 Input.Passowrd 图标颜色错误。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34354">#34354</a></li> <li>🐞 修复 ConfigProvider <code>csp</code> 有时在 Icon 上不会生效的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34356">#34356</a></li> </ul> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ant-design/ant-design/blob/master/CHANGELOG.en-US.md">antd's changelog</a>.</em></p> <blockquote> <h2>4.19.2</h2> <p><code>2022-03-13</code></p> <ul> <li>🐞 Fix Dropdown not auto adjust placement when position on the edge of window. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34390">#34390</a></li> <li>💄 Change PageHeader elements margin from <code>12px</code> to <code>8px</code> inside <code>extra</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34428">#34428</a></li> <li>🛠 Export css variable function in <code>antd/es/config-provider</code> folder to enable ssr requirement. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34436">#34436</a></li> <li>🛠 Refactor Menu with React hooks. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34433">#34433</a></li> <li>Input <ul> <li>💄 Fix Input font-size when <code>size</code> is large. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34381">#34381</a></li> <li>💄 Fix Input.Group wrong border when status is error. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34412">#34412</a></li> </ul> </li> <li>Form <ul> <li>🐞 Fix Form.Item removed in <code>form.validateFields</code> throw <code>Can't perform a React state update on an unmounted component</code> warning. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34405">#34405</a></li> <li>🐞 Fix to Form that <code>initialValues</code> would change if <code>preserve</code> is false. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34411">#34411</a></li> </ul> </li> <li>Tooltip <ul> <li>💄 Fix Tooltip width in Safari. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34415">#34415</a> <a href="https://github.com/jiandandkl"><code>@jiandandkl</code></a></li> <li>💄 Fix arrow size of Tooltip/Popover/Popconfirm. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34407">#34407</a></li> </ul> </li> <li>💄 Remove Collapse bottom border in simple style. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34366">#34366</a> <a href="https://github.com/PanStar"><code>@PanStar</code></a></li> <li>TypeScript <ul> <li>� Fix Input <code>data-*</code> type definition. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34410">#34410</a> <a href="https://github.com/GitKou"><code>@GitKou</code></a></li> <li>� Fix Transfer <code>footer</code> type definition. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34337">#34337</a> <a href="https://github.com/zomixi"><code>@zomixi</code></a></li> </ul> </li> </ul> <h2>4.19.1</h2> <p><code>2022-03-08</code></p> <ul> <li>🐞 Fix less compile error related to custom status. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34350">#34350</a> <ul> <li>🐞 Fix error <code>ReferenceError: colorPalette is not defined</code> when customize theme.</li> <li>🐞 Fix error <code>Error: Invalid class or id selector syntax</code> when import <code>antd/dist/antd.css</code>.</li> </ul> </li> <li>🐞 Fix Input.Passowrd icon color in site. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34354">#34354</a></li> <li>🐞 Fix ConfigProvider <code>csp</code> sometime not effect on Icon. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34356">#34356</a></li> </ul> <h2>4.19.0</h2> <p><code>2022-03-08</code></p> <ul> <li> <p>💄 Optimize arrow style for some components. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33710">#33710</a></p> </li> <li> <p>Input</p> <ul> <li>🛠 Refactor Input with rc-input. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34206">#34206</a> <ul> <li>Attention: The type and value of <code>ref</code> is modified because of refactoring from class component to function component. You can still get DOM node from <code>input</code>, and other methods such as <code>focus</code> and <code>blur</code> mentioned in document are also supported.</li> </ul> </li> <li>🆕 Support <code>clearIcon</code> prop for customizing clear icon. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34325">#34325</a></li> </ul> </li> <li> <p>Table</p> <ul> <li>🆕 <code>filterSearch</code> now support passing function to customize search. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34085">#34085</a> <a href="https://github.com/heiyu4585"><code>@heiyu4585</code></a></li> <li>🆕 <code>column.filterDropdown({ clearFilters })</code> support <code>clearFilters({ confirm: false, closeDropdown: false })</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34120">#34120</a> <a href="https://github.com/heiyu4585"><code>@heiyu4585</code></a></li> <li>⌨️ Table adds <code>aria-sort</code> attribute for screen readers. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33603">#33603</a> <a href="https://github.com/dgreene1"><code>@dgreene1</code></a></li> <li>🐞 Fix Table filters select-all Checkbox not changed when select item. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/34295">#34295</a></li> </ul> </li> <li> <p>🆕 Data entry components add <code>status</code> prop to support custom status.</p> </li> </ul> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
dependabot[bot]
|
5685d774a9 |
Bump @emotion/react from 11.8.1 to 11.8.2 in /desktop (#3533)
Summary: Bumps [emotion/react](https://github.com/emotion-js/emotion) from 11.8.1 to 11.8.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/emotion-js/emotion/releases"><code>@emotion/react</code>'s releases</a>.</em></p> <blockquote> <h2><code>@emotion/react</code><a href="https://github.com/11"><code>@11</code></a>.8.2</h2> <h3>Patch Changes</h3> <ul> <li><a href="https://github-redirect.dependabot.com/emotion-js/emotion/pull/2677">https://github.com/facebook/flipper/issues/2677</a> <a href=" |
||
|
dependabot[bot]
|
1112175aca |
Bump @testing-library/react from 12.1.3 to 12.1.4 in /desktop (#3527)
Summary: Bumps [testing-library/react](https://github.com/testing-library/react-testing-library) from 12.1.3 to 12.1.4. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/testing-library/react-testing-library/releases"><code>@testing-library/react</code>'s releases</a>.</em></p> <blockquote> <h2>v12.1.4</h2> <h2><a href="https://github.com/testing-library/react-testing-library/compare/v12.1.3...v12.1.4">12.1.4</a> (2022-03-09)</h2> <h3>Bug Fixes</h3> <ul> <li>Match runtime type of baseElement in TypeScript types (<a href="https://github-redirect.dependabot.com/testing-library/react-testing-library/issues/1023">https://github.com/facebook/flipper/issues/1023</a>) (<a href=" |
||
Lorenzo Blasa
|
f8371b19db |
Not clearing up a previous client connection should not log as error
Summary: ^ This doesn't seem a functionality impairment and there's no actionable items. Reviewed By: lawrencelomax Differential Revision: D34787962 fbshipit-source-id: 9fe42187456bfab3748d469860f6ed7cda2f83d5 |
||
|
Pascal Hartig
|
8372d07ae6 |
Demote "failed to find device" error
Summary: This is not actionable for us as it includes changing device identifiers. In this case it's better to rely on individual user reports if this is about a particular device/app combo. Reviewed By: lawrencelomax Differential Revision: D34749996 fbshipit-source-id: 88c6c8b076b3f7d9808b6a2a9b08854d2d7cb39f |
||
|
dependabot[bot]
|
e5a8ba3ea9 |
Bump console-feed from 3.2.2 to 3.3.0 in /desktop (#3504)
Summary: Bumps [console-feed](https://github.com/samdenty99/console-feed) from 3.2.2 to 3.3.0. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/samdenty99/console-feed/commits">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `dependabot rebase` will rebase this PR - `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `dependabot merge` will merge this PR after your CI passes on it - `dependabot squash and merge` will squash and merge this PR after your CI passes on it - `dependabot cancel merge` will cancel a previously requested merge and block automerging - `dependabot reopen` will reopen this PR if it is closed - `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Pull Request resolved: https://github.com/facebook/flipper/pull/3504 Reviewed By: lblasa Differential Revision: D34718814 Pulled By: passy fbshipit-source-id: 248418bf460abbd4849d09c946fd8d6deccdc54b |
||
|
Pascal Hartig
|
9d390d0864 |
Dep bump for /desktop
Summary: Combining dependabot bumps. Reviewed By: nikoant Differential Revision: D34682717 fbshipit-source-id: 09975ed9f258d2f5bed6871e15643c38a07e0459 |
||
|
Anton Nikolaev
|
37ff34390a |
Enable Marketplace for Flipper (#3491)
Summary: This is PR on top of: https://github.com/facebook/flipper/pull/3473 It adds an option to Settings to allow distribution of marketplace plugins. Also includes a simple fetch function to retrieve data from external API/server. ## Changelog Allow marketplace plugins Pull Request resolved: https://github.com/facebook/flipper/pull/3491 Test Plan: 1. Enable marketplace 2. Provide custom marketplace server (it will serve the list of internal plugins with downloadURL) 3. Test if can see Available plugins and can download/remove the plugin 4. If new update for the plugin, it should also allow auto update Reviewed By: antonk52 Differential Revision: D34586339 Pulled By: nikoant fbshipit-source-id: c887982aa0f0f9abd3b5360f22e8692a2445d345 |
||
|
Andrey Goncharov
|
6c74f2dd18 |
Set device features on device initialization
Summary: 1. Identify if device supports screenshots/screen recording when it is created. 2. Disable screen recording/screenshot buttons when they are not supported Reviewed By: passy Differential Revision: D34611133 fbshipit-source-id: 82ad2d67e4af482d9becf7995187667b5d99bc36 |
||
|
Pascal Hartig
|
7c1251075f |
Dep bump for /desktop
Summary: Combining a bunch of dependabot PRs. N.B. I had to manually clean up the `yarn.lock` a few times because some dependencies resolved to multiple version numbers, catching tsc off-guard. allow-large-files Reviewed By: nikoant Differential Revision: D34579180 fbshipit-source-id: a4848e1010ff240d9b0e721d3878585e7b4bd078 |
||
|
Andrey Goncharov
|
5068c8273b |
Add deprecation notice notification
Summary: Add deprecation notice device icon and notification Reviewed By: lblasa Differential Revision: D34582475 fbshipit-source-id: 90fde15caf1925b42f50fbfc77dece88c82833cf |
||
|
Andrey Goncharov
|
8b94186783 |
Load installed server add-ons
Reviewed By: nikoant Differential Revision: D34300475 fbshipit-source-id: 6bb6c0ab811e28806a0924b3487931bdb0dd2c59 |
||
|
Andrey Goncharov
|
b4b9c0ab28 |
Implement receiving messages from add-on on the client
Reviewed By: mweststrate Differential Revision: D34249101 fbshipit-source-id: 07297b84ed8640e3b41599726ba613b6b4e2b62e |
||
|
Andrey Goncharov
|
4067f5bd88 |
Implement sending messages from desktop to add-on
Reviewed By: antonk52 Differential Revision: D34239803 fbshipit-source-id: 1a18d522ba877ade3d0703fbb374c15b596241d7 |
||
|
Andrey Goncharov
|
3b390b74ff |
Track client connections and autostop server add-ons when all clients leave
Reviewed By: mweststrate Differential Revision: D34045584 fbshipit-source-id: 1ad0cfffb9d304f0359c973d76d6956f7e932f72 |
||
|
Andrey Goncharov
|
9113006851 |
Make Client initialize server add-ons
Reviewed By: mweststrate Differential Revision: D34044353 fbshipit-source-id: 99bcb1559787b2a904bdd796233666a7a4783ea4 |
||
|
Anton Nikolaev
|
38c81ca159 |
Make internal plugin distribution code publicly available (#3473)
Summary: Pull Request resolved: https://github.com/facebook/flipper/pull/3473 This diff is the first one which addresses https://github.com/facebook/flipper/issues/3320. In this diff we are making a part of the code used for internal Flipper plugin distribution in Meta also available publicly for re-using in other orgs. Some explanation on how plugin installation and updates is designed now: 1) We periodically poll for plugins available for download. API for retrieving available plugins list is abstracted and will be different between public and fb versions, however all other logic is re-used. 2) In addition to "Enabled" and "Disabled" plugins in the left panel Flipper shows "Detected in App" list. Plugins in this list are those which are known compatible with the currently selected device/app, but not yet installed. 3) User can install any of "Detected in App" plugins by clicking to "Download and install" button near them in the left panel similarly to enabling plugins in "Disabled" list. 4) If we detect that for some installed plugin we have a newer version available for download - we download it silently and store on disk. 5) If the plugin for which we have new downloaded version is disabled - we update it silently without any notifications by loading new version from the disk and unloading the previous version from cache. 6) If the plugin for which we have new downloaded version is enabled then we avoid updating it automatically (because we need to reset plugin state in such case) and instead show notification on top of the plugin and ask user to reload it to apply new version. On reloading we reset the plugin state. 7) On Flipper startup we always update all plugins to their latest versions available on the disk. Reviewed By: aigoncharov Differential Revision: D34380308 fbshipit-source-id: a94d724e42aa5ef78445af266fcd4c424226a703 |
||
|
Anton Nikolaev
|
5da0a83a36 |
Refactor recommended plugin API
Summary: This is just refactoring in preparation to open-sourcing internal plugin distribution code to make it available for other orgs so they can distribute their internal plugins. See other diffs in the same stack. This diff moves recommended plugins handling from `pluginMarketplace` which will be the same for fb-internal and OS versions into `pluginMarketplaceAPI` which will differ for fb-internal and OS versions. This will make it possible for other orgs to define their own "recommended" plugins which then will be automatically installed/enabled for new users. Reviewed By: aigoncharov Differential Revision: D34379981 fbshipit-source-id: 5c3a4efb6d0171256cf508f9005d914d7332e14f |
||
|
Lorenzo Blasa
|
77ab722b52 |
Better notification messaging
Summary: 'Failed to start connection server' is a bit misleading. 'server-error' is used for both server and client errors. Changelog: Better notification messaging Reviewed By: aigoncharov Differential Revision: D34269045 fbshipit-source-id: f51a28fc0e9ba394b464e5bfca4d0e497f740b1b |
||
|
Pascal Hartig
|
1910d3b713 |
Bump dependencies in /desktop
Summary: Combining green-ticked upgrades from GitHub into one push. Reviewed By: lblasa Differential Revision: D34212788 fbshipit-source-id: 12b207a05b9df08eac5b5c58fe1025932c448258 |
||
|
Michel Weststrate
|
762267bccc |
Fix name casing to make plugin more easily findable
Summary: Noticed in https://fb.workplace.com/groups/flippersupport/permalink/1305583723255616/ that always shows at the end of the plugin list. Fixed this on two levels: 1. uppercase the title for consistency 2. Make sorting case insensitive Differential Revision: D33985518 fbshipit-source-id: 70bed519e1ae5b3251b103931472844b2b55a512 |
||
|
Michel Weststrate
|
e4a3696fd5 |
Don't create always rejecting promises for timeout
Summary: Our existing `timeout` implementation was always throwing an exception, due to sleeping and then throw an exception, which is than handled but ignored by `Promise.race`. This implementation has a few problems 1. Because it always throws, having a debugger session with 'break on caught exceptions' will pause on every usage of timeout (rather than just the ones that actually timeout). This makes this way of debugging a bit useless. 2. Throwing exceptions is in principle an expensive process (due to the stack trace generation) 3. Not cancelling the timeout used by sleep is a bit of a waste as well Reviewed By: lawrencelomax Differential Revision: D33982717 fbshipit-source-id: d739c02112e1c1bc4cd691af852371d08a99abc6 |
||
Bartosz Kaszubowski
|
6639b547dd |
UI: fix hover effect of LeftRail icons with badge (#3372)
Summary: This PR fixes the missing hover effect for the `LeftRail` component buttons, when they have included the badge. To fix the issue, I had to wrap the whole `Button` with `Badge` component (instead wrapping only around icon). However, this solution required to added `offset` property to the `Badge` which moves the indicator to the position prior change (otherwise indicator was moved to the right corner of the button). The file has been formatted after the changes with ESLint. **Edit:** I have also spotted that this change fixes the icon placement inside the button, when badge is present. Earlier, as seen below, the log icon was moved towards the top of the button: <img width="111" alt="Screenshot 2022-01-31 at 00 57 49" src="https://user-images.githubusercontent.com/719641/151723422-0ffb83ee-5806-412e-9191-f9953f78532e.png"> ## Changelog [desktop] UI: fix hover effect of LeftRail icons with badge Pull Request resolved: https://github.com/facebook/flipper/pull/3372 Test Plan: The change has been testes by running the desktop Flipper app locally from source. ## Preview (before & after) #### Before <img width="1339" alt="Screenshot 2022-01-31 at 00 24 23" src="https://user-images.githubusercontent.com/719641/151722800-a2f3dd44-aa24-4858-b43e-0620b1f2ae65.png"> #### After > I have used mocked indicator values locally to ensure that the Badges are displayed correctly. <img width="1339" alt="Screenshot 2022-01-31 at 00 26 10" src="https://user-images.githubusercontent.com/719641/151722795-745b04ac-9ee4-49a8-8217-206d8d7456e6.png"> <img width="1339" alt="Screenshot 2022-01-31 at 00 45 08" src="https://user-images.githubusercontent.com/719641/151722940-aaaf0e9b-f2d1-4245-8b2b-cfc11052b39e.png"> Reviewed By: aigoncharov Differential Revision: D33975324 Pulled By: mweststrate fbshipit-source-id: fe4773b4825b9f22e01821e45259747d319233aa |
||
|
dependabot[bot]
|
a0ec82c981 |
Bump @emotion/react from 11.6.0 to 11.7.1 in /desktop (#3388)
Summary: Bumps [emotion/react](https://github.com/emotion-js/emotion) from 11.6.0 to 11.7.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/emotion-js/emotion/releases"><code>@emotion/react</code>'s releases</a>.</em></p> <blockquote> <h2><code>@emotion/react</code><a href="https://github.com/11"><code>@11</code></a>.7.1</h2> <h3>Patch Changes</h3> <ul> <li> <p><a href="https://github-redirect.dependabot.com/emotion-js/emotion/pull/2577">https://github.com/facebook/flipper/issues/2577</a> <a href=" |
||
Anton Kastritskiy
|
f2abbf63db |
ban interface usage for component props and state
Summary: another eslint rule for flipper codebase Reviewed By: passy Differential Revision: D33917213 fbshipit-source-id: e60b867d359ef5b94a481edf0eda318ecff17eee |
||
|
Anton Kastritskiy
|
c5dd1fc350 |
rename files from ts to tsx in flipper-* packages
Summary: mass files rename Reviewed By: nikoant Differential Revision: D33890252 fbshipit-source-id: d5afaa60af7340313a97d8e4967fe37f00abd9db |
||
|
dependabot[bot]
|
e9da574720 |
Bump antd from 4.18.2 to 4.18.5 in /desktop (#3346)
Summary: Bumps [antd](https://github.com/ant-design/ant-design) from 4.18.2 to 4.18.5. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ant-design/ant-design/releases">antd's releases</a>.</em></p> <blockquote> <h2>4.18.5</h2> <ul> <li>Cascader <ul> <li>💄 Fix Cascader loading icon. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33799">#33799</a></li> <li>🐞 Fix Cascader not auto offset placement when popup is out of screen and fix active option out of screen not scroll. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33777">#33777</a></li> </ul> </li> <li>💄 Fix Tag style in dark theme. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33751">#33751</a></li> <li>💄 Fix disabled Checkbox inside Tooltip dom structure. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33772">#33772</a> <a href="https://github.com/boomler"><code>@boomler</code></a></li> <li>⚡️ Fix invalid hook dependency array in Row and Layout.Sider components. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33804">#33804</a> <a href="https://github.com/mrwd2009"><code>@mrwd2009</code></a></li> <li>🐞 Fix Card <code>ref</code> not working. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33784">#33784</a> <a href="https://github.com/LongHaoo"><code>@LongHaoo</code></a></li> <li>🐞 Fix a Checkbox problem that <code>onChange</code> could not correctly pass in the modified value when dynamically modifying <code>value</code> property. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33753">#33753</a></li> </ul> <hr /> <ul> <li>Cascader <ul> <li>🐞 修复 Cascader 弹层超出屏幕时不会自动偏移以及激活选项不会自动滚动到正确位置的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33777">#33777</a></li> <li>💄 修复 Cascader 加载中图标。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33799">#33799</a></li> </ul> </li> <li>💄 修复 Tag 在暗黑主题下的样式。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33751">#33751</a></li> <li>💄 修复 Tooltip 的子元素含有禁用态的 CheckBox 时可能引起的行为和样式异常。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33772">#33772</a> <a href="https://github.com/boomler"><code>@boomler</code></a></li> <li>⚡️ 优化 Row 和 Layout.Sider 的 hooks 依赖数组。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33804">#33804</a> <a href="https://github.com/mrwd2009"><code>@mrwd2009</code></a></li> <li>🐞 修复 Card <code>ref</code> 不生效的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33784">#33784</a> <a href="https://github.com/LongHaoo"><code>@LongHaoo</code></a></li> <li>🐞 修复动态修改 Checkbox 的 <code>value</code> 时 <code>onChange</code> 不能正确传入修改后的值的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33753">#33753</a></li> </ul> <h2>4.18.4</h2> <ul> <li>Typography <ul> <li>⚡️ Optimize Typography to use native css ellipsis when <code>tooltip</code> is configured. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33669">#33669</a></li> <li>🐞 Refactor Typography <code>ellipsis</code> logic to fix error when <code>children</code> use Context content. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33725">#33725</a></li> </ul> </li> <li>Icon <ul> <li>🐞 Fix <code><Icon component={HomeOutlined} /></code> and <code><HomeOutlined /></code> not aligned. (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33709">ant-design/ant-design#33709</a>)</li> <li>🐞 Fix <code><Icon component={SyncOutlined} spin /></code> shake. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33726">#33726</a> <a href="https://github.com/JX-Zhuang"><code>@JX-Zhuang</code></a></li> </ul> </li> <li>Input <ul> <li>🐞 Fix the display effect for Input related components with <code>hidden</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33735">#33735</a> <a href="https://github.com/fanerge"><code>@fanerge</code></a> <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33706">#33706</a> <a href="https://github.com/hydraZty"><code>@hydraZty</code></a></li> <li>🐞 Fix the warning in console for Input with <code>showCount</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33686">#33686</a> <a href="https://github.com/whwangms"><code>@whwangms</code></a></li> </ul> </li> <li>⚡️ Fix ConfigProvider and Anchor rerender unexpectedly. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33723">#33723</a> <a href="https://github.com/mrwd2009"><code>@mrwd2009</code></a></li> <li>🐞 Fix the duplicate keys warning in console for Cascader. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33649">#33649</a> <a href="https://github.com/dimbslmh"><code>@dimbslmh</code></a></li> <li>🐞 Checkbox.Group support number and boolean as options element. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33678">#33678</a></li> <li>🐞 Fix Form <code>validateMessages</code> bug in multiple ConfigProvider. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33705">#33705</a></li> <li>🐞 Fix Steps the tail part would be hidden when type is navigation and labelPlacement is vertical. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33716">#33716</a> <a href="https://github.com/toSayNothing"><code>@toSayNothing</code></a></li> <li>🐞 Fix Image has bottom blank style. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33631">#33631</a> <a href="https://github.com/fanerge"><code>@fanerge</code></a></li> <li>🐞 Fix TreeSelect with keyboard operation missing highlight issue. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33755">#33755</a></li> <li>🇰🇭 Fix some translations for Khmer (km_KH). <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33738">#33738</a> <a href="https://github.com/vireakkeosokvibol"><code>@vireakkeosokvibol</code></a></li> </ul> <hr /> <ul> <li>Typography <ul> <li>⚡️ 优化 Typography 在配置 <code>tooltip</code> 时优先使用原生省略样式以提升性能。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33669">#33669</a></li> <li>🐞 重构 Typography <code>ellipsis</code> 逻辑以修复 <code>children</code> 如果消费上游 Context 会报错的问题。 <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33725">#33725</a></li> </ul> </li> <li>Icon <ul> <li>🐞 修复 <code><Icon component={HomeOutlined} /></code> 和 <code><HomeOutlined /></code> 不对齐的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33709">#33709</a></li> <li>🐞 修复 <code><Icon component={SyncOutlined} spin /></code> 抖动的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33726">#33726</a> <a href="https://github.com/JX-Zhuang"><code>@JX-Zhuang</code></a></li> </ul> </li> <li>Input <ul> <li>🐞 修复 Input 相关组件设置 <code>hidden</code> 时的展示问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33735">#33735</a> <a href="https://github.com/fanerge"><code>@fanerge</code></a>，<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33706">#33706</a> <a href="https://github.com/hydraZty"><code>@hydraZty</code></a></li> <li>🐞 修复 Input 传入 <code>showCount</code> 时控制台 warning 问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33686">#33686</a> <a href="https://github.com/whwangms"><code>@whwangms</code></a></li> </ul> </li> <li>⚡️ 修复 ConfigProvider 和 Anchor 的渲染函数多次运行的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33723">#33723</a> <a href="https://github.com/mrwd2009"><code>@mrwd2009</code></a></li> <li>🐞 修复 Cascader 组件中出现重复 key 的控制台 warning 问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33649">#33649</a> <a href="https://github.com/dimbslmh"><code>@dimbslmh</code></a></li> <li>🐞 Checkbox.Group 的 <code>options</code> 支持数组中直接传入 number 和 boolean 类型。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33678">#33678</a></li> </ul> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ant-design/ant-design/blob/master/CHANGELOG.en-US.md">antd's changelog</a>.</em></p> <blockquote> <h2>4.18.5</h2> <p><code>2022-01-24</code></p> <ul> <li>Cascader <ul> <li>💄 Fix Cascader loading icon. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33799">#33799</a></li> <li>🐞 Fix Cascader not auto offset placement when popup is out of screen and fix active option out of screen not scroll. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33777">#33777</a></li> </ul> </li> <li>💄 Fix Tag style in dark theme. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33751">#33751</a></li> <li>💄 Fix disabled Checkbox inside Tooltip dom structure. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33772">#33772</a> <a href="https://github.com/boomler"><code>@boomler</code></a></li> <li>⚡️ Fix invalid hook dependency array in Row and Layout.Sider components. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33804">#33804</a> <a href="https://github.com/mrwd2009"><code>@mrwd2009</code></a></li> <li>🐞 Fix Card <code>ref</code> not working. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33784">#33784</a> <a href="https://github.com/LongHaoo"><code>@LongHaoo</code></a></li> <li>🐞 Fix a Checkbox problem that <code>onChange</code> could not correctly pass in the modified value when dynamically modifying <code>value</code> property. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33753">#33753</a></li> </ul> <h2>4.18.4</h2> <p><code>2022-01-18</code></p> <ul> <li>Typography <ul> <li>⚡️ Optimize Typography to use native css ellipsis when <code>tooltip</code> is configured. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33669">#33669</a></li> <li>🐞 Refactor Typography <code>ellipsis</code> logic to fix error when <code>children</code> use Context content. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33725">#33725</a></li> </ul> </li> <li>Icon <ul> <li>🐞 Fix <code><Icon component={HomeOutlined} /></code> and <code><HomeOutlined /></code> not aligned. (<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33709">ant-design/ant-design#33709</a>)</li> <li>🐞 Fix <code><Icon component={SyncOutlined} spin /></code> shake. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33726">#33726</a> <a href="https://github.com/JX-Zhuang"><code>@JX-Zhuang</code></a></li> </ul> </li> <li>Input <ul> <li>🐞 Fix the display effect for Input related components with <code>hidden</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33735">#33735</a> <a href="https://github.com/fanerge"><code>@fanerge</code></a> <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33706">#33706</a> <a href="https://github.com/hydraZty"><code>@hydraZty</code></a></li> <li>🐞 Fix the warning in console for Input with <code>showCount</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33686">#33686</a> <a href="https://github.com/whwangms"><code>@whwangms</code></a></li> </ul> </li> <li>⚡️ Fix ConfigProvider and Anchor rerender unexpectedly. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33723">#33723</a> <a href="https://github.com/mrwd2009"><code>@mrwd2009</code></a></li> <li>🐞 Fix the duplicate keys warning in console for Cascader. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33649">#33649</a> <a href="https://github.com/dimbslmh"><code>@dimbslmh</code></a></li> <li>🐞 Checkbox.Group support number and boolean as options element. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33678">#33678</a></li> <li>🐞 Fix Form <code>validateMessages</code> bug in multiple ConfigProvider. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33705">#33705</a></li> <li>🐞 Fix Steps the tail part would be hidden when type is navigation and labelPlacement is vertical. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33716">#33716</a> <a href="https://github.com/toSayNothing"><code>@toSayNothing</code></a></li> <li>🐞 Fix Image has bottom blank style. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33631">#33631</a> <a href="https://github.com/fanerge"><code>@fanerge</code></a></li> <li>🐞 Fix TreeSelect with keyboard operation missing highlight issue. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33755">#33755</a></li> <li>🇰🇭 Fix some translations for Khmer (km_KH). <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33738">#33738</a> <a href="https://github.com/vireakkeosokvibol"><code>@vireakkeosokvibol</code></a></li> </ul> <h2>4.18.3</h2> <p><code>2022-01-10</code></p> <ul> <li>🆕 Menu support <code>home</code> and <code>end</code> keyboard navigate. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33642">#33642</a> <a href="https://github.com/dartamonov-vertex"><code>@dartamonov-vertex</code></a></li> <li>Table <ul> <li>⚡️ Improve Table perfermance significantly when mount and unmount. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33554">#33554</a></li> <li>🐞 Fix Table emptynode fixed display. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33610">#33610</a> <a href="https://github.com/hemengke1997"><code>@hemengke1997</code></a></li> <li>🐞 Fix Table tree data hover error. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33638">#33638</a> <a href="https://github.com/LongHaoo"><code>@LongHaoo</code></a></li> </ul> </li> <li>Form <ul> <li>🐞 Fix Form validateMessages is not correct in default locale. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33511">#33511</a></li> <li>🐞 Fix Form.Item help with empty string makes layout shaking. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33644">#33644</a></li> </ul> </li> <li>🐞 Fix Input.Textarea throws error on preact. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33536">#33536</a> <a href="https://github.com/developit"><code>@developit</code></a></li> <li>🐞 Fix PageHeader state update error after unmounted. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33546">#33546</a> <a href="https://github.com/wuifdesign"><code>@wuifdesign</code></a></li> <li>💄 Fix Select tag margin issue when using <code>tagRender</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33539">#33539</a></li> </ul> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
dependabot[bot]
|
1262ee05f1 |
Bump react-debounce-render from 7.0.0 to 7.0.1 in /desktop (#3351)
Summary: Bumps [react-debounce-render](https://github.com/podefr/react-debounce-render) from 7.0.0 to 7.0.1. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/podefr/react-debounce-render/commits">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `dependabot rebase` will rebase this PR - `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `dependabot merge` will merge this PR after your CI passes on it - `dependabot squash and merge` will squash and merge this PR after your CI passes on it - `dependabot cancel merge` will cancel a previously requested merge and block automerging - `dependabot reopen` will reopen this PR if it is closed - `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Pull Request resolved: https://github.com/facebook/flipper/pull/3351 Reviewed By: mweststrate Differential Revision: D33741785 Pulled By: lblasa fbshipit-source-id: 4ceee9922dd80ec2ec47b9826fd8da09cd551122 |
||
|
Simek
|
f08bcb2a2c |
tweak dark mode theme colors, improve LeftRail UI (#3335)
Summary: Currently the design of `LeftRail` varies a bit between light and dark modes. Additionally washed background color is hard to differentiate from the main background color in comparison to the light theme (See `LeftRail` sidebars toggle buttons background for example). This lead to few contrast related issues, for example the hover effect on the WelcomeScreen elements is not visible in dark mode. The PR tweaks the dark mode theme colors and fixes the unnecessary background of Settings icon in dark mode. I have also spotted that icon `hover` effect is not working when icon has a badge (pure dot or count), I might have an idea how to fix this and I will push another PR for that. 🙂 ## Changelog * tweak dark mode theme colors, improve LeftRail UI Pull Request resolved: https://github.com/facebook/flipper/pull/3335 Test Plan: The change has been testes by running the desktop Flipper app locally from source. ## Preview (before & after) <img width="390" alt="Screenshot 2022-01-24 at 13 37 20" align="left" src="https://user-images.githubusercontent.com/719641/150784627-36e222a8-e53e-4409-ab72-783d4a594f8e.png"> <img width="390" alt="Screenshot 2022-01-24 at 13 46 08" src="https://user-images.githubusercontent.com/719641/150785438-bb496adf-83ab-4b1c-928d-07f4b0098f1a.png"> Reviewed By: antonk52 Differential Revision: D33741513 Pulled By: lblasa fbshipit-source-id: ef187db0725ac2b04c09b7f06823e713b50be88f |
||
|
Simek
|
903476bdad |
use centered prop for variable height modals (#3334)
Summary: Currently all of the modals are displayed using default positioning, which works fine for small modals and large app windows, but it cause small UI/UX issues (double scroll bars) when app window is quite small. Adding [`centered` prop](https://ant.design/components/modal/#API) for variable height modals improves this situation a bit, but it also changes a bit the modal position when using maximised window, but I think this is bearable looking at improvements gained when window size is reduced. ## Changelog * use `centered` prop for variable height modals to improve UI in small app window Pull Request resolved: https://github.com/facebook/flipper/pull/3334 Test Plan: The change has been testes by running the desktop Flipper app locally from source. ## Preview (before & after) #### Small App Window <img width="390" alt="Screenshot 2022-01-24 at 11 58 40" align="left" src="https://user-images.githubusercontent.com/719641/150771900-cb25d110-82c7-4ba9-8ee5-07a093c4f702.png"> <img width="390" alt="Screenshot 2022-01-24 at 11 58 37" src="https://user-images.githubusercontent.com/719641/150771911-c81592ac-1eba-4112-86ad-9549e6248239.png"> <img width="390" alt="Screenshot 2022-01-24 at 12 00 13" align="left" src="https://user-images.githubusercontent.com/719641/150772045-de37c432-4381-4207-8476-5f142dfb6fa5.png"> <img width="390" alt="Screenshot 2022-01-24 at 12 00 10" src="https://user-images.githubusercontent.com/719641/150772057-574cf6cd-6f1a-4ca2-a343-b8fd6342eddb.png"> #### Maximised App Window <img width="390" alt="Screenshot 2022-01-24 at 12 12 12" align="left" src="https://user-images.githubusercontent.com/719641/150772777-8ac3cb59-3b41-4dcb-9554-137e95857af8.png"> <img width="390" alt="Screenshot 2022-01-24 at 12 12 29" src="https://user-images.githubusercontent.com/719641/150772758-ca9f8c20-d6d0-412d-9067-7e756da0b56c.png"> Reviewed By: mweststrate Differential Revision: D33741484 Pulled By: lblasa fbshipit-source-id: 0c3ca883d051cf4fcce9f9c1b6688974b66fd0d8 |
||
|
dependabot[bot]
|
3764b5aa2d |
Bump immer from 9.0.7 to 9.0.12 in /desktop (#3345)
Summary: Bumps [immer](https://github.com/immerjs/immer) from 9.0.7 to 9.0.12. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/immerjs/immer/releases">immer's releases</a>.</em></p> <blockquote> <h2>v9.0.12</h2> <h2><a href="https://github.com/immerjs/immer/compare/v9.0.11...v9.0.12">9.0.12</a> (2022-01-11)</h2> <h3>Bug Fixes</h3> <ul> <li>produceWithPatches should not wrap result in Immutable, fixes <a href="https://github-redirect.dependabot.com/immerjs/immer/issues/850">https://github.com/facebook/flipper/issues/850</a>, <a href="https://github-redirect.dependabot.com/immerjs/immer/issues/881">https://github.com/facebook/flipper/issues/881</a> (<a href=" |
||
|
Simek
|
1c91d28390 |
improve dev perf canvas readability (#3333)
Summary: This PR updates the performance Canvas widgets readability in Dev mode. Currently, for unknown for me reason, the text was rendered with stroke not fill, which results in blurry text. Also the color of texts and plot in light mode have not enough contrast in comparison to the background. I have tried to use `theme` in there, but unfortunately the CSS variables are not available in the Canvas context and using those values leads to always black text. ## Changelog * improve the performance canvas widgets readability in Development mode Pull Request resolved: https://github.com/facebook/flipper/pull/3333 Test Plan: The change has been testes by running the desktop Flipper app locally from source. ## Preview (before & after) #### Dark Mode <img width="189" alt="Screenshot 2022-01-23 at 17 46 20" align="left" src="https://user-images.githubusercontent.com/719641/150689046-28895487-d488-440f-9440-f792daeca86f.png"> <img width="189" alt="Screenshot 2022-01-23 at 17 54 59" src="https://user-images.githubusercontent.com/719641/150689179-5ef96ca3-78e0-4995-b60c-317a87082604.png"> #### Light Mode <img width="189" alt="Screenshot 2022-01-23 at 17 46 27" align="left" src="https://user-images.githubusercontent.com/719641/150689061-a3264961-390a-4182-bd81-ba84b6e4979f.png"> <img width="189" alt="Screenshot 2022-01-23 at 17 55 09" src="https://user-images.githubusercontent.com/719641/150689188-17efc7d9-7add-409e-af3b-befa5fbba0bc.png"> Reviewed By: aigoncharov Differential Revision: D33738722 Pulled By: lblasa fbshipit-source-id: b992ecacd31bb6aa2a53885ca6dcc858fa510775 |
||
|
Simek
|
1fef844878 |
fix ReleaseChannel info in WelcomeScreen in dark mode (#3328)
Summary: This PR fixes the color of ReleaseChannel information in the WelcomeScreen, when user uses dark mode. I have decided to switch to `textColorSecondary` instead of `textColorPrimary` to emphasise a bit more the information, but I can change it to the primary color if you think it will fit there better. Also the font size has been adjusted to match the paragraph font size. ## Changelog * fix ReleaseChannel info in WelcomeScreen in dark mode Pull Request resolved: https://github.com/facebook/flipper/pull/3328 Test Plan: The change has been testes by running the desktop Flipper app locally from source. ## Preview #### Dark Mode (before & after) <img width="333" alt="Screenshot 2022-01-23 at 15 14 12" align="left" src="https://user-images.githubusercontent.com/719641/150682951-6e256054-d8d9-4293-8f76-4d67b654482f.png"> <img width="333" alt="Screenshot 2022-01-23 at 15 09 58" src="https://user-images.githubusercontent.com/719641/150682954-942eda7a-443d-4ca1-be51-b6d0036548cd.png"> #### Light Mode <img width="333" alt="Screenshot 2022-01-23 at 15 22 42" src="https://user-images.githubusercontent.com/719641/150683094-62983788-646e-4745-b9c0-3c7f7bea9787.png"> Reviewed By: aigoncharov Differential Revision: D33738596 Pulled By: lblasa fbshipit-source-id: 2fdd18871fbf9d1c215b58173932d57d5731948a |
||
|
Simek
|
f1b83a96fd |
do not add GrayedOutOverlay if there is no children (#3329)
Summary: Do not add `GrayedOutOverlay` to the `ToggledSection` component if there is no children. Current approach was causing UI issue in the Settings Modal in dark mode. ## Changelog * do not add `GrayedOutOverlay` to the `ToggledSection` if there is no children Pull Request resolved: https://github.com/facebook/flipper/pull/3329 Test Plan: The change has been testes by running the desktop Flipper app locally from source. ## Preview (before & after) <img width="390" alt="Screenshot 2022-01-23 at 15 32 29" align="left" src="https://user-images.githubusercontent.com/719641/150683689-d70f2af9-d835-4139-a8bb-a638aca9b8d3.png"> <img width="390" alt="Screenshot 2022-01-23 at 15 32 12" src="https://user-images.githubusercontent.com/719641/150683692-86da3fba-5740-426e-96c7-6838632f42f0.png"> Reviewed By: aigoncharov Differential Revision: D33738627 Pulled By: lblasa fbshipit-source-id: 12b028e3c7986a4fa196bac6f32a9efc19f1883d |
||
|
Pascal Hartig
|
7135456434 |
Dep bump
Summary: Get ahead of dependabot by bundling a few small bumps. Reviewed By: nikoant Differential Revision: D33739602 fbshipit-source-id: 1482c062493a4214da81cbf5daf408aa382fb0ac |
||
|
Simek
|
4b0091df0f |
fix Plugins table UI glitch in dark mode, add column name (#3332)
Summary: Same as Settings modal, the Plugin Manager table used in Plugins modal includes the UI glitch in dark mode due to overflow setting. This PR fixes that and also adds missing column caption in "Install Plugins" table. I have chosen `Action` as a title but this can be altered, I have no strong preference in there. The goal was to improve the clarity and also improve the context menu content (where user can show/hide columns). ## Changelog * fix Plugins table UI glitch in dark mode, add column name Pull Request resolved: https://github.com/facebook/flipper/pull/3332 Test Plan: The change has been testes by running the desktop Flipper app locally from source. ## Preview (before & after) <img width="396" alt="Screenshot 2022-01-23 at 16 19 02" align="left" src="https://user-images.githubusercontent.com/719641/150685739-e2047e70-de14-4801-ac5a-0fc45a6ea476.png"> <img width="396" alt="Screenshot 2022-01-23 at 16 19 31" src="https://user-images.githubusercontent.com/719641/150685735-3de8b7a2-ea3f-489a-b1f8-7af73f0a5225.png"> Reviewed By: aigoncharov Differential Revision: D33738705 Pulled By: lblasa fbshipit-source-id: 704fe40f26d424c62a9bbc3e73132a0026f2e8b8 |
||
|
Simek
|
41950946a2 |
tweak Doctor modal footer UI, replace deprecated UI components (#3331)
Summary: This PR fixes the unaligned checkbox in the Doctor modal (I have based the solution of the Settings modal code) and also replaces deprecated components `FlexRow` and `FlexColumn` in Settings modal. ## Changelog * fix checkbox placement in the Doctor modal footer Pull Request resolved: https://github.com/facebook/flipper/pull/3331 Test Plan: The change has been testes by running the desktop Flipper app locally from source. ## Preview (before & after) <img width="596" alt="Screenshot 2022-01-23 at 16 01 48" src="https://user-images.githubusercontent.com/719641/150685091-ce494847-eea6-4263-900a-2b5541d3d897.png"> <img width="596" alt="Screenshot 2022-01-23 at 16 01 44" src="https://user-images.githubusercontent.com/719641/150685096-29723d14-6cfc-42aa-9564-431a61b1061d.png"> Reviewed By: aigoncharov Differential Revision: D33738683 Pulled By: lblasa fbshipit-source-id: 900657d6cb095d6d32dd412205e714a46e64a564 |
||
|
Simek
|
d897cfd765 |
fix Settings modal UI glitch with overlow in dark mode (#3330)
Summary: This small tweak fixes the Setting modal UI glitch (white rectangle in the bottom right) related to the modal content overflow setting. ## Changelog * fix Settings modal UI glitch with content overflow setting in dark mode Pull Request resolved: https://github.com/facebook/flipper/pull/3330 Test Plan: The change has been testes by running the desktop Flipper app locally from source. ## Preview (before & after) #### No scrollbar <img width="390" alt="Screenshot 2022-01-23 at 15 45 47" align="left" src="https://user-images.githubusercontent.com/719641/150684278-b09031bd-9b8c-4c9c-9ac2-2dba3c1af63d.png"> <img width="390" alt="Screenshot 2022-01-23 at 15 45 39" src="https://user-images.githubusercontent.com/719641/150684279-151b83d6-c819-45e0-a662-3d294f4f6a77.png"> #### With scrollbar <img width="390" alt="Screenshot 2022-01-23 at 15 51 40" align="left" src="https://user-images.githubusercontent.com/719641/150684331-a8f27623-9a2b-4ffe-b4c1-3fb06a6362a2.png"> <img width="390" alt="Screenshot 2022-01-23 at 15 51 47" src="https://user-images.githubusercontent.com/719641/150684330-57434f21-0d4d-4ef6-be41-fdd88d082d1b.png"> Reviewed By: aigoncharov Differential Revision: D33738647 Pulled By: lblasa fbshipit-source-id: f5a170950271302241a29d4382c481f2ce8bf4ec |
||
|
dependabot[bot]
|
a93d4aee71 |
Bump antd from 4.18.0 to 4.18.2 in /desktop (#3233)
Summary: allow-large-files Bumps [antd](https://github.com/ant-design/ant-design) from 4.18.0 to 4.18.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ant-design/ant-design/releases">antd's releases</a>.</em></p> <blockquote> <h2>4.18.2</h2> <ul> <li>🐞 Revert <a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33411">#33411</a> to Table onChange being invoked infinitely.</li> </ul> <hr /> <ul> <li>🐞 回滚 <a href="https://github-redirect.dependabot.com/ant-design/ant-design/issues/33411">#33411</a> 以修复 Table 死循环调用 onChange 的问题。</li> </ul> <h2>4.18.1</h2> <ul> <li>🐞 Fix Popconfirm throws <code>Can't perform a React state update on an unmounted component.</code> warning in some async case. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33432">#33432</a> <a href="https://github.com/MadCcc"><code>@MadCcc</code></a></li> <li>🐞 Fix Input with <code>suffix</code> will crash when <code>value</code> is number type. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33462">#33462</a></li> <li>🐞 Fix Divider with text dashed border color error. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33452">#33452</a> <a href="https://github.com/chen-jingjie"><code>@chen-jingjie</code></a></li> <li>🐞 Fix Dropdown.Button not support <code>destroyPopupOnHide</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33442">#33442</a> <a href="https://github.com/LongHaoo"><code>@LongHaoo</code></a></li> <li>🐞 Fix Table Pagination not trigger <code>onChange</code> when <code>current</code> changed. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33411">#33411</a> <a href="https://github.com/2724635499"><code>@2724635499</code></a></li> </ul> <hr /> <ul> <li>🐞 修复 Popconfirm 在某些情况下会出现 <code>Can't perform a React state update on an unmounted component.</code> 的错误。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33432">#33432</a> <a href="https://github.com/MadCcc"><code>@MadCcc</code></a></li> <li>🐞 修复 Input 配置 <code>suffix</code> 时 <code>value</code> 为数字类型会崩溃的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33462">#33462</a></li> <li>🐞 修复 Divider with text dashed 的边框颜色错误问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33452">#33452</a> <a href="https://github.com/chen-jingjie"><code>@chen-jingjie</code></a></li> <li>🐞 修复 Dropdown.Button 不支持 <code>destroyPopupOnHide</code> 的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33442">#33442</a> <a href="https://github.com/LongHaoo"><code>@LongHaoo</code></a></li> <li>🐞 修复 Table 的 Pagination 在 <code>current</code> 改变时不触发 <code>pagination.onChange</code> 的问题。<a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33411">#33411</a> <a href="https://github.com/2724635499"><code>@2724635499</code></a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ant-design/ant-design/blob/master/CHANGELOG.en-US.md">antd's changelog</a>.</em></p> <blockquote> <h2>4.18.2</h2> <p><code>2021-12-30</code></p> <ul> <li>🐞 Revert <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33411">#33411</a> to Table <code>onChange</code> being invoked infinitely.</li> </ul> <h2>4.18.1</h2> <p><code>2021-12-29</code></p> <ul> <li>🐞 Fix Popconfirm throws <code>Can't perform a React state update on an unmounted component.</code> warning in some async case. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33432">#33432</a> <a href="https://github.com/MadCcc"><code>@MadCcc</code></a></li> <li>🐞 Fix Input with <code>suffix</code> will crash when <code>value</code> is number type. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33462">#33462</a></li> <li>🐞 Fix Divider with text dashed border color error. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33452">#33452</a> <a href="https://github.com/chen-jingjie"><code>@chen-jingjie</code></a></li> <li>🐞 Fix Dropdown.Button not support <code>destroyPopupOnHide</code>. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33442">#33442</a> <a href="https://github.com/LongHaoo"><code>@LongHaoo</code></a></li> <li>🐞 Fix Table Pagination not trigger <code>onChange</code> when <code>current</code> changed. <a href="https://github-redirect.dependabot.com/ant-design/ant-design/pull/33411">#33411</a> <a href="https://github.com/2724635499"><code>@2724635499</code></a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
Lorenzo Blasa
|
e8dd7ffcc0 |
Adresses an issue with menu mutation
Summary: A Logview issue was raised for the following error: Cannot assign to read only property '0' of object '[object Array]'. Analysis: Currently, the menuEntries are stored by reference in the reducer, and made read only to protect it against accidental writes. Tha's probably why the '0' assignment fails, and the fix is that the reducer should only get a defensive copy as config about the current menu entries to show. Reviewed By: mweststrate Differential Revision: D33454514 fbshipit-source-id: 2faf3036eb6ae4fbe9a8d0253fde27cf389d3e4c |
||
|
Michel Weststrate
|
9267a19c89 |
Fix settings not being saved before restart
Summary: 2022 New years intention: don't fix problems with arbitrarily timeouts In production builds, settings weren't saved if apply + restart was used (apply and manual restart did work). I suspect a bug in redux-persist, since we do await a flush, but anyway a little delay seems to fix it consistently. Changelog: Fixed an issue where changing settings wasn't persisted when using "Apply + Restart P.S. I won't accept any insinuations that this was my new years intention of 2015, 2017, 2018, 2020 and 2021 as well. Reviewed By: cekkaewnumchai Differential Revision: D33377718 fbshipit-source-id: 3a9ec58b4f8208603d786342ddaf6bf02b3887c7 |
||
|
Michel Weststrate
|
b77b234e98 |
fix table header column widths deviating from rows
Summary: changelog: Improved column widths in data tables This diff fixes two issues: 1) dynamic width columns became invisible if there is too much else, and therefor it was hard to make them bigger or even notice them 2) column headers could be out of sync with the actually rendered rows, due to minor styling differences Reviewed By: cekkaewnumchai Differential Revision: D33364781 fbshipit-source-id: c3d47bb8db4af521859a5cbdf525d8ce39c71d00 |
||
|
Michel Weststrate
|
b6c884f011 |
Make sure flipper server initialization errors are propagated properly
Summary: This diff makes sure that errors are propagated similarly in flipper desktop and browser version, and that they are shown in either case. Since in the browser version, the UI loads after the error happened, we'll store the error so that any client connecting in the future will read and report it. Also added a `--failFast` flag to flipper-server, so that the process exits immediately if misconfigured, which is convenient in CI use cases and such Reviewed By: nikoant Differential Revision: D33348922 fbshipit-source-id: 0f584104f881141fde38da3f0031748415343ea2 |
