Files
flipper/desktop/flipper-ui-core
Michel Weststrate e4a3696fd5 Don't create always rejecting promises for timeout
Summary:
Our existing `timeout` implementation was always throwing an exception, due to sleeping and then throw an exception, which is than handled but ignored by `Promise.race`.

This implementation has a few problems

1. Because it always throws, having a debugger session with 'break on caught exceptions' will pause on every usage of timeout (rather than just the ones that actually timeout). This makes this way of debugging a bit useless.
2. Throwing exceptions is in principle an expensive process (due to the stack trace generation)
3. Not cancelling the timeout used by sleep is a bit of a waste as well

Reviewed By: lawrencelomax

Differential Revision: D33982717

fbshipit-source-id: d739c02112e1c1bc4cd691af852371d08a99abc6
2022-02-04 01:15:41 -08:00
..
2021-10-08 01:33:03 -07:00
2021-12-17 10:04:23 -08:00

flipper-ui-core (TBD)

Flipper's UI, agnostic of Electron vs Browser.