Summary:
1. Need to unminify the names from something call the minification map
2. Bloks attributes themselves are already minified. However the uidebugger also has a similar concept in its own metadata so the data we get off the device has been minified twice. To fix this we remap the metadata off the device using the minification map. In order to find the correct entry we need to get the style id of the bloks model parent. this is sent as a metadata custom attribute
Reviewed By: lblasa
Differential Revision: D45079136
fbshipit-source-id: bb448d81918c0b8c9e8ac87c4390b46a8a374d78
Summary:
Hooked up metadata to the stream inteceptor, enhanced error handling to deal with:
1. Recording subsequent metadata messaages that came in while in error state such that all of them are processed
2. Recording any frames that came in while in error state such that after recovering from error we have the latest state
3. Splitting out recoverable and non recoverable errors more explicitly
Reviewed By: lblasa
Differential Revision: D45079137
fbshipit-source-id: 67a2ffef72d94d2b1492f201a2228659720e306b
Summary:
Added stream interecptor which gets a chance to augment the messages off the wire. Stream interceptor transformations are async and can fail due to network errors so added error state with a retry button. The retry button will just call the function again.
I am also handling errors better generally when this method fails unexpectedly, logging more clearly what went wrong and communicating it to the user
Did some refactoring of subtree update event to support this
Reviewed By: lblasa
Differential Revision: D44415260
fbshipit-source-id: a5a5542b318775b641d53941808399a8fa4634d3
Summary: Type is any as it can be litterally anything, using json is a bit of pain as we have to do a lot of type checks to access anything
Reviewed By: lblasa
Differential Revision: D45079133
fbshipit-source-id: bcce93a1fce48d2779a648576f12df6392a0938e
Summary: These replace tags, and are KV instead. They allow us to send framework specific data that arent common enough to be promoted to the top level, similar to hidden attributes. They will be needed for bloks
Reviewed By: lblasa
Differential Revision: D45079134
fbshipit-source-id: e4962bd56f0c24608504367f50cd796fd3d79fcd
Summary: This is no longer needed or sent by the client given our new approach to frames
Reviewed By: antonk52
Differential Revision: D44872566
fbshipit-source-id: 9ec340a5cc68605f730cf6677fb89778bf77a3a1
Summary:
^
There's no references to this anywhere, so delete.
Reviewed By: antonk52
Differential Revision: D45309041
fbshipit-source-id: e62e94b089eee30b82b05f64c8e7b31dd03597b6
Summary: Payload size is useful to understand how much data is going down the wire for frame updates.
Reviewed By: LukeDefeo
Differential Revision: D45114582
fbshipit-source-id: d0c2a01deb84a67017db88bd396b4859e08d0037
Summary:
These are attributes that are:
1. Not common across frameworks
2. Not in every node
3. Will not be visualised via inspectable attribute mechansism
Currently we will use them for bloks but they should be useful for other features down the road
Reviewed By: lblasa
Differential Revision: D45048025
fbshipit-source-id: c258d0a384a2b09abb642778e68da178899fa9eb
Summary: This will allow a lot more flexibility and will be essential for making bloks work
Reviewed By: lblasa
Differential Revision: D44871256
fbshipit-source-id: 59d9fdccea7b18406eac532080e80a69a251267b
Summary: Since subtree update is effectively a frame dump its a lot easier to send the parent ID. This will save having figure it out on the client which is somewhat expensive and is needed for bloks
Reviewed By: lblasa
Differential Revision: D45048023
fbshipit-source-id: 90c4888df063de0aa69c9b93c86d9891e30becbe
Summary:
Bumps [com.vanniktech:gradle-maven-publish-plugin](https://github.com/vanniktech/gradle-maven-publish-plugin) from 0.24.0 to 0.25.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/vanniktech/gradle-maven-publish-plugin/releases">com.vanniktech:gradle-maven-publish-plugin's releases</a>.</em></p>
<blockquote>
<h2>0.25.2</h2>
<ul>
<li>Fix javadoc jar being empty when using dokka.</li>
</ul>
<h2>0.25.1</h2>
<ul>
<li>Fix snapshot publishing being broken.</li>
</ul>
<h2>0.25.0</h2>
<ul>
<li>The <code>createStagingRepository</code> task now uses the worker API which allows the project to built
in parallel to the creation of the staging repository.</li>
<li>Fix incompatibility with Kotlin 1.8.20-Beta for Kotlin/JS projects. The Kotlin/JS plugin is now taking
care of creating the sources jar on its own. Because of this the base plugin won't allow disabling
sources jar creation for Kotlin/JS projects anymore starting with 1.8.20. The <code>KotlinJs</code> constructor
with a <code>sourcesJar</code> parameter has been deprecated.</li>
<li>Fix incompatibility with Gradle 8.1 for <code>java-test-fixtures</code> projects</li>
<li>Fix incompatibility with <code>com.gradle.plugin-publish</code> 1.0.0 and 1.1.0</li>
<li>New minimum supported versions:
<ul>
<li>Gradle 7.4</li>
<li>Android Gradle Plugin 7.3.0</li>
<li>Kotlin Gradle Plugin 1.7.0</li>
<li><code>com.gradle.plugin-publish</code> 1.0.0</li>
</ul>
</li>
<li>Note: Starting with Kotlin 1.8.20-Beta the <code>common</code> sources jar for multiplatform projects will only contain
the sources of the common source set instead of containing the sources from all source sets.</li>
</ul>
<h4>Configuration cache status</h4>
<p>Configuration cache is supported starting with <strong>Gradle 7.6+</strong> except for:</p>
<ul>
<li>Builds with enabled signing, will be resolved in Gradle 8.1.</li>
<li>Publishing releases to Maven Central (snapshots are fine), blocked by [Gradle issue <a href="https://redirect.github.com/vanniktech/gradle-maven-publish-plugin/issues/22779">#22779</a>](<a href="https://redirect.github.com/gradle/gradle/issues/22779">gradle/gradle#22779</a>).</li>
<li>Kotlin Multiplatform projects, blocked by <a href="https://youtrack.jetbrains.com/issue/KT-49933">KT-49933</a>.</li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/vanniktech/gradle-maven-publish-plugin/blob/main/CHANGELOG.md">com.vanniktech:gradle-maven-publish-plugin's changelog</a>.</em></p>
<blockquote>
<h2>0.25.2 <em>(2023-04-16)</em></h2>
<ul>
<li>Fix javadoc jar being empty when using dokka.</li>
</ul>
<h2>0.25.1 <em>(2023-03-24)</em></h2>
<ul>
<li>Fix snapshot publishing being broken.</li>
</ul>
<h2>0.25.0 <em>(2023-03-23)</em></h2>
<ul>
<li>The <code>createStagingRepository</code> task now uses the worker API which allows the project to built
in parallel to the creation of the staging repository.</li>
<li>Fix incompatibility with Kotlin 1.8.20-Beta for Kotlin/JS projects. The Kotlin/JS plugin is now taking
care of creating the sources jar on its own. Because of this the base plugin won't allow disabling
sources jar creation for Kotlin/JS projects anymore starting with 1.8.20. The <code>KotlinJs</code> constructor
with a <code>sourcesJar</code> parameter has been deprecated.</li>
<li>Fix incompatibility with Gradle 8.1 for <code>java-test-fixtures</code> projects</li>
<li>Fix incompatibility with <code>com.gradle.plugin-publish</code> 1.0.0 and 1.1.0</li>
<li>New minimum supported versions:
<ul>
<li>Gradle 7.4</li>
<li>Android Gradle Plugin 7.3.0</li>
<li>Kotlin Gradle Plugin 1.7.0</li>
<li><code>com.gradle.plugin-publish</code> 1.0.0</li>
</ul>
</li>
<li>Note: Starting with Kotlin 1.8.20-Beta the <code>common</code> sources jar for multiplatform projects will only contain
the sources of the common source set instead of containing the sources from all source sets.</li>
</ul>
<h4>Configuration cache status</h4>
<p>Configuration cache is supported starting with <strong>Gradle 7.6+</strong> except for:</p>
<ul>
<li>Builds with enabled signing, will be resolved in Gradle 8.1.</li>
<li>Publishing releases to Maven Central (snapshots are fine), blocked by [Gradle issue <a href="https://redirect.github.com/vanniktech/gradle-maven-publish-plugin/issues/22779">#22779</a>](<a href="https://redirect.github.com/gradle/gradle/issues/22779">gradle/gradle#22779</a>).</li>
<li>Kotlin Multiplatform projects, blocked by <a href="https://youtrack.jetbrains.com/issue/KT-49933">KT-49933</a>.</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="faae7cc990"><code>faae7cc</code></a> Update to 0.25.2-rc1</li>
<li><a href="7c9a1c9b1e"><code>7c9a1c9</code></a> Changelog for 0.25.2</li>
<li><a href="899b4da7ea"><code>899b4da</code></a> fix Dokka javadoc jar set up (<a href="https://redirect.github.com/vanniktech/gradle-maven-publish-plugin/issues/559">https://github.com/facebook/flipper/issues/559</a>)</li>
<li><a href="df8aee6f99"><code>df8aee6</code></a> Update dependency com.android.tools.build:gradle to v8 (<a href="https://redirect.github.com/vanniktech/gradle-maven-publish-plugin/issues/557">https://github.com/facebook/flipper/issues/557</a>)</li>
<li><a href="efb4317fdf"><code>efb4317</code></a> Update plugin com.gradle.enterprise to v3.13 (<a href="https://redirect.github.com/vanniktech/gradle-maven-publish-plugin/issues/556">https://github.com/facebook/flipper/issues/556</a>)</li>
<li><a href="5acae8c36f"><code>5acae8c</code></a> Gradle 8.1 (<a href="https://redirect.github.com/vanniktech/gradle-maven-publish-plugin/issues/554">https://github.com/facebook/flipper/issues/554</a>)</li>
<li><a href="8cc89daa5f"><code>8cc89da</code></a> update tested versions (<a href="https://redirect.github.com/vanniktech/gradle-maven-publish-plugin/issues/552">https://github.com/facebook/flipper/issues/552</a>)</li>
<li><a href="436ee0002f"><code>436ee00</code></a> Update kotlin monorepo to v1.8.20 (<a href="https://redirect.github.com/vanniktech/gradle-maven-publish-plugin/issues/553">https://github.com/facebook/flipper/issues/553</a>)</li>
<li><a href="454faf601d"><code>454faf6</code></a> Update plugin com.gradle.enterprise to v3.12.6 (<a href="https://redirect.github.com/vanniktech/gradle-maven-publish-plugin/issues/550">https://github.com/facebook/flipper/issues/550</a>)</li>
<li><a href="f740112300"><code>f740112</code></a> Update dependency com.vanniktech:gradle-maven-publish-plugin to v0.25.1 (<a href="https://redirect.github.com/vanniktech/gradle-maven-publish-plugin/issues/548">https://github.com/facebook/flipper/issues/548</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/vanniktech/gradle-maven-publish-plugin/compare/0.24.0...0.25.2">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/4679
Reviewed By: antonk52
Differential Revision: D45079156
Pulled By: passy
fbshipit-source-id: b996d486b817056b3ff5e3ddcc4eb81caa5abb62
Summary:
Bumps [shellexpand](https://gitlab.com/ijackson/rust-shellexpand) from 2.1.2 to 3.1.0.
<details>
<summary>Commits</summary>
<ul>
<li><a href="b8d99fca87"><code>b8d99fc</code></a> Merge branch 'release' into 'main'</li>
<li><a href="1e14162d48"><code>1e14162</code></a> Declare version 3.1.0</li>
<li><a href="692b419f8d"><code>692b419</code></a> Fix theoretical bug in str::strip_prefix</li>
<li><a href="644df9f4c2"><code>644df9f</code></a> Rename latest CI test to latest-deps</li>
<li><a href="20be8b8d4c"><code>20be8b8</code></a> Document deps updates</li>
<li><a href="9e7a99369f"><code>9e7a993</code></a> Merge branch 'msrv' into 'main'</li>
<li><a href="3946ad227b"><code>3946ad2</code></a> Document new features and MSRV changes in changelog</li>
<li><a href="ffb5036e1d"><code>ffb5036</code></a> State an MSRV policy</li>
<li><a href="fc731ae496"><code>fc731ae</code></a> Usually test with supplied Cargo.lock.example</li>
<li><a href="9c686723a0"><code>9c68672</code></a> Break out feature-matrix tests</li>
<li>Additional commits viewable in <a href="https://gitlab.com/ijackson/rust-shellexpand/compare/shellexpand/2.1.2...shellexpand-3.1.0">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/4640
Reviewed By: antonk52
Differential Revision: D45079162
Pulled By: passy
fbshipit-source-id: 4547f921fd839d3b9af3a4b95aa76200de41f87b
Summary:
Bumps [com.facebook.fresco:flipper](https://github.com/facebook/fresco) from 2.6.0 to 3.0.0.
<details>
<summary>Commits</summary>
<ul>
<li><a href="bfcc9242bb"><code>bfcc924</code></a> Bump version to 3.0.0</li>
<li><a href="545919272c"><code>5459192</code></a> Bump Robolectric to v4.9.2</li>
<li><a href="5bcf7efecb"><code>5bcf7ef</code></a> More Fresco OSS build fixes, including removing deprecated scroll test</li>
<li><a href="041dd2c354"><code>041dd2c</code></a> Promote Vito open source artifacts from alpha to normal artifacts</li>
<li><a href="0d08840a82"><code>0d08840</code></a> Modernize Fresco's CircleCI setup, including Java 11 support</li>
<li><a href="8822457e86"><code>8822457</code></a> Remove empty animated-base-test</li>
<li><a href="61b6c9fa01"><code>61b6c9f</code></a> Fixed more open source Fresco build issues</li>
<li><a href="b08b79e3c5"><code>b08b79e</code></a> Added AssertJ Gradle dependencies for Fresco tests</li>
<li><a href="8267e9b914"><code>8267e9b</code></a> fix thumbnail only loading for android OS below Q</li>
<li><a href="a38efeb23d"><code>a38efeb</code></a> convert_fest_assertions: //fbandroid/libraries/fresco/animated-drawable/src/t...</li>
<li>Additional commits viewable in <a href="https://github.com/facebook/fresco/compare/v2.6.0...v3.0.0">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/4681
Reviewed By: antonk52
Differential Revision: D45079152
Pulled By: passy
fbshipit-source-id: 48c2892ed6965f150eee6c8f60c45bd801a2bf7d
Summary: Combining a bunch of green-tick PRs from GitHub into a single diff. allow-large-files
Reviewed By: ivanmisuno
Differential Revision: D44995391
fbshipit-source-id: 4185212f67bbaf532788c2a0651e30c061d47423
Summary:
Bumps [serde_yaml](https://github.com/dtolnay/serde-yaml) from 0.9.19 to 0.9.21.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/dtolnay/serde-yaml/releases">serde_yaml's releases</a>.</em></p>
<blockquote>
<h2>0.9.21</h2>
<ul>
<li>Make <code>Tag::new</code> panic if given empty string, since YAML has no syntax for an empty tag</li>
</ul>
<h2>0.9.20</h2>
<ul>
<li>Allow an empty YAML document to deserialize to <code>None</code> or <code>Value::Null</code>, in addition to the previously supported empty vector, empty map, and struct with no required fields</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="8057faddd6"><code>8057fad</code></a> Release 0.9.21</li>
<li><a href="19a7bd3d9b"><code>19a7bd3</code></a> Merge pull request <a href="https://redirect.github.com/dtolnay/serde-yaml/issues/371">https://github.com/facebook/flipper/issues/371</a> from dtolnay/emptytag</li>
<li><a href="ebb4b7af3a"><code>ebb4b7a</code></a> Fix deserialization of tag !<%21></li>
<li><a href="879a57fe91"><code>879a57f</code></a> Factor out conversion function from libyaml Tag to tag string</li>
<li><a href="e3b9a02a13"><code>e3b9a02</code></a> Merge pull request <a href="https://redirect.github.com/dtolnay/serde-yaml/issues/370">https://github.com/facebook/flipper/issues/370</a> from dtolnay/emptytag</li>
<li><a href="ef435495d1"><code>ef43549</code></a> Treat Tag::new("!") as tag %21, instead of empty tag</li>
<li><a href="221154cc1b"><code>221154c</code></a> Merge pull request <a href="https://redirect.github.com/dtolnay/serde-yaml/issues/369">https://github.com/facebook/flipper/issues/369</a> from dtolnay/emptytag</li>
<li><a href="39a866c695"><code>39a866c</code></a> Reuse Tag visitor in Value's Deserialize impl</li>
<li><a href="80e53a5166"><code>80e53a5</code></a> Merge pull request <a href="https://redirect.github.com/dtolnay/serde-yaml/issues/368">https://github.com/facebook/flipper/issues/368</a> from dtolnay/emptytag</li>
<li><a href="f668f71ea4"><code>f668f71</code></a> Preserve location information better when parsing invalid tag</li>
<li>Additional commits viewable in <a href="https://github.com/dtolnay/serde-yaml/compare/0.9.19...0.9.21">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/4664
Reviewed By: ivanmisuno
Differential Revision: D44995834
Pulled By: passy
fbshipit-source-id: dca70186444985211f298b9c4769db2343694da3
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/4661
Reviewed By: ivanmisuno
Differential Revision: D44995374
Pulled By: passy
fbshipit-source-id: 4c93a3750da5ae9977e62451e0bf7f3717b8c233
Summary: Allow callers to pass id, deviceName, processName, and packageName when initializing Flipper. Since these are used to create the connection id, callers can use these to configure Flipper to work for secondary processes.
Reviewed By: calebgomer
Differential Revision: D44719389
fbshipit-source-id: 3df6d47855c113f454f37031df32c4891626aa66
Summary: The error below was uncaught, showing up in our error monitoring, however, since it is a transient problem (probably an app not responding, too slow in startup, paused in a debuggger, emu being slow, whatever, this isn't actionable from our side, so lowered to warning
Reviewed By: lblasa
Differential Revision: D44717738
fbshipit-source-id: aefd5e58b4953f563ed155f7a252c130aaafe7ab
Summary:
This diff is reverting D44566060
D44566060: Add Flipper support for secondary processes in Messenger VR by rra has been identified to be causing the following test or build failures:
Tests affected:
- [//fbandroid/javatests/com/facebook/messenger:no_sonar_in_production - main](https://www.internalfb.com/intern/test/281474996792449/)
Here's the Multisect link:
https://www.internalfb.com/multisect/1809753
Here are the tasks that are relevant to this breakage:
We're generating a revert to back out the changes in this diff, please note the backout may land if someone accepts it.
If you believe this diff has been generated in error you may Commandeer and Abandon it.
Reviewed By: passy
Differential Revision: D44682510
fbshipit-source-id: c0ae489bc5ae22c5339edd2c8988126b0adedd7f
Summary:
An issue was reported for the visualiser whereas there seemed to be some cropping taking place on the right hand side.
https://pxl.cl/2BhPT
The issue was the resizable panel and visualiser both were set with the same width.
The resizable panel was set as to have a gutter which was not taken into consideration, add this width to the panel width and that fixes the issue.
Also change box sizing model as to not affect the dimensions of the wireframe.
Reviewed By: LukeDefeo
Differential Revision: D44664377
fbshipit-source-id: e640af2090f7c3378e624626fe3ea5df631caa11
Summary: Allow callers to pass id, deviceName, processName, and packageName when initializing Flipper. Since these are used to create the connection id, callers can use these to configure Flipper to work for secondary processes.
Reviewed By: passy
Differential Revision: D44566060
fbshipit-source-id: 605264c230956f4c9643c95c610ec40d736547ac
Summary: Resize oberserver limit exceeded appears to be a benign error that we can safely ignore, added ability to change log level. Given we report errors to our user logs, fb log view and console the console log patching has been centralised and now logs are pushed to whatever destinations we have.
Reviewed By: lblasa
Differential Revision: D44666836
fbshipit-source-id: e028dbc52b00947097833f9f3619189226247e1d
Summary:
As events get bigger, this change includes the following:
- Dedicated event inspector
- Stacktrace viewer for events with stacktrace attribution
- Stacktrace viewer is displayed within a new BottomPanel. BottomPanel can display any React component and can be reused in the future in different use cases.
Reviewed By: LukeDefeo
Differential Revision: D44628768
fbshipit-source-id: 71a9ef87e71c9a17f58c2544a1aa356eed14ed27
Summary: Requested by antonk52 and MSYS team
Reviewed By: passy
Differential Revision: D44662243
fbshipit-source-id: 2bace476c4e79b6a05bfb89ddc3e6acb437c6c3b
Summary: This way plugins get something meaningful when they call `getFlipperLib()` in their tests
Reviewed By: LukeDefeo
Differential Revision: D44662821
fbshipit-source-id: c13800f9d8e905ae4a89955f2186adb816730b77
Summary: It makes little sense to hide this info from developers. It was also requested by antonk52
Reviewed By: LukeDefeo
Differential Revision: D44631235
fbshipit-source-id: 1756c5ca2a95b2f815f8c4336621d3c057b704f2
Summary: It no longer makes sense since we are going to export "isLoggedIn" atom that always stays up-to-date in subsequent diffs
Reviewed By: LukeDefeo
Differential Revision: D44631234
fbshipit-source-id: 3e3b29b77d250eef430e81eef80098afe38a1538
Summary:
When a marker is selected, it was difficult to notice any style differences.
This changes makes it more obvious when a marker is selected.
Reviewed By: antonk52, aigoncharov
Differential Revision: D44628828
fbshipit-source-id: c4634338e04969f3d973137ad861cb999b28c139
Summary:
`onClick` was not getting called if it wasn't paired with `canSetCurrent`.
Ultimately, we can benefit from propagating this event in all cases as to give indication of whenever a marker has been selected.
Reviewed By: antonk52, aigoncharov
Differential Revision: D44628819
fbshipit-source-id: bee910b48ad065d7479e247fbacdcd738f281b26
Summary:
Make it more specific as to keep it consistent with the other types.
Do not export JSON.
Reviewed By: antonk52
Differential Revision: D44625218
fbshipit-source-id: 9cab52ee7e7be21d13f85102597a60c9be967fd0
Summary: Leverage the properties prop of `TimelineDataDescription`. Whenever an event is selected, the event payload is shown as the event properties.
Reviewed By: antonk52
Differential Revision: D44497058
fbshipit-source-id: 09782d583957a0df8c3efd3f5a62af6b321a26e3
