Summary: Don't log it, otherwise it may end up in Scuba, we don't want that.
Reviewed By: antonk52
Differential Revision: D49187133
fbshipit-source-id: 38d4ea0801a9abbc463c23340e23f8b55e0d22f3
Summary: `lint` is already called by CI. No further work is needed.
Reviewed By: LukeDefeo, passy
Differential Revision: D49188675
fbshipit-source-id: 731c21567af329fab4125869bcbea8cc9561a5d3
Summary: Changelog: FLIPPER_DISABLE_KEYTAR env var can be used to force in-memory implementation
Reviewed By: lblasa
Differential Revision: D49183501
fbshipit-source-id: 4ce886303678485673750417b09f272dd3f66623
Summary: Making a few changes to make the information more accurate
Reviewed By: antonk52
Differential Revision: D49152177
fbshipit-source-id: c6dee089a6e30b96c3b8258ef56bebd6eeefaa56
Summary: A few improvements to the installation wizard.
Reviewed By: antonk52
Differential Revision: D49145069
fbshipit-source-id: 1aadd85e1d187bd61983a0b4201b530cbdbf509a
Summary:
If a requests fails due to lack of allow-listing or other incompatibilities, we will now fall back to VPN mode while logging an error that will hopefully end up at the plugin owner.
For this, there's a new `vpnMode` option on every request that can also be used to enforce a particular type.
There's a lot of verbose logging that's turned off by default but very handy when debugging. Also potentially useful for plugin authors that are looking into request issues.
Reviewed By: lblasa
Differential Revision: D49023365
fbshipit-source-id: 755393063e379587feda9ae13973877780a1d987
Summary:
Add a connection listener similarly to the one used on Android.
The usage at this point will come from framework events as a means to control when to capture the events or not.
Reviewed By: ivanmisuno
Differential Revision: D49092691
fbshipit-source-id: d004f7ff5d1a254ad5f9c7f207d485afcb7ac54a
Summary:
Changelog: UI Debugger is now available for Litho in Open Source
Pull Request resolved: https://github.com/facebook/flipper/pull/5109
Remove the stub, replace with the real thing.
Reviewed By: lblasa
Differential Revision: D46859213
fbshipit-source-id: 74c59a53d1d22e046254f4bca202da17a0b0e5d8
Summary: Push the timeout to one second. Users are not going to mind if we try to load after a second but they can mind if they see their tab attempt to reload several times a second.
Reviewed By: ivanmisuno
Differential Revision: D49054898
fbshipit-source-id: 132168a1d6d381f76500bcc9c0a00e05ef0c541b
Summary:
A typo in the settings page has been fixed.
Pull Request resolved: https://github.com/facebook/flipper/pull/5102
Reviewed By: ivanmisuno
Differential Revision: D48948584
Pulled By: passy
fbshipit-source-id: 2469a25d2deb7c6c128f7d88a68fd5d147aad428
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/5108
Reviewed By: ivanmisuno
Differential Revision: D48948580
Pulled By: passy
fbshipit-source-id: eb3cbd1a0856c08ea6a5e443e567404fdd694a98
Summary:
Mostly mechanical change from jsx to object based api. However some changes:
1. Managed to get rid of UIDebugger context menu item. its now possible to listen to when any context menu is clicked
2. The construction code is cleaner. no more mutable arrary and pushing, its just a big spliced literal
3. Had to change how the ide function worked. It is dynamic and used react query hook to update the number of items. Added a callback to recreate this behaviour.
Reviewed By: aigoncharov
Differential Revision: D48910165
fbshipit-source-id: 9a71f5ecd302e6ff72194f83a13839f78e9b0796
Summary:
We recently raised a concern that for some packages types/* version is different than the package we are using. This can cause runtime errors as typescript can suggest usage that no longer reflects current API of a library. To combat this issue we decided to add a CI check to verify that major versions of types and a libriary match.
This script will be refined if in the next few diffs
Reviewed By: LukeDefeo
Differential Revision: D48779652
fbshipit-source-id: 2a826ba9d00565563553f04cd809ae0638db6282
Summary:
If the server certificates have expired, then the returned token will no longer be valid as soon as the certificates are renewed.
So, validate this before returning any existing token.
This was not an issue before, as launching used to be the last step during bootstrapping.
Reviewed By: antonk52
Differential Revision: D48902334
fbshipit-source-id: 2458aa0df806db245994ee742f42bff47a533e23
Summary:
The socket will close as the endpoint is terminating the connection.
Status code 1000 and 1001 are used for normal closures. Either the connection is no longer needed or the endpoint is going away i.e. browser navigating away from the current page.
WS RFC: https://www.rfc-editor.org/rfc/rfc6455
Reviewed By: LukeDefeo
Differential Revision: D48896696
fbshipit-source-id: 22070ae34b7f35d35589db06108feb718e73e866
Summary:
Before this change, opening deep-links or importing files would open new windows.
Instead, just use an existing window if there is one.
Documentation: https://developer.chrome.com/docs/web-platform/launch-handler/
Reviewed By: lawrencelomax
Differential Revision: D48865950
fbshipit-source-id: 80c3fb58f1fcc3b8ace00fd9241bf1e374c8345e
Summary: Need to copy this resource too from the static directory.
Reviewed By: aigoncharov
Differential Revision: D48864174
fbshipit-source-id: 0f3bfe9608bb9d48ec1cfb7243b3f0701d2fd8cf
Summary:
A previous diff introduced the isReady state as to make it possible to serve HTML content sooner than we are ready.
This worked great on debugging. As I was testing a release, it was discovered that there was a race condition and the server was not ready when it was already handling upgrade events.
To solve this, I've added another state flag in the form of a promise.
This one, can be waited on. This is used then during upgrade events as we can safely wait until the server is ready to accept incoming connections before proceeding with the upgrade.
Problem is shown below:
{F1080003241}
{F1080003356}
Reviewed By: passy
Differential Revision: D48829453
fbshipit-source-id: e148a392bbe66dd91710e32871e270c8950e25c2
Summary: Apply suggestion from D48605129 to have access to "modern" `replaceAll`.
Reviewed By: lblasa
Differential Revision: D48642120
fbshipit-source-id: 1e273fe5590e7b4a48c9176ef5f1afdab688b7d6
