Summary:
The navigation plugin supports logging of a date and the class name. This addition adds that support.
I have kept the previoius method which I will remove once I update the fb4a navigation plugin integration.
Reviewed By: danielbuechele
Differential Revision: D17202996
fbshipit-source-id: eac95328a6e2278c3a27ca608b9b675c8efe4528
Summary: Migrated all the tests. I've put these in a single diff as there were only a couple of lines that had to be changed in each file.
Reviewed By: danielbuechele
Differential Revision: D17181587
fbshipit-source-id: cdcc20d71a47e786db4cefbebe9ea686d5e235e5
Summary:
Publishing React Dev tools plugin:
- migrate to TS
- move iOS and JS part to public folder (Android was already)
Reviewed By: passy
Differential Revision: D17164782
fbshipit-source-id: 20ccba71d807df2d33fe5348a62c6ee7f78ae8ba
Summary: When clicking a node in the tree, currently it expands or collapses the subtree under it. This adds a chevron button which only handles the expansion functionality, and clicking on the label with the Section name will show info about that Section in the side panel.
Reviewed By: fabiomassimo
Differential Revision: D17165150
fbshipit-source-id: ac6b6c127b68274f53523b3ea62422ff96116e9b
Summary:
I've added in a timeline line. Getting the CSS for this to work perfectly was tricky, but in the end this result looks pretty good. I've opted for the unknown events to have a smaller circle.
Edit:
I have fixed the border radius issue with the img element:
{F206482232}
And Unknown events are better aligned:
{F206482255}
Reviewed By: jknoxville
Differential Revision: D17180819
fbshipit-source-id: c318d2721adde758494267095524961c796f7a54
Summary:
This is a UI ovehaul for the Navigation plugin, taking inspiration from the Notifications page in Flipper.
We now display a timestamp, open page and bookmark are more clearly identified, screenshots are organized more neatly, and parameters are displayed in a table.
If the class name of the ViewController is available, that will also be displayed.
Edit:
Adding in some of the requested changes.
Improved UI:
https://pxl.cl/K0h9
Scroll on opening a page:
https://pxl.cl/K0hQ
Reviewed By: danielbuechele
Differential Revision: D17161734
fbshipit-source-id: e5e054bf87f540964e90da3a798fd0c23df86540
Summary: Migrate CPU plugin to use TypeScript
Reviewed By: danielbuechele
Differential Revision: D17072709
fbshipit-source-id: d9acf172af08d764216e7b79b79994199dc83f5c
Summary: I've made some slight changes to how bookmarks are displayed in the app, and added the ability to remove them from the tab.
Reviewed By: danielbuechele
Differential Revision: D17154083
fbshipit-source-id: 587e1e0f6f79f461c92e4866f4a59608a6173ccb
Summary: This functionality already existed in FlexColumn by adding the prop grow.
Reviewed By: danielbuechele
Differential Revision: D17132219
fbshipit-source-id: d284f2c5e219beff743525abd344a8b9d1955d0b
Summary: Luckily I put all my types in one file, so this was very easy to convert over.
Reviewed By: danielbuechele
Differential Revision: D17132226
fbshipit-source-id: cacd0d66e15504d6f82ccc4aaaa4e27339e513f1
Summary: This commit provides the navigation plugin with more value, showing the ViewController of the rendered view.This allows the user to quickly start working on that view controller once they have the name. This works on nearly all views in the iOS app.
Reviewed By: passy
Differential Revision: D17071558
fbshipit-source-id: 22a22d4a0991e9f20bc85eb106a98a42214d4d0c
Summary:
This converts the index file to TypeScript which is used as an export for all plugins. Alongside, I had to fix a couple of errors in various files to make sure everything works correctly.
For plugins using flow, we define an interface which uses the type definition for FlipperPlugin and types all UI components as `any`.
Reviewed By: passy
Differential Revision: D16936890
fbshipit-source-id: dacd9a63a82b9f0bbb530b06072186874cba7b6f
Summary:
Here I've attempted to add screenshots to the nav plugin. This isn't the most elegant solution, but it might have to do due to limitations on the event handler for navigation being fired when the navigation occurs, and not when all remote content on the view has loaded. With this in mind, I added a 1 second delay for the screenshot. This has its own issues such as navigating within a second away from the page will display the wrong view.
If anyone has some suggestions I am open.
Another issue faced here was that incoming nav events are now impure as I need to go take a screenshot on each nav event. Therefore, I have removed the the tests which no longer work for the NavPlugin.
Reviewed By: danielbuechele
Differential Revision: D16915859
fbshipit-source-id: 95db0d1ded2084441d49e1f2e4712c55acf9f1b8
Summary: Since I've published docs for the Nav Plugin, might as well remove the Gate Keeper. When integrating the Nav Plugin in our sample app, I've observed that the Plugin is stable.
Reviewed By: passy
Differential Revision: D16857344
fbshipit-source-id: c4b0b5828ae82f6e43cfcb000e7f003c5ccce568
Summary: I added the height css style to align the sheet. In this revision, I removed the height to recenter the text, but I've had to nudge the sheet up 3 pixels.
Reviewed By: danielbuechele
Differential Revision: D16855746
fbshipit-source-id: 14b4b83abeb74c01c3706c5b81921f30c8d7e2d3
Summary: Booleans must also be validated. These are denoted by {!boolParam}, as in they have a '!' symbol in front.
Reviewed By: danielbuechele
Differential Revision: D16802996
fbshipit-source-id: c03b858f0872dea0610e1d28aa9b48936f1117a6
Summary: Taking on the feedback from the demo yesterday, I've improved the required parameter's dialog by showing where specific errors occur in the form and adding live editing to the URI displayed.
Reviewed By: danielbuechele
Differential Revision: D16802921
fbshipit-source-id: 2e729549306a8efb79ca76d3da6f70632ccd9212
Summary:
Here I've added the LocationsButton to the TitleBar in Flipper. This allows the user to navigate to saved bookmarks, or display the current page URI without ever opening the Navigation Plugin (Except to add bookmarks). The challenge of this diff was having a TitleBar child be controlled by a plugin.
The LocationsButton pulls bookmarks straight from the database whenever a mouseDown event is called on the button. (The Electron popup menu does not respond to props changes, so the menu is opened on mouse up and getting the bookmarks from the database occurs on mouse down... This seems to work fine).
The nav plugin on the Android side will now also send a welcome message alerting the app to created a persisted state for the navigation plugin, which shows the button in the TitleBar.
Let me know if I can answer any questions.
Reviewed By: danielbuechele
Differential Revision: D16786330
fbshipit-source-id: afc95348d9b7ec4ee041f42bb4d022f58c6bb969
