Commit Graph

2065 Commits

Author SHA1 Message Date
Pascal Hartig
dbab2d1d6d Add types for which
Summary:
Used by

src/dispatcher/androidDevice.tsx
src/chrome/DevicesButton.tsx

Reviewed By: jknoxville

Differential Revision: D17204335

fbshipit-source-id: 40fa266d7301d2ddceea8b884f26b3e4741d7797
2019-09-09 07:04:54 -07:00
Pascal Hartig
c91b778fc0 Make dispatcher/notifications.tsx strict
Summary: _typescript_

Reviewed By: jknoxville

Differential Revision: D17204312

fbshipit-source-id: 23a3b5144545db9c165fc853ece40bb5025391e6
2019-09-09 07:04:53 -07:00
Pascal Hartig
76e857041c Make dispatcher/tracking.tsx strict
Summary: _typescript_

Reviewed By: jknoxville

Differential Revision: D17204302

fbshipit-source-id: 10b6add125bb6b500122c0a7a30eb8ed223a7ad8
2019-09-09 07:04:53 -07:00
Pascal Hartig
a60bcf7aca Make fb-stubs/Logger.tsx strict
Summary: _typescript_

Reviewed By: jknoxville

Differential Revision: D17204281

fbshipit-source-id: c694aed012c30cc325fe507723476a3e6bc43e83
2019-09-09 07:04:53 -07:00
John Knox
b71ae59545 TableNativePlugin
Reviewed By: passy

Differential Revision: D17258701

fbshipit-source-id: 0d622e63cc028969c9c6d51c5aa2cc8977aac151
2019-09-09 06:54:37 -07:00
John Knox
c8c027150a SeaMammals/index.tsx
Reviewed By: passy

Differential Revision: D17258652

fbshipit-source-id: 0c7931c3e5a619cb8d06703aaf9e276458ef38f4
2019-09-09 06:54:37 -07:00
John Knox
6aab0bd826 Make plugin.tsx strict
Reviewed By: danielbuechele

Differential Revision: D17228192

fbshipit-source-id: 74e5edf9dfd3260a3463e57a16d1f9c8c0399137
2019-09-09 06:54:37 -07:00
John Knox
6e8b31e2ed PluginContainer.tsx
Reviewed By: passy

Differential Revision: D17258340

fbshipit-source-id: 26ce421345f6152efe7da07daf649395e299af14
2019-09-09 06:54:36 -07:00
Pascal Hartig
96d9c9638c Update README.md (#541)
Summary:
Fix indentation for the ToC
Pull Request resolved: https://github.com/facebook/flipper/pull/541

Reviewed By: danielbuechele

Differential Revision: D17257799

Pulled By: passy

fbshipit-source-id: 7ac402f4cadd287536f3f25578116084316831fc
2019-09-09 06:38:35 -07:00
Pritesh Nandgaonkar
566f2bf96e Do not use custom serializer for all the plugins
Summary:
This diff solves the problem where the export for the graphql plugin was super super super sloooooowwww...... The reason being that the graphql plugin had chunky graphql responses which were json blob which was being serialized by our custom serializer. Instead of serializing those with custom serializer we can directly serialize them as they won't have any map's, sets, classes etc.

This diff adds the two static functions on the plugin which will provide the serialized and deserialized object for the persistedstate. As the plugin knows the structure of its state it can optimize the serialization and deserialization of its data.

This change solves the slow export issue and makes it blazing fast..... 🏎

Bug:

{F206550514}

Reviewed By: danielbuechele

Differential Revision: D17166054

fbshipit-source-id: 058b903c03c12c9194702162c46763ef5b5e7283
2019-09-09 06:13:39 -07:00
Ivelin Rachev
9ebf5346df Convert Flipper plugin "mobileboost" to TypeScript
Summary: Bugfix for Tab.tsx + implicitly typed react vizualized

Reviewed By: danielbuechele

Differential Revision: D17205342

fbshipit-source-id: 48d29c583f0790af46f3d9c8d0280015b58d56aa
2019-09-09 03:51:22 -07:00
James Kao
975af8fa43 Change default deviceId for MacOS
Summary: It appears the certificate provider is generating a deviceId which is then sent down to the flipper client to store (under CONNECTION_CONFIG_FILE). For MacOS, this ends up being "unknown". Yet when we attempt to connect to the flipper app, it expects empty string. This diff ensures that for MacOS, we're not sending down "unknown" for the client to store into its config file.

Reviewed By: danielbuechele

Differential Revision: D17190130

fbshipit-source-id: e0d9825f1f0330a03bcb3cf8d606d5bd9fcc1d7f
2019-09-06 11:20:42 -07:00
John Knox
8fff3fcf59 Apply some styles
Summary: It looks a lot better now, but the input is only single line, so entering more than one line would not be good right now.

Reviewed By: danielbuechele

Differential Revision: D17210091

fbshipit-source-id: 9313b6a67731cfa944394962cdc09be915a07720
2019-09-06 08:32:48 -07:00
John Knox
be22cc711a Use API to get prompt values
Summary: To keep it in sync with the JS implementation.

Reviewed By: danielbuechele

Differential Revision: D17208786

fbshipit-source-id: 8d89f33bfef22317266a0ad1e0c5689540d54f9e
2019-09-06 08:32:48 -07:00
John Knox
612cfd81ae Change feedback to use ITSR
Summary:
This isn't ready to release yet, it's still behind a GK so noone will see it.
There has been no styling applied to the popover so it looks bad but is fully functional.

What it also doesn't have yet:
* Get the prompt text from the API (including the predefined selectable comments)
* Check with the server whether it should pop up proactively, it's completely passive at the moment.

Reviewed By: passy

Differential Revision: D17206158

fbshipit-source-id: f1734f3d6bc555c860ebbaad7515d4675e1700cb
2019-09-06 08:32:48 -07:00
Ram N
4204562fee Add FlipperKitReactPlugin to podspec
Reviewed By: danielbuechele

Differential Revision: D7277601

fbshipit-source-id: 7a6c3dc1c94715a93f4bd34c9eb90282dcc69184
2019-09-06 07:29:25 -07:00
John Knox
b4c1d1942a Make File > Open more self-explanatory
Summary:
Yesterday I saw someone try to open the xcode executable with the File > Open function.

This made me realise it's not clear what this is for, and you might think it can open all kinds of things.

Reviewed By: danielbuechele

Differential Revision: D17225496

fbshipit-source-id: 893360a1f450a8db25be34fce6c288e8db8f9626
2019-09-06 04:14:58 -07:00
Daniel Büchele
98b4071242 react-docgen for TypeScript
Summary: Update react-docgen to support TypeScript

Reviewed By: passy

Differential Revision: D17204178

fbshipit-source-id: 408ce5569a253c9a836f65bd9a9f289cc82b5175
2019-09-05 07:43:11 -07:00
Roman Gorbunov
eff95991c6 Moving SKHighlightOverlay
Summary: Moving FlipperKitLayoutPlugin/FlipperKitPluginUtils/SKHighlightOverlay to shared folder, so Layout and WorkingRange plugins can depend on it

Reviewed By: kevin0571

Differential Revision: D17156396

fbshipit-source-id: 3f17371f2ab4818924d61e6cfb243f60ad1f2892
2019-09-05 07:31:23 -07:00
Pascal Hartig
26c9bf3853 Flipper Bump: v0.23.7-SNAPSHOT
Summary: Back to snapshots.

Reviewed By: danielbuechele

Differential Revision: D17204024

fbshipit-source-id: 7fdc71f0c8011d6f400321a0369a7252540d04f7
2019-09-05 06:15:33 -07:00
Pascal Hartig
17d48d92b0 Flipper Release: v0.23.6
Summary:
**Highlights**

1. Windows builds should publish on the release page now.
2. We have x86_64 support on Android.
3. React DevTools are now publicly available.

Reviewed By: danielbuechele

Differential Revision: D17204023

fbshipit-source-id: 41aaa1c884e1f251216423a8b08cec6e8802fd80
2019-09-05 06:15:33 -07:00
Benjamin Elo
a90422bf2f Added additional parameters for logging
Summary:
The navigation plugin supports logging of a date and the class name. This addition adds that support.

I have kept the previoius method which I will remove once  I update the fb4a navigation plugin integration.

Reviewed By: danielbuechele

Differential Revision: D17202996

fbshipit-source-id: eac95328a6e2278c3a27ca608b9b675c8efe4528
2019-09-05 05:59:55 -07:00
Benjamin Elo
4e71d9b1ea Removed flow-types file
Summary: This completes the navigation plugin ts migration by removing the flow types file.

Reviewed By: passy

Differential Revision: D17181605

fbshipit-source-id: b4931d28664e990c37dea229a7fe3f52685e5ee7
2019-09-05 05:49:30 -07:00
Daniel Büchele
ffd4a29bba VirtualList
Summary: fixing ts-strict errors

Reviewed By: passy

Differential Revision: D17181140

fbshipit-source-id: 0b67a744c7fa5d3ef3aad9212e52d1397d873d4d
2019-09-05 04:42:38 -07:00
Daniel Büchele
4850da6a72 ViewWithSize
Summary: fixing ts-strict errors

Reviewed By: passy

Differential Revision: D17181146

fbshipit-source-id: a0f8cab121c5fefd505cba4166122c1ce191e6c2
2019-09-05 04:42:38 -07:00
Daniel Büchele
f34c8ba9fe Tooltip
Summary: fixing ts-strict errors

Reviewed By: passy

Differential Revision: D17181144

fbshipit-source-id: c48de5718f1a917c2eebd6b5913a43ce62b9b0a1
2019-09-05 04:42:38 -07:00
Daniel Büchele
e29563cfca ToggleSwitch
Summary: fixing ts-strict errors

Reviewed By: passy

Differential Revision: D17181148

fbshipit-source-id: 959a01fd61950ddb263c3b9c44c9069d19541c36
2019-09-05 04:42:38 -07:00
Daniel Büchele
cfd4793d05 Textarea
Summary: fixing ts-strict errors

Reviewed By: passy

Differential Revision: D17181150

fbshipit-source-id: 5de7f4d971c988bdaf18ae281a0e76ba99b67648
2019-09-05 04:42:37 -07:00
Daniel Büchele
3bdc4a2b8d Text
Summary: fixing ts-strict errors

Reviewed By: passy

Differential Revision: D17181142

fbshipit-source-id: df82f234061735e62f15a18e6b738c9e9e398807
2019-09-05 04:42:37 -07:00
Daniel Büchele
244df345f4 Tabs
Summary: fixing ts-strict errors

Reviewed By: passy

Differential Revision: D17181149

fbshipit-source-id: 43b12336e6467e0b134087fdabfd21f414741188
2019-09-05 04:42:37 -07:00
Chaiwat Ekkaewnumchai
7055deff7e Button.tsx
Summary: _typescript_

Reviewed By: danielbuechele

Differential Revision: D17165021

fbshipit-source-id: 6a8cb9f6167efc4c3105c38854d7b6b8fd931be9
2019-09-05 04:38:59 -07:00
Pascal Hartig
2d9b94ada5 Update getting-started.md (#540)
Summary:
Remove duplicate `client:start`.
Pull Request resolved: https://github.com/facebook/flipper/pull/540

Test Plan: eyes

Reviewed By: danielbuechele

Differential Revision: D17203282

Pulled By: passy

fbshipit-source-id: 2245c376181a0069d04c55af5f51170b793cd52a
2019-09-05 04:35:43 -07:00
Daniel Büchele
9ba36e2795 ManagedTable
Summary: fixing ts-strict errors

Reviewed By: jknoxville

Differential Revision: D17181143

fbshipit-source-id: b25cf07f3aad61e451fdb5e274faeaea62474f2d
2019-09-05 04:03:19 -07:00
Chaiwat Ekkaewnumchai
f4bb0f987f DataDescription
Summary: _typescript_

Reviewed By: danielbuechele

Differential Revision: D17174253

fbshipit-source-id: d2ad87954a4fe49626f35234c2a9db180093fc54
2019-09-05 03:36:47 -07:00
Benjamin Elo
d7814b19da Migrate navigation tests
Summary: Migrated all the tests. I've put these in a single diff as there were only a couple of lines that had to be changed in each file.

Reviewed By: danielbuechele

Differential Revision: D17181587

fbshipit-source-id: cdcc20d71a47e786db4cefbebe9ea686d5e235e5
2019-09-05 03:33:09 -07:00
Chaiwat Ekkaewnumchai
5b883351c4 data-inspector/utils.tsx
Summary: _typescript_

Reviewed By: danielbuechele

Differential Revision: D17180421

fbshipit-source-id: 1264f402d1b5071617462179c80e6c951e513f0e
2019-09-05 03:19:48 -07:00
Daniel Büchele
b7933aef2e publish react plugin
Summary:
Publishing React Dev tools plugin:
- migrate to TS
- move iOS and JS part to public folder (Android was already)

Reviewed By: passy

Differential Revision: D17164782

fbshipit-source-id: 20ccba71d807df2d33fe5348a62c6ee7f78ae8ba
2019-09-05 03:19:47 -07:00
Chaiwat Ekkaewnumchai
7bb9ef4a37 elements-inspector/elements
Summary: _typescript_

Reviewed By: danielbuechele

Differential Revision: D17180489

fbshipit-source-id: 6ddc53f03fddf56494a18a7e1826ba4dd1e7e564
2019-09-05 03:16:03 -07:00
Chaiwat Ekkaewnumchai
158f7cba33 ResizeSensor
Summary: _typescript_

Reviewed By: danielbuechele

Differential Revision: D17181422

fbshipit-source-id: 73b802ac339c7f7e474c9ee8f13b6aaa50884c97
2019-09-05 03:05:38 -07:00
Chaiwat Ekkaewnumchai
d7e3514d9b desktop-toolbar
Summary: _typescript_

Reviewed By: danielbuechele

Differential Revision: D17180448

fbshipit-source-id: 67459523fb7047c0580b5b7b3f116397e0ad9c42
2019-09-05 03:05:38 -07:00
Chaiwat Ekkaewnumchai
be3772bd16 Orderable
Summary: _typescript_

Reviewed By: danielbuechele

Differential Revision: D17181370

fbshipit-source-id: 079a1a89f30665e4c86356ace299bd086819bcfb
2019-09-05 03:05:38 -07:00
Chaiwat Ekkaewnumchai
f6b371e2be DataPreview
Summary: _typescript_

Reviewed By: danielbuechele

Differential Revision: D17180388

fbshipit-source-id: 2375ce5eafbaac75cc789436c9ee1a199a233784
2019-09-05 03:02:05 -07:00
Chaiwat Ekkaewnumchai
e586c53393 Popover
Summary: _typescript_

Reviewed By: danielbuechele

Differential Revision: D17181415

fbshipit-source-id: 8b30cc1fdd7d4410b3ca13775ffdea3cae6f9ba4
2019-09-05 03:02:04 -07:00
Chaiwat Ekkaewnumchai
6fb59607c0 elements-inspector/sidebar
Summary: _typescript_

Reviewed By: danielbuechele

Differential Revision: D17180511

fbshipit-source-id: d5c3b8b671d05e57002739f9e038670a6c895fd8
2019-09-05 03:02:04 -07:00
Chaiwat Ekkaewnumchai
c120896ac8 ModelOverlay
Summary: _typescript_

Reviewed By: danielbuechele

Differential Revision: D17180882

fbshipit-source-id: 4a51bbd90f0a46807888de63ac305a7395d74a61
2019-09-05 03:02:04 -07:00
Chaiwat Ekkaewnumchai
56b061d883 Input
Summary: _typescript_

Reviewed By: danielbuechele

Differential Revision: D17180572

fbshipit-source-id: 2c820b6c2aef7abf567c42f87de7864501a91c2d
2019-09-05 03:02:04 -07:00
Chaiwat Ekkaewnumchai
8ae170c034 FileList
Summary: _typescript_

Reviewed By: danielbuechele

Differential Revision: D17180529

fbshipit-source-id: 50258a17c34177317397af618b43f2d2f76fb3a2
2019-09-05 03:02:03 -07:00
Chaiwat Ekkaewnumchai
2d83de99c5 MarketTimeline
Summary: _typescript_

Reviewed By: danielbuechele

Differential Revision: D17180745

fbshipit-source-id: 0a42d5deba70ed0dfe5cd344dd5da6d2fd572999
2019-09-05 03:02:03 -07:00
Chaiwat Ekkaewnumchai
aa48e71c08 DataInspector
Summary: _typescript_

Reviewed By: danielbuechele

Differential Revision: D17180390

fbshipit-source-id: 85fd4c2ad95a3be48df7dcbae9b77aee2578ae42
2019-09-05 02:59:18 -07:00
Daniel Büchele
ef2c6787fa convert Layout plugin
Summary: _typescript_

Reviewed By: passy

Differential Revision: D17153997

fbshipit-source-id: 308a070b86430a9256beb93b4d3e5f8d5b6c6e52
2019-09-05 02:51:41 -07:00