Summary:
Bumps [react-native-flipper](https://github.com/facebook/flipper) from 0.56.0 to 0.57.0.
<details>
<summary>Commits</summary>
<ul>
<li><a href="2fcab458bf"><code>2fcab45</code></a> Flipper Release: v0.57.0</li>
<li><a href="bb176577e9"><code>bb17657</code></a> Back out "Use interface SupportSQLiteDatabase in Android Databases Plugin"</li>
<li><a href="09e3c7a80f"><code>09e3c7a</code></a> Add chocolatey as a way to install openssl for windows (<a href="https://github-redirect.dependabot.com/facebook/flipper/issues/1527">https://github.com/facebook/flipper/issues/1527</a>)</li>
<li><a href="a5fbe167b9"><code>a5fbe16</code></a> Bump react-native-flipper from 0.54.0 to 0.56.0 in /react-native/ReactNativeF...</li>
<li><a href="48270af383"><code>48270af</code></a> Bump eslint-plugin-react-hooks from 4.1.0 to 4.1.2 in /flipper-js-client-sdk ...</li>
<li><a href="bb807243ae"><code>bb80724</code></a> Revert "fbjni 0.0.4 (<a href="https://github-redirect.dependabot.com/facebook/flipper/issues/1428">https://github.com/facebook/flipper/issues/1428</a>)" (<a href="https://github-redirect.dependabot.com/facebook/flipper/issues/1524">https://github.com/facebook/flipper/issues/1524</a>)</li>
<li><a href="d468d94363"><code>d468d94</code></a> Back out "Show FB internal instructions by default on "Getting Started" page"</li>
<li><a href="643a656cd9"><code>643a656</code></a> Back out "Merge internal and external troubleshooting pages into one with opt...</li>
<li><a href="8425db7b8b"><code>8425db7</code></a> Merge internal and external troubleshooting pages into one with optional inte...</li>
<li><a href="12d7b48443"><code>12d7b48</code></a> Show FB internal instructions by default on "Getting Started" page</li>
<li>Additional commits viewable in <a href="https://github.com/facebook/flipper/compare/v0.56.0...v0.57.0">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/configuring-github-dependabot-security-updates)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/1537
Reviewed By: mweststrate
Differential Revision: D23876572
Pulled By: cekkaewnumchai
fbshipit-source-id: 37fa5e66f6feb60701762f43a349dbe3b6eec1fd
Summary:
This adds support for flipper logs in Sandy, including some theme adjustments.
Did remove storage and showing of debug messages, as I noticed it tends to crash Flipper after a while since there are so many. Also added a fixed limit of only remembering last 1000
Also converted Toolbar and button with dropdown items to Sandy.
Reviewed By: cekkaewnumchai
Differential Revision: D23824528
fbshipit-source-id: b89d1182d4f14682251dbb482d93c2c009ddc7a4
Summary:
allow-large-files
Updated to typescript 4. Note that this is no new major, the way TS numbers is that 4.0 is simply the number after 3.9 (so they refuse to use 3.10).
Primarily reason is that it allows us to use `/** deprecated */`. although there are definitely more interesting improvements
Reviewed By: passy, nikoant
Differential Revision: D23869445
fbshipit-source-id: 54e251b398b8698d9b18898ce66c3203b32aa356
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/1542
Reviewed By: mweststrate
Differential Revision: D23888791
Pulled By: cekkaewnumchai
fbshipit-source-id: 75e0de6ea8f4d356fc1d3fca88127351d9164bba
Summary:
Per title
~~Note: `useStore.tsx` is copied from D23783500 (e7fdd8332d). This should be merged correctly in case the diff is landed before.~~
Reviewed By: mweststrate
Differential Revision: D23784302
fbshipit-source-id: adb5678c1b2614e3af4278889529c3fa79335bef
Summary:
Typography on Sandy! The designed typography is [here in Figma](https://www.figma.com/file/4e6BMdm2SuZ1L7FSuOPQVC/Flipper?node-id=238%3A172)
Current deflects
- cannot find component for 'body - small' and 'meta'
- don't know how to set 'link secondary hover' as designed
Reviewed By: mweststrate
Differential Revision: D23869256
fbshipit-source-id: efb1475749cebad529b502458d1b15bd445bb346
Summary:
We're seeing some CSR mismatches when they aren't expected. Adding logging to print out what is being found, to see if it's any OS-specific encoding issues or something like that, or completely different CSRs, etc.
URL encoded in case there are differences in non printable characters.
Reviewed By: nikoant
Differential Revision: D23867267
fbshipit-source-id: f406a396c808687b6b84561eb1def61b565aee34
Summary: The Flipper `Button` component now uses Ant.design under the hood if available. This is detected using context
Reviewed By: cekkaewnumchai
Differential Revision: D23813166
fbshipit-source-id: 489a34d55c0b69d7b5bcd30f4275b89d0bb22c0d
Summary: Converted Buttons to hooks, to make it easier to use context in the future. No further changes.
Reviewed By: cekkaewnumchai
Differential Revision: D23812921
fbshipit-source-id: 3739ad49e734dbe4d903a23d58da7cc267f6e109
Summary:
This enables opening the settings panel from Sandy. Created a small code switch in layouting to make sure it looks ok in both sandy and native dialog. Inside the settings no new components are used yet, which will be done in next diffs.
Also removed the close button from temporarily titlebar as settings are now accessible from Sandy chrome
Reviewed By: cekkaewnumchai
Differential Revision: D23812321
fbshipit-source-id: f8888373632786bb75f6dad635d300729b5086dc
Summary: This copies several utilities from the old title bar to the new one. We will have to revisit this in the future as it will eventually disappear. But in the mean time it makes sure version info and performance graphs are shown
Reviewed By: cekkaewnumchai
Differential Revision: D23824366
fbshipit-source-id: 0e495cd6d70db6a38da6df52b47ffee4bcb6f69f
Summary: FlipperEditor has migrated to `litho-editor-flipper`, so this diff fixes the dependency tree and deletes the file.
Reviewed By: muraziz
Differential Revision: D23380023
fbshipit-source-id: 75f5f037dc392194212fc156499f090c381999bd
Summary: I accidently broke search by query in a previous diff, so fixing it here
Reviewed By: passy
Differential Revision: D23842187
fbshipit-source-id: 9fcc7a46048ff99e1bf26c8a70ef0240b38018cb
Summary:
Implemented a first button: make main menu collapsible.
Also introduced some additional utilities and hooked up startup performance logging
Reviewed By: cekkaewnumchai
Differential Revision: D23783500
fbshipit-source-id: 2456fd781a52d497facbaccfabe885e4f8c408c5
Summary: This diff introduces the. main sections and restyled resizable panes according to the Figma design
Reviewed By: cekkaewnumchai
Differential Revision: D23758349
fbshipit-source-id: 7f09574f6b5fb54551141c13667c664e1769f09a
Summary:
Flipper cannot load Sandy plugins packaged by flipper-pkg, because the latter only expose default export, but Sandy API is using named exports instead ("Component" and "plugin").
This change fixes this by exposing both default and named exports from plugin package.
Reviewed By: passy
Differential Revision: D23815769
fbshipit-source-id: 1dd273b2e7b98bd01148506037066c41ffd19eb8
Summary:
Probably more than just KitKat, but we got a specific report in
https://fburl.com/f88cvz4c for 4.4. ABI lists are not included
in the probs and unfortunately TS doesn't resolve this to a
`string | undefined` as it should.
{F336605489}
Reviewed By: jknoxville
Differential Revision: D23815568
fbshipit-source-id: b6af928f85549d0c973feb0d83a324252ce0f654
Summary: jknoxville helped me debug this. The underlying problem was that we didn't include a dependency which is transitive in gradle land. We swallowed the exception and just returned an empty list. I left an error log in there to make future debugging easier. For reference, this was the error:
Reviewed By: cekkaewnumchai
Differential Revision: D23759727
fbshipit-source-id: 244510d2765913bf4c89458e336889c3c6838fc4
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/1532
Upgrade to Electron 10, in an attempt to fix random hard Electron crashes. Didn't fix it, but given the changelog of Electron with all the bug fixes, seems to be a good idea nonetheless :)
Changelog: Flipper now uses Electron 10
Reviewed By: nikoant
Differential Revision: D23565000
fbshipit-source-id: 3f07b8cf8c438147bde5314698d20046ac9f94cf
Summary:
Adds a link to the Yoga playground atop all properties of Yoga-based views.
We could make the playground match the properties below if I figure out the hashing mechanism the website uses. This is a start.
Reviewed By: muraziz
Differential Revision: D23758538
fbshipit-source-id: 6a3f206914aa9962e55852df548f8026783506e9
Summary:
As requested in https://fburl.com/dpuz2cew
This diff adds a new popup menu option to copy the info of all the expanded elements in a view/component tree.
It does it by moving the copy function to the layer where all elements are available.
The diff also replaces `Copy` to a call to the same function.
Reviewed By: muraziz
Differential Revision: D23757826
fbshipit-source-id: 3f70c85267f928f7153db75ed8f4eaa3fac669e7
Summary:
You know the drill.
Pull Request resolved: https://github.com/facebook/flipper/pull/1530
Test Plan: Checked that `yarn.lock` references the respective new versions.
Reviewed By: nikoant
Differential Revision: D23733338
Pulled By: passy
fbshipit-source-id: abf9812b977542a8b297b88ea16c7c01a062898b
Summary:
I've already removed support for plugin format v1 and thus compilation on startup is not needed anymore and many dependencies can be safely removed.
I actually already removed them before that, but it looks like automerge returned them back somehow.
Reviewed By: mweststrate
Differential Revision: D23735001
fbshipit-source-id: 7b1ae655738a35e388f818fb27f80c5a0e8327de
Summary:
This diff fixes two problems when further theming Flipper:
1. All shades of gray where defined in terms of black/white + transparency. Converted all colors to non transparent to make sure they stack well.
2. The color theme defined in less aren't available as javascript colors. It is possible to achieve that through setting up a babel parser that parses the less files and exposes them to JS. But since we have modern stack, figured that exposing all theme variables as CSS variables as well is a much simpler setup.
Reviewed By: passy
Differential Revision: D23756558
fbshipit-source-id: e92be1f66b11c2c9c400fc1622cb8a493cc4c2a5
Summary:
This setups the first bits of the Sandy Layout, and has a styled siderail according to the design, that does absolutely nothing.
{gif:0sa60r8c}
Reviewed By: cekkaewnumchai
Differential Revision: D23655313
fbshipit-source-id: e30278aeae0913e231ad105a9afb55c74c6a3370
Summary: Adds support for switching dark mode on the fly. Also added the option to apply certain settings without restarting Flipper, as that isn't needed in all cases.
Reviewed By: cekkaewnumchai
Differential Revision: D23625854
fbshipit-source-id: 82175ba10524daf1b48a65feec8c610460df9418
Summary:
allow-large-files
This makes the Ant.design component library available to Flipper
The CSS setup is unconventional, in the sense that the normal way to do this is to use a webpack loader to dynamically load the right less files, and a babel transform to automatically import the style sheets.
Since we use Metro, which is not very suitable for transforming non-JS(like) files, I figured that the simplest thing is to pre-compile the entire less theme. Which should be fine since we shouldn't be changing the less files very often, and since we don't ship a website, it is probably not too bad to have the full ANT theme for now in there, even though we don't use all components. It is 600 K of css. In the next diff the CSS is loaded conditionally, only if Sandy is enabled.
If the CSS turns out to be too big we can optimise this later to only import CSS for components we use by doing some Metro magic, but it doesn't seem to be trivial (that is, I couldn't get in to work in < 2 hours).
Reviewed By: cekkaewnumchai
Differential Revision: D23625855
fbshipit-source-id: 3ba810b2221dc0c7b719f66310e590c7748cf239
Summary:
Now full restart is not required for applying plugin changes (install/uninstall/update). So this diff changes the behavior to use reload instead of restart in Plugin Manager and Auto Update Manager. It is much faster than full restart.
Changelog: faster reload after plugin install/uninstall/update.
Reviewed By: jknoxville
Differential Revision: D23706701
fbshipit-source-id: b2dcaf7768a5d47b3c967c17e090fa74884b3850
Summary: Enable asar which should further improve startup time and bundle size
Reviewed By: passy
Differential Revision: D23705524
fbshipit-source-id: 161d28e4c3995615166171ab4926ec011a4b5dfb
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/1529
Reviewed By: nikoant
Differential Revision: D23733948
Pulled By: passy
fbshipit-source-id: 57d3eeafee518a92fca6dc31a87b5b65c291cae8
Summary:
- Removed compilation on startup which is not required anymore after switching to plugin spec v2.
- Removed from Node process ("static" package) all the dependencies which are not required anymore: e.g. metro, babel etc.
- Plugin loading code from node process moved to browser process and made asyncronous.
Some expected benefits after these changes:
1) Reduced size of Flipper bundle (~4.5MB reduction for lzma package in my tests) as well as startup time. It's hard to say the exact startup time difference as it is very machine-dependent, and on my machine it was already fast ~1500ms (vs 5500ms for p95) and decreased by just 100ms. But I think we should definitely see some improvements on "launch time" analytics graph for p95/p99.
2) Plugin loading is async now and happens when UI is already shown, so perceptive startup time should be also better now.
3) All plugin loading code is now consolidated in "app/dispatcher/plugins.tsx" instead of being splitted between Node and Browser processes as before. So it will be easier to debug plugin loading.
4) Now it is possible to apply updates of plugins by simple refresh of browser window instead of full Electron process restart as before.
5) 60% less code in Node process. This is good because it is harder to debug changes in Node process than in Browser process, especially taking in account differences between dev/release builds. Because of this Node process often ended up broken after changes. Hopefully now it will be more stable.
Changelog: changed the way of plugin loading, and removed obsolete dependencies, which should reduce bundle size and startup time.
Reviewed By: passy
Differential Revision: D23682756
fbshipit-source-id: 8445c877234b41c73853cebe585e2fdb1638b2c9
Summary:
Do not list plugins packaged with format v1 in Plugin Manager.
Changelog: removed support for plugins packaged using legacy format (v1), so they won't appear in Plugin Manager anymore.
Reviewed By: passy
Differential Revision: D23681402
fbshipit-source-id: 1c9496ba6b739069d67228a0f4250f2f01aabd4d
Summary:
Sorry for so long diff, but actually there are no functional changes, just refactoring to make further changes of Plugin Manager easier to understand.
I've de-coupled the code related to plugin management from UI code and moved it from PluginInstaller UI component (which will be replaced soon by new UI) to "flipper-plugin-lib". So pretty much everything related to plugin discovery and installation now consolidated in this package.
Additionally, this refactoring enables re-using of plugin management code in "flipper-pkg", e.g. to create CLI command for plugin installation from NPM, e.g.: `flipper-pkg install flipper-plugin-reactotron`.
Reviewed By: passy
Differential Revision: D23679346
fbshipit-source-id: 82e7b9de9afa08c508c1b228c2038b4ba423571c
Summary: This broke DB opening in FB apps. Will try to fix and reland this, but need to unblock people first.
Reviewed By: cekkaewnumchai
Differential Revision: D23705962
fbshipit-source-id: 3c9ff3a74e5a6d34e6cb2c75e7e2cec749b5a60e
Summary:
We've had several reports that Chocolatey-provided openssl works well with Flipper, so recommending it here.
Pull Request resolved: https://github.com/facebook/flipper/pull/1527
Reviewed By: passy
Differential Revision: D23705926
Pulled By: jknoxville
fbshipit-source-id: c582b2319caf1aa67890c1fefc66730dc1047ecd
Summary:
Bumps [react-native-flipper](https://github.com/facebook/flipper) from 0.54.0 to 0.56.0.
<details>
<summary>Commits</summary>
<ul>
<li><a href="a47ac961f7"><code>a47ac96</code></a> Flipper Release: v0.56.0</li>
<li><a href="1b80877f1a"><code>1b80877</code></a> Implement requestResponse for websocket connection (<a href="https://github-redirect.dependabot.com/facebook/flipper/issues/1510">https://github.com/facebook/flipper/issues/1510</a>)</li>
<li><a href="7a7a88bfde"><code>7a7a88b</code></a> Use interface SupportSQLiteDatabase in Android Databases Plugin (<a href="https://github-redirect.dependabot.com/facebook/flipper/issues/1196">https://github.com/facebook/flipper/issues/1196</a>)</li>
<li><a href="e13d63ea6f"><code>e13d63e</code></a> Bump http-proxy from 1.18.0 to 1.18.1 in /website (<a href="https://github-redirect.dependabot.com/facebook/flipper/issues/1516">https://github.com/facebook/flipper/issues/1516</a>)</li>
<li><a href="fdf9570cb7"><code>fdf9570</code></a> Fix sandbox plugin initialisation</li>
<li><a href="aeebec5cd7"><code>aeebec5</code></a> Prepare for rustfmt 2.0</li>
<li><a href="142eb8f9ea"><code>142eb8f</code></a> Add doc markers to code</li>
<li><a href="f33d4b3f9e"><code>f33d4b3</code></a> Add internaldocs-fb-helpers lib</li>
<li><a href="d4d2937c80"><code>d4d2937</code></a> Fix setting layoutParams fromLayout Editor</li>
<li><a href="842fe6df5c"><code>842fe6d</code></a> Add picker for ViewDescriptor</li>
<li>Additional commits viewable in <a href="https://github.com/facebook/flipper/compare/v0.54.0...v0.56.0">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/configuring-github-dependabot-security-updates)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/1526
Reviewed By: mweststrate
Differential Revision: D23680998
Pulled By: passy
fbshipit-source-id: ad4f35f407acc8d8d76037d6907b5a26adb6d544
Summary: Unfortunately optional require does not work with docusaurus bundler configuration in case file not exist, so open source build is failing now. I'm backing out this commit until solution for dynamic imports in docusaurus found.
Reviewed By: mweststrate
Differential Revision: D23679198
fbshipit-source-id: 9be008f19b5945d17ec31614a8d2cb80bad9ca2e
Summary: Unfortunately optional require does not work with docusaurus bundler configuration in case file not exist, so open source build is failing now. I'm backing out this commit until solution for dynamic imports in docusaurus found.
Reviewed By: mweststrate
Differential Revision: D23679147
fbshipit-source-id: 7934e0a7decf128c1914f52645adaf4617c97eea
