Summary:
Client calls return a promise. Not dealing with the error causes promise unhandled rejection errors.
This change adds a catch block and logs the error instead.
Reviewed By: antonk52
Differential Revision: D37955029
fbshipit-source-id: 50cac5a5339961d16868ab2102d3c77790e6943c
Summary:
Historically, RSocket used to raise an error when there was an error during send, most likely because the connection was dead.
With WS, this is no longer the case.
WS connection issues are raised through the according handlers.
Reviewed By: passy
Differential Revision: D37825821
fbshipit-source-id: 7fcda8cf26fb42eb0d8ca03b62482f11c931777f
Summary:
This diff has been automatically generated by the inpage editor.
If you want to update this diff, go through the preview link that would be attached to the test plan.
Please ensure you are editing the same page that was used to create this diff.
Reviewed By: passy
Differential Revision: D37853011
fbshipit-source-id: 1d68d5a80b30bb1b1cdf5703272717dadbe3a977
Summary:
Nothing interesting here, just adding necessary sources from Flipper into the VS Studio solution.
As a consequence, some warnings had to be turned off as otherwise they're treated as errors and the solution doesn't build.
Reviewed By: passy
Differential Revision: D36760242
fbshipit-source-id: 2f5e615f8a465554dd35c245756f94bcace6e34a
Summary:
This change brings in Folly and Boost into our solution.
Boost is resolved with NuGet. Folly is resolved by re-using the RNW integration.
For reference:
Flipper depends on Folly. Folly depends on a few things:
- Boost
- FMT
- Glog
- Double-Conversion
Folly from RNW uses some stubs to resolve fmt, glog, and double-conversion. That's OK.
Only Boost needs resolving.
On Visual Studio, we can use the following package managers: NuGet and vcpkg.
Boost can be resolved using either.
Using NuGet as otherwise vcpkg needs to be run locally by anybody wanting to build the solution. NuGet makes things easier.
Reviewed By: aigoncharov
Differential Revision: D36759384
fbshipit-source-id: 31a9a398ce5c5dc2f3def02689ae4bb8c42fbb99
Summary:
This diff adds a new menu option to the Logs plugin which allows for enabling/disabling the automatic filtering of search terms in the search history as user types.
Additionally, fixed bug regarding the search term that's used is not actually showing correctly. This is caused by the search value being set in the input search bar instead of the autoComplete component level
Differential Revision: D37555209
fbshipit-source-id: 8a76299f7e1a4b0a3adfa6a4dd883d17f1e7a442
Summary:
This change adds the template for a RNW module to the existing react-native flipper project.
Basically, the changes in this diff are the product of executing the react-native-windows init for the existing library.
See:
https://microsoft.github.io/react-native-windows/docs/getting-startedhttps://microsoft.github.io/react-native-windows/docs/native-modules-setup
Notes:
There's some auto-generated module code contained in this change: ReactNativeModule (.h/.cpp)
allow-large-files
Reviewed By: passy
Differential Revision: D36751772
fbshipit-source-id: 41207bedb00ea147883f6d13336ed6c1da4454d7
Summary:
^
If Flipper stops, we cannot freely access the client outside of the scheduler.
There may be an scheduled operation that depends on it.
Instead, schedule the stop and wait until it finishes.
Reviewed By: cekkaewnumchai
Differential Revision: D37814820
fbshipit-source-id: 44217b5f623a8d92211a3d72a4a204d674b4bb76
Summary:
Sets a default key binding of `ctrl+l` to clear the screen within built-in Flipper plugins which display a log view.
Motivation: A small quality of life improvement for developers used to the default "clear screen" binding. This makes our log-rendering plugins consistent with other native apps such as terminals, Chrome DevTools, and many others.
Reviewed By: mweststrate
Differential Revision: D37782638
fbshipit-source-id: 0a85b930faaa0e9468d5391f15092aad7b6057ee
Summary:
If there's a device client disconnect during request execution, no response is ever given back to the client (flipperd).
This change effectively subscribes to client disconnect events and notifies flipperd of any disconnection during request processing.
Reviewed By: passy
Differential Revision: D37787986
fbshipit-source-id: 31737a50b83b0cbe4141ce814064aebef7e09bfc
Summary:
Currently in the Flipper network plugin implementation, XMLTextFormatter is only enabled if `content-type` is `text/html`.
We should enable it for `application/xml` and `text/xml` as well.
Reviewed By: mweststrate
Differential Revision: D37733487
fbshipit-source-id: f272c5d0a305cf4afd32701d40459c3e11049886
Summary: For the Flipper Server Companion, if a plugin is being requested which is not yet installed, try to install it first from the marketplace.
Reviewed By: passy
Differential Revision: D37716962
fbshipit-source-id: d618fbc597f82b540dbb02e8ffc296dcee9e1eb9
Summary:
Expose two new methods as to be able to:
- List plugins from marketplace
- Install a plugin from marketplace
Reviewed By: passy
Differential Revision: D37749817
fbshipit-source-id: 82b78f7906c5664d5747289fa4f8eadebcde1d73
Summary: Expand PluginManager as to be able to load and install plugins from Marketplace.
Reviewed By: passy
Differential Revision: D37749802
fbshipit-source-id: 7d7e23427cc9d01f5c953b90e5b346a9d6bab19f
Summary:
Implementation taken from:
https://www.internalfb.com/code/fbsource/[85c1fe5afee7]/xplat/sonar/desktop/flipper-ui-core/src/fb/pluginMarketplaceAPI.tsx
As with the previous diff, the marketplace API for flipper-server-core accesses the existing config in a different way and depends on FlipperServer, instead of User, to execute intern request as to obtain marketplace plugins.
Reviewed By: passy
Differential Revision: D37749775
fbshipit-source-id: 968ea3f7a412893f032e5a7a50ecf17c298e18ff
Summary:
A few comments in my rewrite stack got missed, I am addressing them here.
In addition react testing library has been hoisted to the root module in the project and been made available to all sub modules
Reviewed By: mweststrate
Differential Revision: D37712339
fbshipit-source-id: 60984c3d16bd535b0c489570907f097c7d80f634
Summary: Move User from reducers to flipper-common. User will now be usable by other modules.
Reviewed By: passy
Differential Revision: D37599802
fbshipit-source-id: 66412e7ed00bf27448fa2deae70f0e8e80303aba
Summary: This is needed to avoid mobile builds depending on BaseDevice
Reviewed By: mweststrate
Differential Revision: D37315909
fbshipit-source-id: a090bd3e76ceefe1f2ac68f832ee544ae45a8d6a
Summary: There is a new flipper server command to install apps. For android it uses adb (via adb kit) For ios depending on idb availablity it will use idb or xcrun. Consumed in the next diff
Reviewed By: lblasa, aigoncharov
Differential Revision: D36936637
fbshipit-source-id: e09d34d840a9f3bf9136bcaf94fb8ca15dd27cbb
Summary:
Provides a much nicer devx, shows test pass / failure in the editor and error messages in line
https://pxl.cl/25G0x
When the extension is installed with this config it will watch all test and run what is needed, automatically updating the editor with test status
It also supports debugging tests individually right in the editor
see https://github.com/jest-community/vscode-jest for full docs
Also Once VS code @ fb is updated to a newer base of vscode, we will get access to to the testing sidebar feature
https://pxl.cl/25G0R
Reviewed By: lblasa, aigoncharov
Differential Revision: D37009812
fbshipit-source-id: e1918a0817d4703089b6300840fcf9564b871682
Summary: This is required to enable off-VPN access to the site
Reviewed By: antonk52
Differential Revision: D37611617
fbshipit-source-id: 7599fc22766315d799345e955fc87ff3a7ddf50f
Summary:
See https://fb.workplace.com/100051336486185/videos/469885544533059/
I couldn't reproduce it myself, but it is reported that when copying logs, the order of the selection is not preserve. Diving into the example there is a block of rows (around the 1.09 timestamp) that appear 'too early' in the output.
In flipper we sort the selection before copying the data by row index. This is to make sure if the user has multiple selections, they appear in the order of the logs (including any applied sorting), rather than in the order of which the user selected them.
However, when sorting numbers, JavaScript by coerces them to strings first (wtf JS), so the issue can be prevented by explicitly providing a sort function. Proof: {F749329864}
Reviewed By: lblasa
Differential Revision: D37596975
fbshipit-source-id: 820e03350034e7af8148200a58a8c858b358acd8
Summary:
In diff D36663929 (e07d5c5bfe) the behaviour of data table was changed so that it only searched fields that were columns in the table. Due to user request we are restoring the functionality where you can search and it will look in all top level fields in the underlying object for the row
changelog: Fixed 'free text search' for data table. E.g network plugin
Reviewed By: mweststrate
Differential Revision: D37552492
fbshipit-source-id: 00ec942b2a2336c19a7d067d85cc6c81b8a175e1
Summary:
^
There may be cases whereas the process exits but leaks the socket descriptors.
There's already a hook to close flipper-server.
Reviewed By: passy
Differential Revision: D37550940
fbshipit-source-id: 35004969834bb92bb7cf0f56bda8d7b43c11d6bf
Summary: We no longer need to Tail the logs as we stream the logs over WebSockets (see D37459924 (dcbc7c40bb))
Reviewed By: lblasa
Differential Revision: D37550482
fbshipit-source-id: 92a87f2ba1ecec140bbbb9e71df107341765ad46
Summary:
Currently, we call onSelect in DataTable only when user changes their selection. At that moment, we pass the row data to the `onSelect` callback. However, if later the data changes, but the selection stays the same, we do not call `onSelect` again. As result, any listener to onSelect does not receive the latest data.
In this diff, we start calling `onSelect` when the selection does not change, but the underlying data does.
Reviewed By: mweststrate
Differential Revision: D37520346
fbshipit-source-id: a88d34654e9ad0721caf5918dde49b86ba20fc1f
Summary:
CHANGELOG: Rotate flipper-server logs
Otherwise, they re going to eat up all space eventually in a one monstrous file
Reviewed By: passy
Differential Revision: D37516868
fbshipit-source-id: 478a61c56ec007e4a3d695f7e6df2a61cb33c33a
