Summary:
Bumps [normalize-url](https://github.com/sindresorhus/normalize-url) from 4.5.0 to 4.5.1.
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a href="https://github.com/sindresorhus/normalize-url/commits">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/facebook/flipper/network/alerts).
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/2440
Reviewed By: mweststrate
Differential Revision: D29036654
Pulled By: passy
fbshipit-source-id: 1a7e823ebf02fdb05af75503f1fe988a6967b5d2
Summary:
Not being able to have timestamps in Jest snapshots, as they would differ across machines required jumping through a lot of hoops.
Run this into once again more by a test suite that didn't trigger on CI, but failed for me locally.
With this fix everyone can happily commit time based snapshots and they will always be assumed to be running in UTC :)
Reviewed By: nikoant
Differential Revision: D29025759
fbshipit-source-id: 426d1b065afdd4a2ed75b47203b13fff0ece1272
Summary:
Re-introduced context menu to DataTable, due to popular demand.
Originally it wasn't there to better align with ant design principles, but in an app like Flipper it makes just too much sense to have it
See e.g. https://fb.workplace.com/groups/flippersupport/permalink/1138285579985432/
changelog: Restored context menu in data tables
Reviewed By: passy
Differential Revision: D28996137
fbshipit-source-id: 16ef4c90997c9313efa62da7576fd453a7853761
Summary:
Bumps [react-native](https://github.com/facebook/react-native) from 0.64.1 to 0.64.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/facebook/react-native/releases">react-native's releases</a>.</em></p>
<blockquote>
<h2>v0.64.2</h2>
<p>Hello everyone - here's the new 0.64.2 patch release with some really good fixes that were asked <a href="https://github-redirect.dependabot.com/react-native-community/releases/issues/224">by the community</a>:</p>
<h3>Changed</h3>
<ul>
<li>Find-node.sh supports Homebrew on M1 (<a href="502b819049">502b819049</a> by <a href="https://github.com/dulmandakh"><code>@dulmandakh</code></a>)</li>
<li>Refactor UIManagerHelper.getUIManager to return null when there's no UIManager registered (<a href="b0e8c1eac0">b0e8c1eac0</a> by <a href="https://github.com/mdvacca"><code>@mdvacca</code></a>)</li>
</ul>
<h3>Fixed</h3>
<ul>
<li>Fix ScrollViewStickyHeader to push up header above it (<a href="d754bdefc6">d754bdefc6</a> by <a href="https://github.com/kacieb"><code>@kacieb</code></a>)</li>
</ul>
<h4>Android specific</h4>
<ul>
<li>Font family is not apply when secureTextEntry is true (<a href="cda77c77dd">cda77c77dd83cba07e6c2e56e938c3e4f7faf8fc</a> by <a href="https://github.com/hank121314"><code>@hank121314</code></a>)</li>
<li>Dimension update events are now properly sent following orientation change (<a href="a6a4d3365f">a6a4d3365f17332e367c34357a07a73f97d6ec83</a> by <a href="https://github.com/ajpaulingalls"><code>@ajpaulingalls</code></a>)</li>
</ul>
<hr />
<p>You can participate in the conversation on the status of this release at <a href="https://github-redirect.dependabot.com/react-native-community/releases/issues/232">this issue</a>.</p>
<hr />
<p>To help you upgrade to this version, you can use the <a href="https://react-native-community.github.io/upgrade-helper/">upgrade helper</a> {emoji:269b}</p>
<hr />
<p>You can find the whole <a href="https://github.com/react-native-community/react-native-releases/blob/master/CHANGELOG.md">changelog history</a> over at <code>react-native-releases</code>.</p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="757bb75fbf"><code>757bb75</code></a> [0.64.2] Bump version numbers</li>
<li><a href="f7ce3f0d85"><code>f7ce3f0</code></a> [LOCAL] auto-generated files</li>
<li><a href="395e8ecab5"><code>395e8ec</code></a> [LOCAL] bump CLI to alpha 1 to fix CLI issue</li>
<li><a href="09dd3e9096"><code>09dd3e9</code></a> find-node.sh supports Homebrew on M1 (<a href="https://github-redirect.dependabot.com/facebook/react-native/issues/31622">#31622</a>)</li>
<li><a href="eaed48fc7d"><code>eaed48f</code></a> Fix ScrollViewStickyHeader to push up header above it</li>
<li><a href="d894163662"><code>d894163</code></a> Refactor UIManagerHelper.getUIManager to return null when there's no UIManage...</li>
<li><a href="a05d179b6a"><code>a05d179</code></a> Add a fatal error handler for Hermes</li>
<li><a href="a6a4d3365f"><code>a6a4d33</code></a> Update the cached dimensions when orientation changes (<a href="https://github-redirect.dependabot.com/facebook/react-native/issues/30324">#30324</a>)</li>
<li><a href="cda77c77dd"><code>cda77c7</code></a> <code>Android</code>: font-family is not apply when secureTextEntry is true (<a href="https://github-redirect.dependabot.com/facebook/react-native/issues/30164">#30164</a>)</li>
<li>See full diff in <a href="https://github.com/facebook/react-native/compare/v0.64.1...v0.64.2">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/2419
Reviewed By: mweststrate
Differential Revision: D29028062
Pulled By: passy
fbshipit-source-id: 3ca71e065aea8321ae57105543e2b092c95feb0a
Summary:
Bumps [jest](https://github.com/facebook/jest) from 27.0.3 to 27.0.4.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/facebook/jest/releases">jest's releases</a>.</em></p>
<blockquote>
<h2>27.0.4</h2>
<h3>Fixes</h3>
<ul>
<li><code>[jest-config, jest-resolve]</code> Pass in <code>require.resolve</code> to resolvers to resolve from correct base (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11493">#11493</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/facebook/jest/blob/master/CHANGELOG.md">jest's changelog</a>.</em></p>
<blockquote>
<h2>27.0.4</h2>
<h3>Fixes</h3>
<ul>
<li><code>[jest-config, jest-resolve]</code> Pass in <code>require.resolve</code> to resolvers to resolve from correct base (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11493">#11493</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="b29acb355a"><code>b29acb3</code></a> v27.0.4</li>
<li><a href="5c4014736c"><code>5c40147</code></a> chore: bump jest-watch-typeahead</li>
<li><a href="d6fb0d8fb0"><code>d6fb0d8</code></a> fix: resolve bundled modules from correct location (<a href="https://github-redirect.dependabot.com/facebook/jest/issues/11493">#11493</a>)</li>
<li><a href="bba34bda37"><code>bba34bd</code></a> Update Architecture documentation. (<a href="https://github-redirect.dependabot.com/facebook/jest/issues/11508">#11508</a>)</li>
<li><a href="82d1a1a57b"><code>82d1a1a</code></a> chore: update lockfile after publish</li>
<li>See full diff in <a href="https://github.com/facebook/jest/compare/v27.0.3...v27.0.4">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/2420
Reviewed By: mweststrate
Differential Revision: D29028060
Pulled By: passy
fbshipit-source-id: 03b7dc8bad8f8a701720d57a7e6bbd58737ae18f
Summary:
Taking fabiomassimo's feedback. We include a lot of internals in the instructions which
made sense when it broke basically at every single step all the time. Now that it's
way more stable, it's probably okay to describe the happy path and leave the debugging
instructions in the wiki.
Reviewed By: fabiomassimo
Differential Revision: D29027849
fbshipit-source-id: 5c7a314cfab1d7e1534376783c9291417b6bf4bc
Summary: This only matters in Flipper proper.
Reviewed By: cekkaewnumchai
Differential Revision: D28964466
fbshipit-source-id: 6fae980cb091900c9b8325f443a2a6a9e81bbfe6
Summary: Since the functionality is now available as part of DataTable, the HoC doesn't seem to be needed as generic abstraction. it is used in handful places outside datatable / datalist, but those can be localized in the future or should datatable / datalist.
Reviewed By: fabiomassimo
Differential Revision: D28993836
fbshipit-source-id: 3e6da7c7b48348faa0c4f7281868196f5585a065
Summary:
`flipper-pkg init` would always introduce `flipper-plugin` peer with version `latest`. Since that can never be checked against the current flipper version, it always generated a warning. Updated the init process to take the version the plugin was generated with as base version instead.
Note that in the test the version will always display as 0.0.0, will double check after release that the proper version will show up when running from npx, but don't see a reason why not (famous last words)
Reviewed By: nikoant, priteshrnandgaonkar
Differential Revision: D28992531
fbshipit-source-id: c32aad1650f575f790c2e04d089104b7a616d26f
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/2435
Reviewed By: fabiomassimo
Differential Revision: D29000395
Pulled By: jknoxville
fbshipit-source-id: 6bec3497db6cb162852bf7f6f8467d22f3f5b7b6
Summary:
The current desktop plugin tutorial was outdated as it has several steps that are now automated, and still referred to old APIs. This has been updated now.
Additionally left the intermediate code of the tutorial in the plugin, but splitting `index.tsx` into `index_table.tsx` and `index_custom.tsx` (which will be updated in the next diff)
Clarified the tutorial page labels a little bit to show that 3 pages are covering the Desktop plugin development process.
Changelog: Updated the Desktop plugin tutorial
Reviewed By: jknoxville
Differential Revision: D28990029
fbshipit-source-id: a06a7a774ceca3daf10f8e8fbd4e03191dbfd1cc
Summary: per title. As follow up for previous diff
Reviewed By: fabiomassimo
Differential Revision: D28965865
fbshipit-source-id: 440c8143ac44011d895b3f194cabe7c69c51af72
Summary:
Bumps [react-native](https://github.com/facebook/react-native) from 0.64.1 to 0.64.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/facebook/react-native/releases">react-native's releases</a>.</em></p>
<blockquote>
<h2>v0.64.2</h2>
<p>Hello everyone - here's the new 0.64.2 patch release with some really good fixes that were asked <a href="https://github-redirect.dependabot.com/react-native-community/releases/issues/224">by the community</a>:</p>
<h3>Changed</h3>
<ul>
<li>Find-node.sh supports Homebrew on M1 (<a href="502b819049">502b819049</a> by <a href="https://github.com/dulmandakh"><code>@dulmandakh</code></a>)</li>
<li>Refactor UIManagerHelper.getUIManager to return null when there's no UIManager registered (<a href="b0e8c1eac0">b0e8c1eac0</a> by <a href="https://github.com/mdvacca"><code>@mdvacca</code></a>)</li>
</ul>
<h3>Fixed</h3>
<ul>
<li>Fix ScrollViewStickyHeader to push up header above it (<a href="d754bdefc6">d754bdefc6</a> by <a href="https://github.com/kacieb"><code>@kacieb</code></a>)</li>
</ul>
<h4>Android specific</h4>
<ul>
<li>Font family is not apply when secureTextEntry is true (<a href="cda77c77dd">cda77c77dd83cba07e6c2e56e938c3e4f7faf8fc</a> by <a href="https://github.com/hank121314"><code>@hank121314</code></a>)</li>
<li>Dimension update events are now properly sent following orientation change (<a href="a6a4d3365f">a6a4d3365f17332e367c34357a07a73f97d6ec83</a> by <a href="https://github.com/ajpaulingalls"><code>@ajpaulingalls</code></a>)</li>
</ul>
<hr />
<p>You can participate in the conversation on the status of this release at <a href="https://github-redirect.dependabot.com/react-native-community/releases/issues/232">this issue</a>.</p>
<hr />
<p>To help you upgrade to this version, you can use the <a href="https://react-native-community.github.io/upgrade-helper/">upgrade helper</a> {emoji:269b}</p>
<hr />
<p>You can find the whole <a href="https://github.com/react-native-community/react-native-releases/blob/master/CHANGELOG.md">changelog history</a> over at <code>react-native-releases</code>.</p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="757bb75fbf"><code>757bb75</code></a> [0.64.2] Bump version numbers</li>
<li><a href="f7ce3f0d85"><code>f7ce3f0</code></a> [LOCAL] auto-generated files</li>
<li><a href="395e8ecab5"><code>395e8ec</code></a> [LOCAL] bump CLI to alpha 1 to fix CLI issue</li>
<li><a href="09dd3e9096"><code>09dd3e9</code></a> find-node.sh supports Homebrew on M1 (<a href="https://github-redirect.dependabot.com/facebook/react-native/issues/31622">#31622</a>)</li>
<li><a href="eaed48fc7d"><code>eaed48f</code></a> Fix ScrollViewStickyHeader to push up header above it</li>
<li><a href="d894163662"><code>d894163</code></a> Refactor UIManagerHelper.getUIManager to return null when there's no UIManage...</li>
<li><a href="a05d179b6a"><code>a05d179</code></a> Add a fatal error handler for Hermes</li>
<li><a href="a6a4d3365f"><code>a6a4d33</code></a> Update the cached dimensions when orientation changes (<a href="https://github-redirect.dependabot.com/facebook/react-native/issues/30324">#30324</a>)</li>
<li><a href="cda77c77dd"><code>cda77c7</code></a> <code>Android</code>: font-family is not apply when secureTextEntry is true (<a href="https://github-redirect.dependabot.com/facebook/react-native/issues/30164">#30164</a>)</li>
<li>See full diff in <a href="https://github.com/facebook/react-native/compare/v0.64.1...v0.64.2">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/2422
Reviewed By: mweststrate
Differential Revision: D28960718
Pulled By: passy
fbshipit-source-id: 1ab0a17550159ba3256dd95dd908fc5e4e2833a7
Summary: Changelog: [Logs] show debug level logs by default. Now only verbose level is hidden by default
Reviewed By: fabiomassimo
Differential Revision: D28963445
fbshipit-source-id: e960654b02cf3b4248e0c8d4a9745208f160bc8d
Summary: Fixed minor keyboard navigation annoyance: pressing arrow down on the last entry would remove selection, then jump to first row. Pressing up on first row would deselect then select first again. After this change the first/last item is kept selected in those cases
Reviewed By: passy
Differential Revision: D28958705
fbshipit-source-id: 01dbce3971ed965eae3b74e6706fef96aa86df66
Summary:
This should take care of the build issue. It's an annoying caching issue that's been around for ages. Also why it didn't happen locally.
Pull Request resolved: https://github.com/facebook/flipper/pull/2432
Test Plan: GitHub CI
Reviewed By: mweststrate
Differential Revision: D28958707
Pulled By: passy
fbshipit-source-id: 8538f6616dec934d924c04713af93e7a6b89e617
Summary: some type simplifications, that makes it easier to reuse data sources and helps type inference
Reviewed By: passy
Differential Revision: D28413380
fbshipit-source-id: 261a8b981bf18a00edc3075926bd668322e1c37d
Summary: We don't need to show plugin-related details and button "open globalError" (which anyway doesn't work) when showing global notifications.
Reviewed By: passy
Differential Revision: D28900468
fbshipit-source-id: 54347ede4f1e4dbfb0e41be5c50374fda35c1223
Summary: Improved message a bit to make it clear that VPN/Lighthouse is required on both sides - computer and mobile device. Also it will now show login link in case user is not signed in yet, because login is also required for www cert exchange.
Reviewed By: passy
Differential Revision: D28899558
fbshipit-source-id: 89de776f602a9f27a2c068efd8e3f08c28ec5f57
Summary:
This diff adds the cocoapod's github repo as a source otherwise Cocoapod uses the cdn to refer the latest pods. We need this as in create_pr job we update the Podfile.lock of this RN sample project and it fails to find the latest flipper pod because Cocapod takes a while to update its cdn. Reffering the specs directly from github repo solves the issue.
## Changelog
Add github spec repo as a source in the Podfile.
Pull Request resolved: https://github.com/facebook/flipper/pull/2412
Test Plan:
CI
https://github.com/facebook/flipper/actions/runs/902547740
Reviewed By: nikoant
Differential Revision: D28896796
Pulled By: priteshrnandgaonkar
fbshipit-source-id: d5a2f10d42fa91218f853cdfb1920a10f438c697
Summary:
Indicatif 0.16 is incompatible with 0.15. Internally, we only have the latter
so I'm reverting instead of fixing forward.
Reviewed By: jknoxville
Differential Revision: D28899744
fbshipit-source-id: 0461073083f34887babbed13abb55a3dbfa1d801
Summary: Thisi diff updates the CK version to > 0.31 everywhere. It also removes direct CK dependency on SampleSwift, as it doesn't use CK directly.
Reviewed By: fabiomassimo
Differential Revision: D28898898
fbshipit-source-id: 77d4cece79a0a4a51e7ac27b3ec68283740cd0b2
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/2409
Reviewed By: passy
Differential Revision: D28896423
Pulled By: priteshrnandgaonkar
fbshipit-source-id: 2758592dad6c0597a6bc3a05e8173f7f00f5593b
Summary:
I'm going through our resolutions one-by-one, removing them and then seeing what the resulting change in the yarn.lock is and if it falls below what was pinned prior to D28835488.
In this case, we're above the previous lock which means we can safely remove it without getting a vulnerable version back.
Reviewed By: muraziz
Differential Revision: D28835545
fbshipit-source-id: 3159e1a165bbd4310c44520b0fe861a0d3a74fed
Summary:
I'm going through our resolutions one-by-one, removing them and then seeing what the resulting change in the yarn.lock is and if it falls below what was pinned prior to D28835488.
In this case, we're above the previous lock which means we can safely remove it without getting a vulnerable version back.
Reviewed By: muraziz
Differential Revision: D28835487
fbshipit-source-id: 3897b2127e923b5ea68ec50b7675869f34c24640
