Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/548
First project to pull out of the "fat distribution" we currently have.
Still needs setup for Maven and registration in Bintray.
Reviewed By: jknoxville
Differential Revision: D17395660
fbshipit-source-id: 6244495a2e25d705dd930ef87c7e5e1f038eb921
Summary: Adding Plugin Manager to menu bar and update wording in sidebar
Reviewed By: passy
Differential Revision: D17450840
fbshipit-source-id: 9426e6053f454a8e3776e9e0e061cd119f8dc7b5
Summary: Adding the plugin installer to the plugin sheet as a second tab
Reviewed By: passy
Differential Revision: D17450842
fbshipit-source-id: 211c9f15ed2614a1dd46d974b86f50c825f81fb0
Summary:
Prepare package.json to publish to NPM.
This should set an example on how plugins can be shared via NPM.
Reviewed By: passy
Differential Revision: D17450841
fbshipit-source-id: 95bfe7331e5a95d4a8d201e5fea148cbdec6859f
Summary: Adding an additional style for tabs on top of a container, similar to the ones used in macOS
Reviewed By: passy
Differential Revision: D17450843
fbshipit-source-id: 6b58c2aa290e0221d917e60bb3ac0751f77ea1ce
Summary:
My MBP just crashed again during startup. I would like to
understand why every plugin compilation appears to start
up a new electron process, but until that's understood
and hopefully fixed, it's probably best to limit the number
of processes we spawn by setting an upper bound here.
N.B. My Linux box doesn't mind this at all.
Reviewed By: jknoxville, danielbuechele
Differential Revision: D17419289
fbshipit-source-id: a11562a21a984059dc35e826eb20d869df218546
Summary: Using styled components rather than class names to follow Flipper's guidelines
Reviewed By: jknoxville
Differential Revision: D17419665
fbshipit-source-id: 17e0a3bd9292327a4b34eb4e87e5271af8fa22c7
Summary:
`this.client.subscribe` was used to listen for navigation events. This means, navigation events are not collected while the plugin is in background.
In this diff, this is changed to a persistedStateReducer, so the events are collected with the plugin not active.
Reviewed By: jknoxville
Differential Revision: D17419668
fbshipit-source-id: 88d9476cb7461ff6774d42a992d32b4c8948ac86
Summary: `idb file pull` no longer accepts a directory name as a destination to pull a file to. This passes the destination file name instead.
Reviewed By: passy
Differential Revision: D17420100
fbshipit-source-id: 9e2f5bfda3733832fc71944f1dbbdb7ac0f08acb
Summary: This diff overrides the serializer and deserializer methods for the plugins.
Reviewed By: danielbuechele
Differential Revision: D17402442
fbshipit-source-id: 245990b6060a84995c6637c2d8e5d6a814d546e1
Summary: This diff refactors Map to Javascript Object so that we can avoid custom serializer.
Reviewed By: danielbuechele
Differential Revision: D17402444
fbshipit-source-id: afd1919b0bea7925fcd26b54cc58f588a116bbcb
Summary: For plugins to be discoverable through NPM, they need to have `flipper-plugin` as a keyword. This adds this keyword to all existing plugins (although they are currently not distributed via NPM) and the webside/docs.
Reviewed By: passy
Differential Revision: D17395079
fbshipit-source-id: e42dd31ca39c3754cf729052ee783687748bafe8
Summary: Checking `~/.flipper/thirdparty` for already installed plugins and displaying them on top of the table
Reviewed By: jknoxville
Differential Revision: D17394821
fbshipit-source-id: 65f392c8beaf72d9effcae9f47a60bcbb9194025
Summary: Using yarn's algolia index to search NPM packages with the tag `flipper-plugin`.
Reviewed By: jknoxville
Differential Revision: D17394823
fbshipit-source-id: d7c88ddf5d4ce017f2672755436ef3ae7ed4e7f0
Summary: Setting up a sheet to list plugins that can be installed from NPM
Reviewed By: jknoxville
Differential Revision: D17394824
fbshipit-source-id: 26c6ffea9de9cf3fe8488ea1a757eae7b7aaa7ef
Summary: Overrides the default serializer and deserializer for the Layout Plugin. This diff uses `JSON.stringify` and `JSON.parse` to serialize and deserialize the object respectively. It turns out the our custom serializer is slower than the `JSON.stringify` and the export is way quicker.
Reviewed By: danielbuechele
Differential Revision: D17402443
fbshipit-source-id: 0d36783858ec1972130bdbc57ba7d3cdc5a73774
Summary: This diff shows the status message of "Uploading Flipper Trace..." when we upload it.
Reviewed By: danielbuechele
Differential Revision: D17402445
fbshipit-source-id: ab2927de34ab5d7e49e7c7ea005d40816a0365bd
Summary: I like the idea, but these reject by default promises cause the global rejection handler to fire at startup, looking like things are broken.
Reviewed By: danielbuechele
Differential Revision: D17397614
fbshipit-source-id: 88601d6c65cb79d61efc27c34a4b7f2dd8716d39
Summary: Just noticed this. There are probably not many version 0's around, but if there are they should be treated as old.
Reviewed By: passy
Differential Revision: D17397155
fbshipit-source-id: fab6f8b2557ecb983441b282ceb29b5b744ae900
Summary:
Plugin keys which are used to record the least recently used plugins to show on sidebar on android emulators depend on the port (connected order), so it can cause unexpected order (swapping between two devices).
This will ensure that for the same app it will have the same order regardless of device it is running
Reviewed By: jknoxville
Differential Revision: D17395033
fbshipit-source-id: 94ef4ef51bd5545f2ef7ce47bf8bc931d0140dbd
Summary:
Per title
Earlier SDK version and this version (3) of Flipper determine a device for an app differently, so there is a case that both versions of the same app can refer to the same device which uses mutual name.
To resolve this problem, we change the name of previous SDK version of an app, so that
1) Both versions will be shown on the sidebar
2) Users know and hopefully update their apps to resolve the connection issue
Reviewed By: jknoxville
Differential Revision: D17376199
fbshipit-source-id: 3dc7c9b0bf99ff06c11c83eff0c72b6ce12f1a5a
Summary:
- Take device id retrieved by matching CSR to the given CSR destination
- Otherwise, use the previous way
Note:
- Backward compatibility will be fixed next diff
Reviewed By: jknoxville
Differential Revision: D17346422
fbshipit-source-id: 59b2fb9849373db1ba930dde702194c5fb201678
Summary:
- Add CSR and CSR destination to request body
- (unrelated) Rearrange the list of include files
Reviewed By: jknoxville
Differential Revision: D17346429
fbshipit-source-id: ce775998884b73e82a931f4dd8986c659a892b51
Summary:
**Highlights**
- Changed to the upstream `adbkit` instead of the Facebook-specific fork of it.
- Migrate the rest of Flipper core from Flow to (strict) TypeScript.
- UI docs use the TypeScript code as basis.
Reviewed By: danielbuechele
Differential Revision: D17368399
fbshipit-source-id: 5ba92c4f0d4ca627ffac58052ef6e4d9fd07bd95
Summary: It's getting really tedious to turn these off one by one.
Reviewed By: jknoxville
Differential Revision: D17366198
fbshipit-source-id: 25443d7a18c81cd18edea21d75cfa70e4fbf4171
Summary: This got really badly mauled by a codemod I reckon.
Reviewed By: jknoxville
Differential Revision: D17366199
fbshipit-source-id: 6f1863e5e3d3ed26753723cf666b70655601a8de
Summary: Finally we are able to switch back from our adbkit-fb fork to the original `adbkit`. Replacing all imports
Reviewed By: jknoxville
Differential Revision: D17343236
fbshipit-source-id: e6dd328f1a956544e8be2ab768aa270972463c6b
Summary: Replace the custom call to ADB with using this.device.adb`.
Reviewed By: jknoxville
Differential Revision: D17343234
fbshipit-source-id: c83fe295ec2c3f994e545a93aa580f44e91291fb
Summary:
moving logic for screen recordings to the respective devices, instead of having it in the button component.
This is part of my wider effort to unify our use of adb/adbkit and upgrade to the latest version of adbkit.
Reviewed By: passy
Differential Revision: D17318702
fbshipit-source-id: cff4459047d7a197ed6cb8ee8c290b4eaab41479
Summary:
Not ideal to just assert a type based on JSON output
but better than the `ts-ignore` because complete
misuse of the functions is still caught.
Reviewed By: jknoxville
Differential Revision: D17346265
fbshipit-source-id: 52d8109a11f552b912b67b1074cb906cb2cc161b
Summary: This diff was a joy to draft.
Reviewed By: jknoxville
Differential Revision: D17344676
fbshipit-source-id: 0694d0393fa243edef61408ecfee92912fbbfa32
Summary: This will block us from landing eslint-failing tests.
Reviewed By: jknoxville
Differential Revision: D17342861
fbshipit-source-id: a42e3bc3fffe8f24420203f399fb702907069132
Summary:
Gets the rating popover to appear automatically after 30s for selected users, according to ITSR constraints.
The ITSR constraints are to stop it annoying people, such as only happening once a month, and global throttling.
Reviewed By: passy
Differential Revision: D17343435
fbshipit-source-id: c06aa10263a64249f7e2c48b8752c37e4314ac24
Summary: Dismissing the popover will stiop the user from being prompted for a while, so we only want to send this event when the user was proactively prompted in the first place - which is when we're using the eligibility check.
Reviewed By: passy
Differential Revision: D17343227
fbshipit-source-id: 95a071e34ce318fe49640c6ee9f68127957f390c
Summary:
Behind a gk.
This uses a hidden webview to check if a user is eligible for star ratings. This means you can practively ask the user, and makes sure you'll get an unbiased distribution.
Reviewed By: danielbuechele
Differential Revision: D17343118
fbshipit-source-id: fe7471416aef947ec10f4734e4136868ab5ab3e5
