Summary: This has caused a few tasks to be raised. We do replace broken configs with a fresh template elsewhere, but we shouldn't throw in this place since we have a fallback.
Reviewed By: antonk52
Differential Revision: D51393314
fbshipit-source-id: 8c04946c5b0e74f5f0d42c9492aa381aa608fd35
Summary: It is an escape hatch for testing iOS Sample app if `navigate('/')` cannot be made to work easily (D51394323)
Reviewed By: lblasa
Differential Revision: D51466697
fbshipit-source-id: fd6c2f37504807b4b634b85cb10e837523dadba8
Summary: There is too much padding on the right wether right sidebar open or not, this fixes it
Reviewed By: lblasa
Differential Revision: D51428892
fbshipit-source-id: 6fa9b0c06ddf32c32d162a7fd2bd765e8996c00a
Summary:
As mentioned on the previous diff, we no longer use a pre-built template when creating a release build.
This change moves the built binary directly into place instead of updating the existing template after which it was moved to its final destination.
Reviewed By: antonk52
Differential Revision: D51424944
fbshipit-source-id: 284fb53bb5f00f92b3ca9db3b28cfd1e4dacfa19
Summary:
So far we have used a 'template' approach, in which the release build script will copy and use to create the final deliverable.
The template itself was updated locally by running:
cd ~/fbsource/xplat/sonar/facebook/flipper-server
yarn start
This would:
- Build the MacOS app for all supported architectures: x64 and arm64
- Update the template found on the static directory
After the update, we would just commit the changes to the repo.
## About this change
Instead, build the MacOS app when the release script is used. This is leaves way less margin for error as we have removed all the manual steps that had to be done as listed above.
Reviewed By: antonk52
Differential Revision: D51397661
fbshipit-source-id: 2234c9996fa98f32db244764acf3e35dc9a388c9
Summary:
Previously we were searching the tree nodes which did not include all nodes since if a not was not expanded it isnt in the tree node list, so now we expand first then find the first tree node that matches
changelog: UIDebugger search now expands matching elements
Reviewed By: lblasa
Differential Revision: D51349213
fbshipit-source-id: 4eef436781ed6ec23187d1aec7633ee4b959d3fa
Summary:
This adds a deeplink into bloks debugger from uidebugger for state events
changelog: UIDebugger - show bloks state & deeplink to bloks debugger
Reviewed By: lblasa
Differential Revision: D51349212
fbshipit-source-id: 6f7ca826228ce11a01fe5eb197f6ce092d2757a9
Summary:
Sometimes after a while scroll bars woudl start to appear in the text areas like so
{F1150744703}
Its hard to repro but seemed to be after flipper was open for a long period. Playing with chrome dev tools setting overflow: hidden makes the problem go away
changelog: UIDebugger fix issue with scrollbars sometimes appearing in sidebar
Reviewed By: antonk52
Differential Revision: D51346366
fbshipit-source-id: 2d9218ac582164c9726a92c3c0c99567382f8929
Summary: Provides power search typings to all users by default
Reviewed By: LukeDefeo
Differential Revision: D51306600
fbshipit-source-id: c1f0d318d8b6953dd02af16d2c51abbf0e6e9590
Summary: setTimeout should terminate process if graceful termination takes too long. Before, we scheduled the timer only *after* the graceful termination completes which does not make any sense
Reviewed By: lblasa
Differential Revision: D51346673
fbshipit-source-id: b5adadbcf474a8c66839e1fc70bcc6482c47635e
Summary: This was not possible in the past because the entry points for dev and production were different. This is no longer the case.
Reviewed By: antonk52
Differential Revision: D51346250
fbshipit-source-id: fc482a9d90352ea4e897092e7670920f148fa274
Summary: This is a duplicate, is not needed, causes confusion.
Reviewed By: aigoncharov
Differential Revision: D51307091
fbshipit-source-id: 4d55d727ea5f20100ecd15ad6e23aa0c01722524
Summary: Make both prod and dev HTML entry points identical.
Reviewed By: aigoncharov
Differential Revision: D51307116
fbshipit-source-id: 5aea8e455d623aba260e3e37a2c549ebc67dd3b0
Summary: Not entirely sure what the use of this socket is, but it can definitely be defined inside flipper-ui-browser instead.
Reviewed By: aigoncharov
Differential Revision: D51307090
fbshipit-source-id: 36eb336536e8672fb0b2bcf12dad31c7fbc00a39
Summary: These logs only available on debug but we already have these logs coming from the actual used socket, so remove.
Reviewed By: aigoncharov
Differential Revision: D51307089
fbshipit-source-id: 32e3eada42fa54b429df0bfcdd936d24cebaf0cb
Summary: These two texts were different, they should be the same for consistency.
Reviewed By: aigoncharov
Differential Revision: D51307086
fbshipit-source-id: a71fb7e6cf072df73e7f9fb386245f266984900b
Summary: This CSS was unused, so remove.
Reviewed By: aigoncharov
Differential Revision: D51307093
fbshipit-source-id: a978d76fca7cfb07c96180c4ece0b1bdf1087894
Summary: Instead of having duplicate configs defined on our HTML. Move the config definition to the server.
Reviewed By: aigoncharov
Differential Revision: D51307092
fbshipit-source-id: 68f4afc918cf191b3a15b3981429c5a05d5df8df
Summary: After the move, let's rename the constants to make them match our code standards.
Reviewed By: aigoncharov
Differential Revision: D51307087
fbshipit-source-id: 4e44e956fd88abd3e8359fe94fa4e31d17f61a55
Summary: Recently we have added a few constants to be used by our main entry point. This change moves them to a central place: flipperConfig.
Reviewed By: aigoncharov
Differential Revision: D51307088
fbshipit-source-id: 09f0ef0e69e2067ce5c8501367629eeec7523858
Summary:
Since Android Studio is technically not required, I made this check optional.
Though, these steps will gurantee that android env will work for an engineer who opened flipper for the first time
Reviewed By: lblasa
Differential Revision: D51267272
fbshipit-source-id: f30e58f322ea080b00a27ae86b871df2b39e1bb9
Summary:
When flipper starts it writes to both env vars the value from settings. This is needed for subprocesses to have access to them.
The problem with the check for both env vars is
- In prod environment applications does not have access to them
- In dev, when developers launch flipper from terminal (`yarn run flipper-server`) it picks up these env vars if they are set which can cause different behaviour in dev and prod
To make flipper work more deterministic, for users and us. I removed this check and now we always write to these env vars what the user has provided in flipper settings or the default.
Reviewed By: lblasa
Differential Revision: D51266495
fbshipit-source-id: cf3adfd4ba83a733a30b5b0b29c270b32ff3a61a
Summary:
The previous logic aimed to reuse an existing server during bootstrap if the launched version was higher than the running one. This is no longer required or wanted.
## Risk assessment: LOW
### Rationale
It is extremely rare to launch Flipper whilst already having another instance running. This can happen during development, but it is extremely rare in production.
Launcher (singleton) launches Server (singleton).
Launcher can be executed multiple times and this will not create newer server instances.
If anything, if we are unable to kill any other instance, whatever that may be, continue. This is to cover the cases where a shutdown may have been acknowledged but the process is still shutting down.
Reviewed By: antonk52
Differential Revision: D51232901
fbshipit-source-id: 8b8b85f4bac68f5670b1878e827871f78dc68999
