Summary: setTimeout should terminate process if graceful termination takes too long. Before, we scheduled the timer only *after* the graceful termination completes which does not make any sense
Reviewed By: lblasa
Differential Revision: D51346673
fbshipit-source-id: b5adadbcf474a8c66839e1fc70bcc6482c47635e
Summary: This was not possible in the past because the entry points for dev and production were different. This is no longer the case.
Reviewed By: antonk52
Differential Revision: D51346250
fbshipit-source-id: fc482a9d90352ea4e897092e7670920f148fa274
Summary: This is a duplicate, is not needed, causes confusion.
Reviewed By: aigoncharov
Differential Revision: D51307091
fbshipit-source-id: 4d55d727ea5f20100ecd15ad6e23aa0c01722524
Summary: Make both prod and dev HTML entry points identical.
Reviewed By: aigoncharov
Differential Revision: D51307116
fbshipit-source-id: 5aea8e455d623aba260e3e37a2c549ebc67dd3b0
Summary: Not entirely sure what the use of this socket is, but it can definitely be defined inside flipper-ui-browser instead.
Reviewed By: aigoncharov
Differential Revision: D51307090
fbshipit-source-id: 36eb336536e8672fb0b2bcf12dad31c7fbc00a39
Summary: These logs only available on debug but we already have these logs coming from the actual used socket, so remove.
Reviewed By: aigoncharov
Differential Revision: D51307089
fbshipit-source-id: 32e3eada42fa54b429df0bfcdd936d24cebaf0cb
Summary: These two texts were different, they should be the same for consistency.
Reviewed By: aigoncharov
Differential Revision: D51307086
fbshipit-source-id: a71fb7e6cf072df73e7f9fb386245f266984900b
Summary: This CSS was unused, so remove.
Reviewed By: aigoncharov
Differential Revision: D51307093
fbshipit-source-id: a978d76fca7cfb07c96180c4ece0b1bdf1087894
Summary: Instead of having duplicate configs defined on our HTML. Move the config definition to the server.
Reviewed By: aigoncharov
Differential Revision: D51307092
fbshipit-source-id: 68f4afc918cf191b3a15b3981429c5a05d5df8df
Summary: After the move, let's rename the constants to make them match our code standards.
Reviewed By: aigoncharov
Differential Revision: D51307087
fbshipit-source-id: 4e44e956fd88abd3e8359fe94fa4e31d17f61a55
Summary: Recently we have added a few constants to be used by our main entry point. This change moves them to a central place: flipperConfig.
Reviewed By: aigoncharov
Differential Revision: D51307088
fbshipit-source-id: 09f0ef0e69e2067ce5c8501367629eeec7523858
Summary:
Since Android Studio is technically not required, I made this check optional.
Though, these steps will gurantee that android env will work for an engineer who opened flipper for the first time
Reviewed By: lblasa
Differential Revision: D51267272
fbshipit-source-id: f30e58f322ea080b00a27ae86b871df2b39e1bb9
Summary:
When flipper starts it writes to both env vars the value from settings. This is needed for subprocesses to have access to them.
The problem with the check for both env vars is
- In prod environment applications does not have access to them
- In dev, when developers launch flipper from terminal (`yarn run flipper-server`) it picks up these env vars if they are set which can cause different behaviour in dev and prod
To make flipper work more deterministic, for users and us. I removed this check and now we always write to these env vars what the user has provided in flipper settings or the default.
Reviewed By: lblasa
Differential Revision: D51266495
fbshipit-source-id: cf3adfd4ba83a733a30b5b0b29c270b32ff3a61a
Summary:
The previous logic aimed to reuse an existing server during bootstrap if the launched version was higher than the running one. This is no longer required or wanted.
## Risk assessment: LOW
### Rationale
It is extremely rare to launch Flipper whilst already having another instance running. This can happen during development, but it is extremely rare in production.
Launcher (singleton) launches Server (singleton).
Launcher can be executed multiple times and this will not create newer server instances.
If anything, if we are unable to kill any other instance, whatever that may be, continue. This is to cover the cases where a shutdown may have been acknowledged but the process is still shutting down.
Reviewed By: antonk52
Differential Revision: D51232901
fbshipit-source-id: 8b8b85f4bac68f5670b1878e827871f78dc68999
Summary:
The single value == / contains are covered by the setlike oper /ators.
Less operators is better as less overwhelming. Plus with the group operators you can add futher options or'ed togther which is a complain from the user.
Reviewed By: aigoncharov
Differential Revision: D51255253
fbshipit-source-id: 72f909319fd3d8034ebe4725a5a5254ecfeb074b
Make as manything as inferred enum as possible
changelog: [Logs] Improve power search config to populate dropdown for level, PID & Tag
Reviewed By: aigoncharov
Differential Revision: D51199644
fbshipit-source-id: 383b61abca5d91a8e318bbfb1aac7d3852074167
Summary:
Current order is confusion, the new order better reflects order at which users gets started with iOS
1. Install Xcode
2. Point Xcode-select at most recent xcode version
3. Install SDK
4. Accept Xcode SDK license
5. check idb health
Reviewed By: lblasa
Differential Revision: D51202202
fbshipit-source-id: da39acf7ef325889c2288b3941cef0ca803356cd
Summary: All functionality was about selecting plugins
Reviewed By: lblasa
Differential Revision: D51200129
fbshipit-source-id: edc33c2b989eabec2ca4a7e285f92c50950977ed
Summary: Error thrown from server is serialiased that is a string, not instance of Error
Reviewed By: LukeDefeo
Differential Revision: D51201870
fbshipit-source-id: 833818789a50a21d3d27e0388635e0e2b7470c9d
Summary:
As I was setting up a new mac I had to change this setting in flipper settings.
From a few android people that I've spoken to no one could answer me if the old one is still used.
Ideally we should infer this during the first time flipper starts
- `/opt/android_sdk` current default
- `$HOME/Library/Android/sdk` adb from Android Studio
- `$HOME/fbsource/third-party/toolchains/android-sdk` adb that is always available in fbsource
Reviewed By: lblasa
Differential Revision: D51120929
fbshipit-source-id: edb2a58b9c9f37465ea2fc5493975dd427d5523b
Summary:
Auth token used be injected in the manifest file. Instead, have the server injected into the main HTML page.
The main driver to this change are:
- Simplify
- There are instances in which for some reason reading/writing the token from the manifest fails. This will address that problem.
Reviewed By: lblasa
Differential Revision: D51160521
fbshipit-source-id: 4626fd8f56bc8b61182a53a5d9cf5acad1e723bc
Summary: It is quite cumbersome to list all of the operators. Much simpler to use a predefined set of power search operators we set up for each specific filed type
Reviewed By: lblasa
Differential Revision: D51116029
fbshipit-source-id: 5dd0b7f4176097109666107dfc3cab996379b818
Summary:
It does not make too much sense to keep the unknown value conversion behind a flag. It is relatively cheap. Let's do it for all strings.
Also, let's extend the list of default string operators
Reviewed By: lblasa
Differential Revision: D51115573
fbshipit-source-id: a62c08a90d8ddf6f23f59412c3fd981e19225e47
