Summary:
Android publishing job fails to attach APKs to the release. An OSS user (rasaha91) came up with a fix. Since passy is on a leave, I've made my own fork to get unblocked.
See https://github.com/aigoncharov/github-upload-release-artifacts-action
Reviewed By: lblasa
Differential Revision: D40378208
fbshipit-source-id: 35e8f41700972751b63014e35696e61cfe986eae
Summary:
This includes a bunch of different things which I wanted to do separately, but it's all a massive Jenga Tower and you cannot remove a single piece.
- Litho upgrade
- Gradle plugin upgrade
- Remove storage permission as it apparently doesn't do anything above Android 10
- Upgraded build target to Android 12 because the new support lib/Kotlin stdlib required this which then caused the issue below to pop up
- Added "export=true" everywhere as this is now a blocking issue if you don't have it
- Upgraded to the LeakCanary2 plugin as version one no longer builds with an Android 12 target for the export reason
- Make CI run on JRE 11 because that's required by the new Gradle plugin
- Update internal CI to no longer define the SDK twice and use Java 11
Pull Request resolved: https://github.com/facebook/flipper/pull/3095
Test Plan: Built Android Sample and Tutorial app, connected to Flipper.
Reviewed By: lblasa
Differential Revision: D32644410
Pulled By: passy
fbshipit-source-id: 8978f158d9c642b3bbd9dbbd7321eb20098a7a53
Summary:
This one is actually fine. We don't do the upload/download dance,
so the file exists in the place we expect it to.
We can see in this run that the current path actually works:
https://github.com/facebook/flipper/runs/4316082427?check_suite_focus=true
Reviewed By: nikoant
Differential Revision: D32652626
fbshipit-source-id: ca9c52d2c3016fe2ec300d1f4fd875b9f3301e3b
Summary:
I can run the same commands locally and everything is fine but in CI, it creates two separate staging repositories.
Maybe this will shed some light.
Pull Request resolved: https://github.com/facebook/flipper/pull/3100
Reviewed By: nikoant
Differential Revision: D32651863
Pulled By: passy
fbshipit-source-id: 30441b29ab6a4270dee1c958e19242f71265a174
Summary:
I've been investigating the now persistent upload issue for our artifacts and it appears to come down to artifacts being uploaded and downloaded as folder structures while they used to be individual files.
Annoyingly, the `ghr` tool we use for uploading throws a cryptic and misleading error: https://github.com/facebook/flipper/runs/4314584032?check_suite_focus=true
There is some more control in the `v2` version of the actions but for now, this seems like the safer option to fix this problem.
{F682461661}
Reviewed By: lblasa
Differential Revision: D32649218
fbshipit-source-id: 47ebefc434cb3b928b82a9fe8da3002b7b8465b6
Summary:
Fixed an issue with the setup of the retry script:
31ee58a796
Reviewed By: nikoant
Differential Revision: D32644463
fbshipit-source-id: 23ac1508784f24e9403e0bca0091f05847a9e91d
Summary:
We're seeing some spurious failures, unrelated to any changes on our end.
I've upgraded the action to do two things:
- Retry on failure (up to three times): b0dfcdf1c7
- Replace the artefact if it's already present (otherwise this might fail subsequent retries): 92bec0ba48
Pull Request resolved: https://github.com/facebook/flipper/pull/3070
Reviewed By: nikoant
Differential Revision: D32532277
Pulled By: passy
fbshipit-source-id: f1899c89c405772490958674fa7f46f479c666f9
Summary: I upgraded the docker image which should pull the latest GHR release (https://github.com/tcnksm/ghr).
Reviewed By: lblasa
Differential Revision: D31442256
fbshipit-source-id: 0f9fa81ec1be1285aea3da621b7ef5a1e63c3e84
Summary:
Because the publish runs aren't triggered on the main branch, we have limited visibility. Sending push notifications, webhooks or email integrations are hard, but opening an issue seems like a decent work-around for this.
We can broaden this to more publish actions as needed.
Pull Request resolved: https://github.com/facebook/flipper/pull/2904
Test Plan: Ran on my fork which generated this issue: https://github.com/passy/flipper/issues/9
Reviewed By: mweststrate
Differential Revision: D31146956
Pulled By: passy
fbshipit-source-id: 08f66bd4c96a5ea2cc5e70a7461c30e7e1f3d42e
Summary:
I've been really sweating about this one. It looks like Google now removed NDK 21 as it's too old. However, we've been struggling with the upgrade because OpenSSL was built against an old version of the NDK/glibc/LLVM/some other stuff.
I've now managed to create an OpenSSL distribution for 1.1.1k (we had 1.1.0h before) that seems to build with this after some small modifications.
This seems to do the trick, but I wouldn't be shocked if we found some more incompatibilities further down the line.
Pull Request resolved: https://github.com/facebook/flipper/pull/2836
Test Plan:
- Locally: `./gradlew :tutorial:installDebug`. Builds, starts up. Cool.
- Public GitHub CI: Happy.
- Circle CI: Only triggers post-land. We'll see. But the setup is simple, so hopefully it should work there, too.
- Internal CI: Waiting for signal.
Reviewed By: fabiomassimo
Differential Revision: D30839209
Pulled By: passy
fbshipit-source-id: efe599f28cc0edfdf2149f905c3483555239edc0
Summary:
From the changelog:
> Removed the deprecated uploadArchives and installArchives tasks. Use publish and publishToMavenLocal instead.
Made the necessary changes to docs and scripts.
Reviewed By: nikoant
Differential Revision: D29752895
fbshipit-source-id: 6e96c7ea9b26be2acb40b9089cb361837ab10a1b
Summary:
Builds up a file with checksums of all `build.gradle` files. Deliberately excludes the `gradle.properties` which changes all the time. The cache shouldn't require nuking except in some rare circumstances.
Pull Request resolved: https://github.com/facebook/flipper/pull/1922
Test Plan: From 41 minutes down to 17: https://github.com/passy/flipper-1/actions/runs/561501374
Reviewed By: mweststrate
Differential Revision: D26427242
Pulled By: passy
fbshipit-source-id: ff1d7370d477c9d7b57c62082ec985108a5ba698
