Summary: The inpage editor is now enabled on flipper sites {emoji:1f973}{emoji:1f973}.
Reviewed By: jknoxville
Differential Revision: D29694782
fbshipit-source-id: 7683892adfd54c2ec6644b1a0ead45124692cf8e
Summary: If no device/client was selected, no plugins would show up in the plugin status list either, which is very confusing. Changed this to always show all loaded plugins, regardless of selected device / app.
Reviewed By: nikoant
Differential Revision: D29661006
fbshipit-source-id: 720a1697df7ed17b00d5db5a72a8e2b6bb344b1e
Summary:
Change iOS to Objective C, reference which file is being updated
- Clarifies how to update iOS if using objective C for flipper network plugin
## Changelog
- renamed iOS to ObjC for flipper network plugin setup
- specified which iOS file to modify for flipper network plugin setup
Pull Request resolved: https://github.com/facebook/flipper/pull/2595
Test Plan:
Imported from GitHub, without a `Test Plan:` line.
|[Site Preview: flipper](https://our.intern.facebook.com/intern/staticdocs/eph/D29662605/V2/flipper/)
Reviewed By: passy
Differential Revision: D29662605
Pulled By: nikoant
fbshipit-source-id: acdc8bba73900c19500fc91f8a275930c51d73ad
Summary:
During component cleanup broke the error handling :'). Causing plugin errors to bubble up and be handled as chrome errors instead. This caused our soft crash metric to spike in the last week.
Changelog: Fixed error handling of UI errors caused by plugins
Reviewed By: passy
Differential Revision: D29585448
fbshipit-source-id: 4c5d40b300a7b71eeb532f7be4765f742d239890
Summary:
It was requested a few times to inline simple values in the preview, to be able to quickly inspect vectors etc while inspecting elements
Implements https://github.com/facebook/flipper/issues/2551
Reviewed By: passy
Differential Revision: D29555541
fbshipit-source-id: c2c171cd7d2bf213f0cd05b5b5723918c9536025
Summary:
Fix selection problem on ManageMockResponsePanel. Currently, when the user adds new routes, the detail section continues to show the detail for the first route. Select different routes in the list does not change the detail panel. The screen is currently not doing anything on selection.
Also fixed a problem with updating on mock header names and values. Updates were not persisting if user did not exist input fields before leaving header input panel.
## Changelog
Network Plugin - Fix selection problem on ManageMockResponsePanel
Pull Request resolved: https://github.com/facebook/flipper/pull/2574
Test Plan:
Add multiple mock routes
Select various routes
Verify that detail panel shows the selected route
Reviewed By: passy
Differential Revision: D29582286
Pulled By: mweststrate
fbshipit-source-id: 6690e2262a033cdfa5afa6e6fdfacc9694244590
Summary: Found some errors in a CI failure originating from a JavaScript file. The horror!
Reviewed By: jknoxville
Differential Revision: D29549998
fbshipit-source-id: 633100ec9a446050bb0c703dcc37e9b132b17198
Summary: Apply local storage setting at a few relevant places, see parent diff
Reviewed By: cekkaewnumchai
Differential Revision: D29516498
fbshipit-source-id: 4797986e3540217e42dfb867f7d627921b97618e
Summary:
Bumps [babel-jest](https://github.com/facebook/jest/tree/HEAD/packages/babel-jest) from 27.0.2 to 27.0.5.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/facebook/jest/releases">babel-jest's releases</a>.</em></p>
<blockquote>
<h2>27.0.5</h2>
<h3>Features</h3>
<ul>
<li><code>[jest/fake-timers]</code> Flush callbacks scheduled with <code>requestAnimationFrame</code> every 16ms when using legacy timers. (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11567">#11523</a>)</li>
<li><code>[pretty-format]</code> Use <code>globalThis</code> (with polyfill if required) to bring support for esbuild's browser bundling mode (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11569">#11569</a></li>
</ul>
<h3>Fixes</h3>
<ul>
<li><code>[jest-core]</code> Support special characters like <code>@</code>, <code>+</code> and <code>()</code> on Windows with <code>--findRelatedTests</code> (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11548">#11548</a>)</li>
<li><code>[jest/fake-timers]</code> Do not add <code>setImmediate</code> and <code>clearImmediate</code> if they do not exist in the global environment (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11599">#11599</a>)</li>
<li><code>[jest/reporters]</code> Allow <code>node-notifier@10</code> as peer dependency (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11523">#11523</a>)</li>
<li><code>[jest/reporters]</code> Update <code>v8-to-istanbul</code> (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11523">#11523</a>)</li>
</ul>
<h2>27.0.4</h2>
<h3>Fixes</h3>
<ul>
<li><code>[jest-config, jest-resolve]</code> Pass in <code>require.resolve</code> to resolvers to resolve from correct base (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11493">#11493</a>)</li>
</ul>
<h2>27.0.3</h2>
<h3>Fixes</h3>
<ul>
<li><code>[jest-config]</code> <code>require.resolve</code> on default test sequencer and test environment (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11482">#11482</a>)</li>
<li><code>[jest-mock]</code> Fixed <code>fn</code> and <code>spyOn</code> exports (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11480">#11480</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/facebook/jest/blob/master/CHANGELOG.md">babel-jest's changelog</a>.</em></p>
<blockquote>
<h2>27.0.5</h2>
<h3>Features</h3>
<ul>
<li><code>[jest/fake-timers]</code> Flush callbacks scheduled with <code>requestAnimationFrame</code> every 16ms when using legacy timers. (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11567">#11523</a>)</li>
<li><code>[pretty-format]</code> Use <code>globalThis</code> (with polyfill if required) to bring support for esbuild's browser bundling mode (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11569">#11569</a></li>
</ul>
<h3>Fixes</h3>
<ul>
<li><code>[jest-core]</code> Support special characters like <code>@</code>, <code>+</code> and <code>()</code> on Windows with <code>--findRelatedTests</code> (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11548">#11548</a>)</li>
<li><code>[jest/fake-timers]</code> Do not add <code>setImmediate</code> and <code>clearImmediate</code> if they do not exist in the global environment (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11599">#11599</a>)</li>
<li><code>[jest/reporters]</code> Allow <code>node-notifier@10</code> as peer dependency (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11523">#11523</a>)</li>
<li><code>[jest/reporters]</code> Update <code>v8-to-istanbul</code> (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11523">#11523</a>)</li>
</ul>
<h2>27.0.4</h2>
<h3>Fixes</h3>
<ul>
<li><code>[jest-config, jest-resolve]</code> Pass in <code>require.resolve</code> to resolvers to resolve from correct base (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11493">#11493</a>)</li>
</ul>
<h2>27.0.3</h2>
<h3>Fixes</h3>
<ul>
<li><code>[jest-config]</code> <code>require.resolve</code> on default test sequencer and test environment (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11482">#11482</a>)</li>
<li><code>[jest-mock]</code> Fixed <code>fn</code> and <code>spyOn</code> exports (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11480">#11480</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="dafa4737dc"><code>dafa473</code></a> v27.0.5</li>
<li>See full diff in <a href="https://github.com/facebook/jest/commits/v27.0.5/packages/babel-jest">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/2522
Reviewed By: priteshrnandgaonkar
Differential Revision: D29490752
Pulled By: passy
fbshipit-source-id: a71cafb4d9a4400205fe8ba84223e076943eea4c
Summary:
Going through all the patch updates and other small updates to pre-empt dependabot.
allow-large-files
Reviewed By: jknoxville
Differential Revision: D29547777
fbshipit-source-id: 86ef2408da0564049916cd96d66665074cdc23f2
Summary: Remove the duplicate function and centralise it as nikoant suggested.
Reviewed By: fabiomassimo
Differential Revision: D29548480
fbshipit-source-id: 3e931cc88198415017c557c6b7c81cb35c3f22c9
Summary: This makes it possible to save source maps to a separate folder so we can upload them from CI.
Reviewed By: nikoant
Differential Revision: D29521599
fbshipit-source-id: a137659092b7648858b97ecf5b5c60c88889517a
Summary: Dependabot complaining that the package is vulnerable so I pinned it to the latest minor/parch versions for all three packages depending on it.
Reviewed By: passy
Differential Revision: D29519029
fbshipit-source-id: 3f3476e8fc61c74f533da4038633dd23bea6d682
Summary:
Per title.
Feature will be used in several plugins in next diffs.
Differential Revision: D29514456
fbshipit-source-id: c12427c2a7c53fa01cd1c7f429be8611be55496d
Summary: ReactNativeFlipperExample crashed as soon as a running app tried to connect to the Metro instance, which turns out to be caused by a pinned `ws`. Luckily someone else experienced this before, would have taken a while otherwise :-P, as the error is not logged in Metro, and on Flipper side we just receive a super generic error message https://github.com/facebook/metro/issues/678#issuecomment-865835602
Reviewed By: nikoant
Differential Revision: D29515730
fbshipit-source-id: 2524f85338c9b93d8bcf31b1db150c3c8e664500
Summary:
OpenSSL-Univeral cause app to crash with `rpath/OpenSSL.framework/OpenSSL' not found` when [debugger is not attached] (https://github.com/krzyzanowskim/OpenSSL/issues/115). Looks like this was caused by arm64e slice and it's now resolved in version 1.1.1000
It also updates the folly version to the latest checkout and solves this task T94605859. According to this task it has been asked by folly team to update its dependency to the latest version.
## Changelog
Bump OpenSSL-Universal to version 1.1.1000
Use latest folly checkout v2021.06.14.00
Pull Request resolved: https://github.com/facebook/flipper/pull/2515
Test Plan: There are no code changes, this only removes problematic arm64 slice from OpenSSL-Universal xcframework.
Reviewed By: nikoant
Differential Revision: D29489739
Pulled By: priteshrnandgaonkar
fbshipit-source-id: cd54eccddb9fb87c9e0e25c3b2cedbdb74408f92
Summary:
Fixed bug with "Hermes Debugger" and "React Dev Tools" plugin loading reported on GitHub: https://github.com/facebook/flipper/issues/2545.
Changelog: Fixed bug with React Native plugins not loaded: Hermes Debugger, React Dev Tools etc.
Reviewed By: mweststrate
Differential Revision: D29516394
fbshipit-source-id: 4620e3d2b49ca2a1d3a5b2dd76d40d4667a0980b
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/2544
Test Plan:
Imported from GitHub, without a `Test Plan:` line.
|[Site Preview: flipper](https://our.intern.facebook.com/intern/staticdocs/eph/D29499361/V2/flipper/)
Reviewed By: priteshrnandgaonkar
Differential Revision: D29499361
Pulled By: nikoant
fbshipit-source-id: 8052bdfd86c55cfe890849ba31a6f7020b45f298
Summary: We don't need to re-publish plugin package when only docs are changed, so excluding "docs" from checksum computation
Differential Revision: D29508239
fbshipit-source-id: dfae89432f68b784caf07ae24ba7711f76c649b4
Summary:
Changelog: Flipper message debugging moved from a separate device to the console tab
This makes message debugging easier accessible, and in production (recently requested at GH). Also it clears up a lot of infra that was created just to make flipper a self recursive inspection device + a separate plugin. While fun, a hardcoded setup is just a bit more simpler (no exception rules and better static verification)
Reviewed By: nikoant
Differential Revision: D29487811
fbshipit-source-id: b412adc3ef5bd831001333443b432b6c0f934a5e
Summary:
Changelog: Add support for negative filters in data tables
As requested per somewhere on workplace but couldn't find it back :)
Reviewed By: nikoant
Differential Revision: D29486096
fbshipit-source-id: 467c8598f6d09afc9a5ed85affb6c51840afe00c
Summary: Removing old components that are no longer used, and cleaning up index.tsx to prevent future for some of those
Reviewed By: nikoant
Differential Revision: D29428621
fbshipit-source-id: 78ae51c09510738cf2d75982fdae35b9ef6d2d7e
Summary: Fury was the last user of this component
Reviewed By: nikoant
Differential Revision: D29426804
fbshipit-source-id: 793135119e70b41eda0391d3fedee1c9b6834cbd
Summary:
This removes all code duplication / old plugin infra that isn't needed anymore when all plugin run on the Sandy plugin infra structure.
The diff is quite large, but the minimal one that passes tests and compiles. Existing tests are preserved by wrapping all remaining tests in `wrapSandy` for classic plugins where needed
Reviewed By: passy
Differential Revision: D29394738
fbshipit-source-id: 1315fabd9f048576aed15ed5f1cb6414d5fdbd40
Summary:
Since the Sandy wrapper is now rolled out to 100%, removing the GK. Further code cleanup in next diffs.
Changelog: Flipper that don't use the new Sandy plugin format yet (see https://fbflipper.com/docs/extending/sandy-migration) will now always be loaded inside a legacy container
Reviewed By: timur-valiev
Differential Revision: D29394736
fbshipit-source-id: f7a7c321c6b6a82470d47e4352d86135c3849b82
Summary:
Bumps [jest](https://github.com/facebook/jest) from 27.0.4 to 27.0.6.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/facebook/jest/releases">jest's releases</a>.</em></p>
<blockquote>
<h2>27.0.6</h2>
<h3>Fixes</h3>
<ul>
<li><code>[*]</code> Publish all modules to include the build change in <a href="https://github-redirect.dependabot.com/facebook/jest/pull/11569">#11569</a></li>
</ul>
<h2>27.0.5</h2>
<h3>Features</h3>
<ul>
<li><code>[jest/fake-timers]</code> Flush callbacks scheduled with <code>requestAnimationFrame</code> every 16ms when using legacy timers. (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11567">#11523</a>)</li>
<li><code>[pretty-format]</code> Use <code>globalThis</code> (with polyfill if required) to bring support for esbuild's browser bundling mode (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11569">#11569</a></li>
</ul>
<h3>Fixes</h3>
<ul>
<li><code>[jest-core]</code> Support special characters like <code>@</code>, <code>+</code> and <code>()</code> on Windows with <code>--findRelatedTests</code> (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11548">#11548</a>)</li>
<li><code>[jest/fake-timers]</code> Do not add <code>setImmediate</code> and <code>clearImmediate</code> if they do not exist in the global environment (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11599">#11599</a>)</li>
<li><code>[jest/reporters]</code> Allow <code>node-notifier@10</code> as peer dependency (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11523">#11523</a>)</li>
<li><code>[jest/reporters]</code> Update <code>v8-to-istanbul</code> (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11523">#11523</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/facebook/jest/blob/master/CHANGELOG.md">jest's changelog</a>.</em></p>
<blockquote>
<h2>27.0.6</h2>
<h3>Fixes</h3>
<ul>
<li><code>[*]</code> Publish all modules to include the build change in <a href="https://github-redirect.dependabot.com/facebook/jest/pull/11569">#11569</a></li>
</ul>
<h2>27.0.5</h2>
<h3>Features</h3>
<ul>
<li><code>[jest/fake-timers]</code> Flush callbacks scheduled with <code>requestAnimationFrame</code> every 16ms when using legacy timers. (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11567">#11523</a>)</li>
<li><code>[pretty-format]</code> Use <code>globalThis</code> (with polyfill if required) to bring support for esbuild's browser bundling mode (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11569">#11569</a>)</li>
</ul>
<h3>Fixes</h3>
<ul>
<li><code>[jest-core]</code> Support special characters like <code>@</code>, <code>+</code> and <code>()</code> on Windows with <code>--findRelatedTests</code> (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11548">#11548</a>)</li>
<li><code>[jest/fake-timers]</code> Do not add <code>setImmediate</code> and <code>clearImmediate</code> if they do not exist in the global environment (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11599">#11599</a>)</li>
<li><code>[jest/reporters]</code> Allow <code>node-notifier@10</code> as peer dependency (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11523">#11523</a>)</li>
<li><code>[jest/reporters]</code> Update <code>v8-to-istanbul</code> (<a href="https://github-redirect.dependabot.com/facebook/jest/pull/11523">#11523</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="d257d1c44b"><code>d257d1c</code></a> v27.0.6</li>
<li><a href="48cda778b2"><code>48cda77</code></a> chore: update lockfile after publish</li>
<li><a href="dafa4737dc"><code>dafa473</code></a> v27.0.5</li>
<li><a href="83a7ca3def"><code>83a7ca3</code></a> chore: update changelog for release</li>
<li><a href="6373529888"><code>6373529</code></a> fix(legacy-timers): Do not add <code>setImmediate</code> and <code>clearImmediate</code> if they do...</li>
<li><a href="e5f9f2197b"><code>e5f9f21</code></a> chore(docs): run prettier</li>
<li><a href="6826764078"><code>6826764</code></a> chore(docs): correct generated mock example</li>
<li><a href="6308b6c8e4"><code>6308b6c</code></a> Fix docs: Update MockFunctions.md (<a href="https://github-redirect.dependabot.com/facebook/jest/issues/11556">#11556</a>)</li>
<li><a href="0a210dc434"><code>0a210dc</code></a> docs: enable syntax highlighting to a code block (<a href="https://github-redirect.dependabot.com/facebook/jest/issues/11594">#11594</a>)</li>
<li><a href="7be63ef9a2"><code>7be63ef</code></a> Use <code>globalThis</code> (with fallback if needed) instead of <code>global</code> to enable esbu...</li>
<li>Additional commits viewable in <a href="https://github.com/facebook/jest/compare/v27.0.4...v27.0.6">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/2536
Reviewed By: priteshrnandgaonkar
Differential Revision: D29489931
Pulled By: passy
fbshipit-source-id: cbd242764b3a5db721182aff181148c3614b8ecb
Summary:
This PR splits the linting of the flipperkit pods into different subspecs. This will fasten the overall validation time. Before, all the pods were validated in a serialised fashion, but now its done in a parallel way.
This brings down the total validation time from 2+ hrs to ~ 25mins
## Changelog
- Split the validation of the FlipperKit pod into parallelised subspecs
Pull Request resolved: https://github.com/facebook/flipper/pull/2540
Test Plan: https://github.com/facebook/flipper/actions/runs/986790548
Reviewed By: passy
Differential Revision: D29489716
Pulled By: priteshrnandgaonkar
fbshipit-source-id: 55557c581d56ee01796ca64405cf78b647d2a68b
Summary:
Github build is currently broken, so I'm removing this for now while I'm looking for the proper fix.
Failed job: https://github.com/facebook/flipper/runs/2947749418
Reviewed By: priteshrnandgaonkar
Differential Revision: D29491530
fbshipit-source-id: a2430033e18d3883adf2617beb0c60a67db5e183
Summary: Just some documentation on documenting plugins
Reviewed By: jknoxville
Differential Revision: D29488048
fbshipit-source-id: 1fef3d66894e7e2659043c02c82dab71963ecbff
Summary:
This PR adds a script to publish pods. It handles different edge cases like:
- The version was already pushed but still you are trying to push it, it will skip in that case and give a proper message.
- This also makes sure that the same version Flipper pod exists before pushing FlipperKit.
- It also has the retry mechanism in place if at all the pod trunk push fails to push.
## Changelog
Updated the workflow to push pods
Pull Request resolved: https://github.com/facebook/flipper/pull/2511
Test Plan:
While pushing already published release:
https://github.com/facebook/flipper/actions/runs/974346766
While pushing new release:
https://github.com/facebook/flipper/actions/runs/978707041
Reviewed By: passy
Differential Revision: D29415078
Pulled By: priteshrnandgaonkar
fbshipit-source-id: f0fb68a2e399802e5719d7be4216d4a5ed6ef782
