Summary:
Original commit changeset: 9d09d9660dfa
This breaks the build on GitHub.
Original Phabricator Diff: D49772851
Reviewed By: antonk52
Differential Revision: D49829328
fbshipit-source-id: 88f4a29abe148b1427ed9af5bd8b6d0c14066343
Summary:
If no version information is obtained, check if port is in use.
This is for the cases in which an older server which may not have implemented this endpoint fails to return version information.
In this case, send the shutdown command.
Reviewed By: antonk52
Differential Revision: D49830759
fbshipit-source-id: 6c9763d01f335ecc8a28df3b90d319f98016c2da
Summary: Currently, we are not interested in these errors. Let's add some logging as a way of knowing if they take place and why.
Reviewed By: antonk52
Differential Revision: D49828378
fbshipit-source-id: f741a45e1ba9892aa54dca85f97bcc419e0b5e25
Summary: Some columns set title to an empty string
Reviewed By: lblasa
Differential Revision: D49826852
fbshipit-source-id: 3661394323dade813295420a1186d9297a8be153
Summary: We treat every column without the power search config as if it contains strings. Sometimes that might bite us, for instance, when the column contains an object.
Reviewed By: lblasa
Differential Revision: D49822511
fbshipit-source-id: 18dadb5abe624fae510663fc26668b2b594899c3
Summary: Not in use in this diff, but it will be for next diffs.
Reviewed By: antonk52
Differential Revision: D49823258
fbshipit-source-id: 364414d7c37a14c6a166b33b9229e6f874f7f146
Summary: Show an unsupported modal for Electron builds (FB employees only)
Reviewed By: antonk52
Differential Revision: D49770083
fbshipit-source-id: 3616dce3206e976f2fdccd834b2c57748f19fcb0
Summary: No need to check for updates on Electron builds.
Reviewed By: antonk52
Differential Revision: D49821903
fbshipit-source-id: d836e4254bbe793921bb4a627220fee961c1c402
Summary: For the last stable Electron version, do not delegate to Launcher.
Reviewed By: antonk52
Differential Revision: D49821835
fbshipit-source-id: 0a80627cd1da312447b7d98d0351aa8faf2bae89
Summary:
Bumps [clap](https://github.com/clap-rs/clap) from 3.2.25 to 4.4.5.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/clap-rs/clap/releases">clap's releases</a>.</em></p>
<blockquote>
<h2>v4.4.5</h2>
<h2>[4.4.5] - 2023-09-25</h2>
<h3>Fixes</h3>
<ul>
<li><em>(parser)</em> When inferring subcommand <code>name</code> or <code>long_flag</code>, allow ambiguous-looking matches that unambiguously map back to the same command</li>
<li><em>(parser)</em> When inferring subcommand <code>long_flag</code>, don't panic</li>
<li><em>(assert)</em> Clarify what action is causing a positional that doesn't set values which is especially useful for derive users</li>
</ul>
<h2>v4.4.4</h2>
<h2>[4.4.4] - 2023-09-18</h2>
<h3>Internal</h3>
<ul>
<li>Update <code>terminal_size</code> to 0.3</li>
</ul>
<h2>v4.4.3</h2>
<h2>[4.4.3] - 2023-09-12</h2>
<h3>Documentation</h3>
<ul>
<li><em>(derive)</em> Clarify use of attributes within the tutorial</li>
<li>Split sections in the builder and derive tutorials into separate modules</li>
</ul>
<h2>v4.4.2</h2>
<h2>[4.4.2] - 2023-08-31</h2>
<h3>Performance</h3>
<ul>
<li>Improve build times by removing <code>once_cell</code> dependency</li>
</ul>
<h2>v4.4.1</h2>
<h2>[4.4.1] - 2023-08-28</h2>
<h3>Features</h3>
<ul>
<li>Stabilize <code>Command::styles</code></li>
</ul>
<h2>v4.3.24</h2>
<h2>[4.3.24] - 2023-08-23</h2>
<h3>Fixes</h3>
<ul>
<li>Ensure column padding is preserved in <code>--help</code> with custom templates</li>
</ul>
<h2>v4.3.23</h2>
<h2>[4.3.23] - 2023-08-18</h2>
<h3>Fixes</h3>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/clap-rs/clap/blob/master/CHANGELOG.md">clap's changelog</a>.</em></p>
<blockquote>
<h2>[4.4.5] - 2023-09-25</h2>
<h3>Fixes</h3>
<ul>
<li><em>(parser)</em> When inferring subcommand <code>name</code> or <code>long_flag</code>, allow ambiguous-looking matches that unambiguously map back to the same command</li>
<li><em>(parser)</em> When inferring subcommand <code>long_flag</code>, don't panic</li>
<li><em>(assert)</em> Clarify what action is causing a positional that doesn't set values which is especially useful for derive users</li>
</ul>
<h2>[4.4.4] - 2023-09-18</h2>
<h3>Internal</h3>
<ul>
<li>Update <code>terminal_size</code> to 0.3</li>
</ul>
<h2>[4.4.3] - 2023-09-12</h2>
<h3>Documentation</h3>
<ul>
<li><em>(derive)</em> Clarify use of attributes within the tutorial</li>
<li>Split sections in the builder and derive tutorials into separate modules</li>
</ul>
<h2>[4.4.2] - 2023-08-31</h2>
<h3>Performance</h3>
<ul>
<li>Improve build times by removing <code>once_cell</code> dependency</li>
</ul>
<h2>[4.4.1] - 2023-08-28</h2>
<h3>Features</h3>
<ul>
<li>Stabilize <code>Command::styles</code></li>
</ul>
<h2>[4.4.0] - 2023-08-24</h2>
<h3>Compatibility</h3>
<ul>
<li>Update MSRV to 1.70.0</li>
</ul>
<h2>[4.3.24] - 2023-08-23</h2>
<h3>Fixes</h3>
<ul>
<li>Ensure column padding is preserved in <code>--help</code> with custom templates</li>
</ul>
<h2>[4.3.23] - 2023-08-18</h2>
<h3>Fixes</h3>
<ul>
<li>Fixed <code>UnknownArgumentValueParser</code> to not error on flag's absence</li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="c298f6a52c"><code>c298f6a</code></a> chore: Release</li>
<li><a href="463d6c52af"><code>463d6c5</code></a> docs: Update changelog</li>
<li><a href="3ac44040ef"><code>3ac4404</code></a> Merge pull request <a href="https://redirect.github.com/clap-rs/clap/issues/5025">https://github.com/facebook/flipper/issues/5025</a> from SUPERCILEX/resolve-alias-conflicts</li>
<li><a href="a76789eb8b"><code>a76789e</code></a> fix: Make long subcommand flag inference consistent</li>
<li><a href="c2b8ec3bd3"><code>c2b8ec3</code></a> fix: Resolve conflicting name inference if from aliases</li>
<li><a href="e5c6993cca"><code>e5c6993</code></a> test: Long flags inference</li>
<li><a href="0d9b14fa6e"><code>0d9b14f</code></a> Merge pull request <a href="https://redirect.github.com/clap-rs/clap/issues/5136">https://github.com/facebook/flipper/issues/5136</a> from epage/panic</li>
<li><a href="221177b9cb"><code>221177b</code></a> fix(assert): Call out the action in positional assert</li>
<li><a href="cb2d2bcf07"><code>cb2d2bc</code></a> chore: Update from '_rust/main'</li>
<li><a href="4173c8f476"><code>4173c8f</code></a> chore(ci): Don't set patch for MSRV</li>
<li>Additional commits viewable in <a href="https://github.com/clap-rs/clap/compare/v3.2.25...v4.4.5">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/5180
Reviewed By: lawrencelomax
Differential Revision: D49772851
Pulled By: passy
fbshipit-source-id: 9d09d9660dfac85a5246817e412eba164c34f81d
Summary:
the glyph isnt working and need to get it fixed asap
changelog: UIDebugger fix icon for litho event timeline tab
Reviewed By: ivanmisuno
Differential Revision: D49780805
fbshipit-source-id: 832746237a43552171cd8e0bd3063318159279dd
Summary:
^
Currently, it is a duplicate of the ui-debugger documentation image. The idea is creating this asset, for which we can obtain a URL, which can then be freely updated as we see fit.
Reviewed By: passy
Differential Revision: D49770514
fbshipit-source-id: 77a891c92e6aa803ad08a9b909ffd23d6a61c5a0
Summary:
The run through indexes could be cut off when they were elements that touched the left edge of the screen.
If label was complete obscured when it was on the top left
Also index 0 was missing
changelog: UIDebugger: improvements to iOS Accessibility mode
Reviewed By: zats
Differential Revision: D49704398
fbshipit-source-id: cb069857a9175f2c1a8157f41fe6d83fb96f795d
Summary:
This is an automated PR to update the Podfile.lock.
- Make sure that the Podfile.lock contains latest FlipperKit and Flipper pod versions.
- Also make sure that all the dependencies are updated to the latest one.
- This is auto-generated by [create-pull-request](https://github.com/peter-evans/create-pull-request)
Pull Request resolved: https://github.com/facebook/flipper/pull/5179
Reviewed By: lblasa
Differential Revision: D49641870
Pulled By: passy
fbshipit-source-id: 2b5ce1a42cac07d5cdc454a411ebea851d63bba8
Summary:
Bumps [serde_json](https://github.com/serde-rs/json) from 1.0.106 to 1.0.107.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/serde-rs/json/releases">serde_json's releases</a>.</em></p>
<blockquote>
<h2>v1.0.107</h2>
<ul>
<li>impl IntoDeserializer for &RawValue (<a href="https://redirect.github.com/serde-rs/json/issues/1071">https://github.com/facebook/flipper/issues/1071</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="b6e113f203"><code>b6e113f</code></a> Release 1.0.107</li>
<li><a href="00626a0a95"><code>00626a0</code></a> Merge pull request <a href="https://redirect.github.com/serde-rs/json/issues/1073">https://github.com/facebook/flipper/issues/1073</a> from dtolnay/rawvalue</li>
<li><a href="b9d296f87d"><code>b9d296f</code></a> IntoDeserializer for &RawValue</li>
<li><a href="4ea34a2566"><code>4ea34a2</code></a> Merge pull request <a href="https://redirect.github.com/serde-rs/json/issues/1072">https://github.com/facebook/flipper/issues/1072</a> from dtolnay/rawvalue</li>
<li><a href="fe30766ae5"><code>fe30766</code></a> Support deserializing from &RawValue</li>
<li><a href="2c22077f0e"><code>2c22077</code></a> Merge pull request <a href="https://redirect.github.com/serde-rs/json/issues/1062">https://github.com/facebook/flipper/issues/1062</a> from osiewicz/remove_build_rs</li>
<li><a href="04f7758b6e"><code>04f7758</code></a> fixup! chore: Remove no_btreemap_get_key_value and no_btreemap_remove_entry.</li>
<li><a href="83bdc5fd42"><code>83bdc5f</code></a> Omit return keyword in <code>remove_entry</code></li>
<li><a href="89a2741956"><code>89a2741</code></a> Revert "Remove limb_width32 and limb_width64 features"</li>
<li><a href="16e04ceedd"><code>16e04ce</code></a> fixup! Remove limb_width32 and limb_width64 features</li>
<li>See full diff in <a href="https://github.com/serde-rs/json/compare/v1.0.106...v1.0.107">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/5154
Reviewed By: ivanmisuno
Differential Revision: D49641876
Pulled By: passy
fbshipit-source-id: 0c5a3ed4b3ed10fd5d52ecbd8f885166d568d513
Summary:
Bumps [rayon](https://github.com/rayon-rs/rayon) from 1.7.0 to 1.8.0.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/rayon-rs/rayon/blob/master/RELEASES.md">rayon's changelog</a>.</em></p>
<blockquote>
<h1>Release rayon 1.8.0 / rayon-core 1.12.0 (2023-09-20)</h1>
<ul>
<li>The minimum supported <code>rustc</code> is now 1.63.</li>
<li>Added <code>ThreadPoolBuilder::use_current_thread</code> to use the builder thread as
part of the new thread pool. That thread does not run the pool's main loop,
but it may participate in work-stealing if it yields to rayon in some way.</li>
<li>Implemented <code>FromParallelIterator<T></code> for <code>Box<[T]></code>, <code>Rc<[T]></code>, and
<code>Arc<[T]></code>, as well as <code>FromParallelIterator<Box<str>></code> and
<code>ParallelExtend<Box<str>></code> for <code>String</code>.</li>
<li><code>ThreadPoolBuilder::build_scoped</code> now uses <code>std::thread::scope</code>.</li>
<li>The default number of threads is now determined using
<code>std::thread::available_parallelism</code> instead of the <code>num_cpus</code> crate.</li>
<li>The internal logging facility has been removed, reducing bloat for all users.</li>
<li>Many smaller performance tweaks and documentation updates.</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="21e1ae1e12"><code>21e1ae1</code></a> Release rayon 1.4.0 / rayon-core 1.8.0</li>
<li><a href="a0e5833b76"><code>a0e5833</code></a> Merge <a href="https://redirect.github.com/rayon-rs/rayon/issues/785">https://github.com/facebook/flipper/issues/785</a> <a href="https://redirect.github.com/rayon-rs/rayon/issues/790">https://github.com/facebook/flipper/issues/790</a> <a href="https://redirect.github.com/rayon-rs/rayon/issues/791">https://github.com/facebook/flipper/issues/791</a></li>
<li><a href="9f7357befb"><code>9f7357b</code></a> Merge <a href="https://redirect.github.com/rayon-rs/rayon/issues/792">https://github.com/facebook/flipper/issues/792</a></li>
<li><a href="998f134242"><code>998f134</code></a> Removed outdated documentation</li>
<li><a href="c7d963a9c2"><code>c7d963a</code></a> Use crossbeam_deque::Injector instead of crossbeam_queue::SegQueue</li>
<li><a href="2e889293a8"><code>2e88929</code></a> Micro-optimize the WorkerThread::steal loop</li>
<li><a href="66559fe9ce"><code>66559fe</code></a> Remove the lifetime constraint from the scope OP</li>
<li><a href="09428ec11d"><code>09428ec</code></a> Merge <a href="https://redirect.github.com/rayon-rs/rayon/issues/746">https://github.com/facebook/flipper/issues/746</a></li>
<li><a href="ed6a5f75c4"><code>ed6a5f7</code></a> Update ci/compat-Cargo.lock</li>
<li><a href="96ba9ef188"><code>96ba9ef</code></a> inline more Counter methods</li>
<li>Additional commits viewable in <a href="https://github.com/rayon-rs/rayon/compare/rayon-core-v1.7.0...rayon-core-v1.8.0">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/5172
Reviewed By: lblasa
Differential Revision: D49725788
Pulled By: passy
fbshipit-source-id: 5798c7c8bd831acd2291fc07628cc3005ab8f703
Summary:
Bumps [indicatif](https://github.com/console-rs/indicatif) from 0.17.6 to 0.17.7.
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a href="https://github.com/console-rs/indicatif/commits">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/5173
Reviewed By: lblasa
Differential Revision: D49725790
Pulled By: passy
fbshipit-source-id: e9fea2896eb6fc927d1493ae017404e6fbd1e9f9
Summary:
Now when we are simulating device running in VoiceOver mode while showing accessiblity hierarchy in flipper, we are getting correct hierarchy + getting production-like custom actions,
Instagram + Facebook feed is a good example of using accessiblity actions to avoid exposing individual buttons
Reviewed By: lblasa
Differential Revision: D49641875
fbshipit-source-id: 1153ec3bffc7110c4bfe702cbb5a6b729d91b9a3
Summary:
There has been multiple requests to incorporate an export to plain text functionality for a while.
This diff adds it.
It will export a node and optionally its chidren as JSON.
Reviewed By: antonk52
Differential Revision: D49596476
fbshipit-source-id: 3681bc0c2d02e1ea64ff589e0e272f6d54ad0524
Summary:
Should be more discoverable
changelog: UIDebugger accessibility mode for iOS launched, look for icon to the right of the search bar
Reviewed By: zats
Differential Revision: D49547952
fbshipit-source-id: 3befdffedb34907d9824bb66b86e20fd4a1a42ff
Summary: Log views were being generated, this seems like a reasonable solution.
Reviewed By: zats
Differential Revision: D49547368
fbshipit-source-id: 575dd81a7c9b9a831d1dfb46088c2f5e1d731f22
Summary:
All the FoA have different logic depending on whether device is running in VoiceOver mode or not. This results in incorrect accessibility being reported through the Flipper plugin.
For example on Instagram we fetch the image descriptions, in Facebook app we group individual elements into the accessibility groups to simplify traversing the screen
This tells device that it is in a voice over mode while inspecting accessibility mode is on meaning that it will be the closest approximation to the
Reviewed By: nscoding
Differential Revision: D49579241
fbshipit-source-id: f3be9057007ee6eefbe3b448f0f97c1fcd2c8f46
Summary: These are quite verbose even when debugging, so remove.
Reviewed By: ivanmisuno
Differential Revision: D49538582
fbshipit-source-id: 089027390a825dde3d3d53b67e3f920f2f1f75f2
Summary: Having default and extra actions at the bottom is not actionable. Users are used to haveing table controls on the top.
Reviewed By: LukeDefeo, aigoncharov
Differential Revision: D49538205
fbshipit-source-id: 724a31dc44de79cb0e09efae48dd2135450b34ae
