Summary: The previous approach would set the atom many times causing several unnecessary renders
Reviewed By: lblasa
Differential Revision: D47519869
fbshipit-source-id: 536334c892334035a6c0fefc86a2e205b2c9769d
Summary: I was experiencing some odd behaviour and locks ups from deep within Ant d. It seems to be related to the fact that tooltips for the visualiser were showing up when there was a modal on top.
Reviewed By: lblasa
Differential Revision: D47519848
fbshipit-source-id: d67edaedba2910069ba1eb424548de55c2badff3
Summary:
Added selection source concept to onSelect callback. This allows us to only autoscroll the tree when selection source is the visualiser. We had feedback that the horizontal autoscrolling whilst using the tree was unhelpful.
A side benefit of selection source is better tracking of how people use kb, tree vs visualiser to select things
Changelog: UIDebugger only autoscroll horizontally when selecting via the visualiser
Reviewed By: lblasa
Differential Revision: D47334078
fbshipit-source-id: d7eadddb8d3d0fd428d5c294b2dccc2f1efa5a95
Summary: It was complaining about no key for items in a list
Reviewed By: antonk52
Differential Revision: D47396639
fbshipit-source-id: c3d5cb7205dbe1c343d109e22f43e5756a071119
Summary:
Bumps [anyhow](https://github.com/dtolnay/anyhow) from 1.0.71 to 1.0.72.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/dtolnay/anyhow/releases">anyhow's releases</a>.</em></p>
<blockquote>
<h2>1.0.72</h2>
<ul>
<li>Documentation improvements</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="e458996b0a"><code>e458996</code></a> Release 1.0.72</li>
<li><a href="660fb0f068"><code>660fb0f</code></a> Opt in to generate-link-to-definition when building on docs.rs</li>
<li><a href="24d9166581"><code>24d9166</code></a> Add CI job using minimal-versions</li>
<li><a href="2c913b3078"><code>2c913b3</code></a> Remove .clippy.toml in favor of respecting rust-version from Cargo.toml</li>
<li><a href="1f17666ef1"><code>1f17666</code></a> Ignore needless_else clippy lint in test suite</li>
<li><a href="6046674814"><code>6046674</code></a> Show error details during miri setup in CI</li>
<li><a href="dffcb4bf6c"><code>dffcb4b</code></a> Revert "Temporarily disable miri CI"</li>
<li><a href="438fec6036"><code>438fec6</code></a> Temporarily disable miri CI</li>
<li>See full diff in <a href="https://github.com/dtolnay/anyhow/compare/1.0.71...1.0.72">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/4953
Reviewed By: antonk52
Differential Revision: D47553549
Pulled By: passy
fbshipit-source-id: 4486ad16fba61214dbc0749867498eca25517ca6
Summary:
Upgrade to Gradle `8.1.1`
Done using:
```bash
./gradlew wrapper --gradle-version=8.1.1 --distribution-type=all
```
This is to align with the bump to gradle `8.x` in React Native.
## Changelog
[GENERAL] [SECURITY] - Upgrade to Gradle `8.1.1`
Pull Request resolved: https://github.com/facebook/flipper/pull/4907
Test Plan: - CI checks should pass & builds should be successful without any errors.
Reviewed By: antonk52
Differential Revision: D47553708
Pulled By: passy
fbshipit-source-id: a0ab9ab732a254c563d8cb55b277f73571da8927
Summary:
Bumps [serde_yaml](https://github.com/dtolnay/serde-yaml) from 0.9.21 to 0.9.23.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/dtolnay/serde-yaml/releases">serde_yaml's releases</a>.</em></p>
<blockquote>
<h2>0.9.23</h2>
<ul>
<li>Documentation improvements</li>
</ul>
<h2>0.9.22</h2>
<ul>
<li>Update indexmap dependency to version 2</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="6b212e08b3"><code>6b212e0</code></a> Release 0.9.23</li>
<li><a href="cc83b0a220"><code>cc83b0a</code></a> Opt in to generate-link-to-definition when building on docs.rs</li>
<li><a href="954e38428c"><code>954e384</code></a> Make minimal-versions job consistent with other repos</li>
<li><a href="060eb8669c"><code>060eb86</code></a> Release 0.9.22</li>
<li><a href="b12ad38d63"><code>b12ad38</code></a> Merge pull request <a href="https://redirect.github.com/dtolnay/serde-yaml/issues/377">https://github.com/facebook/flipper/issues/377</a> from dtolnay/indexmap</li>
<li><a href="c418ad56c3"><code>c418ad5</code></a> Update indexmap dependency to version 2</li>
<li><a href="f1cd9e6b7f"><code>f1cd9e6</code></a> Remove .clippy.toml in favor of respecting rust-version from Cargo.toml</li>
<li><a href="147103c4f4"><code>147103c</code></a> Show error details during miri setup in CI</li>
<li><a href="622553f382"><code>622553f</code></a> Fix unused import warnings in test under cfg miri</li>
<li><a href="2037c7e62b"><code>2037c7e</code></a> Fix new unused_mut detected by nightly-2023-04-30</li>
<li>See full diff in <a href="https://github.com/dtolnay/serde-yaml/compare/0.9.21...0.9.23">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/4952
Reviewed By: antonk52
Differential Revision: D47553552
Pulled By: passy
fbshipit-source-id: 2d90115eebe71748270d813e26cea7053e96bdb0
Summary: Filter exceptions allow us to add singular items to table views. Extremely useful for Bloks Debugger where we have to jump between multiple types of rows that could be filtered out
Reviewed By: LukeDefeo
Differential Revision: D47472006
fbshipit-source-id: 74d21a65d364ec5ab88652effc06aade20ad80b2
Summary: This was added initially for login button only which was redundant. Fixed in this diff
Reviewed By: elboman
Differential Revision: D47517366
fbshipit-source-id: 58191c618fe2e85d6a06e444029a308223b4e235
Summary:
- remove tooltip as it is about the items that are in the navbar now
- metro buttons and bookmarks are still located in the sidebar
- so are plugin app actions
Reviewed By: elboman
Differential Revision: D47470797
fbshipit-source-id: cb7d757821eaa45ea770d3731b94e4e2f1a6d0ff
Summary: Don't mind busy navbar, flipper debugger buttons will be moved into a menu down the stack
Reviewed By: elboman
Differential Revision: D47469851
fbshipit-source-id: b29367810287d77106a56a5b1ae4aec49188e8fc
Summary: I also changed the "export" button icon as having two bug icons in the navbar is confusion. lblasa is going to squish all 4 or 5 debug flipper related buttons into one in the near future, so I am not focused on solving this currently
Reviewed By: elboman
Differential Revision: D47468721
fbshipit-source-id: 9492f9feba0df4afaf5b72470cb65e5cefbcb955
Summary: lblasa said Sandy migration was done years ago. Can be removed safely.
Reviewed By: elboman
Differential Revision: D47439199
fbshipit-source-id: 3ae0e1b3133d051740cd28e9d47c978e6f478c36
Summary:
Requested by litho team
Changelog: UIDebugger Add seperate icon for litho mountables
Changelog: UIDebugger Serialize all props using java.lang.toString
Changelog: UIDebugger show drawables mounted by litho
Reviewed By: lblasa
Differential Revision: D47295799
fbshipit-source-id: ce5b9384e4796a5c58080a289709ed9f7afdf329
Summary:
Previous approach was a bit flawed as the `isOpen()` API returns true by the time close is called.
This was OK in the case of errors, as the open flag was set to false hence preventing us to report a close after the error. It is not OK on healthy disconnect situations as these events were not getting reported.
In this case, a better solution is just to clear the event handler after a close or error because in either case we are no longer interested in dispatching any other events to the handler.
Reviewed By: antonk52
Differential Revision: D47510883
fbshipit-source-id: 883a3f87f24f71fe44a624590a310fe2563cbd8a
Summary:
Bumps [serde](https://github.com/serde-rs/serde) from 1.0.164 to 1.0.165.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/serde-rs/serde/releases">serde's releases</a>.</em></p>
<blockquote>
<h2>v1.0.165</h2>
<ul>
<li>Fix incorrect count of fields passed to tuple deserialization methods when using <code>serde(skip_deserializing)</code> attributes (<a href="https://redirect.github.com/serde-rs/serde/issues/2466">https://github.com/facebook/flipper/issues/2466</a>, thanks <a href="https://github.com/Mingun"><code>@Mingun</code></a>)</li>
<li>Fix <code>-Zminimal-versions</code> build</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="dcbc3e0162"><code>dcbc3e0</code></a> Release 1.0.165</li>
<li><a href="0289d31724"><code>0289d31</code></a> Fix -Zminimal-versions build</li>
<li><a href="015e39776f"><code>015e397</code></a> No need for single-element vec for chaining one element</li>
<li><a href="6a9a21f178"><code>6a9a21f</code></a> Resolve useless_conversion clippy lint in test</li>
<li><a href="81ac54b20d"><code>81ac54b</code></a> Resolve redundant_closure_call clippy lint</li>
<li><a href="6b4e75520a"><code>6b4e755</code></a> Resolve explicit_iter_loop pedantic clippy lint</li>
<li><a href="b053b4f492"><code>b053b4f</code></a> Touch up early return in Enum checks</li>
<li><a href="c0ba323166"><code>c0ba323</code></a> Support a manual trigger on CI workflow</li>
<li><a href="20a48c9580"><code>20a48c9</code></a> Remove .clippy.toml in favor of respecting rust-version from Cargo.toml</li>
<li><a href="09938803af"><code>0993880</code></a> Resolve redundant_static_lifetimes clippy lint</li>
<li>Additional commits viewable in <a href="https://github.com/serde-rs/serde/compare/v1.0.164...v1.0.165">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Pull Request resolved: https://github.com/facebook/flipper/pull/4910
Reviewed By: lblasa
Differential Revision: D47294568
Pulled By: passy
fbshipit-source-id: 284710438e91a56b63f56f52a5974478af603eeb
Summary:
Add support for secondary indices, to allow for cheap lookups, like a set of events for a specific UI element in the events table:
```
#### getAllRecordsByIndex
Usage: `getAllRecordsByIndex({ indexedAttribute: value, indexAttribute2: value2, .... })`
This method allows fast lookups for objects that match specific attributes exactly.
Returns all items matching the specified index query.
Note that the results are unordered, unless
records have not been updated using upsert / update, in that case
insertion order is maintained.
If no index has been specified for this exact keyset in the indexQuery (see options.indices), this method will throw.
Example:
```
```
const ds = createDataSource([eatCookie, drinkCoffee, submitBug], {
key: 'id',
indices: [
['title']
['id', 'title'],
['title', 'done'],
],
});
// Find first element with title === cookie (or undefined)
const todo = ds.getFirstRecordByIndex({
title: 'cookie',
})
// Find all elements where title === cookie, and done === false
const todos = ds.getAllRecordsByIndex({
title: 'cookie',
done: false,
})
```
Reviewed By: antonk52
Differential Revision: D47396435
fbshipit-source-id: 20c4527be83532863b9b07ab20ebf20a80c3c35d
